[INFO] crate extrahop 0.2.5 is already in cache
[INFO] extracting crate extrahop 0.2.5 into work/ex/clippy-test-run/sources/stable/reg/extrahop/0.2.5
[INFO] extracting crate extrahop 0.2.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/extrahop/0.2.5
[INFO] validating manifest of extrahop-0.2.5 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of extrahop-0.2.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing extrahop-0.2.5
[INFO] finished frobbing extrahop-0.2.5
[INFO] frobbed toml for extrahop-0.2.5 written to work/ex/clippy-test-run/sources/stable/reg/extrahop/0.2.5/Cargo.toml
[INFO] started frobbing extrahop-0.2.5
[INFO] finished frobbing extrahop-0.2.5
[INFO] frobbed toml for extrahop-0.2.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/extrahop/0.2.5/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting extrahop-0.2.5 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/extrahop/0.2.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 0563d0928f7819b7417551033469f046a5dc4888f19c3e2454a376e304c19f75
[INFO] running `"docker" "start" "-a" "0563d0928f7819b7417551033469f046a5dc4888f19c3e2454a376e304c19f75"`
[INFO] [stderr]     Checking extrahop v0.2.5 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/client.rs:21:13
[INFO] [stderr]    |
[INFO] [stderr] 21 |             api_key: api_key,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `api_key`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/activitymap/query.rs:185:13
[INFO] [stderr]     |
[INFO] [stderr] 185 |             object_type: object_type,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `object_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/activitymap/query.rs:277:13
[INFO] [stderr]     |
[INFO] [stderr] 277 |             role: role,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `role`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/activitymap/query.rs:295:13
[INFO] [stderr]     |
[INFO] [stderr] 295 |             role: role,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `role`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/activitymap/rsp.rs:195:13
[INFO] [stderr]     |
[INFO] [stderr] 195 |             walk: walk,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `walk`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/activitymap/rsp.rs:196:13
[INFO] [stderr]     |
[INFO] [stderr] 196 |             step: step,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `step`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/errors.rs:50:13
[INFO] [stderr]    |
[INFO] [stderr] 50 |             status: status,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `status`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/client.rs:21:13
[INFO] [stderr]    |
[INFO] [stderr] 21 |             api_key: api_key,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `api_key`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/activitymap/query.rs:185:13
[INFO] [stderr]     |
[INFO] [stderr] 185 |             object_type: object_type,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `object_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/activitymap/query.rs:277:13
[INFO] [stderr]     |
[INFO] [stderr] 277 |             role: role,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `role`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/activitymap/query.rs:295:13
[INFO] [stderr]     |
[INFO] [stderr] 295 |             role: role,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `role`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/activitymap/rsp.rs:195:13
[INFO] [stderr]     |
[INFO] [stderr] 195 |             walk: walk,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `walk`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/activitymap/rsp.rs:196:13
[INFO] [stderr]     |
[INFO] [stderr] 196 |             step: step,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `step`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/errors.rs:50:13
[INFO] [stderr]    |
[INFO] [stderr] 50 |             status: status,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `status`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/api_key.rs:45:22
[INFO] [stderr]    |
[INFO] [stderr] 45 |     pub fn to_header(self) -> header::Authorization<ApiKey> {
[INFO] [stderr]    |                      ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/client.rs:93:49
[INFO] [stderr]    |
[INFO] [stderr] 93 |         let leading_slash = if path.starts_with("/") { "" } else { "/" };
[INFO] [stderr]    |                                                 ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/query_time.rs:47:61
[INFO] [stderr]    |
[INFO] [stderr] 47 |             QueryTime::Unitized(ref val) => val.starts_with("-") || val == "0"
[INFO] [stderr]    |                                                             ^^^ help: try using a char instead: `'-'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/traits.rs:42:32
[INFO] [stderr]    |
[INFO] [stderr] 42 |             Err(RestError::new(self.status().clone(), self.json().ok()).into())
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.status()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/activitymap/query.rs:311:19
[INFO] [stderr]     |
[INFO] [stderr] 311 |     fn is_default(&self) -> bool {
[INFO] [stderr]     |                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/activitymap/rsp.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 | /     pub fn iter<'a>(&'a self) -> slice::Iter<'a, Edge> {
[INFO] [stderr] 47 | |         self.edges.iter()
[INFO] [stderr] 48 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/activitymap/rsp.rs:98:18
[INFO] [stderr]    |
[INFO] [stderr] 98 |                 *node_idx.get(&edge.from).unwrap(),
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node_idx[&edge.from]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/activitymap/rsp.rs:99:18
[INFO] [stderr]    |
[INFO] [stderr] 99 |                 *node_idx.get(&edge.to).unwrap(),
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node_idx[&edge.to]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/api_key.rs:45:22
[INFO] [stderr]    |
[INFO] [stderr] 45 |     pub fn to_header(self) -> header::Authorization<ApiKey> {
[INFO] [stderr]    |                      ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/client.rs:93:49
[INFO] [stderr]    |
[INFO] [stderr] 93 |         let leading_slash = if path.starts_with("/") { "" } else { "/" };
[INFO] [stderr]    |                                                 ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/query_time.rs:47:61
[INFO] [stderr]    |
[INFO] [stderr] 47 |             QueryTime::Unitized(ref val) => val.starts_with("-") || val == "0"
[INFO] [stderr]    |                                                             ^^^ help: try using a char instead: `'-'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/traits.rs:42:32
[INFO] [stderr]    |
[INFO] [stderr] 42 |             Err(RestError::new(self.status().clone(), self.json().ok()).into())
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.status()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> examples/map_reverse_index.rs:62:13
[INFO] [stderr]    |
[INFO] [stderr] 62 |             node_map: node_map,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `node_map`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/activitymap/query.rs:311:19
[INFO] [stderr]     |
[INFO] [stderr] 311 |     fn is_default(&self) -> bool {
[INFO] [stderr]     |                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/activitymap/rsp.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 | /     pub fn iter<'a>(&'a self) -> slice::Iter<'a, Edge> {
[INFO] [stderr] 47 | |         self.edges.iter()
[INFO] [stderr] 48 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/activitymap/rsp.rs:98:18
[INFO] [stderr]    |
[INFO] [stderr] 98 |                 *node_idx.get(&edge.from).unwrap(),
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node_idx[&edge.from]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/activitymap/rsp.rs:99:18
[INFO] [stderr]    |
[INFO] [stderr] 99 |                 *node_idx.get(&edge.to).unwrap(),
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&node_idx[&edge.to]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified
[INFO] [stderr]   --> examples/activity_map_tsv.rs:31:19
[INFO] [stderr]    |
[INFO] [stderr] 31 |                 ..Default::default()
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_update)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]   --> examples/map_reverse_index.rs:37:30
[INFO] [stderr]    |
[INFO] [stderr] 37 |                 .map(|index| self.topology.edges.get(*index).unwrap())
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.topology.edges[*index]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> examples/map_reverse_index.rs:50:48
[INFO] [stderr]    |
[INFO] [stderr] 50 |                 let entry = node_map.entry(id).or_insert(Vec::new());
[INFO] [stderr]    |                                                ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 23.65s
[INFO] running `"docker" "inspect" "0563d0928f7819b7417551033469f046a5dc4888f19c3e2454a376e304c19f75"`
[INFO] running `"docker" "rm" "-f" "0563d0928f7819b7417551033469f046a5dc4888f19c3e2454a376e304c19f75"`
[INFO] [stdout] 0563d0928f7819b7417551033469f046a5dc4888f19c3e2454a376e304c19f75