[INFO] crate extfsm 0.11.0 is already in cache [INFO] extracting crate extfsm 0.11.0 into work/ex/clippy-test-run/sources/stable/reg/extfsm/0.11.0 [INFO] extracting crate extfsm 0.11.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/extfsm/0.11.0 [INFO] validating manifest of extfsm-0.11.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of extfsm-0.11.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing extfsm-0.11.0 [INFO] finished frobbing extfsm-0.11.0 [INFO] frobbed toml for extfsm-0.11.0 written to work/ex/clippy-test-run/sources/stable/reg/extfsm/0.11.0/Cargo.toml [INFO] started frobbing extfsm-0.11.0 [INFO] finished frobbing extfsm-0.11.0 [INFO] frobbed toml for extfsm-0.11.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/extfsm/0.11.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting extfsm-0.11.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/extfsm/0.11.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7f6e099eb900a4e130673b1ebcf7e499bc6633b9583b8d449bbebb26d6942191 [INFO] running `"docker" "start" "-a" "7f6e099eb900a4e130673b1ebcf7e499bc6633b9583b8d449bbebb26d6942191"` [INFO] [stderr] Checking dot v0.1.4 [INFO] [stderr] Checking enum_derive v0.1.7 [INFO] [stderr] Checking slog-atomic v2.0.0 [INFO] [stderr] Checking extfsm v0.11.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | target: target, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:273:13 [INFO] [stderr] | [INFO] [stderr] 273 | entryexit: entryexit, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entryexit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:662:29 [INFO] [stderr] | [INFO] [stderr] 662 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:664:29 [INFO] [stderr] | [INFO] [stderr] 664 | shape: shape, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:690:41 [INFO] [stderr] | [INFO] [stderr] 690 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:698:41 [INFO] [stderr] | [INFO] [stderr] 698 | label: label, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:752:37 [INFO] [stderr] | [INFO] [stderr] 752 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:772:37 [INFO] [stderr] | [INFO] [stderr] 772 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:791:29 [INFO] [stderr] | [INFO] [stderr] 791 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:827:13 [INFO] [stderr] | [INFO] [stderr] 827 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:828:13 [INFO] [stderr] | [INFO] [stderr] 828 | event: event, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `event` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:907:13 [INFO] [stderr] | [INFO] [stderr] 907 | endstate: endstate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `endstate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:908:13 [INFO] [stderr] | [INFO] [stderr] 908 | transfn: transfn, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `transfn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1004:13 [INFO] [stderr] | [INFO] [stderr] 1004 | transfn: transfn, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `transfn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | target: target, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:273:13 [INFO] [stderr] | [INFO] [stderr] 273 | entryexit: entryexit, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entryexit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:662:29 [INFO] [stderr] | [INFO] [stderr] 662 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:664:29 [INFO] [stderr] | [INFO] [stderr] 664 | shape: shape, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shape` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:690:41 [INFO] [stderr] | [INFO] [stderr] 690 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:698:41 [INFO] [stderr] | [INFO] [stderr] 698 | label: label, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:752:37 [INFO] [stderr] | [INFO] [stderr] 752 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:772:37 [INFO] [stderr] | [INFO] [stderr] 772 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:791:29 [INFO] [stderr] | [INFO] [stderr] 791 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:827:13 [INFO] [stderr] | [INFO] [stderr] 827 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:828:13 [INFO] [stderr] | [INFO] [stderr] 828 | event: event, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `event` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:907:13 [INFO] [stderr] | [INFO] [stderr] 907 | endstate: endstate, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `endstate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:908:13 [INFO] [stderr] | [INFO] [stderr] 908 | transfn: transfn, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `transfn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1004:13 [INFO] [stderr] | [INFO] [stderr] 1004 | transfn: transfn, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `transfn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:336:24 [INFO] [stderr] | [INFO] [stderr] 336 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 337 | | if let Some(_) = self.statetransitions.borrow().get(eek) { [INFO] [stderr] 338 | | DotNodeKey::new(None, eek.state.clone()) [INFO] [stderr] 339 | | } else { [INFO] [stderr] 340 | | unreachable!(); [INFO] [stderr] 341 | | } [INFO] [stderr] 342 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 336 | } else if let Some(_) = self.statetransitions.borrow().get(eek) { [INFO] [stderr] 337 | DotNodeKey::new(None, eek.state.clone()) [INFO] [stderr] 338 | } else { [INFO] [stderr] 339 | unreachable!(); [INFO] [stderr] 340 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:354:24 [INFO] [stderr] | [INFO] [stderr] 354 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 355 | | if let Some(_) = self.statetransitions.borrow().get(eek) { [INFO] [stderr] 356 | | DotNodeKey::new(None, eek.state.clone()) [INFO] [stderr] 357 | | } else { [INFO] [stderr] 358 | | unreachable!(); [INFO] [stderr] 359 | | } [INFO] [stderr] 360 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 354 | } else if let Some(_) = self.statetransitions.borrow().get(eek) { [INFO] [stderr] 355 | DotNodeKey::new(None, eek.state.clone()) [INFO] [stderr] 356 | } else { [INFO] [stderr] 357 | unreachable!(); [INFO] [stderr] 358 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:336:24 [INFO] [stderr] | [INFO] [stderr] 336 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 337 | | if let Some(_) = self.statetransitions.borrow().get(eek) { [INFO] [stderr] 338 | | DotNodeKey::new(None, eek.state.clone()) [INFO] [stderr] 339 | | } else { [INFO] [stderr] 340 | | unreachable!(); [INFO] [stderr] 341 | | } [INFO] [stderr] 342 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 336 | } else if let Some(_) = self.statetransitions.borrow().get(eek) { [INFO] [stderr] 337 | DotNodeKey::new(None, eek.state.clone()) [INFO] [stderr] 338 | } else { [INFO] [stderr] 339 | unreachable!(); [INFO] [stderr] 340 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:354:24 [INFO] [stderr] | [INFO] [stderr] 354 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 355 | | if let Some(_) = self.statetransitions.borrow().get(eek) { [INFO] [stderr] 356 | | DotNodeKey::new(None, eek.state.clone()) [INFO] [stderr] 357 | | } else { [INFO] [stderr] 358 | | unreachable!(); [INFO] [stderr] 359 | | } [INFO] [stderr] 360 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 354 | } else if let Some(_) = self.statetransitions.borrow().get(eek) { [INFO] [stderr] 355 | DotNodeKey::new(None, eek.state.clone()) [INFO] [stderr] 356 | } else { [INFO] [stderr] 357 | unreachable!(); [INFO] [stderr] 358 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:143:18 [INFO] [stderr] | [INFO] [stderr] 143 | transitions: Rc< [INFO] [stderr] | __________________^ [INFO] [stderr] 144 | | RefCell< [INFO] [stderr] 145 | | TransitionTable, [INFO] [stderr] 146 | | >, [INFO] [stderr] 147 | | >, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:148:23 [INFO] [stderr] | [INFO] [stderr] 148 | statetransitions: Rc< [INFO] [stderr] | _______________________^ [INFO] [stderr] 149 | | RefCell< [INFO] [stderr] 150 | | EntryExitTransitionTable< [INFO] [stderr] 151 | | ExtendedState, [INFO] [stderr] ... | [INFO] [stderr] 157 | | >, [INFO] [stderr] 158 | | >, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:337:28 [INFO] [stderr] | [INFO] [stderr] 337 | if let Some(_) = self.statetransitions.borrow().get(eek) { [INFO] [stderr] | _____________________- ^^^^^^^ [INFO] [stderr] 338 | | DotNodeKey::new(None, eek.state.clone()) [INFO] [stderr] 339 | | } else { [INFO] [stderr] 340 | | unreachable!(); [INFO] [stderr] 341 | | } [INFO] [stderr] | |_____________________- help: try this: `if self.statetransitions.borrow().get(eek).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:355:28 [INFO] [stderr] | [INFO] [stderr] 355 | if let Some(_) = self.statetransitions.borrow().get(eek) { [INFO] [stderr] | _____________________- ^^^^^^^ [INFO] [stderr] 356 | | DotNodeKey::new(None, eek.state.clone()) [INFO] [stderr] 357 | | } else { [INFO] [stderr] 358 | | unreachable!(); [INFO] [stderr] 359 | | } [INFO] [stderr] | |_____________________- help: try this: `if self.statetransitions.borrow().get(eek).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:609:9 [INFO] [stderr] | [INFO] [stderr] 609 | self.event_queue.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.event_queue.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:631:41 [INFO] [stderr] | [INFO] [stderr] 631 | fs::File::create(fname).map(|f| Some(f)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:682:45 [INFO] [stderr] | [INFO] [stderr] 682 | let label = match t { [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 683 | | &EntryExit::EntryTransition => "Enter".into(), [INFO] [stderr] 684 | | &EntryExit::ExitTransition => "Exit".into(), [INFO] [stderr] 685 | | }; [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 682 | let label = match *t { [INFO] [stderr] 683 | EntryExit::EntryTransition => "Enter".into(), [INFO] [stderr] 684 | EntryExit::ExitTransition => "Exit".into(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:720:54 [INFO] [stderr] | [INFO] [stderr] 720 | for (source, pertargetsource) in pertargetsource [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 721 | | .into_iter() [INFO] [stderr] | |________________________________________^ help: consider removing `.into_iter()`: `pertargetsource` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: the `v @ _` pattern can be written as just `v` [INFO] [stderr] --> src/lib.rs:726:37 [INFO] [stderr] | [INFO] [stderr] 726 | v @ _ => v, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:736:62 [INFO] [stderr] | [INFO] [stderr] 736 | for (color, pertargetsourcecolor) in pertargetsource [INFO] [stderr] | ______________________________________________________________^ [INFO] [stderr] 737 | | .into_iter() [INFO] [stderr] | |________________________________________^ help: consider removing `.into_iter()`: `pertargetsource` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:754:44 [INFO] [stderr] | [INFO] [stderr] 754 | label: pertargetsourcecolor [INFO] [stderr] | ____________________________________________^ [INFO] [stderr] 755 | | .into_iter() [INFO] [stderr] | |____________________________________________________^ help: consider removing `.into_iter()`: `pertargetsourcecolor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:765:56 [INFO] [stderr] | [INFO] [stderr] 765 | }).unwrap_or("".into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:761:65 [INFO] [stderr] | [INFO] [stderr] 761 | .map(|n| if n.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!n.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:793:36 [INFO] [stderr] | [INFO] [stderr] 793 | label: format!("{}", tv.get_name().clone().unwrap_or(String::from(""))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `tv.get_name().clone().unwrap_or(String::from("")).to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:793:72 [INFO] [stderr] | [INFO] [stderr] 793 | label: format!("{}", tv.get_name().clone().unwrap_or(String::from(""))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from(""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:801:17 [INFO] [stderr] | [INFO] [stderr] 801 | / match &mut mf { [INFO] [stderr] 802 | | &mut Some(ref mut f) => dot::render(self, f), [INFO] [stderr] 803 | | _ => dot::render(self, &mut sout), // as io::Write [INFO] [stderr] 804 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 801 | match *(&mut mf) { [INFO] [stderr] 802 | Some(ref mut f) => dot::render(self, f), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:1115:21 [INFO] [stderr] | [INFO] [stderr] 1115 | let ref mut q = self.event_queue; [INFO] [stderr] | ----^^^^^^^^^-------------------- help: try: `let q = &mut self.event_queue;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/lib.rs:1123:17 [INFO] [stderr] | [INFO] [stderr] 1123 | / fn entryexit< [INFO] [stderr] 1124 | | ExtendedState, [INFO] [stderr] 1125 | | EventType, [INFO] [stderr] 1126 | | StateType, [INFO] [stderr] ... | [INFO] [stderr] 1182 | | } [INFO] [stderr] 1183 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:1159:33 [INFO] [stderr] | [INFO] [stderr] 1159 | let ref func = entryexittrans.transfn; [INFO] [stderr] | ----^^^^^^^^-------------------------- help: try: `let func = &entryexittrans.transfn;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:1160:33 [INFO] [stderr] | [INFO] [stderr] 1160 | let ref tname = entryexittrans.get_name(); [INFO] [stderr] | ----^^^^^^^^^----------------------------- help: try: `let tname = &entryexittrans.get_name();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:143:18 [INFO] [stderr] | [INFO] [stderr] 143 | transitions: Rc< [INFO] [stderr] | __________________^ [INFO] [stderr] 144 | | RefCell< [INFO] [stderr] 145 | | TransitionTable, [INFO] [stderr] 146 | | >, [INFO] [stderr] 147 | | >, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:148:23 [INFO] [stderr] | [INFO] [stderr] 148 | statetransitions: Rc< [INFO] [stderr] | _______________________^ [INFO] [stderr] 149 | | RefCell< [INFO] [stderr] 150 | | EntryExitTransitionTable< [INFO] [stderr] 151 | | ExtendedState, [INFO] [stderr] ... | [INFO] [stderr] 157 | | >, [INFO] [stderr] 158 | | >, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:337:28 [INFO] [stderr] | [INFO] [stderr] 337 | if let Some(_) = self.statetransitions.borrow().get(eek) { [INFO] [stderr] | _____________________- ^^^^^^^ [INFO] [stderr] 338 | | DotNodeKey::new(None, eek.state.clone()) [INFO] [stderr] 339 | | } else { [INFO] [stderr] 340 | | unreachable!(); [INFO] [stderr] 341 | | } [INFO] [stderr] | |_____________________- help: try this: `if self.statetransitions.borrow().get(eek).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:355:28 [INFO] [stderr] | [INFO] [stderr] 355 | if let Some(_) = self.statetransitions.borrow().get(eek) { [INFO] [stderr] | _____________________- ^^^^^^^ [INFO] [stderr] 356 | | DotNodeKey::new(None, eek.state.clone()) [INFO] [stderr] 357 | | } else { [INFO] [stderr] 358 | | unreachable!(); [INFO] [stderr] 359 | | } [INFO] [stderr] | |_____________________- help: try this: `if self.statetransitions.borrow().get(eek).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:609:9 [INFO] [stderr] | [INFO] [stderr] 609 | self.event_queue.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.event_queue.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:631:41 [INFO] [stderr] | [INFO] [stderr] 631 | fs::File::create(fname).map(|f| Some(f)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:682:45 [INFO] [stderr] | [INFO] [stderr] 682 | let label = match t { [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 683 | | &EntryExit::EntryTransition => "Enter".into(), [INFO] [stderr] 684 | | &EntryExit::ExitTransition => "Exit".into(), [INFO] [stderr] 685 | | }; [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 682 | let label = match *t { [INFO] [stderr] 683 | EntryExit::EntryTransition => "Enter".into(), [INFO] [stderr] 684 | EntryExit::ExitTransition => "Exit".into(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:720:54 [INFO] [stderr] | [INFO] [stderr] 720 | for (source, pertargetsource) in pertargetsource [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 721 | | .into_iter() [INFO] [stderr] | |________________________________________^ help: consider removing `.into_iter()`: `pertargetsource` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: the `v @ _` pattern can be written as just `v` [INFO] [stderr] --> src/lib.rs:726:37 [INFO] [stderr] | [INFO] [stderr] 726 | v @ _ => v, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:736:62 [INFO] [stderr] | [INFO] [stderr] 736 | for (color, pertargetsourcecolor) in pertargetsource [INFO] [stderr] | ______________________________________________________________^ [INFO] [stderr] 737 | | .into_iter() [INFO] [stderr] | |________________________________________^ help: consider removing `.into_iter()`: `pertargetsource` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:754:44 [INFO] [stderr] | [INFO] [stderr] 754 | label: pertargetsourcecolor [INFO] [stderr] | ____________________________________________^ [INFO] [stderr] 755 | | .into_iter() [INFO] [stderr] | |____________________________________________________^ help: consider removing `.into_iter()`: `pertargetsourcecolor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:765:56 [INFO] [stderr] | [INFO] [stderr] 765 | }).unwrap_or("".into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:761:65 [INFO] [stderr] | [INFO] [stderr] 761 | .map(|n| if n.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!n.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:793:36 [INFO] [stderr] | [INFO] [stderr] 793 | label: format!("{}", tv.get_name().clone().unwrap_or(String::from(""))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `tv.get_name().clone().unwrap_or(String::from("")).to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:793:72 [INFO] [stderr] | [INFO] [stderr] 793 | label: format!("{}", tv.get_name().clone().unwrap_or(String::from(""))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from(""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:801:17 [INFO] [stderr] | [INFO] [stderr] 801 | / match &mut mf { [INFO] [stderr] 802 | | &mut Some(ref mut f) => dot::render(self, f), [INFO] [stderr] 803 | | _ => dot::render(self, &mut sout), // as io::Write [INFO] [stderr] 804 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 801 | match *(&mut mf) { [INFO] [stderr] 802 | Some(ref mut f) => dot::render(self, f), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:1115:21 [INFO] [stderr] | [INFO] [stderr] 1115 | let ref mut q = self.event_queue; [INFO] [stderr] | ----^^^^^^^^^-------------------- help: try: `let q = &mut self.event_queue;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/lib.rs:1123:17 [INFO] [stderr] | [INFO] [stderr] 1123 | / fn entryexit< [INFO] [stderr] 1124 | | ExtendedState, [INFO] [stderr] 1125 | | EventType, [INFO] [stderr] 1126 | | StateType, [INFO] [stderr] ... | [INFO] [stderr] 1182 | | } [INFO] [stderr] 1183 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:1159:33 [INFO] [stderr] | [INFO] [stderr] 1159 | let ref func = entryexittrans.transfn; [INFO] [stderr] | ----^^^^^^^^-------------------------- help: try: `let func = &entryexittrans.transfn;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:1160:33 [INFO] [stderr] | [INFO] [stderr] 1160 | let ref tname = entryexittrans.get_name(); [INFO] [stderr] | ----^^^^^^^^^----------------------------- help: try: `let tname = &entryexittrans.get_name();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:1449:77 [INFO] [stderr] | [INFO] [stderr] 1449 | Box::new(|mut estate: RefMut>, _, _| { [INFO] [stderr] | _____________________________________________________________________________^ [INFO] [stderr] 1450 | | estate.coincounter += 1; [INFO] [stderr] 1451 | | // we count open/close on entry/exit [INFO] [stderr] 1452 | | Ok(None) [INFO] [stderr] 1453 | | }) [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:1496:84 [INFO] [stderr] | [INFO] [stderr] 1496 | |mut estate: RefMut>, laststate, lastevent| { [INFO] [stderr] | ____________________________________________________________________________________^ [INFO] [stderr] 1497 | | estate.opened += 1; [INFO] [stderr] 1498 | | estate.enteredon.push((laststate, lastevent)); [INFO] [stderr] 1499 | | Ok(None) [INFO] [stderr] 1500 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/lib.rs:1510:84 [INFO] [stderr] | [INFO] [stderr] 1510 | |mut estate: RefMut>, laststate, lastevent| { [INFO] [stderr] | ____________________________________________________________________________________^ [INFO] [stderr] 1511 | | estate.closed += 1; [INFO] [stderr] 1512 | | estate.exitedon.push((laststate, lastevent)); [INFO] [stderr] 1513 | | Ok(None) [INFO] [stderr] 1514 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.94s [INFO] running `"docker" "inspect" "7f6e099eb900a4e130673b1ebcf7e499bc6633b9583b8d449bbebb26d6942191"` [INFO] running `"docker" "rm" "-f" "7f6e099eb900a4e130673b1ebcf7e499bc6633b9583b8d449bbebb26d6942191"` [INFO] [stdout] 7f6e099eb900a4e130673b1ebcf7e499bc6633b9583b8d449bbebb26d6942191