[INFO] crate external_sort 0.1.1 is already in cache
[INFO] extracting crate external_sort 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/external_sort/0.1.1
[INFO] extracting crate external_sort 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/external_sort/0.1.1
[INFO] validating manifest of external_sort-0.1.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of external_sort-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing external_sort-0.1.1
[INFO] finished frobbing external_sort-0.1.1
[INFO] frobbed toml for external_sort-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/external_sort/0.1.1/Cargo.toml
[INFO] started frobbing external_sort-0.1.1
[INFO] finished frobbing external_sort-0.1.1
[INFO] frobbed toml for external_sort-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/external_sort/0.1.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting external_sort-0.1.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/external_sort/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 133389c58fa983de129cdf83181849bb73e9ba8bb55170b3852353e469d73cf8
[INFO] running `"docker" "start" "-a" "133389c58fa983de129cdf83181849bb73e9ba8bb55170b3852353e469d73cf8"`
[INFO] [stderr]     Checking external_sort v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/external_sort.rs:98:13
[INFO] [stderr]     |
[INFO] [stderr] 98  | /             if !self.buffers[chunk_num].is_empty() {
[INFO] [stderr] 99  | |                 if self.buffers[idx].is_empty()
[INFO] [stderr] 100 | |                     || (self.sort_by_fn)(
[INFO] [stderr] 101 | |                         self.buffers[chunk_num].front().unwrap(),
[INFO] [stderr] ...   |
[INFO] [stderr] 106 | |                 }
[INFO] [stderr] 107 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 98  |             if !self.buffers[chunk_num].is_empty() && (self.buffers[idx].is_empty()
[INFO] [stderr] 99  |                     || (self.sort_by_fn)(
[INFO] [stderr] 100 |                         self.buffers[chunk_num].front().unwrap(),
[INFO] [stderr] 101 |                         self.buffers[idx].front().unwrap(),
[INFO] [stderr] 102 |                     ) == Less) {
[INFO] [stderr] 103 |     idx = chunk_num;
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/external_sort.rs:242:16
[INFO] [stderr]     |
[INFO] [stderr] 242 |             if chunk.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!chunk.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/external_sort.rs:98:13
[INFO] [stderr]     |
[INFO] [stderr] 98  | /             if !self.buffers[chunk_num].is_empty() {
[INFO] [stderr] 99  | |                 if self.buffers[idx].is_empty()
[INFO] [stderr] 100 | |                     || (self.sort_by_fn)(
[INFO] [stderr] 101 | |                         self.buffers[chunk_num].front().unwrap(),
[INFO] [stderr] ...   |
[INFO] [stderr] 106 | |                 }
[INFO] [stderr] 107 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 98  |             if !self.buffers[chunk_num].is_empty() && (self.buffers[idx].is_empty()
[INFO] [stderr] 99  |                     || (self.sort_by_fn)(
[INFO] [stderr] 100 |                         self.buffers[chunk_num].front().unwrap(),
[INFO] [stderr] 101 |                         self.buffers[idx].front().unwrap(),
[INFO] [stderr] 102 |                     ) == Less) {
[INFO] [stderr] 103 |     idx = chunk_num;
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/external_sort.rs:242:16
[INFO] [stderr]     |
[INFO] [stderr] 242 |             if chunk.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!chunk.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> tests/external_sort.rs:116:36
[INFO] [stderr]     |
[INFO] [stderr] 116 |     let iter = ExternalSorter::new(999999999, None)
[INFO] [stderr]     |                                    ^^^^^^^^^ help: consider: `999_999_999`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.58s
[INFO] running `"docker" "inspect" "133389c58fa983de129cdf83181849bb73e9ba8bb55170b3852353e469d73cf8"`
[INFO] running `"docker" "rm" "-f" "133389c58fa983de129cdf83181849bb73e9ba8bb55170b3852353e469d73cf8"`
[INFO] [stdout] 133389c58fa983de129cdf83181849bb73e9ba8bb55170b3852353e469d73cf8