[INFO] crate express 0.0.2 is already in cache [INFO] extracting crate express 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/express/0.0.2 [INFO] extracting crate express 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/express/0.0.2 [INFO] validating manifest of express-0.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of express-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing express-0.0.2 [INFO] finished frobbing express-0.0.2 [INFO] frobbed toml for express-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/express/0.0.2/Cargo.toml [INFO] started frobbing express-0.0.2 [INFO] finished frobbing express-0.0.2 [INFO] frobbed toml for express-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/express/0.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting express-0.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/express/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 450278566a509596381bbe8ae445388a119c0b739e9c01506abfd403486820ae [INFO] running `"docker" "start" "-a" "450278566a509596381bbe8ae445388a119c0b739e9c01506abfd403486820ae"` [INFO] [stderr] Checking express v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/express.rs:16:18 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn Use() -> () {} [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/express.rs:26:33 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn listen(port: String) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/router/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub mod router; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused variable: `res` [INFO] [stderr] --> src/middleware.rs:4:15 [INFO] [stderr] | [INFO] [stderr] 4 | fn invoke(res: String, req: String, next: String) {} [INFO] [stderr] | ^^^ help: consider using `_res` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `req` [INFO] [stderr] --> src/middleware.rs:4:28 [INFO] [stderr] | [INFO] [stderr] 4 | fn invoke(res: String, req: String, next: String) {} [INFO] [stderr] | ^^^ help: consider using `_req` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `next` [INFO] [stderr] --> src/middleware.rs:4:41 [INFO] [stderr] | [INFO] [stderr] 4 | fn invoke(res: String, req: String, next: String) {} [INFO] [stderr] | ^^^^ help: consider using `_next` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `port` [INFO] [stderr] --> src/express.rs:26:19 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn listen(port: String) -> () { [INFO] [stderr] | ^^^^ help: consider using `_port` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `res` [INFO] [stderr] --> src/router/router.rs:18:15 [INFO] [stderr] | [INFO] [stderr] 18 | fn invoke(res: String, req: String, next: String) {} [INFO] [stderr] | ^^^ help: consider using `_res` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `req` [INFO] [stderr] --> src/router/router.rs:18:28 [INFO] [stderr] | [INFO] [stderr] 18 | fn invoke(res: String, req: String, next: String) {} [INFO] [stderr] | ^^^ help: consider using `_req` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `next` [INFO] [stderr] --> src/router/router.rs:18:41 [INFO] [stderr] | [INFO] [stderr] 18 | fn invoke(res: String, req: String, next: String) {} [INFO] [stderr] | ^^^^ help: consider using `_next` instead [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `express::Express` [INFO] [stderr] --> src/express.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> Express { [INFO] [stderr] 10 | | Express {} [INFO] [stderr] 11 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: method `Use` should have a snake case name such as `use` [INFO] [stderr] --> src/express.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn Use() -> () {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `router::router::Router` [INFO] [stderr] --> src/router/router.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> Router { [INFO] [stderr] 10 | | Router {} [INFO] [stderr] 11 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/express.rs:16:18 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn Use() -> () {} [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/express.rs:26:33 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn listen(port: String) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/router/mod.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub mod router; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused variable: `res` [INFO] [stderr] --> src/middleware.rs:4:15 [INFO] [stderr] | [INFO] [stderr] 4 | fn invoke(res: String, req: String, next: String) {} [INFO] [stderr] | ^^^ help: consider using `_res` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `req` [INFO] [stderr] --> src/middleware.rs:4:28 [INFO] [stderr] | [INFO] [stderr] 4 | fn invoke(res: String, req: String, next: String) {} [INFO] [stderr] | ^^^ help: consider using `_req` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `next` [INFO] [stderr] --> src/middleware.rs:4:41 [INFO] [stderr] | [INFO] [stderr] 4 | fn invoke(res: String, req: String, next: String) {} [INFO] [stderr] | ^^^^ help: consider using `_next` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `port` [INFO] [stderr] --> src/express.rs:26:19 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn listen(port: String) -> () { [INFO] [stderr] | ^^^^ help: consider using `_port` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `res` [INFO] [stderr] --> src/router/router.rs:18:15 [INFO] [stderr] | [INFO] [stderr] 18 | fn invoke(res: String, req: String, next: String) {} [INFO] [stderr] | ^^^ help: consider using `_res` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `req` [INFO] [stderr] --> src/router/router.rs:18:28 [INFO] [stderr] | [INFO] [stderr] 18 | fn invoke(res: String, req: String, next: String) {} [INFO] [stderr] | ^^^ help: consider using `_req` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `next` [INFO] [stderr] --> src/router/router.rs:18:41 [INFO] [stderr] | [INFO] [stderr] 18 | fn invoke(res: String, req: String, next: String) {} [INFO] [stderr] | ^^^^ help: consider using `_next` instead [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `express::Express` [INFO] [stderr] --> src/express.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> Express { [INFO] [stderr] 10 | | Express {} [INFO] [stderr] 11 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: method `Use` should have a snake case name such as `use` [INFO] [stderr] --> src/express.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn Use() -> () {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `router::router::Router` [INFO] [stderr] --> src/router/router.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> Router { [INFO] [stderr] 10 | | Router {} [INFO] [stderr] 11 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.69s [INFO] running `"docker" "inspect" "450278566a509596381bbe8ae445388a119c0b739e9c01506abfd403486820ae"` [INFO] running `"docker" "rm" "-f" "450278566a509596381bbe8ae445388a119c0b739e9c01506abfd403486820ae"` [INFO] [stdout] 450278566a509596381bbe8ae445388a119c0b739e9c01506abfd403486820ae