[INFO] crate expo-server-sdk 0.1.0 is already in cache [INFO] extracting crate expo-server-sdk 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/expo-server-sdk/0.1.0 [INFO] extracting crate expo-server-sdk 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/expo-server-sdk/0.1.0 [INFO] validating manifest of expo-server-sdk-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of expo-server-sdk-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing expo-server-sdk-0.1.0 [INFO] finished frobbing expo-server-sdk-0.1.0 [INFO] frobbed toml for expo-server-sdk-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/expo-server-sdk/0.1.0/Cargo.toml [INFO] started frobbing expo-server-sdk-0.1.0 [INFO] finished frobbing expo-server-sdk-0.1.0 [INFO] frobbed toml for expo-server-sdk-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/expo-server-sdk/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting expo-server-sdk-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/expo-server-sdk/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7e1a4d807a049c8592f47c22c7e1a31aaba8ee9e8a7f582d0f8da9927172da1d [INFO] running `"docker" "start" "-a" "7e1a4d807a049c8592f47c22c7e1a31aaba8ee9e8a7f582d0f8da9927172da1d"` [INFO] [stderr] Checking structopt v0.2.14 [INFO] [stderr] Checking expo-server-sdk v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:58:28 [INFO] [stderr] | [INFO] [stderr] 58 | && s.ends_with("]") [INFO] [stderr] | ^^^ help: try using a char instead: `']'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:58:28 [INFO] [stderr] | [INFO] [stderr] 58 | && s.ends_with("]") [INFO] [stderr] | ^^^ help: try using a char instead: `']'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `PushNotifier` [INFO] [stderr] --> src/lib.rs:291:5 [INFO] [stderr] | [INFO] [stderr] 291 | / pub fn new() -> PushNotifier { [INFO] [stderr] 292 | | PushNotifier { [INFO] [stderr] 293 | | url: "https://exp.host/--/api/v2/push/send".to_string(), [INFO] [stderr] 294 | | pushes_per_request: 100, [INFO] [stderr] ... | [INFO] [stderr] 297 | | } [INFO] [stderr] 298 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 290 | impl Default for PushNotifier { [INFO] [stderr] 291 | fn default() -> Self { [INFO] [stderr] 292 | Self::new() [INFO] [stderr] 293 | } [INFO] [stderr] 294 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/lib.rs:354:17 [INFO] [stderr] | [INFO] [stderr] 354 | / if body.len() > 1024 { [INFO] [stderr] 355 | | true [INFO] [stderr] 356 | | } else { [INFO] [stderr] 357 | | false [INFO] [stderr] 358 | | } [INFO] [stderr] | |_________________^ help: you can reduce it to: `body.len() > 1024` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:407:9 [INFO] [stderr] | [INFO] [stderr] 407 | encoder.write(body.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `PushNotifier` [INFO] [stderr] --> src/lib.rs:291:5 [INFO] [stderr] | [INFO] [stderr] 291 | / pub fn new() -> PushNotifier { [INFO] [stderr] 292 | | PushNotifier { [INFO] [stderr] 293 | | url: "https://exp.host/--/api/v2/push/send".to_string(), [INFO] [stderr] 294 | | pushes_per_request: 100, [INFO] [stderr] ... | [INFO] [stderr] 297 | | } [INFO] [stderr] 298 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 290 | impl Default for PushNotifier { [INFO] [stderr] 291 | fn default() -> Self { [INFO] [stderr] 292 | Self::new() [INFO] [stderr] 293 | } [INFO] [stderr] 294 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: Could not compile `expo-server-sdk`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/lib.rs:354:17 [INFO] [stderr] | [INFO] [stderr] 354 | / if body.len() > 1024 { [INFO] [stderr] 355 | | true [INFO] [stderr] 356 | | } else { [INFO] [stderr] 357 | | false [INFO] [stderr] 358 | | } [INFO] [stderr] | |_________________^ help: you can reduce it to: `body.len() > 1024` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:407:9 [INFO] [stderr] | [INFO] [stderr] 407 | encoder.write(body.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `expo-server-sdk`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7e1a4d807a049c8592f47c22c7e1a31aaba8ee9e8a7f582d0f8da9927172da1d"` [INFO] running `"docker" "rm" "-f" "7e1a4d807a049c8592f47c22c7e1a31aaba8ee9e8a7f582d0f8da9927172da1d"` [INFO] [stdout] 7e1a4d807a049c8592f47c22c7e1a31aaba8ee9e8a7f582d0f8da9927172da1d