[INFO] crate expedite 0.1.0 is already in cache [INFO] extracting crate expedite 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/expedite/0.1.0 [INFO] extracting crate expedite 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/expedite/0.1.0 [INFO] validating manifest of expedite-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of expedite-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing expedite-0.1.0 [INFO] finished frobbing expedite-0.1.0 [INFO] frobbed toml for expedite-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/expedite/0.1.0/Cargo.toml [INFO] started frobbing expedite-0.1.0 [INFO] finished frobbing expedite-0.1.0 [INFO] frobbed toml for expedite-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/expedite/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting expedite-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/expedite/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 02c2af26bcf06acd371d053a33df67f70ac9399780cb132d6a7731283ae7978f [INFO] running `"docker" "start" "-a" "02c2af26bcf06acd371d053a33df67f70ac9399780cb132d6a7731283ae7978f"` [INFO] [stderr] Checking expedite v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datetime/date.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | day: day, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `day` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datetime/date.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | month: month, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `month` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datetime/date.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | day: day, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `day` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datetime/date.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | month: month, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `month` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datetime/date.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | year: year, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `year` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datetime/time.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | date: date, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datetime/time.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | date: date, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datetime/time.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | date: date, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datetime/date.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | day: day, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `day` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datetime/date.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | month: month, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `month` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datetime/date.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | day: day, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `day` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datetime/date.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | month: month, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `month` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datetime/date.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | year: year, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `year` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datetime/time.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | date: date, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datetime/time.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | date: date, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/datetime/time.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | date: date, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `datetime::time_change::TimeChange` [INFO] [stderr] --> src/datetime/date.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use datetime::time_change::TimeChange; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/datetime/date.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | static B: u32 = 274277; [INFO] [stderr] | ^^^^^^ help: consider: `274_277` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/datetime/date.rs:29:60 [INFO] [stderr] | [INFO] [stderr] 29 | let f = jdn + J + (((4u32.wrapping_mul(jdn) + B) / 146097) * 3) / 4 - C; [INFO] [stderr] | ^^^^^^ help: consider: `146_097` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/datetime/date.rs:62:12 [INFO] [stderr] | [INFO] [stderr] 62 | if (n >= 0) { [INFO] [stderr] | ^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/datetime/date.rs:73:12 [INFO] [stderr] | [INFO] [stderr] 73 | if (after_this_year > 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/datetime/date.rs:84:12 [INFO] [stderr] | [INFO] [stderr] 84 | if (n > self.month) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/datetime/date.rs:104:16 [INFO] [stderr] | [INFO] [stderr] 104 | jdn += (365u32.wrapping_mul(y)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/datetime/date.rs:105:16 [INFO] [stderr] | [INFO] [stderr] 105 | jdn += (y / 4); [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/datetime/date.rs:106:16 [INFO] [stderr] | [INFO] [stderr] 106 | jdn -= (y / 100); [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/datetime/date.rs:107:16 [INFO] [stderr] | [INFO] [stderr] 107 | jdn += (y / 400); [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/datetime/time_change.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | time [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/datetime/time_change.rs:161:20 [INFO] [stderr] | [INFO] [stderr] 161 | let time = Time::with_date(date) [INFO] [stderr] | ____________________^ [INFO] [stderr] 162 | | .hour(changed_hours as u32) [INFO] [stderr] 163 | | .minute(changed_minutes as u32) [INFO] [stderr] 164 | | .second(changed_seconds as u32) [INFO] [stderr] 165 | | .nanos(self.nanos); [INFO] [stderr] | |______________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `month` [INFO] [stderr] --> src/datetime/date.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | let month = self.month; [INFO] [stderr] | ^^^^^ help: consider using `_month` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `datetime::time::Time` [INFO] [stderr] --> src/datetime/time.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn new() -> Time { [INFO] [stderr] 34 | | let date = Date { [INFO] [stderr] 35 | | year: 0, [INFO] [stderr] 36 | | month: 0, [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | impl Default for datetime::time::Time { [INFO] [stderr] 14 | fn default() -> Self { [INFO] [stderr] 15 | Self::new() [INFO] [stderr] 16 | } [INFO] [stderr] 17 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `datetime::time_change::TimeChange` [INFO] [stderr] --> src/datetime/time_change.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> TimeChange { [INFO] [stderr] 20 | | TimeChange { [INFO] [stderr] 21 | | years: None, [INFO] [stderr] 22 | | months: None, [INFO] [stderr] ... | [INFO] [stderr] 29 | | } [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/datetime/time_change.rs:32:21 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn from_now(&self) -> Time { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/datetime/time_change.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | change.years.map(|supplied_years| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 96 | || let full_years = supplied_years.trunc(); [INFO] [stderr] 97 | || years = Some(full_years); [INFO] [stderr] 98 | || let partial_years = supplied_years - full_years; [INFO] [stderr] 99 | || [INFO] [stderr] 100 | || days = Some((partial_years * 365f32) + days.unwrap_or(0f32)); [INFO] [stderr] 101 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(supplied_years) = change.years { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/datetime/time_change.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | change.months.map(|supplied_months| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 104 | || let full_months = supplied_months.trunc(); [INFO] [stderr] 105 | || months = Some(full_months); [INFO] [stderr] 106 | || let partial_months = supplied_months - full_months; [INFO] [stderr] 107 | || [INFO] [stderr] 108 | || days = Some((partial_months * 30f32) + days.unwrap_or(0f32)); [INFO] [stderr] 109 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(supplied_months) = change.months { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/datetime/time_change.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | change.weeks.map(|supplied_weeks| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 112 | || days = Some(supplied_weeks * 7f32 + days.unwrap_or(0f32)); [INFO] [stderr] 113 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(supplied_weeks) = change.weeks { days = Some(supplied_weeks * 7f32 + days.unwrap_or(0f32)); }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/datetime/time_change.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | days.map(|supplied_days| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 116 | || let full_days = supplied_days.trunc(); [INFO] [stderr] 117 | || days = Some(full_days); [INFO] [stderr] 118 | || let partial_days = supplied_days - full_days; [INFO] [stderr] 119 | || [INFO] [stderr] 120 | || hours = Some((partial_days * 24f32) + hours.unwrap_or(0f32)); [INFO] [stderr] 121 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(supplied_days) = days { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/datetime/time_change.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | change.seconds.map(|seconds| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 133 | || if seconds + changed_seconds > 59f32 { [INFO] [stderr] 134 | || carry_minutes = 1f32; [INFO] [stderr] 135 | || changed_seconds += seconds - 60f32; [INFO] [stderr] 136 | || } [INFO] [stderr] 137 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(seconds) = change.seconds { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/datetime/time_change.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | change.minutes.map(|minutes| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 140 | || if minutes + changed_minutes + carry_minutes > 59f32 { [INFO] [stderr] 141 | || carry_hours = 1f32; [INFO] [stderr] 142 | || changed_minutes += minutes + carry_minutes - 60f32; [INFO] [stderr] 143 | || } [INFO] [stderr] 144 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(minutes) = change.minutes { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/datetime/time_change.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | change.hours.map(|hours| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 147 | || if hours + changed_hours + carry_hours > 23f32 { [INFO] [stderr] 148 | || carry_days = 1f32; [INFO] [stderr] 149 | || changed_hours += hours + carry_hours - 24f32; [INFO] [stderr] 150 | || } [INFO] [stderr] 151 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(hours) = change.hours { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/datetime/time_change.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | years.map(|years| date = date.advance_years(years as u32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(years) = years { ... }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/datetime/time_change.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | months.map(|months| date = date.advance_months(months as i32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(months) = months { ... }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/datetime/time_change.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | days.map(|days| date = date.advance_days(days as u32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(days) = days { ... }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: unused import: `datetime::time_change::TimeChange` [INFO] [stderr] --> src/datetime/date.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use datetime::time_change::TimeChange; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/datetime/date.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | static B: u32 = 274277; [INFO] [stderr] | ^^^^^^ help: consider: `274_277` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/datetime/date.rs:29:60 [INFO] [stderr] | [INFO] [stderr] 29 | let f = jdn + J + (((4u32.wrapping_mul(jdn) + B) / 146097) * 3) / 4 - C; [INFO] [stderr] | ^^^^^^ help: consider: `146_097` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/datetime/date.rs:62:12 [INFO] [stderr] | [INFO] [stderr] 62 | if (n >= 0) { [INFO] [stderr] | ^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/datetime/date.rs:73:12 [INFO] [stderr] | [INFO] [stderr] 73 | if (after_this_year > 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/datetime/date.rs:84:12 [INFO] [stderr] | [INFO] [stderr] 84 | if (n > self.month) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/datetime/date.rs:104:16 [INFO] [stderr] | [INFO] [stderr] 104 | jdn += (365u32.wrapping_mul(y)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/datetime/date.rs:105:16 [INFO] [stderr] | [INFO] [stderr] 105 | jdn += (y / 4); [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/datetime/date.rs:106:16 [INFO] [stderr] | [INFO] [stderr] 106 | jdn -= (y / 100); [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/datetime/date.rs:107:16 [INFO] [stderr] | [INFO] [stderr] 107 | jdn += (y / 400); [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/datetime/time_change.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | time [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/datetime/time_change.rs:161:20 [INFO] [stderr] | [INFO] [stderr] 161 | let time = Time::with_date(date) [INFO] [stderr] | ____________________^ [INFO] [stderr] 162 | | .hour(changed_hours as u32) [INFO] [stderr] 163 | | .minute(changed_minutes as u32) [INFO] [stderr] 164 | | .second(changed_seconds as u32) [INFO] [stderr] 165 | | .nanos(self.nanos); [INFO] [stderr] | |______________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `month` [INFO] [stderr] --> src/datetime/date.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | let month = self.month; [INFO] [stderr] | ^^^^^ help: consider using `_month` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `datetime::time::Time` [INFO] [stderr] --> src/datetime/time.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn new() -> Time { [INFO] [stderr] 34 | | let date = Date { [INFO] [stderr] 35 | | year: 0, [INFO] [stderr] 36 | | month: 0, [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | impl Default for datetime::time::Time { [INFO] [stderr] 14 | fn default() -> Self { [INFO] [stderr] 15 | Self::new() [INFO] [stderr] 16 | } [INFO] [stderr] 17 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `datetime::time_change::TimeChange` [INFO] [stderr] --> src/datetime/time_change.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> TimeChange { [INFO] [stderr] 20 | | TimeChange { [INFO] [stderr] 21 | | years: None, [INFO] [stderr] 22 | | months: None, [INFO] [stderr] ... | [INFO] [stderr] 29 | | } [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/datetime/time_change.rs:32:21 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn from_now(&self) -> Time { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/datetime/time_change.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | change.years.map(|supplied_years| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 96 | || let full_years = supplied_years.trunc(); [INFO] [stderr] 97 | || years = Some(full_years); [INFO] [stderr] 98 | || let partial_years = supplied_years - full_years; [INFO] [stderr] 99 | || [INFO] [stderr] 100 | || days = Some((partial_years * 365f32) + days.unwrap_or(0f32)); [INFO] [stderr] 101 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(supplied_years) = change.years { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/datetime/time_change.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | change.months.map(|supplied_months| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 104 | || let full_months = supplied_months.trunc(); [INFO] [stderr] 105 | || months = Some(full_months); [INFO] [stderr] 106 | || let partial_months = supplied_months - full_months; [INFO] [stderr] 107 | || [INFO] [stderr] 108 | || days = Some((partial_months * 30f32) + days.unwrap_or(0f32)); [INFO] [stderr] 109 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(supplied_months) = change.months { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/datetime/time_change.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | change.weeks.map(|supplied_weeks| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 112 | || days = Some(supplied_weeks * 7f32 + days.unwrap_or(0f32)); [INFO] [stderr] 113 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(supplied_weeks) = change.weeks { days = Some(supplied_weeks * 7f32 + days.unwrap_or(0f32)); }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/datetime/time_change.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | days.map(|supplied_days| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 116 | || let full_days = supplied_days.trunc(); [INFO] [stderr] 117 | || days = Some(full_days); [INFO] [stderr] 118 | || let partial_days = supplied_days - full_days; [INFO] [stderr] 119 | || [INFO] [stderr] 120 | || hours = Some((partial_days * 24f32) + hours.unwrap_or(0f32)); [INFO] [stderr] 121 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(supplied_days) = days { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/datetime/time_change.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | change.seconds.map(|seconds| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 133 | || if seconds + changed_seconds > 59f32 { [INFO] [stderr] 134 | || carry_minutes = 1f32; [INFO] [stderr] 135 | || changed_seconds += seconds - 60f32; [INFO] [stderr] 136 | || } [INFO] [stderr] 137 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(seconds) = change.seconds { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/datetime/time_change.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | change.minutes.map(|minutes| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 140 | || if minutes + changed_minutes + carry_minutes > 59f32 { [INFO] [stderr] 141 | || carry_hours = 1f32; [INFO] [stderr] 142 | || changed_minutes += minutes + carry_minutes - 60f32; [INFO] [stderr] 143 | || } [INFO] [stderr] 144 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(minutes) = change.minutes { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/datetime/time_change.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | change.hours.map(|hours| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 147 | || if hours + changed_hours + carry_hours > 23f32 { [INFO] [stderr] 148 | || carry_days = 1f32; [INFO] [stderr] 149 | || changed_hours += hours + carry_hours - 24f32; [INFO] [stderr] 150 | || } [INFO] [stderr] 151 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(hours) = change.hours { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/datetime/time_change.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | years.map(|years| date = date.advance_years(years as u32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(years) = years { ... }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/datetime/time_change.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | months.map(|months| date = date.advance_months(months as i32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(months) = months { ... }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/datetime/time_change.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | days.map(|days| date = date.advance_days(days as u32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(days) = days { ... }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | let mut map = hash!{'{' => '}', '[' => ']', '(' => ')'}; [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | let mut map = hash!{'{' => '}', '[' => ']', '(' => ')'}; [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.92s [INFO] running `"docker" "inspect" "02c2af26bcf06acd371d053a33df67f70ac9399780cb132d6a7731283ae7978f"` [INFO] running `"docker" "rm" "-f" "02c2af26bcf06acd371d053a33df67f70ac9399780cb132d6a7731283ae7978f"` [INFO] [stdout] 02c2af26bcf06acd371d053a33df67f70ac9399780cb132d6a7731283ae7978f