[INFO] crate expectation 0.1.1 is already in cache [INFO] extracting crate expectation 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/expectation/0.1.1 [INFO] extracting crate expectation 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/expectation/0.1.1 [INFO] validating manifest of expectation-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of expectation-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing expectation-0.1.1 [INFO] finished frobbing expectation-0.1.1 [INFO] frobbed toml for expectation-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/expectation/0.1.1/Cargo.toml [INFO] started frobbing expectation-0.1.1 [INFO] finished frobbing expectation-0.1.1 [INFO] frobbed toml for expectation-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/expectation/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting expectation-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/expectation/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] db3133a8f7634e00860bb3549606454544c6a1c5e1fe0a2482663aaf31d344e1 [INFO] running `"docker" "start" "-a" "db3133a8f7634e00860bb3549606454544c6a1c5e1fe0a2482663aaf31d344e1"` [INFO] [stderr] Checking expectation-shared v0.1.0 [INFO] [stderr] Checking expectation v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/extensions/image.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | / return write_requester.request(path.join("img-format.txt"), |w| { [INFO] [stderr] 136 | | writeln!(w, "image formats are different"); [INFO] [stderr] 137 | | writeln!(w, "actual: RGB8"); [INFO] [stderr] 138 | | writeln!(w, "expected: RGBA8 (Alpha)"); [INFO] [stderr] 139 | | Ok(()) [INFO] [stderr] 140 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 135 | write_requester.request(path.join("img-format.txt"), |w| { [INFO] [stderr] 136 | writeln!(w, "image formats are different"); [INFO] [stderr] 137 | writeln!(w, "actual: RGB8"); [INFO] [stderr] 138 | writeln!(w, "expected: RGBA8 (Alpha)"); [INFO] [stderr] 139 | Ok(()) [INFO] [stderr] 140 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/extensions/image.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | / return write_requester.request(path.join("img-format.txt"), |w| { [INFO] [stderr] 144 | | writeln!(w, "image formats are different"); [INFO] [stderr] 145 | | writeln!(w, "actual: RGBA8 (Alpha)"); [INFO] [stderr] 146 | | writeln!(w, "expected: RGB8"); [INFO] [stderr] 147 | | Ok(()) [INFO] [stderr] 148 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 143 | write_requester.request(path.join("img-format.txt"), |w| { [INFO] [stderr] 144 | writeln!(w, "image formats are different"); [INFO] [stderr] 145 | writeln!(w, "actual: RGBA8 (Alpha)"); [INFO] [stderr] 146 | writeln!(w, "expected: RGB8"); [INFO] [stderr] 147 | Ok(()) [INFO] [stderr] 148 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/extensions/image.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | / return write_requester.request(path.join("img-format.txt"), |w| { [INFO] [stderr] 136 | | writeln!(w, "image formats are different"); [INFO] [stderr] 137 | | writeln!(w, "actual: RGB8"); [INFO] [stderr] 138 | | writeln!(w, "expected: RGBA8 (Alpha)"); [INFO] [stderr] 139 | | Ok(()) [INFO] [stderr] 140 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 135 | write_requester.request(path.join("img-format.txt"), |w| { [INFO] [stderr] 136 | writeln!(w, "image formats are different"); [INFO] [stderr] 137 | writeln!(w, "actual: RGB8"); [INFO] [stderr] 138 | writeln!(w, "expected: RGBA8 (Alpha)"); [INFO] [stderr] 139 | Ok(()) [INFO] [stderr] 140 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/extensions/image.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | / return write_requester.request(path.join("img-format.txt"), |w| { [INFO] [stderr] 144 | | writeln!(w, "image formats are different"); [INFO] [stderr] 145 | | writeln!(w, "actual: RGBA8 (Alpha)"); [INFO] [stderr] 146 | | writeln!(w, "expected: RGB8"); [INFO] [stderr] 147 | | Ok(()) [INFO] [stderr] 148 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 143 | write_requester.request(path.join("img-format.txt"), |w| { [INFO] [stderr] 144 | writeln!(w, "image formats are different"); [INFO] [stderr] 145 | writeln!(w, "actual: RGBA8 (Alpha)"); [INFO] [stderr] 146 | writeln!(w, "expected: RGB8"); [INFO] [stderr] 147 | Ok(()) [INFO] [stderr] 148 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/extensions/text.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | |a, b| text_eq(a, b), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `text_eq` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/extensions/image.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | |a, b| image_eq(a, b), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `image_eq` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/extensions/image.rs:136:17 [INFO] [stderr] | [INFO] [stderr] 136 | writeln!(w, "image formats are different"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/extensions/image.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | writeln!(w, "actual: RGB8"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/extensions/image.rs:138:17 [INFO] [stderr] | [INFO] [stderr] 138 | writeln!(w, "expected: RGBA8 (Alpha)"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/extensions/image.rs:144:17 [INFO] [stderr] | [INFO] [stderr] 144 | writeln!(w, "image formats are different"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/extensions/image.rs:145:17 [INFO] [stderr] | [INFO] [stderr] 145 | writeln!(w, "actual: RGBA8 (Alpha)"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/extensions/image.rs:146:17 [INFO] [stderr] | [INFO] [stderr] 146 | writeln!(w, "expected: RGB8"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ipc.rs:24:39 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn send(test_name: &str, results: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[EResult]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:35:20 [INFO] [stderr] | [INFO] [stderr] 35 | .split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let fs =` [INFO] [stderr] --> src/lib.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | let fs = (); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/extensions/text.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | |a, b| text_eq(a, b), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `text_eq` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/extensions/image.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | |a, b| image_eq(a, b), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `image_eq` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/extensions/image.rs:136:17 [INFO] [stderr] | [INFO] [stderr] 136 | writeln!(w, "image formats are different"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/extensions/image.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | writeln!(w, "actual: RGB8"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/extensions/image.rs:138:17 [INFO] [stderr] | [INFO] [stderr] 138 | writeln!(w, "expected: RGBA8 (Alpha)"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/extensions/image.rs:144:17 [INFO] [stderr] | [INFO] [stderr] 144 | writeln!(w, "image formats are different"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/extensions/image.rs:145:17 [INFO] [stderr] | [INFO] [stderr] 145 | writeln!(w, "actual: RGBA8 (Alpha)"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/extensions/image.rs:146:17 [INFO] [stderr] | [INFO] [stderr] 146 | writeln!(w, "expected: RGB8"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ipc.rs:24:39 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn send(test_name: &str, results: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[EResult]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/test.rs:240:13 [INFO] [stderr] | [INFO] [stderr] 240 | |a, b| byte_for_byte_equality(a, b), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `byte_for_byte_equality` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:35:20 [INFO] [stderr] | [INFO] [stderr] 35 | .split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let fs =` [INFO] [stderr] --> src/lib.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | let fs = (); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.46s [INFO] running `"docker" "inspect" "db3133a8f7634e00860bb3549606454544c6a1c5e1fe0a2482663aaf31d344e1"` [INFO] running `"docker" "rm" "-f" "db3133a8f7634e00860bb3549606454544c6a1c5e1fe0a2482663aaf31d344e1"` [INFO] [stdout] db3133a8f7634e00860bb3549606454544c6a1c5e1fe0a2482663aaf31d344e1