[INFO] crate exif-rs 0.1.0 is already in cache
[INFO] extracting crate exif-rs 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/exif-rs/0.1.0
[INFO] extracting crate exif-rs 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/exif-rs/0.1.0
[INFO] validating manifest of exif-rs-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of exif-rs-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing exif-rs-0.1.0
[INFO] finished frobbing exif-rs-0.1.0
[INFO] frobbed toml for exif-rs-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/exif-rs/0.1.0/Cargo.toml
[INFO] started frobbing exif-rs-0.1.0
[INFO] finished frobbing exif-rs-0.1.0
[INFO] frobbed toml for exif-rs-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/exif-rs/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting exif-rs-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/exif-rs/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] afebd72247f4206f9b62eb00174d8506b2b6949475ae00ec564e87310b45b5a7
[INFO] running `"docker" "start" "-a" "afebd72247f4206f9b62eb00174d8506b2b6949475ae00ec564e87310b45b5a7"`
[INFO] [stderr]     Checking exif-rs v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:25:20
[INFO] [stderr]    |
[INFO] [stderr] 25 |         PosWriter{ inner: inner, pos: 0 }
[INFO] [stderr]    |                    ^^^^^^^^^^^^ help: replace it with: `inner`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:81:18
[INFO] [stderr]    |
[INFO] [stderr] 81 |         Ok(Exif{ ifds: ifds })
[INFO] [stderr]    |                  ^^^^^^^^^^ help: replace it with: `ifds`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:158:13
[INFO] [stderr]     |
[INFO] [stderr] 158 |             id: id,
[INFO] [stderr]     |             ^^^^^^ help: replace it with: `id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:159:13
[INFO] [stderr]     |
[INFO] [stderr] 159 |             entries: entries,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `entries`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:160:13
[INFO] [stderr]     |
[INFO] [stderr] 160 |             children: children,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `children`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:291:13
[INFO] [stderr]     |
[INFO] [stderr] 291 |             tag: tag,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `tag`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:25:20
[INFO] [stderr]    |
[INFO] [stderr] 25 |         PosWriter{ inner: inner, pos: 0 }
[INFO] [stderr]    |                    ^^^^^^^^^^^^ help: replace it with: `inner`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:81:18
[INFO] [stderr]    |
[INFO] [stderr] 81 |         Ok(Exif{ ifds: ifds })
[INFO] [stderr]    |                  ^^^^^^^^^^ help: replace it with: `ifds`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:158:13
[INFO] [stderr]     |
[INFO] [stderr] 158 |             id: id,
[INFO] [stderr]     |             ^^^^^^ help: replace it with: `id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:159:13
[INFO] [stderr]     |
[INFO] [stderr] 159 |             entries: entries,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `entries`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:160:13
[INFO] [stderr]     |
[INFO] [stderr] 160 |             children: children,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `children`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:291:13
[INFO] [stderr]     |
[INFO] [stderr] 291 |             tag: tag,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `tag`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]   --> src/jpeg.rs:33:20
[INFO] [stderr]    |
[INFO] [stderr] 33 |                 if &hdr == &[b'E', b'x', b'i', b'f', 0x00, 0x00] {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]    |
[INFO] [stderr] 33 |                 if hdr == [b'E', b'x', b'i', b'f', 0x00, 0x00] {
[INFO] [stderr]    |                    ^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/jpeg.rs:43:49
[INFO] [stderr]    |
[INFO] [stderr] 43 |                 try!(rdr.seek(SeekFrom::Current(len as i64)));
[INFO] [stderr]    |                                                 ^^^^^^^^^^ help: try: `i64::from(len)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:131:55
[INFO] [stderr]     |
[INFO] [stderr] 131 |                         try!(rdr.seek(SeekFrom::Start(off as u64)));
[INFO] [stderr]     |                                                       ^^^^^^^^^^ help: try: `u64::from(off)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `write_all` doesn't need a mutable reference
[INFO] [stderr]    --> src/lib.rs:348:34
[INFO] [stderr]     |
[INFO] [stderr] 348 |                 try!(w.write_all(&mut &pbuf[..pad as usize]));
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:429:47
[INFO] [stderr]     |
[INFO] [stderr] 429 |                 try!(rdr.seek(SeekFrom::Start(o as u64)));
[INFO] [stderr]     |                                               ^^^^^^^^ help: try: `u64::from(o)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:439:42
[INFO] [stderr]     |
[INFO] [stderr] 439 |                                         .ok_or(io::Error::new(io::ErrorKind::InvalidData, "invalid ascii data, no null terminator")));
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| io::Error::new(io::ErrorKind::InvalidData, "invalid ascii data, no null terminator"))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]   --> src/jpeg.rs:33:20
[INFO] [stderr]    |
[INFO] [stderr] 33 |                 if &hdr == &[b'E', b'x', b'i', b'f', 0x00, 0x00] {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]    |
[INFO] [stderr] 33 |                 if hdr == [b'E', b'x', b'i', b'f', 0x00, 0x00] {
[INFO] [stderr]    |                    ^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/jpeg.rs:43:49
[INFO] [stderr]    |
[INFO] [stderr] 43 |                 try!(rdr.seek(SeekFrom::Current(len as i64)));
[INFO] [stderr]    |                                                 ^^^^^^^^^^ help: try: `i64::from(len)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:131:55
[INFO] [stderr]     |
[INFO] [stderr] 131 |                         try!(rdr.seek(SeekFrom::Start(off as u64)));
[INFO] [stderr]     |                                                       ^^^^^^^^^^ help: try: `u64::from(off)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `write_all` doesn't need a mutable reference
[INFO] [stderr]    --> src/lib.rs:348:34
[INFO] [stderr]     |
[INFO] [stderr] 348 |                 try!(w.write_all(&mut &pbuf[..pad as usize]));
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/lib.rs:429:47
[INFO] [stderr]     |
[INFO] [stderr] 429 |                 try!(rdr.seek(SeekFrom::Start(o as u64)));
[INFO] [stderr]     |                                               ^^^^^^^^ help: try: `u64::from(o)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:439:42
[INFO] [stderr]     |
[INFO] [stderr] 439 |                                         .ok_or(io::Error::new(io::ErrorKind::InvalidData, "invalid ascii data, no null terminator")));
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| io::Error::new(io::ErrorKind::InvalidData, "invalid ascii data, no null terminator"))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.50s
[INFO] running `"docker" "inspect" "afebd72247f4206f9b62eb00174d8506b2b6949475ae00ec564e87310b45b5a7"`
[INFO] running `"docker" "rm" "-f" "afebd72247f4206f9b62eb00174d8506b2b6949475ae00ec564e87310b45b5a7"`
[INFO] [stdout] afebd72247f4206f9b62eb00174d8506b2b6949475ae00ec564e87310b45b5a7