[INFO] crate executors 0.4.1 is already in cache [INFO] extracting crate executors 0.4.1 into work/ex/clippy-test-run/sources/stable/reg/executors/0.4.1 [INFO] extracting crate executors 0.4.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/executors/0.4.1 [INFO] validating manifest of executors-0.4.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of executors-0.4.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing executors-0.4.1 [INFO] finished frobbing executors-0.4.1 [INFO] frobbed toml for executors-0.4.1 written to work/ex/clippy-test-run/sources/stable/reg/executors/0.4.1/Cargo.toml [INFO] started frobbing executors-0.4.1 [INFO] finished frobbing executors-0.4.1 [INFO] frobbed toml for executors-0.4.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/executors/0.4.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting executors-0.4.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/executors/0.4.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d4b60e0b933fa426b24e650ecefca77dc5b80c7556dee74cd2e88183fc24f3a0 [INFO] running `"docker" "start" "-a" "d4b60e0b933fa426b24e650ecefca77dc5b80c7556dee74cd2e88183fc24f3a0"` [INFO] [stderr] Checking synchronoise v0.4.0 [INFO] [stderr] Checking executors v0.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/common.rs:106:31 [INFO] [stderr] | [INFO] [stderr] 106 | pub(crate) fn ignore(_: V) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/common.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/crossbeam_workstealing_pool.rs:437:51 [INFO] [stderr] | [INFO] [stderr] 437 | recv(channel::after(max_wait)) => (), [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused import: `common::LogErrors` [INFO] [stderr] --> src/lib.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | use common::LogErrors; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `NS_PER_S` [INFO] [stderr] --> src/timeconstants.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | pub const NS_PER_S: u64 = 1_000_000_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `US_PER_S` [INFO] [stderr] --> src/timeconstants.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub const US_PER_S: u64 = 1_000_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `US_PER_MS` [INFO] [stderr] --> src/timeconstants.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | pub const US_PER_MS: u64 = 1_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `NS_PER_US` [INFO] [stderr] --> src/timeconstants.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | pub const NS_PER_US: u64 = 1_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `run_now::RunNowExecutor` [INFO] [stderr] --> src/run_now.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / pub fn new() -> RunNowExecutor { [INFO] [stderr] 39 | | RunNowExecutor { active: Arc::new(AtomicBool::new(true)) } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 31 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/crossbeam_channel_pool.rs:159:29 [INFO] [stderr] | [INFO] [stderr] 159 | Result::Err(String::from(msg)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `msg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/crossbeam_workstealing_pool.rs:197:29 [INFO] [stderr] | [INFO] [stderr] 197 | Result::Err(String::from(msg)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `msg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/common.rs:106:31 [INFO] [stderr] | [INFO] [stderr] 106 | pub(crate) fn ignore(_: V) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/common.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/crossbeam_workstealing_pool.rs:437:51 [INFO] [stderr] | [INFO] [stderr] 437 | recv(channel::after(max_wait)) => (), [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused import: `common::LogErrors` [INFO] [stderr] --> src/lib.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | use common::LogErrors; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `a` [INFO] [stderr] --> src/common.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | a: u32, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `b` [INFO] [stderr] --> src/common.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | b: f64, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `c` [INFO] [stderr] --> src/common.rs:170:9 [INFO] [stderr] | [INFO] [stderr] 170 | c: bool, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `NS_PER_S` [INFO] [stderr] --> src/timeconstants.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | pub const NS_PER_S: u64 = 1_000_000_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `US_PER_S` [INFO] [stderr] --> src/timeconstants.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub const US_PER_S: u64 = 1_000_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `US_PER_MS` [INFO] [stderr] --> src/timeconstants.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | pub const US_PER_MS: u64 = 1_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `NS_PER_US` [INFO] [stderr] --> src/timeconstants.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | pub const NS_PER_US: u64 = 1_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `run_now::RunNowExecutor` [INFO] [stderr] --> src/run_now.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / pub fn new() -> RunNowExecutor { [INFO] [stderr] 39 | | RunNowExecutor { active: Arc::new(AtomicBool::new(true)) } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 31 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/crossbeam_channel_pool.rs:159:29 [INFO] [stderr] | [INFO] [stderr] 159 | Result::Err(String::from(msg)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `msg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/crossbeam_workstealing_pool.rs:197:29 [INFO] [stderr] | [INFO] [stderr] 197 | Result::Err(String::from(msg)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `msg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/crossbeam_workstealing_pool.rs:612:9 [INFO] [stderr] | [INFO] [stderr] 612 | pool.shutdown(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/crossbeam_workstealing_pool.rs:635:9 [INFO] [stderr] | [INFO] [stderr] 635 | pool.shutdown(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/crossbeam_workstealing_pool.rs:651:9 [INFO] [stderr] | [INFO] [stderr] 651 | pool.shutdown(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/crossbeam_workstealing_pool.rs:670:9 [INFO] [stderr] | [INFO] [stderr] 670 | pool.shutdown(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.61s [INFO] running `"docker" "inspect" "d4b60e0b933fa426b24e650ecefca77dc5b80c7556dee74cd2e88183fc24f3a0"` [INFO] running `"docker" "rm" "-f" "d4b60e0b933fa426b24e650ecefca77dc5b80c7556dee74cd2e88183fc24f3a0"` [INFO] [stdout] d4b60e0b933fa426b24e650ecefca77dc5b80c7556dee74cd2e88183fc24f3a0