[INFO] crate evm-stateful 0.9.2 is already in cache
[INFO] extracting crate evm-stateful 0.9.2 into work/ex/clippy-test-run/sources/stable/reg/evm-stateful/0.9.2
[INFO] extracting crate evm-stateful 0.9.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/evm-stateful/0.9.2
[INFO] validating manifest of evm-stateful-0.9.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of evm-stateful-0.9.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing evm-stateful-0.9.2
[INFO] finished frobbing evm-stateful-0.9.2
[INFO] frobbed toml for evm-stateful-0.9.2 written to work/ex/clippy-test-run/sources/stable/reg/evm-stateful/0.9.2/Cargo.toml
[INFO] started frobbing evm-stateful-0.9.2
[INFO] finished frobbing evm-stateful-0.9.2
[INFO] frobbed toml for evm-stateful-0.9.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/evm-stateful/0.9.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting evm-stateful-0.9.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/evm-stateful/0.9.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] cf9da2e9155edbe692fb0e9efa0f1d4897410c29036d2f1571caefa0f7622192
[INFO] running `"docker" "start" "-a" "cf9da2e9155edbe692fb0e9efa0f1d4897410c29036d2f1571caefa0f7622192"`
[INFO] [stderr]     Checking ethereum-hexutil v0.2.3
[INFO] [stderr]     Checking elastic-array-plus v0.9.1
[INFO] [stderr]     Checking hmac v0.4.2
[INFO] [stderr]     Checking sha3 v0.6.0
[INFO] [stderr]     Checking ripemd160 v0.6.0
[INFO] [stderr]     Checking hmac-drbg v0.1.2
[INFO] [stderr]     Checking libsecp256k1 v0.1.15
[INFO] [stderr]     Checking ethereum-rlp v0.2.3
[INFO] [stderr]     Checking ethereum-bigint v0.2.9
[INFO] [stderr]     Checking ethereum-block-core v0.1.0
[INFO] [stderr]     Checking ethereum-trie v0.3.8
[INFO] [stderr]     Checking ethereum-bloom v0.2.1
[INFO] [stderr]     Checking ethereum-block v0.3.5
[INFO] [stderr]     Checking evm v0.9.4
[INFO] [stderr]     Checking evm-stateful v0.9.2 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:104:33
[INFO] [stderr]     |
[INFO] [stderr] 104 |                                 address: address,
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^ help: replace it with: `address`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:126:33
[INFO] [stderr]     |
[INFO] [stderr] 126 |                                 address: address,
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^ help: replace it with: `address`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:144:33
[INFO] [stderr]     |
[INFO] [stderr] 144 |                                 address: address,
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^ help: replace it with: `address`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:188:33
[INFO] [stderr]     |
[INFO] [stderr] 188 |                                 address: address,
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^ help: replace it with: `address`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:210:33
[INFO] [stderr]     |
[INFO] [stderr] 210 |                                 address: address,
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^ help: replace it with: `address`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:228:33
[INFO] [stderr]     |
[INFO] [stderr] 228 |                                 address: address,
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^ help: replace it with: `address`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:352:25
[INFO] [stderr]     |
[INFO] [stderr] 352 |                         nonce: nonce,
[INFO] [stderr]     |                         ^^^^^^^^^^^^ help: replace it with: `nonce`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:353:25
[INFO] [stderr]     |
[INFO] [stderr] 353 |                         balance: balance,
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^ help: replace it with: `balance`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:405:33
[INFO] [stderr]     |
[INFO] [stderr] 405 |                                 address: address,
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^ help: replace it with: `address`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:427:33
[INFO] [stderr]     |
[INFO] [stderr] 427 |                                 address: address,
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^ help: replace it with: `address`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:445:33
[INFO] [stderr]     |
[INFO] [stderr] 445 |                                 address: address,
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^ help: replace it with: `address`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:104:33
[INFO] [stderr]     |
[INFO] [stderr] 104 |                                 address: address,
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^ help: replace it with: `address`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:126:33
[INFO] [stderr]     |
[INFO] [stderr] 126 |                                 address: address,
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^ help: replace it with: `address`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:144:33
[INFO] [stderr]     |
[INFO] [stderr] 144 |                                 address: address,
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^ help: replace it with: `address`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:188:33
[INFO] [stderr]     |
[INFO] [stderr] 188 |                                 address: address,
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^ help: replace it with: `address`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:210:33
[INFO] [stderr]     |
[INFO] [stderr] 210 |                                 address: address,
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^ help: replace it with: `address`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:228:33
[INFO] [stderr]     |
[INFO] [stderr] 228 |                                 address: address,
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^ help: replace it with: `address`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:352:25
[INFO] [stderr]     |
[INFO] [stderr] 352 |                         nonce: nonce,
[INFO] [stderr]     |                         ^^^^^^^^^^^^ help: replace it with: `nonce`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:353:25
[INFO] [stderr]     |
[INFO] [stderr] 353 |                         balance: balance,
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^ help: replace it with: `balance`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:405:33
[INFO] [stderr]     |
[INFO] [stderr] 405 |                                 address: address,
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^ help: replace it with: `address`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:427:33
[INFO] [stderr]     |
[INFO] [stderr] 427 |                                 address: address,
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^ help: replace it with: `address`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:445:33
[INFO] [stderr]     |
[INFO] [stderr] 445 |                                 address: address,
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^ help: replace it with: `address`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]   --> src/lib.rs:41:23
[INFO] [stderr]    |
[INFO] [stderr] 41 |             database: self.database.clone(),
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]    |
[INFO] [stderr] 41 |             database: &(*self.database).clone(),
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]    |
[INFO] [stderr] 41 |             database: &D::clone(self.database),
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/lib.rs:42:19
[INFO] [stderr]    |
[INFO] [stderr] 42 |             root: self.root.clone(),
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.root`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:141:73
[INFO] [stderr]     |
[INFO] [stderr] 141 |                             let value = storage.get(&H256::from(index)).unwrap_or(M256::zero());
[INFO] [stderr]     |                                                                         ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(M256::zero)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:225:73
[INFO] [stderr]     |
[INFO] [stderr] 225 |                             let value = storage.get(&H256::from(index)).unwrap_or(M256::zero());
[INFO] [stderr]     |                                                                         ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(M256::zero)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:442:73
[INFO] [stderr]     |
[INFO] [stderr] 442 |                             let value = storage.get(&H256::from(index)).unwrap_or(M256::zero());
[INFO] [stderr]     |                                                                         ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(M256::zero)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `evm-stateful`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]   --> src/lib.rs:41:23
[INFO] [stderr]    |
[INFO] [stderr] 41 |             database: self.database.clone(),
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]    |
[INFO] [stderr] 41 |             database: &(*self.database).clone(),
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]    |
[INFO] [stderr] 41 |             database: &D::clone(self.database),
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/lib.rs:42:19
[INFO] [stderr]    |
[INFO] [stderr] 42 |             root: self.root.clone(),
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.root`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:141:73
[INFO] [stderr]     |
[INFO] [stderr] 141 |                             let value = storage.get(&H256::from(index)).unwrap_or(M256::zero());
[INFO] [stderr]     |                                                                         ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(M256::zero)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:225:73
[INFO] [stderr]     |
[INFO] [stderr] 225 |                             let value = storage.get(&H256::from(index)).unwrap_or(M256::zero());
[INFO] [stderr]     |                                                                         ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(M256::zero)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:442:73
[INFO] [stderr]     |
[INFO] [stderr] 442 |                             let value = storage.get(&H256::from(index)).unwrap_or(M256::zero());
[INFO] [stderr]     |                                                                         ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(M256::zero)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `evm-stateful`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "cf9da2e9155edbe692fb0e9efa0f1d4897410c29036d2f1571caefa0f7622192"`
[INFO] running `"docker" "rm" "-f" "cf9da2e9155edbe692fb0e9efa0f1d4897410c29036d2f1571caefa0f7622192"`
[INFO] [stdout] cf9da2e9155edbe692fb0e9efa0f1d4897410c29036d2f1571caefa0f7622192