[INFO] crate eventsourcing-derive 0.1.1 is already in cache [INFO] extracting crate eventsourcing-derive 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/eventsourcing-derive/0.1.1 [INFO] extracting crate eventsourcing-derive 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/eventsourcing-derive/0.1.1 [INFO] validating manifest of eventsourcing-derive-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of eventsourcing-derive-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing eventsourcing-derive-0.1.1 [INFO] finished frobbing eventsourcing-derive-0.1.1 [INFO] frobbed toml for eventsourcing-derive-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/eventsourcing-derive/0.1.1/Cargo.toml [INFO] started frobbing eventsourcing-derive-0.1.1 [INFO] finished frobbing eventsourcing-derive-0.1.1 [INFO] frobbed toml for eventsourcing-derive-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/eventsourcing-derive/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting eventsourcing-derive-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/eventsourcing-derive/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4c4017db61343eb0490eda6a4ae43d90607794e5785d3cf104d8a78f1349b654 [INFO] running `"docker" "start" "-a" "4c4017db61343eb0490eda6a4ae43d90607794e5785d3cf104d8a78f1349b654"` [INFO] [stderr] Checking eventsourcing-derive v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | x [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:86:21 [INFO] [stderr] | [INFO] [stderr] 86 | let x = syn::parse2::(attr.tts.clone()) [INFO] [stderr] | _____________________^ [INFO] [stderr] 87 | | .unwrap() [INFO] [stderr] 88 | | .event_type_version; [INFO] [stderr] | |___________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | x [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:98:21 [INFO] [stderr] | [INFO] [stderr] 98 | let x = syn::parse2::(attr.tts.clone()) [INFO] [stderr] | _____________________^ [INFO] [stderr] 99 | | .unwrap() [INFO] [stderr] 100 | | .event_source; [INFO] [stderr] | |_____________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | x [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:86:21 [INFO] [stderr] | [INFO] [stderr] 86 | let x = syn::parse2::(attr.tts.clone()) [INFO] [stderr] | _____________________^ [INFO] [stderr] 87 | | .unwrap() [INFO] [stderr] 88 | | .event_type_version; [INFO] [stderr] | |___________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | x [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:98:21 [INFO] [stderr] | [INFO] [stderr] 98 | let x = syn::parse2::(attr.tts.clone()) [INFO] [stderr] | _____________________^ [INFO] [stderr] 99 | | .unwrap() [INFO] [stderr] 100 | | .event_source; [INFO] [stderr] | |_____________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / named!(parse -> Self, map!( [INFO] [stderr] 58 | | parens!(syn!(LitStr)), [INFO] [stderr] 59 | | |(_, event_source)| EventSourceAttribute { event_source } [INFO] [stderr] 60 | | )); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | / named!(parse -> Self, map!( [INFO] [stderr] 65 | | parens!(syn!(Path)), [INFO] [stderr] 66 | | |(_, aggregate)| AggregateAttribute { aggregate } [INFO] [stderr] 67 | | )); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | / named!(parse -> Self, map!( [INFO] [stderr] 72 | | parens!(syn!(LitStr)), [INFO] [stderr] 73 | | |(_, event_type_version) | EventTypeVersionAttribute { event_type_version } [INFO] [stderr] 74 | | )); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:133:11 [INFO] [stderr] | [INFO] [stderr] 133 | name: &Ident, [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:162:26 [INFO] [stderr] | [INFO] [stderr] 162 | fn event_type_name(name: &Ident, variant_id: &Ident) -> String { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:162:46 [INFO] [stderr] | [INFO] [stderr] 162 | fn event_type_name(name: &Ident, variant_id: &Ident) -> String { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / named!(parse -> Self, map!( [INFO] [stderr] 58 | | parens!(syn!(LitStr)), [INFO] [stderr] 59 | | |(_, event_source)| EventSourceAttribute { event_source } [INFO] [stderr] 60 | | )); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | / named!(parse -> Self, map!( [INFO] [stderr] 65 | | parens!(syn!(Path)), [INFO] [stderr] 66 | | |(_, aggregate)| AggregateAttribute { aggregate } [INFO] [stderr] 67 | | )); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | / named!(parse -> Self, map!( [INFO] [stderr] 72 | | parens!(syn!(LitStr)), [INFO] [stderr] 73 | | |(_, event_type_version) | EventTypeVersionAttribute { event_type_version } [INFO] [stderr] 74 | | )); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:133:11 [INFO] [stderr] | [INFO] [stderr] 133 | name: &Ident, [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:162:26 [INFO] [stderr] | [INFO] [stderr] 162 | fn event_type_name(name: &Ident, variant_id: &Ident) -> String { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:162:46 [INFO] [stderr] | [INFO] [stderr] 162 | fn event_type_name(name: &Ident, variant_id: &Ident) -> String { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.32s [INFO] running `"docker" "inspect" "4c4017db61343eb0490eda6a4ae43d90607794e5785d3cf104d8a78f1349b654"` [INFO] running `"docker" "rm" "-f" "4c4017db61343eb0490eda6a4ae43d90607794e5785d3cf104d8a78f1349b654"` [INFO] [stdout] 4c4017db61343eb0490eda6a4ae43d90607794e5785d3cf104d8a78f1349b654