[INFO] crate evalchroma 0.1.1 is already in cache [INFO] extracting crate evalchroma 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/evalchroma/0.1.1 [INFO] extracting crate evalchroma 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/evalchroma/0.1.1 [INFO] validating manifest of evalchroma-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of evalchroma-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing evalchroma-0.1.1 [INFO] finished frobbing evalchroma-0.1.1 [INFO] frobbed toml for evalchroma-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/evalchroma/0.1.1/Cargo.toml [INFO] started frobbing evalchroma-0.1.1 [INFO] finished frobbing evalchroma-0.1.1 [INFO] frobbed toml for evalchroma-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/evalchroma/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting evalchroma-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/evalchroma/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 087742a616cb356791066a58021c3e0f0d9e9699ab9ada699429ad8ed0111d1f [INFO] running `"docker" "start" "-a" "087742a616cb356791066a58021c3e0f0d9e9699ab9ada699429ad8ed0111d1f"` [INFO] [stderr] Checking imgref v1.3.5 [INFO] [stderr] Checking evalchroma v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | let r = self.r as i16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i16::from(self.r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | let g = self.g as i16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i16::from(self.g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | let b = self.b as i16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i16::from(self.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:113:16 [INFO] [stderr] | [INFO] [stderr] 113 | let cb_d = (c0.cb + c2.cb) as i32 - 2*c1.cb as i32; // average is an ideal slope we can do with upscaling [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(c0.cb + c2.cb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:113:43 [INFO] [stderr] | [INFO] [stderr] 113 | let cb_d = (c0.cb + c2.cb) as i32 - 2*c1.cb as i32; // average is an ideal slope we can do with upscaling [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(c1.cb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:114:16 [INFO] [stderr] | [INFO] [stderr] 114 | let cr_d = (c0.cr + c2.cr) as i32 - 2*c1.cr as i32; // average is an ideal slope we can do with upscaling [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(c0.cr + c2.cr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:114:43 [INFO] [stderr] | [INFO] [stderr] 114 | let cr_d = (c0.cr + c2.cr) as i32 - 2*c1.cr as i32; // average is an ideal slope we can do with upscaling [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(c1.cr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:118:26 [INFO] [stderr] | [INFO] [stderr] 118 | let contrast_boost = (y_max - (y_max/2 - c1.y as i16).abs()) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(y_max - (y_max/2 - c1.y as i16).abs())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:120:16 [INFO] [stderr] | [INFO] [stderr] 120 | let edge = (c0.y as i16 - c2.y as i16).abs() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from((c0.y as i16 - c2.y as i16).abs())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:121:25 [INFO] [stderr] | [INFO] [stderr] 121 | let no_edge_boost = y_max as i32 * 2 - edge; // range is y_max .. 2*y_max, so that even hard edges keep some weight [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(y_max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/lib.rs:196:9 [INFO] [stderr] | [INFO] [stderr] 196 | 0...100 => sh.horiz *= 2, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_overlapping_arm)] on by default [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/lib.rs:197:9 [INFO] [stderr] | [INFO] [stderr] 197 | 0...1800 => {}, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/lib.rs:201:9 [INFO] [stderr] | [INFO] [stderr] 201 | 0...100 => sh.vert *= 2, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/lib.rs:202:9 [INFO] [stderr] | [INFO] [stderr] 202 | 0...1600 => {}, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | let r = self.r as i16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i16::from(self.r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | let g = self.g as i16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i16::from(self.g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | let b = self.b as i16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i16::from(self.b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:113:16 [INFO] [stderr] | [INFO] [stderr] 113 | let cb_d = (c0.cb + c2.cb) as i32 - 2*c1.cb as i32; // average is an ideal slope we can do with upscaling [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(c0.cb + c2.cb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:113:43 [INFO] [stderr] | [INFO] [stderr] 113 | let cb_d = (c0.cb + c2.cb) as i32 - 2*c1.cb as i32; // average is an ideal slope we can do with upscaling [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(c1.cb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:114:16 [INFO] [stderr] | [INFO] [stderr] 114 | let cr_d = (c0.cr + c2.cr) as i32 - 2*c1.cr as i32; // average is an ideal slope we can do with upscaling [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(c0.cr + c2.cr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:114:43 [INFO] [stderr] | [INFO] [stderr] 114 | let cr_d = (c0.cr + c2.cr) as i32 - 2*c1.cr as i32; // average is an ideal slope we can do with upscaling [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(c1.cr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:118:26 [INFO] [stderr] | [INFO] [stderr] 118 | let contrast_boost = (y_max - (y_max/2 - c1.y as i16).abs()) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(y_max - (y_max/2 - c1.y as i16).abs())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:120:16 [INFO] [stderr] | [INFO] [stderr] 120 | let edge = (c0.y as i16 - c2.y as i16).abs() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from((c0.y as i16 - c2.y as i16).abs())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:121:25 [INFO] [stderr] | [INFO] [stderr] 121 | let no_edge_boost = y_max as i32 * 2 - edge; // range is y_max .. 2*y_max, so that even hard edges keep some weight [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(y_max)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/lib.rs:196:9 [INFO] [stderr] | [INFO] [stderr] 196 | 0...100 => sh.horiz *= 2, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_overlapping_arm)] on by default [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/lib.rs:197:9 [INFO] [stderr] | [INFO] [stderr] 197 | 0...1800 => {}, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/lib.rs:201:9 [INFO] [stderr] | [INFO] [stderr] 201 | 0...100 => sh.vert *= 2, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/lib.rs:202:9 [INFO] [stderr] | [INFO] [stderr] 202 | 0...1600 => {}, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.09s [INFO] running `"docker" "inspect" "087742a616cb356791066a58021c3e0f0d9e9699ab9ada699429ad8ed0111d1f"` [INFO] running `"docker" "rm" "-f" "087742a616cb356791066a58021c3e0f0d9e9699ab9ada699429ad8ed0111d1f"` [INFO] [stdout] 087742a616cb356791066a58021c3e0f0d9e9699ab9ada699429ad8ed0111d1f