[INFO] crate eval 0.4.3 is already in cache [INFO] extracting crate eval 0.4.3 into work/ex/clippy-test-run/sources/stable/reg/eval/0.4.3 [INFO] extracting crate eval 0.4.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/eval/0.4.3 [INFO] validating manifest of eval-0.4.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of eval-0.4.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing eval-0.4.3 [INFO] finished frobbing eval-0.4.3 [INFO] frobbed toml for eval-0.4.3 written to work/ex/clippy-test-run/sources/stable/reg/eval/0.4.3/Cargo.toml [INFO] started frobbing eval-0.4.3 [INFO] finished frobbing eval-0.4.3 [INFO] frobbed toml for eval-0.4.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/eval/0.4.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting eval-0.4.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/eval/0.4.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7e06fb6efd68f56f65ce6c4a3413fc3e4708f2040c295cf8290e416476bf44c5 [INFO] running `"docker" "start" "-a" "7e06fb6efd68f56f65ce6c4a3413fc3e4708f2040c295cf8290e416476bf44c5"` [INFO] [stderr] Checking eval v0.4.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr/mod.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | expr: expr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `expr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr/mod.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | expr: expr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `expr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node/mod.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | return !self.closed && self.operator.can_have_child() && self.operator.can_have_child() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!self.closed && self.operator.can_have_child() && self.operator.can_have_child()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tree/mod.rs:381:29 [INFO] [stderr] | [INFO] [stderr] 381 | return Ok(value.unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(value.unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tree/mod.rs:383:29 [INFO] [stderr] | [INFO] [stderr] 383 | return Ok(Value::Null); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Value::Null)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tree/mod.rs:432:29 [INFO] [stderr] | [INFO] [stderr] 432 | return Ok(value.unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(value.unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tree/mod.rs:434:29 [INFO] [stderr] | [INFO] [stderr] 434 | return Ok(Value::Null); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Value::Null)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/tree/mod.rs:368:36 [INFO] [stderr] | [INFO] [stderr] 368 | } else { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 369 | | if child.operator.is_identifier() { [INFO] [stderr] 370 | | value = value.as_ref() [INFO] [stderr] 371 | | .unwrap() [INFO] [stderr] ... | [INFO] [stderr] 376 | | } [INFO] [stderr] 377 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 368 | } else if child.operator.is_identifier() { [INFO] [stderr] 369 | value = value.as_ref() [INFO] [stderr] 370 | .unwrap() [INFO] [stderr] 371 | .get(child.operator.get_identifier()) [INFO] [stderr] 372 | .cloned(); [INFO] [stderr] 373 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/tree/mod.rs:414:36 [INFO] [stderr] | [INFO] [stderr] 414 | } else { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 415 | | if name.is_u64() { [INFO] [stderr] 416 | | if value.as_ref().unwrap().is_array() { [INFO] [stderr] 417 | | value = value.as_ref() [INFO] [stderr] ... | [INFO] [stderr] 428 | | } [INFO] [stderr] 429 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 414 | } else if name.is_u64() { [INFO] [stderr] 415 | if value.as_ref().unwrap().is_array() { [INFO] [stderr] 416 | value = value.as_ref() [INFO] [stderr] 417 | .unwrap() [INFO] [stderr] 418 | .as_array() [INFO] [stderr] 419 | .unwrap() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node/mod.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | return !self.closed && self.operator.can_have_child() && self.operator.can_have_child() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!self.closed && self.operator.can_have_child() && self.operator.can_have_child()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tree/mod.rs:381:29 [INFO] [stderr] | [INFO] [stderr] 381 | return Ok(value.unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(value.unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tree/mod.rs:383:29 [INFO] [stderr] | [INFO] [stderr] 383 | return Ok(Value::Null); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Value::Null)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tree/mod.rs:432:29 [INFO] [stderr] | [INFO] [stderr] 432 | return Ok(value.unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(value.unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tree/mod.rs:434:29 [INFO] [stderr] | [INFO] [stderr] 434 | return Ok(Value::Null); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Value::Null)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/tree/mod.rs:368:36 [INFO] [stderr] | [INFO] [stderr] 368 | } else { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 369 | | if child.operator.is_identifier() { [INFO] [stderr] 370 | | value = value.as_ref() [INFO] [stderr] 371 | | .unwrap() [INFO] [stderr] ... | [INFO] [stderr] 376 | | } [INFO] [stderr] 377 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 368 | } else if child.operator.is_identifier() { [INFO] [stderr] 369 | value = value.as_ref() [INFO] [stderr] 370 | .unwrap() [INFO] [stderr] 371 | .get(child.operator.get_identifier()) [INFO] [stderr] 372 | .cloned(); [INFO] [stderr] 373 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/tree/mod.rs:414:36 [INFO] [stderr] | [INFO] [stderr] 414 | } else { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 415 | | if name.is_u64() { [INFO] [stderr] 416 | | if value.as_ref().unwrap().is_array() { [INFO] [stderr] 417 | | value = value.as_ref() [INFO] [stderr] ... | [INFO] [stderr] 428 | | } [INFO] [stderr] 429 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 414 | } else if name.is_u64() { [INFO] [stderr] 415 | if value.as_ref().unwrap().is_array() { [INFO] [stderr] 416 | value = value.as_ref() [INFO] [stderr] 417 | .unwrap() [INFO] [stderr] 418 | .as_array() [INFO] [stderr] 419 | .unwrap() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/tree/mod.rs:398:60 [INFO] [stderr] | [INFO] [stderr] 398 | } else if name.is_object() { [INFO] [stderr] | ____________________________________________________________^ [INFO] [stderr] 399 | | value = Some(name); [INFO] [stderr] 400 | | } else if name.is_null() { [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/tree/mod.rs:396:59 [INFO] [stderr] | [INFO] [stderr] 396 | } else if name.is_array() { [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 397 | | value = Some(name); [INFO] [stderr] 398 | | } else if name.is_object() { [INFO] [stderr] | |_________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/builtin/mod.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> Functions { [INFO] [stderr] 11 | | let mut functions = Functions::new(); [INFO] [stderr] 12 | | functions.insert("min".to_owned(), create_min_fuction()); [INFO] [stderr] 13 | | functions.insert("max".to_owned(), create_max_fuction()); [INFO] [stderr] ... | [INFO] [stderr] 17 | | functions [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/expr/mod.rs:110:60 [INFO] [stderr] | [INFO] [stderr] 110 | pub fn contexts(&mut self, contexts: &'a [Context]) -> &'a mut ExecOptions { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::mut_from_ref)] on by default [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/expr/mod.rs:110:42 [INFO] [stderr] | [INFO] [stderr] 110 | pub fn contexts(&mut self, contexts: &'a [Context]) -> &'a mut ExecOptions { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/expr/mod.rs:116:62 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn functions(&mut self, functions: &'a Functions) -> &'a mut ExecOptions { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/expr/mod.rs:116:44 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn functions(&mut self, functions: &'a Functions) -> &'a mut ExecOptions { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `eval`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/tree/mod.rs:398:60 [INFO] [stderr] | [INFO] [stderr] 398 | } else if name.is_object() { [INFO] [stderr] | ____________________________________________________________^ [INFO] [stderr] 399 | | value = Some(name); [INFO] [stderr] 400 | | } else if name.is_null() { [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/tree/mod.rs:396:59 [INFO] [stderr] | [INFO] [stderr] 396 | } else if name.is_array() { [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 397 | | value = Some(name); [INFO] [stderr] 398 | | } else if name.is_object() { [INFO] [stderr] | |_________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/builtin/mod.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> Functions { [INFO] [stderr] 11 | | let mut functions = Functions::new(); [INFO] [stderr] 12 | | functions.insert("min".to_owned(), create_min_fuction()); [INFO] [stderr] 13 | | functions.insert("max".to_owned(), create_max_fuction()); [INFO] [stderr] ... | [INFO] [stderr] 17 | | functions [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/expr/mod.rs:110:60 [INFO] [stderr] | [INFO] [stderr] 110 | pub fn contexts(&mut self, contexts: &'a [Context]) -> &'a mut ExecOptions { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::mut_from_ref)] on by default [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/expr/mod.rs:110:42 [INFO] [stderr] | [INFO] [stderr] 110 | pub fn contexts(&mut self, contexts: &'a [Context]) -> &'a mut ExecOptions { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/expr/mod.rs:116:62 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn functions(&mut self, functions: &'a Functions) -> &'a mut ExecOptions { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/expr/mod.rs:116:44 [INFO] [stderr] | [INFO] [stderr] 116 | pub fn functions(&mut self, functions: &'a Functions) -> &'a mut ExecOptions { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `eval`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7e06fb6efd68f56f65ce6c4a3413fc3e4708f2040c295cf8290e416476bf44c5"` [INFO] running `"docker" "rm" "-f" "7e06fb6efd68f56f65ce6c4a3413fc3e4708f2040c295cf8290e416476bf44c5"` [INFO] [stdout] 7e06fb6efd68f56f65ce6c4a3413fc3e4708f2040c295cf8290e416476bf44c5