[INFO] crate eureka 1.5.1 is already in cache
[INFO] extracting crate eureka 1.5.1 into work/ex/clippy-test-run/sources/stable/reg/eureka/1.5.1
[INFO] extracting crate eureka 1.5.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/eureka/1.5.1
[INFO] validating manifest of eureka-1.5.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of eureka-1.5.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing eureka-1.5.1
[INFO] finished frobbing eureka-1.5.1
[INFO] frobbed toml for eureka-1.5.1 written to work/ex/clippy-test-run/sources/stable/reg/eureka/1.5.1/Cargo.toml
[INFO] started frobbing eureka-1.5.1
[INFO] finished frobbing eureka-1.5.1
[INFO] frobbed toml for eureka-1.5.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/eureka/1.5.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting eureka-1.5.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/eureka/1.5.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c279cb83686fa665003de1ea77d295c1368f89daddcfed17724727b045e6b94b
[INFO] running `"docker" "start" "-a" "c279cb83686fa665003de1ea77d295c1368f89daddcfed17724727b045e6b94b"`
[INFO] [stderr]     Checking eureka v1.5.1 (/opt/crater/workdir)
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]   --> src/git.rs:1:1
[INFO] [stderr]    |
[INFO] [stderr] 1  | / pub mod git {
[INFO] [stderr] 2  | |     use std::io::Result;
[INFO] [stderr] 3  | |     use std::process::Command;
[INFO] [stderr] 4  | |     use utils::utils;
[INFO] [stderr] ...  |
[INFO] [stderr] 79 | |     }
[INFO] [stderr] 80 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]   --> src/utils.rs:1:1
[INFO] [stderr]    |
[INFO] [stderr] 1  | / pub mod utils {
[INFO] [stderr] 2  | |     use std::env;
[INFO] [stderr] 3  | |     use std::fs;
[INFO] [stderr] 4  | |
[INFO] [stderr] ...  |
[INFO] [stderr] 15 | |     }
[INFO] [stderr] 16 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: struct is never constructed: `MockFileSystem`
[INFO] [stderr]    --> src/file_handler.rs:146:5
[INFO] [stderr]     |
[INFO] [stderr] 146 |     struct MockFileSystem;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: struct is never constructed: `MockFileHandler`
[INFO] [stderr]    --> src/file_handler.rs:147:5
[INFO] [stderr]     |
[INFO] [stderr] 147 |     struct MockFileHandler;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/file_handler.rs:83:14
[INFO] [stderr]    |
[INFO] [stderr] 83 |             .expect(&format!("Unable to read config at: {}", config_path));
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to read config at: {}", config_path))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/file_handler.rs:90:38
[INFO] [stderr]    |
[INFO] [stderr] 90 |         } else if contents.ends_with("\n") {
[INFO] [stderr]    |                                      ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/file_handler.rs:93:18
[INFO] [stderr]    |
[INFO] [stderr] 93 |                 .expect(&format!("File is empty: {}", &config_path));
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("File is empty: {}", &config_path))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/git.rs:6:43
[INFO] [stderr]   |
[INFO] [stderr] 6 |     pub fn git_commit_and_push(repo_path: &String, msg: String) -> Result<()> {
[INFO] [stderr]   |                                           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/git.rs:12:27
[INFO] [stderr]    |
[INFO] [stderr] 12 |     fn git_add(repo_path: &String) -> Result<()> {
[INFO] [stderr]    |                           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/git.rs:27:30
[INFO] [stderr]    |
[INFO] [stderr] 27 |     fn git_commit(repo_path: &String, msg: String) -> Result<()> {
[INFO] [stderr]    |                              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/git.rs:46:28
[INFO] [stderr]    |
[INFO] [stderr] 46 |     fn git_push(repo_path: &String) -> Result<()> {
[INFO] [stderr]    |                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/git.rs:74:32
[INFO] [stderr]    |
[INFO] [stderr] 74 |     fn default_args(repo_path: &String) -> [String; 2] {
[INFO] [stderr]    |                                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]  --> src/utils.rs:7:33
[INFO] [stderr]   |
[INFO] [stderr] 7 |             for p in path.split(":") {
[INFO] [stderr]   |                                 ^^^ help: try using a char instead: `':'`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]   --> src/main.rs:73:13
[INFO] [stderr]    |
[INFO] [stderr] 73 |             Err(_) => panic!("No path to repository found"),
[INFO] [stderr]    |             ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_wild_err_arm)] on by default
[INFO] [stderr]    = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:170:26
[INFO] [stderr]     |
[INFO] [stderr] 170 | fn open_editor(bin_path: &String, file_path: &String) -> Result<(), Error> {
[INFO] [stderr]     |                          ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:170:46
[INFO] [stderr]     |
[INFO] [stderr] 170 | fn open_editor(bin_path: &String, file_path: &String) -> Result<(), Error> {
[INFO] [stderr]     |                                              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]   --> src/git.rs:1:1
[INFO] [stderr]    |
[INFO] [stderr] 1  | / pub mod git {
[INFO] [stderr] 2  | |     use std::io::Result;
[INFO] [stderr] 3  | |     use std::process::Command;
[INFO] [stderr] 4  | |     use utils::utils;
[INFO] [stderr] ...  |
[INFO] [stderr] 79 | |     }
[INFO] [stderr] 80 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]   --> src/utils.rs:1:1
[INFO] [stderr]    |
[INFO] [stderr] 1  | / pub mod utils {
[INFO] [stderr] 2  | |     use std::env;
[INFO] [stderr] 3  | |     use std::fs;
[INFO] [stderr] 4  | |
[INFO] [stderr] ...  |
[INFO] [stderr] 15 | |     }
[INFO] [stderr] 16 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/file_handler.rs:83:14
[INFO] [stderr]    |
[INFO] [stderr] 83 |             .expect(&format!("Unable to read config at: {}", config_path));
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to read config at: {}", config_path))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/file_handler.rs:90:38
[INFO] [stderr]    |
[INFO] [stderr] 90 |         } else if contents.ends_with("\n") {
[INFO] [stderr]    |                                      ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/file_handler.rs:93:18
[INFO] [stderr]    |
[INFO] [stderr] 93 |                 .expect(&format!("File is empty: {}", &config_path));
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("File is empty: {}", &config_path))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/git.rs:6:43
[INFO] [stderr]   |
[INFO] [stderr] 6 |     pub fn git_commit_and_push(repo_path: &String, msg: String) -> Result<()> {
[INFO] [stderr]   |                                           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/git.rs:12:27
[INFO] [stderr]    |
[INFO] [stderr] 12 |     fn git_add(repo_path: &String) -> Result<()> {
[INFO] [stderr]    |                           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/git.rs:27:30
[INFO] [stderr]    |
[INFO] [stderr] 27 |     fn git_commit(repo_path: &String, msg: String) -> Result<()> {
[INFO] [stderr]    |                              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/git.rs:46:28
[INFO] [stderr]    |
[INFO] [stderr] 46 |     fn git_push(repo_path: &String) -> Result<()> {
[INFO] [stderr]    |                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/git.rs:74:32
[INFO] [stderr]    |
[INFO] [stderr] 74 |     fn default_args(repo_path: &String) -> [String; 2] {
[INFO] [stderr]    |                                ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]  --> src/utils.rs:7:33
[INFO] [stderr]   |
[INFO] [stderr] 7 |             for p in path.split(":") {
[INFO] [stderr]   |                                 ^^^ help: try using a char instead: `':'`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]   --> src/main.rs:73:13
[INFO] [stderr]    |
[INFO] [stderr] 73 |             Err(_) => panic!("No path to repository found"),
[INFO] [stderr]    |             ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_wild_err_arm)] on by default
[INFO] [stderr]    = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:170:26
[INFO] [stderr]     |
[INFO] [stderr] 170 | fn open_editor(bin_path: &String, file_path: &String) -> Result<(), Error> {
[INFO] [stderr]     |                          ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:170:46
[INFO] [stderr]     |
[INFO] [stderr] 170 | fn open_editor(bin_path: &String, file_path: &String) -> Result<(), Error> {
[INFO] [stderr]     |                                              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 4.76s
[INFO] running `"docker" "inspect" "c279cb83686fa665003de1ea77d295c1368f89daddcfed17724727b045e6b94b"`
[INFO] running `"docker" "rm" "-f" "c279cb83686fa665003de1ea77d295c1368f89daddcfed17724727b045e6b94b"`
[INFO] [stdout] c279cb83686fa665003de1ea77d295c1368f89daddcfed17724727b045e6b94b