[INFO] crate euphrates_sdl2 0.1.0 is already in cache [INFO] extracting crate euphrates_sdl2 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/euphrates_sdl2/0.1.0 [INFO] extracting crate euphrates_sdl2 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/euphrates_sdl2/0.1.0 [INFO] validating manifest of euphrates_sdl2-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of euphrates_sdl2-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing euphrates_sdl2-0.1.0 [INFO] finished frobbing euphrates_sdl2-0.1.0 [INFO] frobbed toml for euphrates_sdl2-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/euphrates_sdl2/0.1.0/Cargo.toml [INFO] started frobbing euphrates_sdl2-0.1.0 [INFO] finished frobbing euphrates_sdl2-0.1.0 [INFO] frobbed toml for euphrates_sdl2-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/euphrates_sdl2/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting euphrates_sdl2-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/euphrates_sdl2/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2591a66c772d34ae9f7a0c4982b2ae147e63cdcf4d11765108ddca0dbf5e36f4 [INFO] running `"docker" "start" "-a" "2591a66c772d34ae9f7a0c4982b2ae147e63cdcf4d11765108ddca0dbf5e36f4"` [INFO] [stderr] Checking bincode v1.0.1 [INFO] [stderr] Checking sdl2 v0.31.0 [INFO] [stderr] Checking euphrates v0.1.0 [INFO] [stderr] Checking euphrates_sdl2 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simple_graphics.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | canvas: canvas, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `canvas` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simple_graphics.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | texture_creator: texture_creator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `texture_creator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simple_graphics.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | texture: texture, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `texture` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simple_graphics.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | pixels: pixels, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `pixels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simple_graphics.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | canvas: canvas, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `canvas` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simple_graphics.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | texture_creator: texture_creator, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `texture_creator` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simple_graphics.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | texture: texture, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `texture` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simple_graphics.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | pixels: pixels, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `pixels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/simple_audio.rs:12:36 [INFO] [stderr] | [INFO] [stderr] 12 | pub const DEFAULT_FREQUENCY: u32 = 1000000; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/simple_graphics.rs:78:36 [INFO] [stderr] | [INFO] [stderr] 78 | let len = title.find('\0').unwrap_or(title.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| title.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/simple_audio.rs:12:36 [INFO] [stderr] | [INFO] [stderr] 12 | pub const DEFAULT_FREQUENCY: u32 = 1000000; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/simple_graphics.rs:78:36 [INFO] [stderr] | [INFO] [stderr] 78 | let len = title.find('\0').unwrap_or(title.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| title.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 07s [INFO] running `"docker" "inspect" "2591a66c772d34ae9f7a0c4982b2ae147e63cdcf4d11765108ddca0dbf5e36f4"` [INFO] running `"docker" "rm" "-f" "2591a66c772d34ae9f7a0c4982b2ae147e63cdcf4d11765108ddca0dbf5e36f4"` [INFO] [stdout] 2591a66c772d34ae9f7a0c4982b2ae147e63cdcf4d11765108ddca0dbf5e36f4