[INFO] crate euphrates_cli 0.1.0 is already in cache [INFO] extracting crate euphrates_cli 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/euphrates_cli/0.1.0 [INFO] extracting crate euphrates_cli 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/euphrates_cli/0.1.0 [INFO] validating manifest of euphrates_cli-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of euphrates_cli-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing euphrates_cli-0.1.0 [INFO] finished frobbing euphrates_cli-0.1.0 [INFO] frobbed toml for euphrates_cli-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/euphrates_cli/0.1.0/Cargo.toml [INFO] started frobbing euphrates_cli-0.1.0 [INFO] finished frobbing euphrates_cli-0.1.0 [INFO] frobbed toml for euphrates_cli-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/euphrates_cli/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting euphrates_cli-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/euphrates_cli/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 954c4a40d536334e70343822062339c121965447ca17b02d9fbe7ec906db9c89 [INFO] running `"docker" "start" "-a" "954c4a40d536334e70343822062339c121965447ca17b02d9fbe7ec906db9c89"` [INFO] [stderr] Checking euphrates v0.1.0 [INFO] [stderr] Checking euphrates_sdl2 v0.1.0 [INFO] [stderr] Checking euphrates_cli v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:356:5 [INFO] [stderr] | [INFO] [stderr] 356 | / return match matches.subcommand() { [INFO] [stderr] 357 | | ("rom", Some(sub)) => run_rom(&sub), [INFO] [stderr] 358 | | ("load", Some(sub)) => run_load(&sub), [INFO] [stderr] 359 | | ("loadrecord", Some(sub)) => run_record(&sub), [INFO] [stderr] ... | [INFO] [stderr] 365 | | } [INFO] [stderr] 366 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 356 | match matches.subcommand() { [INFO] [stderr] 357 | ("rom", Some(sub)) => run_rom(&sub), [INFO] [stderr] 358 | ("load", Some(sub)) => run_load(&sub), [INFO] [stderr] 359 | ("loadrecord", Some(sub)) => run_record(&sub), [INFO] [stderr] 360 | ("playback", Some(sub)) => run_playback(&sub), [INFO] [stderr] 361 | (x, _) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:156:44 [INFO] [stderr] | [INFO] [stderr] 156 | let sec_time = time.as_secs() as f64 + time.subsec_nanos() as f64 * 1e-9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(time.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:251:16 [INFO] [stderr] | [INFO] [stderr] 251 | if let Err(_) = s.parse::() { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 252 | | return Err("frequency must be ntsc, pal, unlimited, or a positive integer".to_owned()); [INFO] [stderr] 253 | | } [INFO] [stderr] | |_________- help: try this: `if s.parse::().is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:356:5 [INFO] [stderr] | [INFO] [stderr] 356 | / return match matches.subcommand() { [INFO] [stderr] 357 | | ("rom", Some(sub)) => run_rom(&sub), [INFO] [stderr] 358 | | ("load", Some(sub)) => run_load(&sub), [INFO] [stderr] 359 | | ("loadrecord", Some(sub)) => run_record(&sub), [INFO] [stderr] ... | [INFO] [stderr] 365 | | } [INFO] [stderr] 366 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 356 | match matches.subcommand() { [INFO] [stderr] 357 | ("rom", Some(sub)) => run_rom(&sub), [INFO] [stderr] 358 | ("load", Some(sub)) => run_load(&sub), [INFO] [stderr] 359 | ("loadrecord", Some(sub)) => run_record(&sub), [INFO] [stderr] 360 | ("playback", Some(sub)) => run_playback(&sub), [INFO] [stderr] 361 | (x, _) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:156:44 [INFO] [stderr] | [INFO] [stderr] 156 | let sec_time = time.as_secs() as f64 + time.subsec_nanos() as f64 * 1e-9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(time.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:251:16 [INFO] [stderr] | [INFO] [stderr] 251 | if let Err(_) = s.parse::() { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 252 | | return Err("frequency must be ntsc, pal, unlimited, or a positive integer".to_owned()); [INFO] [stderr] 253 | | } [INFO] [stderr] | |_________- help: try this: `if s.parse::().is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 07s [INFO] running `"docker" "inspect" "954c4a40d536334e70343822062339c121965447ca17b02d9fbe7ec906db9c89"` [INFO] running `"docker" "rm" "-f" "954c4a40d536334e70343822062339c121965447ca17b02d9fbe7ec906db9c89"` [INFO] [stdout] 954c4a40d536334e70343822062339c121965447ca17b02d9fbe7ec906db9c89