[INFO] crate euphrates 0.1.0 is already in cache [INFO] extracting crate euphrates 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/euphrates/0.1.0 [INFO] extracting crate euphrates 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/euphrates/0.1.0 [INFO] validating manifest of euphrates-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of euphrates-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing euphrates-0.1.0 [INFO] finished frobbing euphrates-0.1.0 [INFO] frobbed toml for euphrates-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/euphrates/0.1.0/Cargo.toml [INFO] started frobbing euphrates-0.1.0 [INFO] finished frobbing euphrates-0.1.0 [INFO] frobbed toml for euphrates-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/euphrates/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting euphrates-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/euphrates/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 61b7e2750f234ccde7388bff7aa0afaf4663414c1bd897eb7d8dcd94a2dd0f73 [INFO] running `"docker" "start" "-a" "61b7e2750f234ccde7388bff7aa0afaf4663414c1bd897eb7d8dcd94a2dd0f73"` [INFO] [stderr] Checking euphrates v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/systems/sms/emulator.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | rom: rom, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rom` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/systems/sms/emulator.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | rom: rom, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rom` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utilities.rs:181:29 [INFO] [stderr] | [INFO] [stderr] 181 | let total_time_nanos = (1000000000 * remainder_cycles) / frequency; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utilities.rs:198:44 [INFO] [stderr] | [INFO] [stderr] 198 | let guest_duration_subsec_nanos = (1000000000 * guest_cycles_remaining) / frequency; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/sms_io.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | value [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/sms_io.rs:26:21 [INFO] [stderr] | [INFO] [stderr] 26 | let value = match masked { [INFO] [stderr] | _____________________^ [INFO] [stderr] 27 | | 0b00000000 => { [INFO] [stderr] 28 | | match (self.vdp.borrow().kind(), self.player_input.pause()) { [INFO] [stderr] 29 | | (Kind::Gg, true) => 0, [INFO] [stderr] ... | [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_io.rs:25:33 [INFO] [stderr] | [INFO] [stderr] 25 | let masked = (address & 0b11000001) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_io.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | 0b00000000 => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_io.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | 0b00000001 => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_io.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | 0b01000000 => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_io.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | 0b01000001 => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_io.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | 0b10000000 => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_io.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | 0b10000001 => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_io.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | 0b11000000 => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_io.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | 0b11000001 => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_io.rs:75:33 [INFO] [stderr] | [INFO] [stderr] 75 | let masked = (address & 0b11000001) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_io.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | 0b00000000 => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_io.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | 0b00000001 => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_io.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | 0b01000000 => [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_io.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | 0b01000001 => [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_io.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | 0b10000000 => [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_io.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | 0b10000001 => [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_memory.rs:368:38 [INFO] [stderr] | [INFO] [stderr] 368 | if rom_len == 0 || rom_len > 0x400000 { [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hardware/sms_memory.rs:711:9 [INFO] [stderr] | [INFO] [stderr] 711 | return Self::load(state); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Self::load(state)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_player_input.rs:7:34 [INFO] [stderr] | [INFO] [stderr] 7 | pub const JOYPAD2_DOWN: u8 = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_player_input.rs:8:32 [INFO] [stderr] | [INFO] [stderr] 8 | pub const JOYPAD2_UP: u8 = 0b01000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_player_input.rs:9:31 [INFO] [stderr] | [INFO] [stderr] 9 | pub const JOYPAD1_B: u8 = 0b00100000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_player_input.rs:10:31 [INFO] [stderr] | [INFO] [stderr] 10 | pub const JOYPAD1_A: u8 = 0b00010000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_player_input.rs:11:35 [INFO] [stderr] | [INFO] [stderr] 11 | pub const JOYPAD1_RIGHT: u8 = 0b00001000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_player_input.rs:12:34 [INFO] [stderr] | [INFO] [stderr] 12 | pub const JOYPAD1_LEFT: u8 = 0b00000100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_player_input.rs:13:34 [INFO] [stderr] | [INFO] [stderr] 13 | pub const JOYPAD1_DOWN: u8 = 0b00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_player_input.rs:14:32 [INFO] [stderr] | [INFO] [stderr] 14 | pub const JOYPAD1_UP: u8 = 0b00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_player_input.rs:21:26 [INFO] [stderr] | [INFO] [stderr] 21 | pub const B_TH: u8 = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_player_input.rs:22:26 [INFO] [stderr] | [INFO] [stderr] 22 | pub const A_TH: u8 = 0b01000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_player_input.rs:23:26 [INFO] [stderr] | [INFO] [stderr] 23 | pub const CONT: u8 = 0b00100000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_player_input.rs:24:27 [INFO] [stderr] | [INFO] [stderr] 24 | pub const RESET: u8 = 0b00010000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_player_input.rs:25:31 [INFO] [stderr] | [INFO] [stderr] 25 | pub const JOYPAD2_B: u8 = 0b00001000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_player_input.rs:26:31 [INFO] [stderr] | [INFO] [stderr] 26 | pub const JOYPAD2_A: u8 = 0b00000100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_player_input.rs:27:35 [INFO] [stderr] | [INFO] [stderr] 27 | pub const JOYPAD2_RIGHT: u8 = 0b00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_player_input.rs:28:34 [INFO] [stderr] | [INFO] [stderr] 28 | pub const JOYPAD2_LEFT: u8 = 0b00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hardware/sms_roms.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | return Err(SmsRomError::BadLength(len)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(SmsRomError::BadLength(len))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_roms.rs:50:26 [INFO] [stderr] | [INFO] [stderr] 50 | if len == 0 || len > 0x400000 { [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hardware/sms_vdp/line.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/z80/arithmetic_help.rs:342:5 [INFO] [stderr] | [INFO] [stderr] 342 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/z80/arithmetic_help.rs:341:18 [INFO] [stderr] | [INFO] [stderr] 341 | let result = ((x as i8) >> 1) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utilities.rs:181:29 [INFO] [stderr] | [INFO] [stderr] 181 | let total_time_nanos = (1000000000 * remainder_cycles) / frequency; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utilities.rs:198:44 [INFO] [stderr] | [INFO] [stderr] 198 | let guest_duration_subsec_nanos = (1000000000 * guest_cycles_remaining) / frequency; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/sms_io.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | value [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/sms_io.rs:26:21 [INFO] [stderr] | [INFO] [stderr] 26 | let value = match masked { [INFO] [stderr] | _____________________^ [INFO] [stderr] 27 | | 0b00000000 => { [INFO] [stderr] 28 | | match (self.vdp.borrow().kind(), self.player_input.pause()) { [INFO] [stderr] 29 | | (Kind::Gg, true) => 0, [INFO] [stderr] ... | [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_io.rs:25:33 [INFO] [stderr] | [INFO] [stderr] 25 | let masked = (address & 0b11000001) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_io.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | 0b00000000 => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_io.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | 0b00000001 => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_io.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | 0b01000000 => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_io.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | 0b01000001 => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_io.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | 0b10000000 => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_io.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | 0b10000001 => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_io.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | 0b11000000 => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_io.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | 0b11000001 => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_io.rs:75:33 [INFO] [stderr] | [INFO] [stderr] 75 | let masked = (address & 0b11000001) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_io.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | 0b00000000 => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_io.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | 0b00000001 => { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_io.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | 0b01000000 => [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_io.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | 0b01000001 => [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_io.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | 0b10000000 => [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_io.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | 0b10000001 => [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_memory.rs:368:38 [INFO] [stderr] | [INFO] [stderr] 368 | if rom_len == 0 || rom_len > 0x400000 { [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hardware/sms_memory.rs:711:9 [INFO] [stderr] | [INFO] [stderr] 711 | return Self::load(state); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Self::load(state)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_player_input.rs:7:34 [INFO] [stderr] | [INFO] [stderr] 7 | pub const JOYPAD2_DOWN: u8 = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_player_input.rs:8:32 [INFO] [stderr] | [INFO] [stderr] 8 | pub const JOYPAD2_UP: u8 = 0b01000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_player_input.rs:9:31 [INFO] [stderr] | [INFO] [stderr] 9 | pub const JOYPAD1_B: u8 = 0b00100000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_player_input.rs:10:31 [INFO] [stderr] | [INFO] [stderr] 10 | pub const JOYPAD1_A: u8 = 0b00010000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_player_input.rs:11:35 [INFO] [stderr] | [INFO] [stderr] 11 | pub const JOYPAD1_RIGHT: u8 = 0b00001000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_player_input.rs:12:34 [INFO] [stderr] | [INFO] [stderr] 12 | pub const JOYPAD1_LEFT: u8 = 0b00000100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_player_input.rs:13:34 [INFO] [stderr] | [INFO] [stderr] 13 | pub const JOYPAD1_DOWN: u8 = 0b00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_player_input.rs:14:32 [INFO] [stderr] | [INFO] [stderr] 14 | pub const JOYPAD1_UP: u8 = 0b00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_player_input.rs:21:26 [INFO] [stderr] | [INFO] [stderr] 21 | pub const B_TH: u8 = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_player_input.rs:22:26 [INFO] [stderr] | [INFO] [stderr] 22 | pub const A_TH: u8 = 0b01000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_player_input.rs:23:26 [INFO] [stderr] | [INFO] [stderr] 23 | pub const CONT: u8 = 0b00100000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_player_input.rs:24:27 [INFO] [stderr] | [INFO] [stderr] 24 | pub const RESET: u8 = 0b00010000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_player_input.rs:25:31 [INFO] [stderr] | [INFO] [stderr] 25 | pub const JOYPAD2_B: u8 = 0b00001000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_player_input.rs:26:31 [INFO] [stderr] | [INFO] [stderr] 26 | pub const JOYPAD2_A: u8 = 0b00000100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_player_input.rs:27:35 [INFO] [stderr] | [INFO] [stderr] 27 | pub const JOYPAD2_RIGHT: u8 = 0b00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_player_input.rs:28:34 [INFO] [stderr] | [INFO] [stderr] 28 | pub const JOYPAD2_LEFT: u8 = 0b00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hardware/z80/memo.rs:963:9 [INFO] [stderr] | [INFO] [stderr] 963 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hardware/sms_roms.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | return Err(SmsRomError::BadLength(len)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(SmsRomError::BadLength(len))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/sms_roms.rs:50:26 [INFO] [stderr] | [INFO] [stderr] 50 | if len == 0 || len > 0x400000 { [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hardware/sms_vdp/line.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/z80/arithmetic_help.rs:342:5 [INFO] [stderr] | [INFO] [stderr] 342 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/z80/arithmetic_help.rs:341:18 [INFO] [stderr] | [INFO] [stderr] 341 | let result = ((x as i8) >> 1) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hardware/z80/memo.rs:963:9 [INFO] [stderr] | [INFO] [stderr] 963 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/save.rs:3:24 [INFO] [stderr] | [INFO] [stderr] 3 | const MAX_BYTES: u64 = 0x10000000; // 256 MiB [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/systems/sms/emulator.rs:15:37 [INFO] [stderr] | [INFO] [stderr] 15 | pub const NTSC_Z80_FREQUENCY: u64 = 10738580 / 3; [INFO] [stderr] | ^^^^^^^^ help: consider: `10_738_580` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/systems/sms/emulator.rs:17:36 [INFO] [stderr] | [INFO] [stderr] 17 | pub const PAL_Z80_FREQUENCY: u64 = 10640685 / 3; [INFO] [stderr] | ^^^^^^^^ help: consider: `10_640_685` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/systems/sms/inbox.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/systems/sms/inbox.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | return pc_current; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `pc_current` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/systems/sms/inbox.rs:249:9 [INFO] [stderr] | [INFO] [stderr] 249 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/systems/sms/inbox.rs:238:22 [INFO] [stderr] | [INFO] [stderr] 238 | let result = match query { [INFO] [stderr] | ______________________^ [INFO] [stderr] 239 | | RecentMemos => { [INFO] [stderr] 240 | | let mut result = String::new(); [INFO] [stderr] 241 | | for memo in self.recent_memos.iter() { [INFO] [stderr] ... | [INFO] [stderr] 247 | | Disassembly => self.disassembly(None, 0, 0xFFFF), [INFO] [stderr] 248 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/save.rs:3:24 [INFO] [stderr] | [INFO] [stderr] 3 | const MAX_BYTES: u64 = 0x10000000; // 256 MiB [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/systems/sms/emulator.rs:15:37 [INFO] [stderr] | [INFO] [stderr] 15 | pub const NTSC_Z80_FREQUENCY: u64 = 10738580 / 3; [INFO] [stderr] | ^^^^^^^^ help: consider: `10_738_580` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/systems/sms/emulator.rs:17:36 [INFO] [stderr] | [INFO] [stderr] 17 | pub const PAL_Z80_FREQUENCY: u64 = 10640685 / 3; [INFO] [stderr] | ^^^^^^^^ help: consider: `10_640_685` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/systems/sms/inbox.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/systems/sms/inbox.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | return pc_current; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `pc_current` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/systems/sms/inbox.rs:249:9 [INFO] [stderr] | [INFO] [stderr] 249 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/systems/sms/inbox.rs:238:22 [INFO] [stderr] | [INFO] [stderr] 238 | let result = match query { [INFO] [stderr] | ______________________^ [INFO] [stderr] 239 | | RecentMemos => { [INFO] [stderr] 240 | | let mut result = String::new(); [INFO] [stderr] 241 | | for memo in self.recent_memos.iter() { [INFO] [stderr] ... | [INFO] [stderr] 247 | | Disassembly => self.disassembly(None, 0, 0xFFFF), [INFO] [stderr] 248 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/utilities.rs:7:6 [INFO] [stderr] | [INFO] [stderr] 7 | ((hi as u16) << 8) | (lo as u16) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/utilities.rs:7:26 [INFO] [stderr] | [INFO] [stderr] 7 | ((hi as u16) << 8) | (lo as u16) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/utilities.rs:67:48 [INFO] [stderr] | [INFO] [stderr] 67 | let o: &$other_type = unsafe { transmute(self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&*(self as *const hardware::sms_memory::MainCartridgeRam as *const hardware::sms_memory::_impl1::MainCartridgeRamDerive)` [INFO] [stderr] | [INFO] [stderr] ::: src/hardware/sms_memory.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | impl_serde_via!{super::MainCartridgeRam, MainCartridgeRamDerive} [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/utilities.rs:83:48 [INFO] [stderr] | [INFO] [stderr] 83 | let o: &$other_type = unsafe { transmute(self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&*(self as *const hardware::sms_memory::MainCartridgeRam as *const hardware::sms_memory::_impl1::MainCartridgeRamDerive)` [INFO] [stderr] | [INFO] [stderr] ::: src/hardware/sms_memory.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | impl_hash_via!{super::MainCartridgeRam, MainCartridgeRamDerive} [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/utilities.rs:34:48 [INFO] [stderr] | [INFO] [stderr] 34 | let s: &$other_type = unsafe { transmute(self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&*(self as *const hardware::sms_memory::MainCartridgeRam as *const hardware::sms_memory::_impl1::MainCartridgeRamDerive)` [INFO] [stderr] | [INFO] [stderr] ::: src/hardware/sms_memory.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | impl_partial_eq_via!{super::MainCartridgeRam, MainCartridgeRamDerive} [INFO] [stderr] | --------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/utilities.rs:35:48 [INFO] [stderr] | [INFO] [stderr] 35 | let o: &$other_type = unsafe { transmute(rhs) }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&*(rhs as *const hardware::sms_memory::MainCartridgeRam as *const hardware::sms_memory::_impl1::MainCartridgeRamDerive)` [INFO] [stderr] | [INFO] [stderr] ::: src/hardware/sms_memory.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | impl_partial_eq_via!{super::MainCartridgeRam, MainCartridgeRamDerive} [INFO] [stderr] | --------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/utilities.rs:67:48 [INFO] [stderr] | [INFO] [stderr] 67 | let o: &$other_type = unsafe { transmute(self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&*(self as *const hardware::sms_memory::SmsMemoryState as *const hardware::sms_memory::_impl2::SmsMemoryStateDerive)` [INFO] [stderr] | [INFO] [stderr] ::: src/hardware/sms_memory.rs:354:5 [INFO] [stderr] | [INFO] [stderr] 354 | impl_serde_via!{super::SmsMemoryState, SmsMemoryStateDerive} [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/utilities.rs:83:48 [INFO] [stderr] | [INFO] [stderr] 83 | let o: &$other_type = unsafe { transmute(self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&*(self as *const hardware::sms_memory::SmsMemoryState as *const hardware::sms_memory::_impl2::SmsMemoryStateDerive)` [INFO] [stderr] | [INFO] [stderr] ::: src/hardware/sms_memory.rs:355:5 [INFO] [stderr] | [INFO] [stderr] 355 | impl_hash_via!{super::SmsMemoryState, SmsMemoryStateDerive} [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/utilities.rs:34:48 [INFO] [stderr] | [INFO] [stderr] 34 | let s: &$other_type = unsafe { transmute(self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&*(self as *const hardware::sms_memory::SmsMemoryState as *const hardware::sms_memory::_impl2::SmsMemoryStateDerive)` [INFO] [stderr] | [INFO] [stderr] ::: src/hardware/sms_memory.rs:356:5 [INFO] [stderr] | [INFO] [stderr] 356 | impl_partial_eq_via!{super::SmsMemoryState, SmsMemoryStateDerive} [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/utilities.rs:35:48 [INFO] [stderr] | [INFO] [stderr] 35 | let o: &$other_type = unsafe { transmute(rhs) }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&*(rhs as *const hardware::sms_memory::SmsMemoryState as *const hardware::sms_memory::_impl2::SmsMemoryStateDerive)` [INFO] [stderr] | [INFO] [stderr] ::: src/hardware/sms_memory.rs:356:5 [INFO] [stderr] | [INFO] [stderr] 356 | impl_partial_eq_via!{super::SmsMemoryState, SmsMemoryStateDerive} [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/hardware/sms_memory.rs:389:16 [INFO] [stderr] | [INFO] [stderr] 389 | if let None = self.half_cartridge_ram { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 390 | | self.half_cartridge_ram = Some(Box::new([0u8; 0x2000])); [INFO] [stderr] 391 | | } [INFO] [stderr] | |_________- help: try this: `if self.half_cartridge_ram.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/hardware/sms_memory.rs:564:9 [INFO] [stderr] | [INFO] [stderr] 564 | / match &self.main_cartridge_ram { [INFO] [stderr] 565 | | &Zero => panic!("index out of bounds: got {} but len 0", index), [INFO] [stderr] 566 | | &One(ref x) => x[index], [INFO] [stderr] 567 | | &Two(ref x, ref y) => if index < 0x4000 { [INFO] [stderr] ... | [INFO] [stderr] 573 | | }, [INFO] [stderr] 574 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 564 | match self.main_cartridge_ram { [INFO] [stderr] 565 | Zero => panic!("index out of bounds: got {} but len 0", index), [INFO] [stderr] 566 | One(ref x) => x[index], [INFO] [stderr] 567 | Two(ref x, ref y) => if index < 0x4000 { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/sms_memory.rs:579:9 [INFO] [stderr] | [INFO] [stderr] 579 | / match &mut self.main_cartridge_ram { [INFO] [stderr] 580 | | &mut Zero => panic!("index out of bounds: got {} but len 0", index), [INFO] [stderr] 581 | | &mut One(ref mut x) => x[index] = value, [INFO] [stderr] 582 | | &mut Two(ref mut x, ref mut y) => if index < 0x4000 { [INFO] [stderr] ... | [INFO] [stderr] 588 | | }, [INFO] [stderr] 589 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 579 | match *(&mut self.main_cartridge_ram) { [INFO] [stderr] 580 | Zero => panic!("index out of bounds: got {} but len 0", index), [INFO] [stderr] 581 | One(ref mut x) => x[index] = value, [INFO] [stderr] 582 | Two(ref mut x, ref mut y) => if index < 0x4000 { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/hardware/sms_memory.rs:602:9 [INFO] [stderr] | [INFO] [stderr] 602 | / match &self.half_cartridge_ram { [INFO] [stderr] 603 | | &None => panic!("index out of bounds: got {} but len 0", index), [INFO] [stderr] 604 | | &Some(ref x) => x[index], [INFO] [stderr] 605 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 602 | match self.half_cartridge_ram { [INFO] [stderr] 603 | None => panic!("index out of bounds: got {} but len 0", index), [INFO] [stderr] 604 | Some(ref x) => x[index], [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/sms_memory.rs:610:9 [INFO] [stderr] | [INFO] [stderr] 610 | / match &mut self.half_cartridge_ram { [INFO] [stderr] 611 | | &mut None => panic!("index out of bounds: got {} but len 0", index), [INFO] [stderr] 612 | | &mut Some(ref mut x) => x[index] = value, [INFO] [stderr] 613 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 610 | match *(&mut self.half_cartridge_ram) { [INFO] [stderr] 611 | None => panic!("index out of bounds: got {} but len 0", index), [INFO] [stderr] 612 | Some(ref mut x) => x[index] = value, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut hardware::sms_memory::SmsMemoryState`) to a reference type (`&hardware::sms_memory::SmsMemoryState`) [INFO] [stderr] --> src/hardware/sms_memory.rs:731:18 [INFO] [stderr] | [INFO] [stderr] 731 | unsafe { transmute(self.state.get()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*self.state.get()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut hardware::sms_memory::SmsMemoryState`) to a reference type (`&mut hardware::sms_memory::SmsMemoryState`) [INFO] [stderr] --> src/hardware/sms_memory.rs:737:18 [INFO] [stderr] | [INFO] [stderr] 737 | unsafe { transmute(self.state.get()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *self.state.get()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/hardware/sms_memory.rs:870:43 [INFO] [stderr] | [INFO] [stderr] 870 | let scrap_ptr: *mut u8 = unsafe { transmute(self.scrap.deref()) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.scrap.deref() as *const [u8; 1024] as *mut u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/hardware/sms_memory.rs:878:34 [INFO] [stderr] | [INFO] [stderr] 878 | unsafe { state.system_ram.as_mut_ptr().offset(offset as isize) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `state.system_ram.as_mut_ptr().add(offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/sms_memory.rs:885:36 [INFO] [stderr] | [INFO] [stderr] 885 | let ptr: *mut u8 = match &mut state.main_cartridge_ram { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 886 | | &mut MainCartridgeRam::One(ref mut x) => &mut x[0], [INFO] [stderr] 887 | | &mut MainCartridgeRam::Two(ref mut x, _) => &mut x[0], [INFO] [stderr] 888 | | _ => unreachable!(), [INFO] [stderr] 889 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 885 | let ptr: *mut u8 = match *(&mut state.main_cartridge_ram) { [INFO] [stderr] 886 | MainCartridgeRam::One(ref mut x) => &mut x[0], [INFO] [stderr] 887 | MainCartridgeRam::Two(ref mut x, _) => &mut x[0], [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/sms_memory.rs:898:36 [INFO] [stderr] | [INFO] [stderr] 898 | let ptr: *mut u8 = match &mut state.main_cartridge_ram { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 899 | | &mut MainCartridgeRam::Two(_, ref mut x) => &mut x[0], [INFO] [stderr] 900 | | _ => unreachable!(), [INFO] [stderr] 901 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 898 | let ptr: *mut u8 = match *(&mut state.main_cartridge_ram) { [INFO] [stderr] 899 | MainCartridgeRam::Two(_, ref mut x) => &mut x[0], [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/sms_memory.rs:911:37 [INFO] [stderr] | [INFO] [stderr] 911 | let ptr1: *mut u8 = match &mut state.half_cartridge_ram { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 912 | | &mut Some(ref mut x) => &mut x[0], [INFO] [stderr] 913 | | _ => unreachable!(), [INFO] [stderr] 914 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 911 | let ptr1: *mut u8 = match *(&mut state.half_cartridge_ram) { [INFO] [stderr] 912 | Some(ref mut x) => &mut x[0], [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/hardware/sms_memory.rs:960:47 [INFO] [stderr] | [INFO] [stderr] 960 | let minislots: &[*const u8; 64] = transmute(&self.minislots); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self.minislots as *const [[*const u8; 16]; 4] as *const [*const u8; 64])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/hardware/sms_memory.rs:970:55 [INFO] [stderr] | [INFO] [stderr] 970 | let write_minislots: &mut [*mut u8; 64] = transmute(&mut self.write_minislots); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut self.write_minislots as *mut [[*mut u8; 16]; 4] as *mut [*mut u8; 64])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/hardware/sms_player_input.rs:61:21 [INFO] [stderr] | [INFO] [stderr] 61 | pub fn joypad_a(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/hardware/sms_player_input.rs:71:21 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn joypad_b(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/hardware/sms_player_input.rs:81:18 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn pause(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:295:32 [INFO] [stderr] | [INFO] [stderr] 295 | let sprite_pattern_table = ((s.vdp.register(6) & 0x7) as u16) << 11; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(s.vdp.register(6) & 0x7)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:296:34 [INFO] [stderr] | [INFO] [stderr] 296 | let sprite_attribute_table = ((s.vdp.register(5) & 0x7F) as u16) << 7; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(s.vdp.register(5) & 0x7F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:303:17 [INFO] [stderr] | [INFO] [stderr] 303 | let y = s.vdp.vram(sprite_attribute_table + 4 * i).wrapping_add(1) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(s.vdp.vram(sprite_attribute_table + 4 * i).wrapping_add(1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:307:17 [INFO] [stderr] | [INFO] [stderr] 307 | let x = s.vdp.vram(sprite_attribute_table + 4 * i + 1) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(s.vdp.vram(sprite_attribute_table + 4 * i + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:327:20 [INFO] [stderr] | [INFO] [stderr] 327 | let name = s.vdp.vram(sprite_attribute_table + 4 * i + 2) as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(s.vdp.vram(sprite_attribute_table + 4 * i + 2))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:351:34 [INFO] [stderr] | [INFO] [stderr] 351 | s.graphics.paint(x as u32, v as u32, color1); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:351:44 [INFO] [stderr] | [INFO] [stderr] 351 | s.graphics.paint(x as u32, v as u32, color1); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:397:25 [INFO] [stderr] | [INFO] [stderr] 397 | let pattern_table = ((s.vdp.register(4) & 0x7) as u16) << 11; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(s.vdp.register(4) & 0x7)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:398:22 [INFO] [stderr] | [INFO] [stderr] 398 | let name_table = ((s.vdp.register(2) & 0xF) as u16) << 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(s.vdp.register(2) & 0xF)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:399:23 [INFO] [stderr] | [INFO] [stderr] 399 | let color_table = (s.vdp.register(3) as u16) << 6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(s.vdp.register(3))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:407:26 [INFO] [stderr] | [INFO] [stderr] 407 | .map_err(|e| SmsVdpGraphicsError::Graphics(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SmsVdpGraphicsError::Graphics` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:414:18 [INFO] [stderr] | [INFO] [stderr] 414 | .map_err(|e| SmsVdpGraphicsError::Graphics(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SmsVdpGraphicsError::Graphics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:420:17 [INFO] [stderr] | [INFO] [stderr] 420 | v as u32, [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:434:20 [INFO] [stderr] | [INFO] [stderr] 434 | let name = s.vdp.vram(name_table + tile_y * 32 + tile_x) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(s.vdp.vram(name_table + tile_y * 32 + tile_x))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:442:17 [INFO] [stderr] | [INFO] [stderr] 442 | tile_x as u32 * 8 + i, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(tile_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:443:17 [INFO] [stderr] | [INFO] [stderr] 443 | v as u32, [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:460:25 [INFO] [stderr] | [INFO] [stderr] 460 | let pattern_table = ((s.vdp.register(4) & 4) as u16) << 11; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(s.vdp.register(4) & 4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:461:22 [INFO] [stderr] | [INFO] [stderr] 461 | let name_table = ((s.vdp.register(2) & 0xF) as u16) << 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(s.vdp.register(2) & 0xF)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:462:23 [INFO] [stderr] | [INFO] [stderr] 462 | let color_table = ((s.vdp.register(3) & 0x80) as u16) << 6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(s.vdp.register(3) & 0x80)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:470:26 [INFO] [stderr] | [INFO] [stderr] 470 | .map_err(|e| SmsVdpGraphicsError::Graphics(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SmsVdpGraphicsError::Graphics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:477:18 [INFO] [stderr] | [INFO] [stderr] 477 | .map_err(|e| SmsVdpGraphicsError::Graphics(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SmsVdpGraphicsError::Graphics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:483:17 [INFO] [stderr] | [INFO] [stderr] 483 | v as u32, [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:502:20 [INFO] [stderr] | [INFO] [stderr] 502 | let name = s.vdp.vram(name_table + tile_y * 32 + tile_x) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(s.vdp.vram(name_table + tile_y * 32 + tile_x))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:509:17 [INFO] [stderr] | [INFO] [stderr] 509 | tile_x as u32 * 8 + i, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(tile_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:510:17 [INFO] [stderr] | [INFO] [stderr] 510 | v as u32, [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:520:1 [INFO] [stderr] | [INFO] [stderr] 520 | / pub fn draw_line_mode4<'a, V: 'a, G: 'a>( [INFO] [stderr] 521 | | s: &mut SmsVdpGraphicsImpler<'a, V, G>, [INFO] [stderr] 522 | | ) -> Result<(), SmsVdpGraphicsError> [INFO] [stderr] 523 | | where [INFO] [stderr] ... | [INFO] [stderr] 733 | | Ok(()) [INFO] [stderr] 734 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:548:26 [INFO] [stderr] | [INFO] [stderr] 548 | .map_err(|e| SmsVdpGraphicsError::Graphics(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SmsVdpGraphicsError::Graphics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:555:18 [INFO] [stderr] | [INFO] [stderr] 555 | .map_err(|e| SmsVdpGraphicsError::Graphics(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SmsVdpGraphicsError::Graphics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:554:39 [INFO] [stderr] | [INFO] [stderr] 554 | .set_resolution(width as u32, height as u32) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:557:13 [INFO] [stderr] | [INFO] [stderr] 557 | let y = (v - display_y_start) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(v - display_y_start)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `colors` [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:577:18 [INFO] [stderr] | [INFO] [stderr] 577 | for i in 0..32 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 577 | for (i, ) in colors.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `colors` [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:581:18 [INFO] [stderr] | [INFO] [stderr] 581 | for i in 0..32 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 581 | for (i, ) in colors.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:592:24 [INFO] [stderr] | [INFO] [stderr] 592 | let sprite_y = unsafe { s.vdp.sprite_y(i) } as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(unsafe { s.vdp.sprite_y(i) })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `palette_indices` [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:615:18 [INFO] [stderr] | [INFO] [stderr] 615 | for j in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 615 | for (j, ) in palette_indices.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:653:27 [INFO] [stderr] | [INFO] [stderr] 653 | let tile_offset_x = (-((scroll_x >> 3) as i16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(scroll_x >> 3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:662:20 [INFO] [stderr] | [INFO] [stderr] 662 | let scroll_y = s.vdp.y_scroll() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(s.vdp.y_scroll())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `line_buffer`. [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:722:18 [INFO] [stderr] | [INFO] [stderr] 722 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 722 | for in line_buffer.iter_mut().take(8) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/vdp_interface.rs:82:31 [INFO] [stderr] | [INFO] [stderr] 82 | let val = latch as u16 | ((x as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(latch)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/vdp_interface.rs:82:47 [INFO] [stderr] | [INFO] [stderr] 82 | let val = latch as u16 | ((x as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/vdp_interface.rs:90:52 [INFO] [stderr] | [INFO] [stderr] 90 | self.set_cram_unchecked(addr % 32, x as u16); [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/vdp_interface.rs:116:40 [INFO] [stderr] | [INFO] [stderr] 116 | let code_addr = low_byte | (x as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/vdp_interface.rs:128:53 [INFO] [stderr] | [INFO] [stderr] 128 | self.set_register_unchecked(which_reg as u16, low_byte as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(which_reg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/vdp_interface.rs:135:47 [INFO] [stderr] | [INFO] [stderr] 135 | self.set_code_address(high_byte | x as u16); [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/vdp_internal.rs:368:33 [INFO] [stderr] | [INFO] [stderr] 368 | let address = unsafe { (self.register_unchecked(2) as u16 & 0xE) << 10 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.register_unchecked(2))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/vdp_internal.rs:384:22 [INFO] [stderr] | [INFO] [stderr] 384 | unsafe { (self.register_unchecked(2) as u16) << 10 | 0xFBFF } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.register_unchecked(2))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/vdp_internal.rs:440:19 [INFO] [stderr] | [INFO] [stderr] 440 | unsafe { (self.register_unchecked(5) as u16 & 0x7E) << 7 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.register_unchecked(5))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/vdp_internal.rs:453:36 [INFO] [stderr] | [INFO] [stderr] 453 | let low_bit = unsafe { self.register_unchecked(5) as u16 & 1 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.register_unchecked(5))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/vdp_internal.rs:508:13 [INFO] [stderr] | [INFO] [stderr] 508 | self.vram_unchecked(pattern_index_address & self.sprite_attribute_table_mask()) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.vram_unchecked(pattern_index_address & self.sprite_attribute_table_mask()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/vdp_internal.rs:527:19 [INFO] [stderr] | [INFO] [stderr] 527 | unsafe { (self.register_unchecked(6) as u16 & 0x04) << 11 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.register_unchecked(6))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/vdp_internal.rs:545:37 [INFO] [stderr] | [INFO] [stderr] 545 | let low_bits = unsafe { self.register_unchecked(6) as u16 & 3 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.register_unchecked(6))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/utilities.rs:67:48 [INFO] [stderr] | [INFO] [stderr] 67 | let o: &$other_type = unsafe { transmute(self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&*(self as *const hardware::sms_vdp::vdp_internal::SmsVdpState as *const hardware::sms_vdp::vdp_internal::_impl0::SmsVdpStateDerive)` [INFO] [stderr] | [INFO] [stderr] ::: src/hardware/sms_vdp/vdp_internal.rs:796:5 [INFO] [stderr] | [INFO] [stderr] 796 | impl_serde_via!{SmsVdpState, SmsVdpStateDerive} [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/utilities.rs:83:48 [INFO] [stderr] | [INFO] [stderr] 83 | let o: &$other_type = unsafe { transmute(self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&*(self as *const hardware::sms_vdp::vdp_internal::SmsVdpState as *const hardware::sms_vdp::vdp_internal::_impl0::SmsVdpStateDerive)` [INFO] [stderr] | [INFO] [stderr] ::: src/hardware/sms_vdp/vdp_internal.rs:797:5 [INFO] [stderr] | [INFO] [stderr] 797 | impl_hash_via!{SmsVdpState, SmsVdpStateDerive} [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/utilities.rs:34:48 [INFO] [stderr] | [INFO] [stderr] 34 | let s: &$other_type = unsafe { transmute(self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&*(self as *const hardware::sms_vdp::vdp_internal::SmsVdpState as *const hardware::sms_vdp::vdp_internal::_impl0::SmsVdpStateDerive)` [INFO] [stderr] | [INFO] [stderr] ::: src/hardware/sms_vdp/vdp_internal.rs:798:5 [INFO] [stderr] | [INFO] [stderr] 798 | impl_partial_eq_via!{SmsVdpState, SmsVdpStateDerive} [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/utilities.rs:35:48 [INFO] [stderr] | [INFO] [stderr] 35 | let o: &$other_type = unsafe { transmute(rhs) }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&*(rhs as *const hardware::sms_vdp::vdp_internal::SmsVdpState as *const hardware::sms_vdp::vdp_internal::_impl0::SmsVdpStateDerive)` [INFO] [stderr] | [INFO] [stderr] ::: src/hardware/sms_vdp/vdp_internal.rs:798:5 [INFO] [stderr] | [INFO] [stderr] 798 | impl_partial_eq_via!{SmsVdpState, SmsVdpStateDerive} [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:25:25 [INFO] [stderr] | [INFO] [stderr] 25 | let pattern_table = ((v.register(4) & 0x7) as u16) << 11; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(v.register(4) & 0x7)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:26:22 [INFO] [stderr] | [INFO] [stderr] 26 | let name_table = ((v.register(2) & 0xF) as u16) << 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(v.register(2) & 0xF)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:27:23 [INFO] [stderr] | [INFO] [stderr] 27 | let color_table = (v.register(3) as u16) << 6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(v.register(3))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:31:18 [INFO] [stderr] | [INFO] [stderr] 31 | .map_err(|e| SmsVdpGraphicsError::Graphics(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SmsVdpGraphicsError::Graphics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:35:24 [INFO] [stderr] | [INFO] [stderr] 35 | let name = v.vram(name_table + tile_y * 32 + tile_x) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(v.vram(name_table + tile_y * 32 + tile_x))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | tile_x as u32 * 8 + i, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(tile_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:45:25 [INFO] [stderr] | [INFO] [stderr] 45 | tile_y as u32 * 8 + tile_line as u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(tile_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:45:45 [INFO] [stderr] | [INFO] [stderr] 45 | tile_y as u32 * 8 + tile_line as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(tile_line)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:55:18 [INFO] [stderr] | [INFO] [stderr] 55 | .map_err(|e| SmsVdpGraphicsError::Graphics(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SmsVdpGraphicsError::Graphics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:63:25 [INFO] [stderr] | [INFO] [stderr] 63 | let pattern_table = ((v.register(4) & 4) as u16) << 11; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(v.register(4) & 4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:64:22 [INFO] [stderr] | [INFO] [stderr] 64 | let name_table = ((v.register(2) & 0xF) as u16) << 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(v.register(2) & 0xF)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:65:23 [INFO] [stderr] | [INFO] [stderr] 65 | let color_table = ((v.register(3) & 0x80) as u16) << 6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(v.register(3) & 0x80)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:69:18 [INFO] [stderr] | [INFO] [stderr] 69 | .map_err(|e| SmsVdpGraphicsError::Graphics(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SmsVdpGraphicsError::Graphics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:74:24 [INFO] [stderr] | [INFO] [stderr] 74 | let name = v.vram(name_table + tile_y * 32 + tile_x) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(v.vram(name_table + tile_y * 32 + tile_x))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:84:25 [INFO] [stderr] | [INFO] [stderr] 84 | tile_x as u32 * 8 + i, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(tile_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:85:25 [INFO] [stderr] | [INFO] [stderr] 85 | tile_y as u32 * 8 + tile_line as u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(tile_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:85:45 [INFO] [stderr] | [INFO] [stderr] 85 | tile_y as u32 * 8 + tile_line as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(tile_line)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:96:18 [INFO] [stderr] | [INFO] [stderr] 96 | .map_err(|e| SmsVdpGraphicsError::Graphics(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SmsVdpGraphicsError::Graphics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:112:18 [INFO] [stderr] | [INFO] [stderr] 112 | .map_err(|e| SmsVdpGraphicsError::Graphics(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SmsVdpGraphicsError::Graphics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:111:30 [INFO] [stderr] | [INFO] [stderr] 111 | .set_resolution(256, height as u32) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:118:27 [INFO] [stderr] | [INFO] [stderr] 118 | let pixel_x = (8 * tile_x) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(8 * tile_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:119:27 [INFO] [stderr] | [INFO] [stderr] 119 | let pixel_y = (8 * tile_y) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(8 * tile_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:120:27 [INFO] [stderr] | [INFO] [stderr] 120 | let palette = ((high_byte & 8) << 1) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from((high_byte & 8) << 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `palette_indices` [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:125:26 [INFO] [stderr] | [INFO] [stderr] 125 | for j in 0..8usize { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 125 | for (j, ) in palette_indices.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:127:32 [INFO] [stderr] | [INFO] [stderr] 127 | v.cram(palette_indices[j] as u16 + palette) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(palette_indices[j])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:129:66 [INFO] [stderr] | [INFO] [stderr] 129 | graphics.paint(pixel_x + j as u32, pixel_y + line as u32, color); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(line)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | y_scroll as u32 % height as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(y_scroll)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:140:31 [INFO] [stderr] | [INFO] [stderr] 140 | y_scroll as u32 % height as u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:149:21 [INFO] [stderr] | [INFO] [stderr] 149 | for i in 0..height as u32 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:164:17 [INFO] [stderr] | [INFO] [stderr] 164 | for i in 0..height as u32 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | x_scroll as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(x_scroll)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:193:18 [INFO] [stderr] | [INFO] [stderr] 193 | .map_err(|e| SmsVdpGraphicsError::Graphics(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SmsVdpGraphicsError::Graphics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `result`. [INFO] [stderr] --> src/hardware/sms_vdp/replaceable.rs:7:14 [INFO] [stderr] | [INFO] [stderr] 7 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 7 | for in &mut result { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/hardware/sn76489.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | self.clone() [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sn76489.rs:67:39 [INFO] [stderr] | [INFO] [stderr] 67 | *reg = (*reg & 0xFFF0) | (data as u16 & 0x0F); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sn76489.rs:73:44 [INFO] [stderr] | [INFO] [stderr] 73 | *reg = (*reg & 0xFC0F) | ((data as u16 & 0x3F) << 4); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sn76489.rs:76:24 [INFO] [stderr] | [INFO] [stderr] 76 | *reg = (data as u16) & 0x0F; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sn76489.rs:160:29 [INFO] [stderr] | [INFO] [stderr] 160 | let tone0 = self.sn76489.polarity[0] as i16 * amplitudes[0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(self.sn76489.polarity[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sn76489.rs:161:29 [INFO] [stderr] | [INFO] [stderr] 161 | let tone1 = self.sn76489.polarity[1] as i16 * amplitudes[1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(self.sn76489.polarity[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sn76489.rs:162:29 [INFO] [stderr] | [INFO] [stderr] 162 | let tone2 = self.sn76489.polarity[2] as i16 * amplitudes[2]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(self.sn76489.polarity[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sn76489.rs:163:29 [INFO] [stderr] | [INFO] [stderr] 163 | let noise = self.sn76489.polarity[3] as i16 * amplitudes[3]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(self.sn76489.polarity[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/arithmetic_help.rs:61:20 [INFO] [stderr] | [INFO] [stderr] 61 | let result32 = (x as u32).wrapping_add(y as u32).wrapping_add(cf as u32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/arithmetic_help.rs:61:44 [INFO] [stderr] | [INFO] [stderr] 61 | let result32 = (x as u32).wrapping_add(y as u32).wrapping_add(cf as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/arithmetic_help.rs:61:67 [INFO] [stderr] | [INFO] [stderr] 61 | let result32 = (x as u32).wrapping_add(y as u32).wrapping_add(cf as u32); [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(cf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/arithmetic_help.rs:114:20 [INFO] [stderr] | [INFO] [stderr] 114 | let result16 = (x as u16).wrapping_add(a as u16).wrapping_add(cf as u16); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/arithmetic_help.rs:114:44 [INFO] [stderr] | [INFO] [stderr] 114 | let result16 = (x as u16).wrapping_add(a as u16).wrapping_add(cf as u16); [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/arithmetic_help.rs:114:67 [INFO] [stderr] | [INFO] [stderr] 114 | let result16 = (x as u16).wrapping_add(a as u16).wrapping_add(cf as u16); [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(cf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/mem.rs:234:48 [INFO] [stderr] | [INFO] [stderr] 234 | let addr = self.0.view(z).wrapping_add(self.1 as i16 as u16); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i16::from(self.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/mem.rs:245:48 [INFO] [stderr] | [INFO] [stderr] 245 | let addr = self.0.view(z).wrapping_add(self.1 as i16 as u16); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i16::from(self.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/hardware/z80/mem.rs:422:36 [INFO] [stderr] | [INFO] [stderr] 422 | self.z80().set_flag_by(HF, x0 & 0xF == 0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `x0.trailing_zeros() >= 4` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::verbose_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/mem.rs:827:18 [INFO] [stderr] | [INFO] [stderr] 827 | self.rst(x as u16); [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/no.rs:34:53 [INFO] [stderr] | [INFO] [stderr] 34 | let result = adc16_help(self.z80(), x0, y0, cf as u16); [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(cf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/no.rs:235:50 [INFO] [stderr] | [INFO] [stderr] 235 | self.z80().set_reg16(PC, pc.wrapping_add(e as i16 as u16)); [INFO] [stderr] | ^^^^^^^^ help: try: `i16::from(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/no.rs:297:54 [INFO] [stderr] | [INFO] [stderr] 297 | let result = adc16_help(self.z80(), x0, !y0, (1 ^ cf) as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(1 ^ cf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 747 | 0x01 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([BC] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 747 | 0x01 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([BC] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/utilities.rs:7:6 [INFO] [stderr] | [INFO] [stderr] 7 | ((hi as u16) << 8) | (lo as u16) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/utilities.rs:7:26 [INFO] [stderr] | [INFO] [stderr] 7 | ((hi as u16) << 8) | (lo as u16) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 763 | 0x11 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([DE] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 763 | 0x11 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([DE] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 779 | 0x21 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([HL] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 779 | 0x21 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([HL] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 780 | 0x22 => nn_inst!{z, nn, 16, mem, Ld16, ld16, ([Address(nn)] [HL]) }, [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 780 | 0x22 => nn_inst!{z, nn, 16, mem, Ld16, ld16, ([Address(nn)] [HL]) }, [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 788 | 0x2A => nn_inst!{z, nn, 16, mem, Ld16, ld16, ([HL] [Address(nn)]) }, [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 788 | 0x2A => nn_inst!{z, nn, 16, mem, Ld16, ld16, ([HL] [Address(nn)]) }, [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 795 | 0x31 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([SP] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 795 | 0x31 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([SP] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 796 | 0x32 => nn_inst!{z, nn, 13, mem, Ld, ld, ([Address(nn)] [A]) }, [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 796 | 0x32 => nn_inst!{z, nn, 13, mem, Ld, ld, ([Address(nn)] [A]) }, [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 804 | 0x3A => nn_inst!{z, nn, 13, mem, Ld, ld, ([A] [Address(nn)]) }, [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 804 | 0x3A => nn_inst!{z, nn, 13, mem, Ld, ld, ([A] [Address(nn)]) }, [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 940 | 0xC2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([NZcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 940 | 0xC2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([NZcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 941 | 0xC3 => nn_inst!{z, nn, 10, mem, Jp, jp, ([nn]) }, [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 941 | 0xC3 => nn_inst!{z, nn, 10, mem, Jp, jp, ([nn]) }, [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 942 | 0xC4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([NZcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 942 | 0xC4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([NZcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 948 | 0xCA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Zcc] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 948 | 0xCA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Zcc] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 950 | 0xCC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Zcc] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 950 | 0xCC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Zcc] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 951 | 0xCD => nn_inst!{z, nn, 0, mem, Call, call, ([nn]) }, [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 951 | 0xCD => nn_inst!{z, nn, 0, mem, Call, call, ([nn]) }, [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 956 | 0xD2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([NCcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 956 | 0xD2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([NCcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 958 | 0xD4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([NCcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 958 | 0xD4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([NCcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 964 | 0xDA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Ccc] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 964 | 0xDA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Ccc] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 966 | 0xDC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Ccc] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 966 | 0xDC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Ccc] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 972 | 0xE2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([POcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 972 | 0xE2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([POcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 974 | 0xE4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([POcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 974 | 0xE4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([POcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 980 | 0xEA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([PEcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 980 | 0xEA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([PEcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 982 | 0xEC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([PEcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 982 | 0xEC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([PEcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 988 | 0xF2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Pcc] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 988 | 0xF2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Pcc] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 990 | 0xF4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Pcc] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 990 | 0xF4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Pcc] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 996 | 0xFA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Mcc] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 996 | 0xFA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Mcc] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 998 | 0xFC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Mcc] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 998 | 0xFC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Mcc] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/utilities.rs:67:48 [INFO] [stderr] | [INFO] [stderr] 67 | let o: &$other_type = unsafe { transmute(self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&*(self as *const hardware::sms_memory::MainCartridgeRam as *const hardware::sms_memory::_impl1::MainCartridgeRamDerive)` [INFO] [stderr] | [INFO] [stderr] ::: src/hardware/sms_memory.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | impl_serde_via!{super::MainCartridgeRam, MainCartridgeRamDerive} [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/utilities.rs:83:48 [INFO] [stderr] | [INFO] [stderr] 83 | let o: &$other_type = unsafe { transmute(self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&*(self as *const hardware::sms_memory::MainCartridgeRam as *const hardware::sms_memory::_impl1::MainCartridgeRamDerive)` [INFO] [stderr] | [INFO] [stderr] ::: src/hardware/sms_memory.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | impl_hash_via!{super::MainCartridgeRam, MainCartridgeRamDerive} [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/utilities.rs:34:48 [INFO] [stderr] | [INFO] [stderr] 34 | let s: &$other_type = unsafe { transmute(self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&*(self as *const hardware::sms_memory::MainCartridgeRam as *const hardware::sms_memory::_impl1::MainCartridgeRamDerive)` [INFO] [stderr] | [INFO] [stderr] ::: src/hardware/sms_memory.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | impl_partial_eq_via!{super::MainCartridgeRam, MainCartridgeRamDerive} [INFO] [stderr] | --------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/utilities.rs:35:48 [INFO] [stderr] | [INFO] [stderr] 35 | let o: &$other_type = unsafe { transmute(rhs) }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&*(rhs as *const hardware::sms_memory::MainCartridgeRam as *const hardware::sms_memory::_impl1::MainCartridgeRamDerive)` [INFO] [stderr] | [INFO] [stderr] ::: src/hardware/sms_memory.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | impl_partial_eq_via!{super::MainCartridgeRam, MainCartridgeRamDerive} [INFO] [stderr] | --------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1086 | 0x43 => nn_inst!{z, nn, 20, mem, Ld16, ld16, ([Address(nn)] [BC]) }, [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1086 | 0x43 => nn_inst!{z, nn, 20, mem, Ld16, ld16, ([Address(nn)] [BC]) }, [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1094 | 0x4B => nn_inst!{z, nn, 20, mem, Ld16, ld16, ([BC] [Address(nn)]) }, [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1094 | 0x4B => nn_inst!{z, nn, 20, mem, Ld16, ld16, ([BC] [Address(nn)]) }, [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1102 | 0x53 => nn_inst!{z, nn, 20, mem, Ld16, ld16, ([Address(nn)] [DE]) }, [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1102 | 0x53 => nn_inst!{z, nn, 20, mem, Ld16, ld16, ([Address(nn)] [DE]) }, [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1110 | 0x5B => nn_inst!{z, nn, 20, mem, Ld16, ld16, ([DE] [Address(nn)]) }, [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1110 | 0x5B => nn_inst!{z, nn, 20, mem, Ld16, ld16, ([DE] [Address(nn)]) }, [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1118 | 0x63 => nn_inst!{z, nn, 20, mem, Ld16, ld16, ([Address(nn)] [HL]) }, [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1118 | 0x63 => nn_inst!{z, nn, 20, mem, Ld16, ld16, ([Address(nn)] [HL]) }, [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1126 | 0x6B => nn_inst!{z, nn, 20, mem, Ld16, ld16, ([HL] [Address(nn)]) }, [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1126 | 0x6B => nn_inst!{z, nn, 20, mem, Ld16, ld16, ([HL] [Address(nn)]) }, [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1134 | 0x73 => nn_inst!{z, nn, 20, mem, Ld16, ld16, ([Address(nn)] [SP]) }, [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1134 | 0x73 => nn_inst!{z, nn, 20, mem, Ld16, ld16, ([Address(nn)] [SP]) }, [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1144 | 0x7B => nn_inst!{z, nn, 20, mem, Ld16, ld16, ([SP] [Address(nn)]) }, [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1144 | 0x7B => nn_inst!{z, nn, 20, mem, Ld16, ld16, ([SP] [Address(nn)]) }, [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/utilities.rs:67:48 [INFO] [stderr] | [INFO] [stderr] 67 | let o: &$other_type = unsafe { transmute(self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&*(self as *const hardware::sms_memory::SmsMemoryState as *const hardware::sms_memory::_impl2::SmsMemoryStateDerive)` [INFO] [stderr] | [INFO] [stderr] ::: src/hardware/sms_memory.rs:354:5 [INFO] [stderr] | [INFO] [stderr] 354 | impl_serde_via!{super::SmsMemoryState, SmsMemoryStateDerive} [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/utilities.rs:83:48 [INFO] [stderr] | [INFO] [stderr] 83 | let o: &$other_type = unsafe { transmute(self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&*(self as *const hardware::sms_memory::SmsMemoryState as *const hardware::sms_memory::_impl2::SmsMemoryStateDerive)` [INFO] [stderr] | [INFO] [stderr] ::: src/hardware/sms_memory.rs:355:5 [INFO] [stderr] | [INFO] [stderr] 355 | impl_hash_via!{super::SmsMemoryState, SmsMemoryStateDerive} [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/utilities.rs:34:48 [INFO] [stderr] | [INFO] [stderr] 34 | let s: &$other_type = unsafe { transmute(self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&*(self as *const hardware::sms_memory::SmsMemoryState as *const hardware::sms_memory::_impl2::SmsMemoryStateDerive)` [INFO] [stderr] | [INFO] [stderr] ::: src/hardware/sms_memory.rs:356:5 [INFO] [stderr] | [INFO] [stderr] 356 | impl_partial_eq_via!{super::SmsMemoryState, SmsMemoryStateDerive} [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/utilities.rs:35:48 [INFO] [stderr] | [INFO] [stderr] 35 | let o: &$other_type = unsafe { transmute(rhs) }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&*(rhs as *const hardware::sms_memory::SmsMemoryState as *const hardware::sms_memory::_impl2::SmsMemoryStateDerive)` [INFO] [stderr] | [INFO] [stderr] ::: src/hardware/sms_memory.rs:356:5 [INFO] [stderr] | [INFO] [stderr] 356 | impl_partial_eq_via!{super::SmsMemoryState, SmsMemoryStateDerive} [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/hardware/sms_memory.rs:389:16 [INFO] [stderr] | [INFO] [stderr] 389 | if let None = self.half_cartridge_ram { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 390 | | self.half_cartridge_ram = Some(Box::new([0u8; 0x2000])); [INFO] [stderr] 391 | | } [INFO] [stderr] | |_________- help: try this: `if self.half_cartridge_ram.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/hardware/sms_memory.rs:564:9 [INFO] [stderr] | [INFO] [stderr] 564 | / match &self.main_cartridge_ram { [INFO] [stderr] 565 | | &Zero => panic!("index out of bounds: got {} but len 0", index), [INFO] [stderr] 566 | | &One(ref x) => x[index], [INFO] [stderr] 567 | | &Two(ref x, ref y) => if index < 0x4000 { [INFO] [stderr] ... | [INFO] [stderr] 573 | | }, [INFO] [stderr] 574 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 564 | match self.main_cartridge_ram { [INFO] [stderr] 565 | Zero => panic!("index out of bounds: got {} but len 0", index), [INFO] [stderr] 566 | One(ref x) => x[index], [INFO] [stderr] 567 | Two(ref x, ref y) => if index < 0x4000 { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/sms_memory.rs:579:9 [INFO] [stderr] | [INFO] [stderr] 579 | / match &mut self.main_cartridge_ram { [INFO] [stderr] 580 | | &mut Zero => panic!("index out of bounds: got {} but len 0", index), [INFO] [stderr] 581 | | &mut One(ref mut x) => x[index] = value, [INFO] [stderr] 582 | | &mut Two(ref mut x, ref mut y) => if index < 0x4000 { [INFO] [stderr] ... | [INFO] [stderr] 588 | | }, [INFO] [stderr] 589 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 579 | match *(&mut self.main_cartridge_ram) { [INFO] [stderr] 580 | Zero => panic!("index out of bounds: got {} but len 0", index), [INFO] [stderr] 581 | One(ref mut x) => x[index] = value, [INFO] [stderr] 582 | Two(ref mut x, ref mut y) => if index < 0x4000 { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/hardware/sms_memory.rs:602:9 [INFO] [stderr] | [INFO] [stderr] 602 | / match &self.half_cartridge_ram { [INFO] [stderr] 603 | | &None => panic!("index out of bounds: got {} but len 0", index), [INFO] [stderr] 604 | | &Some(ref x) => x[index], [INFO] [stderr] 605 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 602 | match self.half_cartridge_ram { [INFO] [stderr] 603 | None => panic!("index out of bounds: got {} but len 0", index), [INFO] [stderr] 604 | Some(ref x) => x[index], [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/sms_memory.rs:610:9 [INFO] [stderr] | [INFO] [stderr] 610 | / match &mut self.half_cartridge_ram { [INFO] [stderr] 611 | | &mut None => panic!("index out of bounds: got {} but len 0", index), [INFO] [stderr] 612 | | &mut Some(ref mut x) => x[index] = value, [INFO] [stderr] 613 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 610 | match *(&mut self.half_cartridge_ram) { [INFO] [stderr] 611 | None => panic!("index out of bounds: got {} but len 0", index), [INFO] [stderr] 612 | Some(ref mut x) => x[index] = value, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut hardware::sms_memory::SmsMemoryState`) to a reference type (`&hardware::sms_memory::SmsMemoryState`) [INFO] [stderr] --> src/hardware/sms_memory.rs:731:18 [INFO] [stderr] | [INFO] [stderr] 731 | unsafe { transmute(self.state.get()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*self.state.get()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer type (`*mut hardware::sms_memory::SmsMemoryState`) to a reference type (`&mut hardware::sms_memory::SmsMemoryState`) [INFO] [stderr] --> src/hardware/sms_memory.rs:737:18 [INFO] [stderr] | [INFO] [stderr] 737 | unsafe { transmute(self.state.get()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *self.state.get()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/hardware/sms_memory.rs:870:43 [INFO] [stderr] | [INFO] [stderr] 870 | let scrap_ptr: *mut u8 = unsafe { transmute(self.scrap.deref()) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.scrap.deref() as *const [u8; 1024] as *mut u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/hardware/sms_memory.rs:878:34 [INFO] [stderr] | [INFO] [stderr] 878 | unsafe { state.system_ram.as_mut_ptr().offset(offset as isize) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `state.system_ram.as_mut_ptr().add(offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/sms_memory.rs:885:36 [INFO] [stderr] | [INFO] [stderr] 885 | let ptr: *mut u8 = match &mut state.main_cartridge_ram { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 886 | | &mut MainCartridgeRam::One(ref mut x) => &mut x[0], [INFO] [stderr] 887 | | &mut MainCartridgeRam::Two(ref mut x, _) => &mut x[0], [INFO] [stderr] 888 | | _ => unreachable!(), [INFO] [stderr] 889 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 885 | let ptr: *mut u8 = match *(&mut state.main_cartridge_ram) { [INFO] [stderr] 886 | MainCartridgeRam::One(ref mut x) => &mut x[0], [INFO] [stderr] 887 | MainCartridgeRam::Two(ref mut x, _) => &mut x[0], [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/sms_memory.rs:898:36 [INFO] [stderr] | [INFO] [stderr] 898 | let ptr: *mut u8 = match &mut state.main_cartridge_ram { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 899 | | &mut MainCartridgeRam::Two(_, ref mut x) => &mut x[0], [INFO] [stderr] 900 | | _ => unreachable!(), [INFO] [stderr] 901 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 898 | let ptr: *mut u8 = match *(&mut state.main_cartridge_ram) { [INFO] [stderr] 899 | MainCartridgeRam::Two(_, ref mut x) => &mut x[0], [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/sms_memory.rs:911:37 [INFO] [stderr] | [INFO] [stderr] 911 | let ptr1: *mut u8 = match &mut state.half_cartridge_ram { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 912 | | &mut Some(ref mut x) => &mut x[0], [INFO] [stderr] 913 | | _ => unreachable!(), [INFO] [stderr] 914 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 911 | let ptr1: *mut u8 = match *(&mut state.half_cartridge_ram) { [INFO] [stderr] 912 | Some(ref mut x) => &mut x[0], [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/hardware/sms_memory.rs:960:47 [INFO] [stderr] | [INFO] [stderr] 960 | let minislots: &[*const u8; 64] = transmute(&self.minislots); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self.minislots as *const [[*const u8; 16]; 4] as *const [*const u8; 64])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/hardware/sms_memory.rs:970:55 [INFO] [stderr] | [INFO] [stderr] 970 | let write_minislots: &mut [*mut u8; 64] = transmute(&mut self.write_minislots); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut self.write_minislots as *mut [[*mut u8; 16]; 4] as *mut [*mut u8; 64])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/hardware/sms_player_input.rs:61:21 [INFO] [stderr] | [INFO] [stderr] 61 | pub fn joypad_a(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/hardware/sms_player_input.rs:71:21 [INFO] [stderr] | [INFO] [stderr] 71 | pub fn joypad_b(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/hardware/sms_player_input.rs:81:18 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn pause(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:295:32 [INFO] [stderr] | [INFO] [stderr] 295 | let sprite_pattern_table = ((s.vdp.register(6) & 0x7) as u16) << 11; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(s.vdp.register(6) & 0x7)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:296:34 [INFO] [stderr] | [INFO] [stderr] 296 | let sprite_attribute_table = ((s.vdp.register(5) & 0x7F) as u16) << 7; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(s.vdp.register(5) & 0x7F)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:303:17 [INFO] [stderr] | [INFO] [stderr] 303 | let y = s.vdp.vram(sprite_attribute_table + 4 * i).wrapping_add(1) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(s.vdp.vram(sprite_attribute_table + 4 * i).wrapping_add(1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:307:17 [INFO] [stderr] | [INFO] [stderr] 307 | let x = s.vdp.vram(sprite_attribute_table + 4 * i + 1) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(s.vdp.vram(sprite_attribute_table + 4 * i + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:327:20 [INFO] [stderr] | [INFO] [stderr] 327 | let name = s.vdp.vram(sprite_attribute_table + 4 * i + 2) as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(s.vdp.vram(sprite_attribute_table + 4 * i + 2))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:351:34 [INFO] [stderr] | [INFO] [stderr] 351 | s.graphics.paint(x as u32, v as u32, color1); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:351:44 [INFO] [stderr] | [INFO] [stderr] 351 | s.graphics.paint(x as u32, v as u32, color1); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:397:25 [INFO] [stderr] | [INFO] [stderr] 397 | let pattern_table = ((s.vdp.register(4) & 0x7) as u16) << 11; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(s.vdp.register(4) & 0x7)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:398:22 [INFO] [stderr] | [INFO] [stderr] 398 | let name_table = ((s.vdp.register(2) & 0xF) as u16) << 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(s.vdp.register(2) & 0xF)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:399:23 [INFO] [stderr] | [INFO] [stderr] 399 | let color_table = (s.vdp.register(3) as u16) << 6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(s.vdp.register(3))` [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1576 | 0x01 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([BC] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1576 | 0x01 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([BC] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:407:26 [INFO] [stderr] | [INFO] [stderr] 407 | .map_err(|e| SmsVdpGraphicsError::Graphics(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SmsVdpGraphicsError::Graphics` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:414:18 [INFO] [stderr] | [INFO] [stderr] 414 | .map_err(|e| SmsVdpGraphicsError::Graphics(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SmsVdpGraphicsError::Graphics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:420:17 [INFO] [stderr] | [INFO] [stderr] 420 | v as u32, [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:434:20 [INFO] [stderr] | [INFO] [stderr] 434 | let name = s.vdp.vram(name_table + tile_y * 32 + tile_x) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(s.vdp.vram(name_table + tile_y * 32 + tile_x))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1592 | 0x11 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([DE] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1592 | 0x11 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([DE] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:442:17 [INFO] [stderr] | [INFO] [stderr] 442 | tile_x as u32 * 8 + i, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(tile_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:443:17 [INFO] [stderr] | [INFO] [stderr] 443 | v as u32, [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:460:25 [INFO] [stderr] | [INFO] [stderr] 460 | let pattern_table = ((s.vdp.register(4) & 4) as u16) << 11; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(s.vdp.register(4) & 4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:461:22 [INFO] [stderr] | [INFO] [stderr] 461 | let name_table = ((s.vdp.register(2) & 0xF) as u16) << 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(s.vdp.register(2) & 0xF)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:462:23 [INFO] [stderr] | [INFO] [stderr] 462 | let color_table = ((s.vdp.register(3) & 0x80) as u16) << 6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(s.vdp.register(3) & 0x80)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1608 | 0x21 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([IX] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:470:26 [INFO] [stderr] | [INFO] [stderr] 470 | .map_err(|e| SmsVdpGraphicsError::Graphics(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SmsVdpGraphicsError::Graphics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1608 | 0x21 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([IX] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:477:18 [INFO] [stderr] | [INFO] [stderr] 477 | .map_err(|e| SmsVdpGraphicsError::Graphics(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SmsVdpGraphicsError::Graphics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1609 | 0x22 => nn_inst!{z, nn, 16, mem, Ld16, ld16, ([Address(nn)] [IX]) }, [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1609 | 0x22 => nn_inst!{z, nn, 16, mem, Ld16, ld16, ([Address(nn)] [IX]) }, [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:483:17 [INFO] [stderr] | [INFO] [stderr] 483 | v as u32, [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:502:20 [INFO] [stderr] | [INFO] [stderr] 502 | let name = s.vdp.vram(name_table + tile_y * 32 + tile_x) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(s.vdp.vram(name_table + tile_y * 32 + tile_x))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1617 | 0x2A => nn_inst!{z, nn, 16, mem, Ld16, ld16, ([IX] [Address(nn)]) }, [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1617 | 0x2A => nn_inst!{z, nn, 16, mem, Ld16, ld16, ([IX] [Address(nn)]) }, [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:509:17 [INFO] [stderr] | [INFO] [stderr] 509 | tile_x as u32 * 8 + i, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(tile_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:510:17 [INFO] [stderr] | [INFO] [stderr] 510 | v as u32, [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:520:1 [INFO] [stderr] | [INFO] [stderr] 520 | / pub fn draw_line_mode4<'a, V: 'a, G: 'a>( [INFO] [stderr] 521 | | s: &mut SmsVdpGraphicsImpler<'a, V, G>, [INFO] [stderr] 522 | | ) -> Result<(), SmsVdpGraphicsError> [INFO] [stderr] 523 | | where [INFO] [stderr] ... | [INFO] [stderr] 733 | | Ok(()) [INFO] [stderr] 734 | | } [INFO] [stderr] | |_^ [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1624 | 0x31 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([SP] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1624 | 0x31 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([SP] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1625 | 0x32 => nn_inst!{z, nn, 13, mem, Ld, ld, ([Address(nn)] [A]) }, [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1625 | 0x32 => nn_inst!{z, nn, 13, mem, Ld, ld, ([Address(nn)] [A]) }, [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1633 | 0x3A => nn_inst!{z, nn, 13, mem, Ld, ld, ([A] [Address(nn)]) }, [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1633 | 0x3A => nn_inst!{z, nn, 13, mem, Ld, ld, ([A] [Address(nn)]) }, [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:548:26 [INFO] [stderr] | [INFO] [stderr] 548 | .map_err(|e| SmsVdpGraphicsError::Graphics(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SmsVdpGraphicsError::Graphics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:555:18 [INFO] [stderr] | [INFO] [stderr] 555 | .map_err(|e| SmsVdpGraphicsError::Graphics(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SmsVdpGraphicsError::Graphics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:554:39 [INFO] [stderr] | [INFO] [stderr] 554 | .set_resolution(width as u32, height as u32) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:557:13 [INFO] [stderr] | [INFO] [stderr] 557 | let y = (v - display_y_start) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(v - display_y_start)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `colors` [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:577:18 [INFO] [stderr] | [INFO] [stderr] 577 | for i in 0..32 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 577 | for (i, ) in colors.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `colors` [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:581:18 [INFO] [stderr] | [INFO] [stderr] 581 | for i in 0..32 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 581 | for (i, ) in colors.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:592:24 [INFO] [stderr] | [INFO] [stderr] 592 | let sprite_y = unsafe { s.vdp.sprite_y(i) } as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(unsafe { s.vdp.sprite_y(i) })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `palette_indices` [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:615:18 [INFO] [stderr] | [INFO] [stderr] 615 | for j in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 615 | for (j, ) in palette_indices.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:653:27 [INFO] [stderr] | [INFO] [stderr] 653 | let tile_offset_x = (-((scroll_x >> 3) as i16)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(scroll_x >> 3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:662:20 [INFO] [stderr] | [INFO] [stderr] 662 | let scroll_y = s.vdp.y_scroll() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(s.vdp.y_scroll())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `line_buffer`. [INFO] [stderr] --> src/hardware/sms_vdp/graphics.rs:722:18 [INFO] [stderr] | [INFO] [stderr] 722 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 722 | for in line_buffer.iter_mut().take(8) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1769 | 0xC2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([NZcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1769 | 0xC2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([NZcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1770 | 0xC3 => nn_inst!{z, nn, 10, mem, Jp, jp, ([nn]) }, [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1770 | 0xC3 => nn_inst!{z, nn, 10, mem, Jp, jp, ([nn]) }, [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1771 | 0xC4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([NZcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1771 | 0xC4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([NZcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1777 | 0xCA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Zcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1777 | 0xCA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Zcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1779 | 0xCC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Zcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1779 | 0xCC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Zcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1780 | 0xCD => nn_inst!{z, nn, 17, mem, Call, call, ([nn]) }, [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1780 | 0xCD => nn_inst!{z, nn, 17, mem, Call, call, ([nn]) }, [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/vdp_interface.rs:82:31 [INFO] [stderr] | [INFO] [stderr] 82 | let val = latch as u16 | ((x as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(latch)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/vdp_interface.rs:82:47 [INFO] [stderr] | [INFO] [stderr] 82 | let val = latch as u16 | ((x as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(x)` [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1785 | 0xD2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([NCcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1785 | 0xD2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([NCcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/vdp_interface.rs:90:52 [INFO] [stderr] | [INFO] [stderr] 90 | self.set_cram_unchecked(addr % 32, x as u16); [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1787 | 0xD4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([NCcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1787 | 0xD4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([NCcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/vdp_interface.rs:116:40 [INFO] [stderr] | [INFO] [stderr] 116 | let code_addr = low_byte | (x as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/vdp_interface.rs:128:53 [INFO] [stderr] | [INFO] [stderr] 128 | self.set_register_unchecked(which_reg as u16, low_byte as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(which_reg)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1793 | 0xDA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Ccc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1793 | 0xDA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Ccc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1795 | 0xDC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Ccc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1795 | 0xDC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Ccc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1801 | 0xE2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([POcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1801 | 0xE2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([POcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1803 | 0xE4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([POcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1803 | 0xE4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([POcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/vdp_interface.rs:135:47 [INFO] [stderr] | [INFO] [stderr] 135 | self.set_code_address(high_byte | x as u16); [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1809 | 0xEA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([PEcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1809 | 0xEA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([PEcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1811 | 0xEC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([PEcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1811 | 0xEC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([PEcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1817 | 0xF2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Pcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1817 | 0xF2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Pcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1819 | 0xF4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Pcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1819 | 0xF4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Pcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1825 | 0xFA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Mcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1825 | 0xFA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Mcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1827 | 0xFC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Mcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1827 | 0xFC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Mcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/vdp_internal.rs:368:33 [INFO] [stderr] | [INFO] [stderr] 368 | let address = unsafe { (self.register_unchecked(2) as u16 & 0xE) << 10 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.register_unchecked(2))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/vdp_internal.rs:384:22 [INFO] [stderr] | [INFO] [stderr] 384 | unsafe { (self.register_unchecked(2) as u16) << 10 | 0xFBFF } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.register_unchecked(2))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/vdp_internal.rs:440:19 [INFO] [stderr] | [INFO] [stderr] 440 | unsafe { (self.register_unchecked(5) as u16 & 0x7E) << 7 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.register_unchecked(5))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/vdp_internal.rs:453:36 [INFO] [stderr] | [INFO] [stderr] 453 | let low_bit = unsafe { self.register_unchecked(5) as u16 & 1 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.register_unchecked(5))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/vdp_internal.rs:508:13 [INFO] [stderr] | [INFO] [stderr] 508 | self.vram_unchecked(pattern_index_address & self.sprite_attribute_table_mask()) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.vram_unchecked(pattern_index_address & self.sprite_attribute_table_mask()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/vdp_internal.rs:527:19 [INFO] [stderr] | [INFO] [stderr] 527 | unsafe { (self.register_unchecked(6) as u16 & 0x04) << 11 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.register_unchecked(6))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/vdp_internal.rs:545:37 [INFO] [stderr] | [INFO] [stderr] 545 | let low_bits = unsafe { self.register_unchecked(6) as u16 & 3 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.register_unchecked(6))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1849 | 0x01 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([BC] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1849 | 0x01 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([BC] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1865 | 0x11 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([DE] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1865 | 0x11 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([DE] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1881 | 0x21 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([IY] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1881 | 0x21 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([IY] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1882 | 0x22 => nn_inst!{z, nn, 16, mem, Ld16, ld16, ([Address(nn)] [IY]) }, [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1882 | 0x22 => nn_inst!{z, nn, 16, mem, Ld16, ld16, ([Address(nn)] [IY]) }, [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1890 | 0x2A => nn_inst!{z, nn, 16, mem, Ld16, ld16, ([IY] [Address(nn)]) }, [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1890 | 0x2A => nn_inst!{z, nn, 16, mem, Ld16, ld16, ([IY] [Address(nn)]) }, [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1897 | 0x31 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([SP] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1897 | 0x31 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([SP] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1898 | 0x32 => nn_inst!{z, nn, 13, mem, Ld, ld, ([Address(nn)] [A]) }, [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1898 | 0x32 => nn_inst!{z, nn, 13, mem, Ld, ld, ([Address(nn)] [A]) }, [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1906 | 0x3A => nn_inst!{z, nn, 13, mem, Ld, ld, ([A] [Address(nn)]) }, [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1906 | 0x3A => nn_inst!{z, nn, 13, mem, Ld, ld, ([A] [Address(nn)]) }, [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/utilities.rs:67:48 [INFO] [stderr] | [INFO] [stderr] 67 | let o: &$other_type = unsafe { transmute(self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&*(self as *const hardware::sms_vdp::vdp_internal::SmsVdpState as *const hardware::sms_vdp::vdp_internal::_impl0::SmsVdpStateDerive)` [INFO] [stderr] | [INFO] [stderr] ::: src/hardware/sms_vdp/vdp_internal.rs:796:5 [INFO] [stderr] | [INFO] [stderr] 796 | impl_serde_via!{SmsVdpState, SmsVdpStateDerive} [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/utilities.rs:83:48 [INFO] [stderr] | [INFO] [stderr] 83 | let o: &$other_type = unsafe { transmute(self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&*(self as *const hardware::sms_vdp::vdp_internal::SmsVdpState as *const hardware::sms_vdp::vdp_internal::_impl0::SmsVdpStateDerive)` [INFO] [stderr] | [INFO] [stderr] ::: src/hardware/sms_vdp/vdp_internal.rs:797:5 [INFO] [stderr] | [INFO] [stderr] 797 | impl_hash_via!{SmsVdpState, SmsVdpStateDerive} [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/utilities.rs:34:48 [INFO] [stderr] | [INFO] [stderr] 34 | let s: &$other_type = unsafe { transmute(self) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `&*(self as *const hardware::sms_vdp::vdp_internal::SmsVdpState as *const hardware::sms_vdp::vdp_internal::_impl0::SmsVdpStateDerive)` [INFO] [stderr] | [INFO] [stderr] ::: src/hardware/sms_vdp/vdp_internal.rs:798:5 [INFO] [stderr] | [INFO] [stderr] 798 | impl_partial_eq_via!{SmsVdpState, SmsVdpStateDerive} [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/utilities.rs:35:48 [INFO] [stderr] | [INFO] [stderr] 35 | let o: &$other_type = unsafe { transmute(rhs) }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&*(rhs as *const hardware::sms_vdp::vdp_internal::SmsVdpState as *const hardware::sms_vdp::vdp_internal::_impl0::SmsVdpStateDerive)` [INFO] [stderr] | [INFO] [stderr] ::: src/hardware/sms_vdp/vdp_internal.rs:798:5 [INFO] [stderr] | [INFO] [stderr] 798 | impl_partial_eq_via!{SmsVdpState, SmsVdpStateDerive} [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:25:25 [INFO] [stderr] | [INFO] [stderr] 25 | let pattern_table = ((v.register(4) & 0x7) as u16) << 11; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(v.register(4) & 0x7)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:26:22 [INFO] [stderr] | [INFO] [stderr] 26 | let name_table = ((v.register(2) & 0xF) as u16) << 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(v.register(2) & 0xF)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:27:23 [INFO] [stderr] | [INFO] [stderr] 27 | let color_table = (v.register(3) as u16) << 6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(v.register(3))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:31:18 [INFO] [stderr] | [INFO] [stderr] 31 | .map_err(|e| SmsVdpGraphicsError::Graphics(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SmsVdpGraphicsError::Graphics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:35:24 [INFO] [stderr] | [INFO] [stderr] 35 | let name = v.vram(name_table + tile_y * 32 + tile_x) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(v.vram(name_table + tile_y * 32 + tile_x))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | tile_x as u32 * 8 + i, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(tile_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2042 | 0xC2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([NZcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:45:25 [INFO] [stderr] | [INFO] [stderr] 45 | tile_y as u32 * 8 + tile_line as u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(tile_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2042 | 0xC2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([NZcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:45:45 [INFO] [stderr] | [INFO] [stderr] 45 | tile_y as u32 * 8 + tile_line as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(tile_line)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:55:18 [INFO] [stderr] | [INFO] [stderr] 55 | .map_err(|e| SmsVdpGraphicsError::Graphics(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SmsVdpGraphicsError::Graphics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2043 | 0xC3 => nn_inst!{z, nn, 10, mem, Jp, jp, ([nn]) }, [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2043 | 0xC3 => nn_inst!{z, nn, 10, mem, Jp, jp, ([nn]) }, [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2044 | 0xC4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([NZcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2044 | 0xC4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([NZcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:63:25 [INFO] [stderr] | [INFO] [stderr] 63 | let pattern_table = ((v.register(4) & 4) as u16) << 11; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(v.register(4) & 4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2050 | 0xCA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Zcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:64:22 [INFO] [stderr] | [INFO] [stderr] 64 | let name_table = ((v.register(2) & 0xF) as u16) << 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(v.register(2) & 0xF)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2050 | 0xCA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Zcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:65:23 [INFO] [stderr] | [INFO] [stderr] 65 | let color_table = ((v.register(3) & 0x80) as u16) << 6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(v.register(3) & 0x80)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:69:18 [INFO] [stderr] | [INFO] [stderr] 69 | .map_err(|e| SmsVdpGraphicsError::Graphics(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SmsVdpGraphicsError::Graphics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:74:24 [INFO] [stderr] | [INFO] [stderr] 74 | let name = v.vram(name_table + tile_y * 32 + tile_x) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(v.vram(name_table + tile_y * 32 + tile_x))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:84:25 [INFO] [stderr] | [INFO] [stderr] 84 | tile_x as u32 * 8 + i, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(tile_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:85:25 [INFO] [stderr] | [INFO] [stderr] 85 | tile_y as u32 * 8 + tile_line as u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(tile_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:85:45 [INFO] [stderr] | [INFO] [stderr] 85 | tile_y as u32 * 8 + tile_line as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(tile_line)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:96:18 [INFO] [stderr] | [INFO] [stderr] 96 | .map_err(|e| SmsVdpGraphicsError::Graphics(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SmsVdpGraphicsError::Graphics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:112:18 [INFO] [stderr] | [INFO] [stderr] 112 | .map_err(|e| SmsVdpGraphicsError::Graphics(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SmsVdpGraphicsError::Graphics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:111:30 [INFO] [stderr] | [INFO] [stderr] 111 | .set_resolution(256, height as u32) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:118:27 [INFO] [stderr] | [INFO] [stderr] 118 | let pixel_x = (8 * tile_x) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(8 * tile_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:119:27 [INFO] [stderr] | [INFO] [stderr] 119 | let pixel_y = (8 * tile_y) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(8 * tile_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:120:27 [INFO] [stderr] | [INFO] [stderr] 120 | let palette = ((high_byte & 8) << 1) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from((high_byte & 8) << 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2052 | 0xCC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Zcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2052 | 0xCC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Zcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2053 | 0xCD => nn_inst!{z, nn, 17, mem, Call, call, ([nn]) }, [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2053 | 0xCD => nn_inst!{z, nn, 17, mem, Call, call, ([nn]) }, [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2058 | 0xD2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([NCcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2058 | 0xD2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([NCcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `palette_indices` [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:125:26 [INFO] [stderr] | [INFO] [stderr] 125 | for j in 0..8usize { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 125 | for (j, ) in palette_indices.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:127:32 [INFO] [stderr] | [INFO] [stderr] 127 | v.cram(palette_indices[j] as u16 + palette) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(palette_indices[j])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:129:66 [INFO] [stderr] | [INFO] [stderr] 129 | graphics.paint(pixel_x + j as u32, pixel_y + line as u32, color); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(line)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2060 | 0xD4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([NCcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2060 | 0xD4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([NCcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | y_scroll as u32 % height as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(y_scroll)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:140:31 [INFO] [stderr] | [INFO] [stderr] 140 | y_scroll as u32 % height as u32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:149:21 [INFO] [stderr] | [INFO] [stderr] 149 | for i in 0..height as u32 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:164:17 [INFO] [stderr] | [INFO] [stderr] 164 | for i in 0..height as u32 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | x_scroll as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(x_scroll)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2066 | 0xDA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Ccc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2066 | 0xDA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Ccc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/hardware/sms_vdp/debug.rs:193:18 [INFO] [stderr] | [INFO] [stderr] 193 | .map_err(|e| SmsVdpGraphicsError::Graphics(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SmsVdpGraphicsError::Graphics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `result`. [INFO] [stderr] --> src/hardware/sms_vdp/replaceable.rs:7:14 [INFO] [stderr] | [INFO] [stderr] 7 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 7 | for in &mut result { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2068 | 0xDC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Ccc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2068 | 0xDC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Ccc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2074 | 0xE2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([POcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2074 | 0xE2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([POcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2076 | 0xE4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([POcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2076 | 0xE4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([POcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2082 | 0xEA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([PEcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2082 | 0xEA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([PEcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2084 | 0xEC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([PEcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2084 | 0xEC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([PEcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2090 | 0xF2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Pcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2090 | 0xF2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Pcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2092 | 0xF4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Pcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2092 | 0xF4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Pcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2098 | 0xFA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Mcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2098 | 0xFA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Mcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2100 | 0xFC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Mcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2100 | 0xFC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Mcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/hardware/sn76489.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | self.clone() [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sn76489.rs:67:39 [INFO] [stderr] | [INFO] [stderr] 67 | *reg = (*reg & 0xFFF0) | (data as u16 & 0x0F); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sn76489.rs:73:44 [INFO] [stderr] | [INFO] [stderr] 73 | *reg = (*reg & 0xFC0F) | ((data as u16 & 0x3F) << 4); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sn76489.rs:76:24 [INFO] [stderr] | [INFO] [stderr] 76 | *reg = (data as u16) & 0x0F; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sn76489.rs:160:29 [INFO] [stderr] | [INFO] [stderr] 160 | let tone0 = self.sn76489.polarity[0] as i16 * amplitudes[0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(self.sn76489.polarity[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sn76489.rs:161:29 [INFO] [stderr] | [INFO] [stderr] 161 | let tone1 = self.sn76489.polarity[1] as i16 * amplitudes[1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(self.sn76489.polarity[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sn76489.rs:162:29 [INFO] [stderr] | [INFO] [stderr] 162 | let tone2 = self.sn76489.polarity[2] as i16 * amplitudes[2]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(self.sn76489.polarity[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/sn76489.rs:163:29 [INFO] [stderr] | [INFO] [stderr] 163 | let noise = self.sn76489.polarity[3] as i16 * amplitudes[3]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(self.sn76489.polarity[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/arithmetic_help.rs:61:20 [INFO] [stderr] | [INFO] [stderr] 61 | let result32 = (x as u32).wrapping_add(y as u32).wrapping_add(cf as u32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/arithmetic_help.rs:61:44 [INFO] [stderr] | [INFO] [stderr] 61 | let result32 = (x as u32).wrapping_add(y as u32).wrapping_add(cf as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/arithmetic_help.rs:61:67 [INFO] [stderr] | [INFO] [stderr] 61 | let result32 = (x as u32).wrapping_add(y as u32).wrapping_add(cf as u32); [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(cf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/arithmetic_help.rs:114:20 [INFO] [stderr] | [INFO] [stderr] 114 | let result16 = (x as u16).wrapping_add(a as u16).wrapping_add(cf as u16); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/arithmetic_help.rs:114:44 [INFO] [stderr] | [INFO] [stderr] 114 | let result16 = (x as u16).wrapping_add(a as u16).wrapping_add(cf as u16); [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/arithmetic_help.rs:114:67 [INFO] [stderr] | [INFO] [stderr] 114 | let result16 = (x as u16).wrapping_add(a as u16).wrapping_add(cf as u16); [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(cf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/mem.rs:234:48 [INFO] [stderr] | [INFO] [stderr] 234 | let addr = self.0.view(z).wrapping_add(self.1 as i16 as u16); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i16::from(self.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/mem.rs:245:48 [INFO] [stderr] | [INFO] [stderr] 245 | let addr = self.0.view(z).wrapping_add(self.1 as i16 as u16); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i16::from(self.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/hardware/z80/mem.rs:422:36 [INFO] [stderr] | [INFO] [stderr] 422 | self.z80().set_flag_by(HF, x0 & 0xF == 0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `x0.trailing_zeros() >= 4` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::verbose_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/mem.rs:827:18 [INFO] [stderr] | [INFO] [stderr] 827 | self.rst(x as u16); [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/no.rs:34:53 [INFO] [stderr] | [INFO] [stderr] 34 | let result = adc16_help(self.z80(), x0, y0, cf as u16); [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(cf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/no.rs:235:50 [INFO] [stderr] | [INFO] [stderr] 235 | self.z80().set_reg16(PC, pc.wrapping_add(e as i16 as u16)); [INFO] [stderr] | ^^^^^^^^ help: try: `i16::from(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/no.rs:297:54 [INFO] [stderr] | [INFO] [stderr] 297 | let result = adc16_help(self.z80(), x0, !y0, (1 ^ cf) as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(1 ^ cf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 747 | 0x01 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([BC] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 747 | 0x01 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([BC] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 763 | 0x11 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([DE] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 763 | 0x11 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([DE] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 779 | 0x21 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([HL] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 779 | 0x21 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([HL] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 780 | 0x22 => nn_inst!{z, nn, 16, mem, Ld16, ld16, ([Address(nn)] [HL]) }, [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 780 | 0x22 => nn_inst!{z, nn, 16, mem, Ld16, ld16, ([Address(nn)] [HL]) }, [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 788 | 0x2A => nn_inst!{z, nn, 16, mem, Ld16, ld16, ([HL] [Address(nn)]) }, [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 788 | 0x2A => nn_inst!{z, nn, 16, mem, Ld16, ld16, ([HL] [Address(nn)]) }, [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 795 | 0x31 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([SP] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 795 | 0x31 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([SP] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 796 | 0x32 => nn_inst!{z, nn, 13, mem, Ld, ld, ([Address(nn)] [A]) }, [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 796 | 0x32 => nn_inst!{z, nn, 13, mem, Ld, ld, ([Address(nn)] [A]) }, [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 804 | 0x3A => nn_inst!{z, nn, 13, mem, Ld, ld, ([A] [Address(nn)]) }, [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 804 | 0x3A => nn_inst!{z, nn, 13, mem, Ld, ld, ([A] [Address(nn)]) }, [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 940 | 0xC2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([NZcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 940 | 0xC2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([NZcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 941 | 0xC3 => nn_inst!{z, nn, 10, mem, Jp, jp, ([nn]) }, [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 941 | 0xC3 => nn_inst!{z, nn, 10, mem, Jp, jp, ([nn]) }, [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 942 | 0xC4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([NZcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 942 | 0xC4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([NZcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 948 | 0xCA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Zcc] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 948 | 0xCA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Zcc] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 950 | 0xCC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Zcc] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 950 | 0xCC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Zcc] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 951 | 0xCD => nn_inst!{z, nn, 0, mem, Call, call, ([nn]) }, [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 951 | 0xCD => nn_inst!{z, nn, 0, mem, Call, call, ([nn]) }, [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 956 | 0xD2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([NCcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 956 | 0xD2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([NCcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 958 | 0xD4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([NCcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 958 | 0xD4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([NCcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 964 | 0xDA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Ccc] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 964 | 0xDA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Ccc] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 966 | 0xDC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Ccc] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 966 | 0xDC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Ccc] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 972 | 0xE2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([POcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 972 | 0xE2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([POcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 974 | 0xE4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([POcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 974 | 0xE4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([POcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 980 | 0xEA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([PEcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 980 | 0xEA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([PEcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 982 | 0xEC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([PEcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 982 | 0xEC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([PEcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 988 | 0xF2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Pcc] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 988 | 0xF2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Pcc] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 990 | 0xF4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Pcc] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 990 | 0xF4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Pcc] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 996 | 0xFA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Mcc] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 996 | 0xFA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Mcc] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 998 | 0xFC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Mcc] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 998 | 0xFC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Mcc] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1086 | 0x43 => nn_inst!{z, nn, 20, mem, Ld16, ld16, ([Address(nn)] [BC]) }, [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1086 | 0x43 => nn_inst!{z, nn, 20, mem, Ld16, ld16, ([Address(nn)] [BC]) }, [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1094 | 0x4B => nn_inst!{z, nn, 20, mem, Ld16, ld16, ([BC] [Address(nn)]) }, [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1094 | 0x4B => nn_inst!{z, nn, 20, mem, Ld16, ld16, ([BC] [Address(nn)]) }, [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1102 | 0x53 => nn_inst!{z, nn, 20, mem, Ld16, ld16, ([Address(nn)] [DE]) }, [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1102 | 0x53 => nn_inst!{z, nn, 20, mem, Ld16, ld16, ([Address(nn)] [DE]) }, [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1110 | 0x5B => nn_inst!{z, nn, 20, mem, Ld16, ld16, ([DE] [Address(nn)]) }, [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1110 | 0x5B => nn_inst!{z, nn, 20, mem, Ld16, ld16, ([DE] [Address(nn)]) }, [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1118 | 0x63 => nn_inst!{z, nn, 20, mem, Ld16, ld16, ([Address(nn)] [HL]) }, [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1118 | 0x63 => nn_inst!{z, nn, 20, mem, Ld16, ld16, ([Address(nn)] [HL]) }, [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1126 | 0x6B => nn_inst!{z, nn, 20, mem, Ld16, ld16, ([HL] [Address(nn)]) }, [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1126 | 0x6B => nn_inst!{z, nn, 20, mem, Ld16, ld16, ([HL] [Address(nn)]) }, [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1134 | 0x73 => nn_inst!{z, nn, 20, mem, Ld16, ld16, ([Address(nn)] [SP]) }, [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1134 | 0x73 => nn_inst!{z, nn, 20, mem, Ld16, ld16, ([Address(nn)] [SP]) }, [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1144 | 0x7B => nn_inst!{z, nn, 20, mem, Ld16, ld16, ([SP] [Address(nn)]) }, [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1144 | 0x7B => nn_inst!{z, nn, 20, mem, Ld16, ld16, ([SP] [Address(nn)]) }, [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/hardware/z80/internal.rs:344:46 [INFO] [stderr] | [INFO] [stderr] 344 | let byte_array: &[u8; 26] = unsafe { transmute(&self.registers) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self.registers as *const [u16; 13] as *const [u8; 26])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/hardware/z80/internal.rs:351:50 [INFO] [stderr] | [INFO] [stderr] 351 | let byte_array: &mut [u8; 26] = unsafe { transmute(&mut self.registers) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut self.registers as *mut [u16; 13] as *mut [u8; 26])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/hardware/z80/internal.rs:429:9 [INFO] [stderr] | [INFO] [stderr] 429 | self.clone() [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1576 | 0x01 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([BC] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1576 | 0x01 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([BC] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1592 | 0x11 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([DE] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1592 | 0x11 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([DE] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1608 | 0x21 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([IX] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1608 | 0x21 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([IX] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1609 | 0x22 => nn_inst!{z, nn, 16, mem, Ld16, ld16, ([Address(nn)] [IX]) }, [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1609 | 0x22 => nn_inst!{z, nn, 16, mem, Ld16, ld16, ([Address(nn)] [IX]) }, [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1617 | 0x2A => nn_inst!{z, nn, 16, mem, Ld16, ld16, ([IX] [Address(nn)]) }, [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1617 | 0x2A => nn_inst!{z, nn, 16, mem, Ld16, ld16, ([IX] [Address(nn)]) }, [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1624 | 0x31 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([SP] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1624 | 0x31 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([SP] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1625 | 0x32 => nn_inst!{z, nn, 13, mem, Ld, ld, ([Address(nn)] [A]) }, [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1625 | 0x32 => nn_inst!{z, nn, 13, mem, Ld, ld, ([Address(nn)] [A]) }, [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1633 | 0x3A => nn_inst!{z, nn, 13, mem, Ld, ld, ([A] [Address(nn)]) }, [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1633 | 0x3A => nn_inst!{z, nn, 13, mem, Ld, ld, ([A] [Address(nn)]) }, [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | / match self { [INFO] [stderr] 47 | | &Opcode::OneByte(ref x) => f.pad(&format!("{:0>2X}", x[0])), [INFO] [stderr] 48 | | &Opcode::TwoBytes(ref x) => f.pad(&format!("{:0>2X} {:0>2X}", x[0], x[1])), [INFO] [stderr] 49 | | &Opcode::ThreeBytes(ref x) => { [INFO] [stderr] ... | [INFO] [stderr] 55 | | )), [INFO] [stderr] 56 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 46 | match *self { [INFO] [stderr] 47 | Opcode::OneByte(ref x) => f.pad(&format!("{:0>2X}", x[0])), [INFO] [stderr] 48 | Opcode::TwoBytes(ref x) => f.pad(&format!("{:0>2X} {:0>2X}", x[0], x[1])), [INFO] [stderr] 49 | Opcode::ThreeBytes(ref x) => { [INFO] [stderr] 50 | f.pad(&format!("{:0>2} {:0>2X} {:0>2X}", x[0], x[1], x[2])) [INFO] [stderr] 51 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1769 | 0xC2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([NZcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1769 | 0xC2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([NZcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1770 | 0xC3 => nn_inst!{z, nn, 10, mem, Jp, jp, ([nn]) }, [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1770 | 0xC3 => nn_inst!{z, nn, 10, mem, Jp, jp, ([nn]) }, [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1771 | 0xC4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([NZcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1771 | 0xC4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([NZcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1777 | 0xCA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Zcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1777 | 0xCA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Zcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1779 | 0xCC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Zcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1779 | 0xCC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Zcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1780 | 0xCD => nn_inst!{z, nn, 17, mem, Call, call, ([nn]) }, [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1780 | 0xCD => nn_inst!{z, nn, 17, mem, Call, call, ([nn]) }, [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1785 | 0xD2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([NCcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1785 | 0xD2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([NCcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1787 | 0xD4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([NCcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1787 | 0xD4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([NCcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1793 | 0xDA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Ccc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1793 | 0xDA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Ccc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1795 | 0xDC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Ccc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1795 | 0xDC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Ccc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1801 | 0xE2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([POcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1801 | 0xE2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([POcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1803 | 0xE4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([POcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1803 | 0xE4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([POcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1809 | 0xEA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([PEcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1809 | 0xEA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([PEcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1811 | 0xEC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([PEcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1811 | 0xEC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([PEcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1817 | 0xF2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Pcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1817 | 0xF2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Pcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1819 | 0xF4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Pcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1819 | 0xF4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Pcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1825 | 0xFA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Mcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1825 | 0xFA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Mcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1827 | 0xFC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Mcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1827 | 0xFC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Mcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1849 | 0x01 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([BC] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1849 | 0x01 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([BC] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1865 | 0x11 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([DE] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1865 | 0x11 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([DE] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1881 | 0x21 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([IY] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1881 | 0x21 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([IY] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1882 | 0x22 => nn_inst!{z, nn, 16, mem, Ld16, ld16, ([Address(nn)] [IY]) }, [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1882 | 0x22 => nn_inst!{z, nn, 16, mem, Ld16, ld16, ([Address(nn)] [IY]) }, [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1890 | 0x2A => nn_inst!{z, nn, 16, mem, Ld16, ld16, ([IY] [Address(nn)]) }, [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1890 | 0x2A => nn_inst!{z, nn, 16, mem, Ld16, ld16, ([IY] [Address(nn)]) }, [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1897 | 0x31 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([SP] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1897 | 0x31 => nn_inst!{z, nn, 10, mem, Ld16, ld16, ([SP] [nn]) }, [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1898 | 0x32 => nn_inst!{z, nn, 13, mem, Ld, ld, ([Address(nn)] [A]) }, [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1898 | 0x32 => nn_inst!{z, nn, 13, mem, Ld, ld, ([Address(nn)] [A]) }, [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 1906 | 0x3A => nn_inst!{z, nn, 13, mem, Ld, ld, ([A] [Address(nn)]) }, [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 1906 | 0x3A => nn_inst!{z, nn, 13, mem, Ld, ld, ([A] [Address(nn)]) }, [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/memo.rs:192:65 [INFO] [stderr] | [INFO] [stderr] 192 | OneParameter(Jr, I8(e)) => Some(pc.wrapping_add(2 + e as i16 as u16)), [INFO] [stderr] | ^^^^^^^^ help: try: `i16::from(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/memo.rs:193:69 [INFO] [stderr] | [INFO] [stderr] 193 | TwoParameters(Jr, _, I8(e)) => Some(pc.wrapping_add(2 + e as i16 as u16)), [INFO] [stderr] | ^^^^^^^^ help: try: `i16::from(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/memo.rs:194:67 [INFO] [stderr] | [INFO] [stderr] 194 | OneParameter(Djnz, I8(e)) => Some(pc.wrapping_add(2 + e as i16 as u16)), [INFO] [stderr] | ^^^^^^^^ help: try: `i16::from(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:204:17 [INFO] [stderr] | [INFO] [stderr] 204 | let s = match self { [INFO] [stderr] | _________________^ [INFO] [stderr] 205 | | &FullMnemonic::ZeroParameters(f) => format!("{}", f), [INFO] [stderr] 206 | | &FullMnemonic::OneParameter(f, p1) => format!("{} {}", f, p1), [INFO] [stderr] 207 | | &FullMnemonic::TwoParameters(f, p1, p2) => format!("{} {}, {}", f, p1, p2), [INFO] [stderr] ... | [INFO] [stderr] 210 | | } [INFO] [stderr] 211 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 204 | let s = match *self { [INFO] [stderr] 205 | FullMnemonic::ZeroParameters(f) => format!("{}", f), [INFO] [stderr] 206 | FullMnemonic::OneParameter(f, p1) => format!("{} {}", f, p1), [INFO] [stderr] 207 | FullMnemonic::TwoParameters(f, p1, p2) => format!("{} {}, {}", f, p1, p2), [INFO] [stderr] 208 | FullMnemonic::ThreeParameters(f, p1, p2, p3) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2042 | 0xC2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([NZcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2042 | 0xC2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([NZcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2043 | 0xC3 => nn_inst!{z, nn, 10, mem, Jp, jp, ([nn]) }, [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2043 | 0xC3 => nn_inst!{z, nn, 10, mem, Jp, jp, ([nn]) }, [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2044 | 0xC4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([NZcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2044 | 0xC4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([NZcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2050 | 0xCA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Zcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2050 | 0xCA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Zcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2052 | 0xCC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Zcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2052 | 0xCC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Zcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2053 | 0xCD => nn_inst!{z, nn, 17, mem, Call, call, ([nn]) }, [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2053 | 0xCD => nn_inst!{z, nn, 17, mem, Call, call, ([nn]) }, [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2058 | 0xD2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([NCcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2058 | 0xD2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([NCcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2060 | 0xD4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([NCcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2060 | 0xD4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([NCcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: item `hardware::z80::memo::Opcode` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/hardware/z80/memo.rs:528:1 [INFO] [stderr] | [INFO] [stderr] 528 | / impl Opcode { [INFO] [stderr] 529 | | pub fn len(&self) -> usize { [INFO] [stderr] 530 | | match *self { [INFO] [stderr] 531 | | Opcode::OneByte(_) => 1, [INFO] [stderr] ... | [INFO] [stderr] 964 | | } [INFO] [stderr] 965 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2066 | 0xDA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Ccc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2066 | 0xDA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Ccc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2068 | 0xDC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Ccc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2068 | 0xDC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Ccc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/hardware/z80/memo.rs:529:16 [INFO] [stderr] | [INFO] [stderr] 529 | pub fn len(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2074 | 0xE2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([POcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2074 | 0xE2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([POcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2076 | 0xE4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([POcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2076 | 0xE4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([POcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2082 | 0xEA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([PEcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2082 | 0xEA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([PEcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2084 | 0xEC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([PEcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2084 | 0xEC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([PEcc] [nn]) }, [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2090 | 0xF2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Pcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2090 | 0xF2 => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Pcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2092 | 0xF4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Pcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2092 | 0xF4 => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Pcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2098 | 0xFA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Mcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2098 | 0xFA => nn_inst!{z, nn, 10, no, Jpcc, jpcc, ([Mcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:25 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] ... [INFO] [stderr] 2100 | 0xFC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Mcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/instruction.rs:650:44 [INFO] [stderr] | [INFO] [stderr] 650 | let $nn: u16 = (hi as u16) << 8 | (lo as u16); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] ... [INFO] [stderr] 2100 | 0xFC => nn_inst!{z, nn, 0, mem, Callcc, callcc, ([Mcc] [nn]) }, [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 1903 [INFO] [stderr] --> src/hardware/z80/memo.rs:549:5 [INFO] [stderr] | [INFO] [stderr] 549 | / pub fn mnemonic(&self) -> Option { [INFO] [stderr] 550 | | // rustc insists these do not need to be mutable. Somehow it isn't [INFO] [stderr] 551 | | // seeing the assignments behind the macros? [INFO] [stderr] 552 | | let n: u8; [INFO] [stderr] ... | [INFO] [stderr] 963 | | return None; [INFO] [stderr] 964 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/hardware/z80/memo.rs:549:21 [INFO] [stderr] | [INFO] [stderr] 549 | pub fn mnemonic(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/hardware/z80/internal.rs:344:46 [INFO] [stderr] | [INFO] [stderr] 344 | let byte_array: &[u8; 26] = unsafe { transmute(&self.registers) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self.registers as *const [u16; 13] as *const [u8; 26])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/hardware/z80/internal.rs:351:50 [INFO] [stderr] | [INFO] [stderr] 351 | let byte_array: &mut [u8; 26] = unsafe { transmute(&mut self.registers) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut self.registers as *mut [u16; 13] as *mut [u8; 26])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/hardware/z80/internal.rs:429:9 [INFO] [stderr] | [INFO] [stderr] 429 | self.clone() [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | / match self { [INFO] [stderr] 47 | | &Opcode::OneByte(ref x) => f.pad(&format!("{:0>2X}", x[0])), [INFO] [stderr] 48 | | &Opcode::TwoBytes(ref x) => f.pad(&format!("{:0>2X} {:0>2X}", x[0], x[1])), [INFO] [stderr] 49 | | &Opcode::ThreeBytes(ref x) => { [INFO] [stderr] ... | [INFO] [stderr] 55 | | )), [INFO] [stderr] 56 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 46 | match *self { [INFO] [stderr] 47 | Opcode::OneByte(ref x) => f.pad(&format!("{:0>2X}", x[0])), [INFO] [stderr] 48 | Opcode::TwoBytes(ref x) => f.pad(&format!("{:0>2X} {:0>2X}", x[0], x[1])), [INFO] [stderr] 49 | Opcode::ThreeBytes(ref x) => { [INFO] [stderr] 50 | f.pad(&format!("{:0>2} {:0>2X} {:0>2X}", x[0], x[1], x[2])) [INFO] [stderr] 51 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/memo.rs:192:65 [INFO] [stderr] | [INFO] [stderr] 192 | OneParameter(Jr, I8(e)) => Some(pc.wrapping_add(2 + e as i16 as u16)), [INFO] [stderr] | ^^^^^^^^ help: try: `i16::from(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/memo.rs:193:69 [INFO] [stderr] | [INFO] [stderr] 193 | TwoParameters(Jr, _, I8(e)) => Some(pc.wrapping_add(2 + e as i16 as u16)), [INFO] [stderr] | ^^^^^^^^ help: try: `i16::from(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/hardware/z80/memo.rs:194:67 [INFO] [stderr] | [INFO] [stderr] 194 | OneParameter(Djnz, I8(e)) => Some(pc.wrapping_add(2 + e as i16 as u16)), [INFO] [stderr] | ^^^^^^^^ help: try: `i16::from(e)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:204:17 [INFO] [stderr] | [INFO] [stderr] 204 | let s = match self { [INFO] [stderr] | _________________^ [INFO] [stderr] 205 | | &FullMnemonic::ZeroParameters(f) => format!("{}", f), [INFO] [stderr] 206 | | &FullMnemonic::OneParameter(f, p1) => format!("{} {}", f, p1), [INFO] [stderr] 207 | | &FullMnemonic::TwoParameters(f, p1, p2) => format!("{} {}, {}", f, p1, p2), [INFO] [stderr] ... | [INFO] [stderr] 210 | | } [INFO] [stderr] 211 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 204 | let s = match *self { [INFO] [stderr] 205 | FullMnemonic::ZeroParameters(f) => format!("{}", f), [INFO] [stderr] 206 | FullMnemonic::OneParameter(f, p1) => format!("{} {}", f, p1), [INFO] [stderr] 207 | FullMnemonic::TwoParameters(f, p1, p2) => format!("{} {}, {}", f, p1, p2), [INFO] [stderr] 208 | FullMnemonic::ThreeParameters(f, p1, p2, p3) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `hardware::z80::memo::Opcode` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/hardware/z80/memo.rs:528:1 [INFO] [stderr] | [INFO] [stderr] 528 | / impl Opcode { [INFO] [stderr] 529 | | pub fn len(&self) -> usize { [INFO] [stderr] 530 | | match *self { [INFO] [stderr] 531 | | Opcode::OneByte(_) => 1, [INFO] [stderr] ... | [INFO] [stderr] 964 | | } [INFO] [stderr] 965 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/hardware/z80/memo.rs:529:16 [INFO] [stderr] | [INFO] [stderr] 529 | pub fn len(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 1903 [INFO] [stderr] --> src/hardware/z80/memo.rs:549:5 [INFO] [stderr] | [INFO] [stderr] 549 | / pub fn mnemonic(&self) -> Option { [INFO] [stderr] 550 | | // rustc insists these do not need to be mutable. Somehow it isn't [INFO] [stderr] 551 | | // seeing the assignments behind the macros? [INFO] [stderr] 552 | | let n: u8; [INFO] [stderr] ... | [INFO] [stderr] 963 | | return None; [INFO] [stderr] 964 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/hardware/z80/memo.rs:549:21 [INFO] [stderr] | [INFO] [stderr] 549 | pub fn mnemonic(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:803:17 [INFO] [stderr] | [INFO] [stderr] 803 | / if let &Opcode::ThreeBytes(x) = self { [INFO] [stderr] 804 | | if $code == x[0] { [INFO] [stderr] 805 | | nn = utilities::to16(x[1], x[2]); [INFO] [stderr] 806 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 807 | | } [INFO] [stderr] 808 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:848:17 [INFO] [stderr] | [INFO] [stderr] 848 | / if let &Opcode::TwoBytes(x) = self { [INFO] [stderr] 849 | | if $code == x[0] { [INFO] [stderr] 850 | | n = x[1]; [INFO] [stderr] 851 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 852 | | } [INFO] [stderr] 853 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:848:17 [INFO] [stderr] | [INFO] [stderr] 848 | / if let &Opcode::TwoBytes(x) = self { [INFO] [stderr] 849 | | if $code == x[0] { [INFO] [stderr] 850 | | n = x[1]; [INFO] [stderr] 851 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 852 | | } [INFO] [stderr] 853 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:818:17 [INFO] [stderr] | [INFO] [stderr] 818 | / if let &Opcode::TwoBytes(x) = self { [INFO] [stderr] 819 | | if $code == x[0] { [INFO] [stderr] 820 | | e = x[1] as i8; [INFO] [stderr] 821 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 822 | | } [INFO] [stderr] 823 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:803:17 [INFO] [stderr] | [INFO] [stderr] 803 | / if let &Opcode::ThreeBytes(x) = self { [INFO] [stderr] 804 | | if $code == x[0] { [INFO] [stderr] 805 | | nn = utilities::to16(x[1], x[2]); [INFO] [stderr] 806 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 807 | | } [INFO] [stderr] 808 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:848:17 [INFO] [stderr] | [INFO] [stderr] 848 | / if let &Opcode::TwoBytes(x) = self { [INFO] [stderr] 849 | | if $code == x[0] { [INFO] [stderr] 850 | | n = x[1]; [INFO] [stderr] 851 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 852 | | } [INFO] [stderr] 853 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:818:17 [INFO] [stderr] | [INFO] [stderr] 818 | / if let &Opcode::TwoBytes(x) = self { [INFO] [stderr] 819 | | if $code == x[0] { [INFO] [stderr] 820 | | e = x[1] as i8; [INFO] [stderr] 821 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 822 | | } [INFO] [stderr] 823 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:848:17 [INFO] [stderr] | [INFO] [stderr] 848 | / if let &Opcode::TwoBytes(x) = self { [INFO] [stderr] 849 | | if $code == x[0] { [INFO] [stderr] 850 | | n = x[1]; [INFO] [stderr] 851 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 852 | | } [INFO] [stderr] 853 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:818:17 [INFO] [stderr] | [INFO] [stderr] 818 | / if let &Opcode::TwoBytes(x) = self { [INFO] [stderr] 819 | | if $code == x[0] { [INFO] [stderr] 820 | | e = x[1] as i8; [INFO] [stderr] 821 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 822 | | } [INFO] [stderr] 823 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:803:17 [INFO] [stderr] | [INFO] [stderr] 803 | / if let &Opcode::ThreeBytes(x) = self { [INFO] [stderr] 804 | | if $code == x[0] { [INFO] [stderr] 805 | | nn = utilities::to16(x[1], x[2]); [INFO] [stderr] 806 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 807 | | } [INFO] [stderr] 808 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:803:17 [INFO] [stderr] | [INFO] [stderr] 803 | / if let &Opcode::ThreeBytes(x) = self { [INFO] [stderr] 804 | | if $code == x[0] { [INFO] [stderr] 805 | | nn = utilities::to16(x[1], x[2]); [INFO] [stderr] 806 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 807 | | } [INFO] [stderr] 808 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:848:17 [INFO] [stderr] | [INFO] [stderr] 848 | / if let &Opcode::TwoBytes(x) = self { [INFO] [stderr] 849 | | if $code == x[0] { [INFO] [stderr] 850 | | n = x[1]; [INFO] [stderr] 851 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 852 | | } [INFO] [stderr] 853 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:818:17 [INFO] [stderr] | [INFO] [stderr] 818 | / if let &Opcode::TwoBytes(x) = self { [INFO] [stderr] 819 | | if $code == x[0] { [INFO] [stderr] 820 | | e = x[1] as i8; [INFO] [stderr] 821 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 822 | | } [INFO] [stderr] 823 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:803:17 [INFO] [stderr] | [INFO] [stderr] 803 | / if let &Opcode::ThreeBytes(x) = self { [INFO] [stderr] 804 | | if $code == x[0] { [INFO] [stderr] 805 | | nn = utilities::to16(x[1], x[2]); [INFO] [stderr] 806 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 807 | | } [INFO] [stderr] 808 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:848:17 [INFO] [stderr] | [INFO] [stderr] 848 | / if let &Opcode::TwoBytes(x) = self { [INFO] [stderr] 849 | | if $code == x[0] { [INFO] [stderr] 850 | | n = x[1]; [INFO] [stderr] 851 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 852 | | } [INFO] [stderr] 853 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:818:17 [INFO] [stderr] | [INFO] [stderr] 818 | / if let &Opcode::TwoBytes(x) = self { [INFO] [stderr] 819 | | if $code == x[0] { [INFO] [stderr] 820 | | e = x[1] as i8; [INFO] [stderr] 821 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 822 | | } [INFO] [stderr] 823 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:803:17 [INFO] [stderr] | [INFO] [stderr] 803 | / if let &Opcode::ThreeBytes(x) = self { [INFO] [stderr] 804 | | if $code == x[0] { [INFO] [stderr] 805 | | nn = utilities::to16(x[1], x[2]); [INFO] [stderr] 806 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 807 | | } [INFO] [stderr] 808 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:803:17 [INFO] [stderr] | [INFO] [stderr] 803 | / if let &Opcode::ThreeBytes(x) = self { [INFO] [stderr] 804 | | if $code == x[0] { [INFO] [stderr] 805 | | nn = utilities::to16(x[1], x[2]); [INFO] [stderr] 806 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 807 | | } [INFO] [stderr] 808 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:848:17 [INFO] [stderr] | [INFO] [stderr] 848 | / if let &Opcode::TwoBytes(x) = self { [INFO] [stderr] 849 | | if $code == x[0] { [INFO] [stderr] 850 | | n = x[1]; [INFO] [stderr] 851 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 852 | | } [INFO] [stderr] 853 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:818:17 [INFO] [stderr] | [INFO] [stderr] 818 | / if let &Opcode::TwoBytes(x) = self { [INFO] [stderr] 819 | | if $code == x[0] { [INFO] [stderr] 820 | | e = x[1] as i8; [INFO] [stderr] 821 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 822 | | } [INFO] [stderr] 823 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:803:17 [INFO] [stderr] | [INFO] [stderr] 803 | / if let &Opcode::ThreeBytes(x) = self { [INFO] [stderr] 804 | | if $code == x[0] { [INFO] [stderr] 805 | | nn = utilities::to16(x[1], x[2]); [INFO] [stderr] 806 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 807 | | } [INFO] [stderr] 808 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:848:17 [INFO] [stderr] | [INFO] [stderr] 848 | / if let &Opcode::TwoBytes(x) = self { [INFO] [stderr] 849 | | if $code == x[0] { [INFO] [stderr] 850 | | n = x[1]; [INFO] [stderr] 851 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 852 | | } [INFO] [stderr] 853 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [INFO] [stderr] | [INFO] [stderr] 939 | / if let &Opcode::OneByte(x) = self { [INFO] [stderr] 940 | | if $code == x[0] { [INFO] [stderr] 941 | | return Some(make_full_mnemonic!($mnemonic, $arg_list)); [INFO] [stderr] 942 | | } [INFO] [stderr] 943 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 961 | euphrates_process_instructions!(find_code, d, e, n, nn); [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/hardware/z80/memo.rs:939:17 [WARN] too many lines in the log, truncating it