[INFO] crate euclid 0.19.4 is already in cache [INFO] extracting crate euclid 0.19.4 into work/ex/clippy-test-run/sources/stable/reg/euclid/0.19.4 [INFO] extracting crate euclid 0.19.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/euclid/0.19.4 [INFO] validating manifest of euclid-0.19.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of euclid-0.19.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing euclid-0.19.4 [INFO] finished frobbing euclid-0.19.4 [INFO] frobbed toml for euclid-0.19.4 written to work/ex/clippy-test-run/sources/stable/reg/euclid/0.19.4/Cargo.toml [INFO] started frobbing euclid-0.19.4 [INFO] finished frobbing euclid-0.19.4 [INFO] frobbed toml for euclid-0.19.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/euclid/0.19.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting euclid-0.19.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/euclid/0.19.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c8e4d563b2f348a43550f0e99a2c3a3617700888fae47a8c99fa419a41f6f371 [INFO] running `"docker" "start" "-a" "c8e4d563b2f348a43550f0e99a2c3a3617700888fae47a8c99fa419a41f6f371"` [INFO] [stderr] Checking euclid v0.19.4 (/opt/crater/workdir) [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform2d.rs:167:14 [INFO] [stderr] | [INFO] [stderr] 167 | let (_0, _1) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::just_underscores_and_digits)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform2d.rs:167:18 [INFO] [stderr] | [INFO] [stderr] 167 | let (_0, _1) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform2d.rs:216:15 [INFO] [stderr] | [INFO] [stderr] 216 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform2d.rs:216:19 [INFO] [stderr] | [INFO] [stderr] 216 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform2d.rs:238:13 [INFO] [stderr] | [INFO] [stderr] 238 | let _0 = Zero::zero(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform2d.rs:264:13 [INFO] [stderr] | [INFO] [stderr] 264 | let _0 = Zero::zero(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform2d.rs:325:13 [INFO] [stderr] | [INFO] [stderr] 325 | let _0: T = Zero::zero(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform2d.rs:326:13 [INFO] [stderr] | [INFO] [stderr] 326 | let _1: T = One::one(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:102:14 [INFO] [stderr] | [INFO] [stderr] 102 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:102:18 [INFO] [stderr] | [INFO] [stderr] 102 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:135:14 [INFO] [stderr] | [INFO] [stderr] 135 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:135:18 [INFO] [stderr] | [INFO] [stderr] 135 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:152:14 [INFO] [stderr] | [INFO] [stderr] 152 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:152:18 [INFO] [stderr] | [INFO] [stderr] 152 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | let _2 = _1 + _1; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:167:14 [INFO] [stderr] | [INFO] [stderr] 167 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:167:18 [INFO] [stderr] | [INFO] [stderr] 167 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:195:13 [INFO] [stderr] | [INFO] [stderr] 195 | let _0: T = Zero::zero(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:360:13 [INFO] [stderr] | [INFO] [stderr] 360 | let _1: T = One::one(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/transform3d.rs:418:13 [INFO] [stderr] | [INFO] [stderr] 418 | let w = p.x * self.m14 + p.y * self.m24 + self.m44; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/transform3d.rs:463:13 [INFO] [stderr] | [INFO] [stderr] 463 | let w = p.x * self.m14 + p.y * self.m24 + p.z * self.m34 + self.m44; [INFO] [stderr] | ^ [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform2d.rs:167:14 [INFO] [stderr] | [INFO] [stderr] 167 | let (_0, _1) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::just_underscores_and_digits)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform2d.rs:167:18 [INFO] [stderr] | [INFO] [stderr] 167 | let (_0, _1) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform2d.rs:216:15 [INFO] [stderr] | [INFO] [stderr] 216 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform2d.rs:216:19 [INFO] [stderr] | [INFO] [stderr] 216 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform2d.rs:238:13 [INFO] [stderr] | [INFO] [stderr] 238 | let _0 = Zero::zero(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform2d.rs:264:13 [INFO] [stderr] | [INFO] [stderr] 264 | let _0 = Zero::zero(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform2d.rs:325:13 [INFO] [stderr] | [INFO] [stderr] 325 | let _0: T = Zero::zero(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:502:14 [INFO] [stderr] | [INFO] [stderr] 502 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:502:18 [INFO] [stderr] | [INFO] [stderr] 502 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:525:14 [INFO] [stderr] | [INFO] [stderr] 525 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:525:18 [INFO] [stderr] | [INFO] [stderr] 525 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:561:14 [INFO] [stderr] | [INFO] [stderr] 561 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:561:18 [INFO] [stderr] | [INFO] [stderr] 561 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:590:14 [INFO] [stderr] | [INFO] [stderr] 590 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:590:18 [INFO] [stderr] | [INFO] [stderr] 590 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:591:13 [INFO] [stderr] | [INFO] [stderr] 591 | let _2 = _1 + _1; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:640:14 [INFO] [stderr] | [INFO] [stderr] 640 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:640:18 [INFO] [stderr] | [INFO] [stderr] 640 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:652:14 [INFO] [stderr] | [INFO] [stderr] 652 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:652:18 [INFO] [stderr] | [INFO] [stderr] 652 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/translation.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | let _0 = T::zero(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/translation.rs:271:13 [INFO] [stderr] | [INFO] [stderr] 271 | let _0 = T::zero(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform2d.rs:326:13 [INFO] [stderr] | [INFO] [stderr] 326 | let _1: T = One::one(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:102:14 [INFO] [stderr] | [INFO] [stderr] 102 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:102:18 [INFO] [stderr] | [INFO] [stderr] 102 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:135:14 [INFO] [stderr] | [INFO] [stderr] 135 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:135:18 [INFO] [stderr] | [INFO] [stderr] 135 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:152:14 [INFO] [stderr] | [INFO] [stderr] 152 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:152:18 [INFO] [stderr] | [INFO] [stderr] 152 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | let _2 = _1 + _1; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:167:14 [INFO] [stderr] | [INFO] [stderr] 167 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:167:18 [INFO] [stderr] | [INFO] [stderr] 167 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:195:13 [INFO] [stderr] | [INFO] [stderr] 195 | let _0: T = Zero::zero(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:360:13 [INFO] [stderr] | [INFO] [stderr] 360 | let _1: T = One::one(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/transform3d.rs:418:13 [INFO] [stderr] | [INFO] [stderr] 418 | let w = p.x * self.m14 + p.y * self.m24 + self.m44; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/transform3d.rs:463:13 [INFO] [stderr] | [INFO] [stderr] 463 | let w = p.x * self.m14 + p.y * self.m24 + p.z * self.m34 + self.m44; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:502:14 [INFO] [stderr] | [INFO] [stderr] 502 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:502:18 [INFO] [stderr] | [INFO] [stderr] 502 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:525:14 [INFO] [stderr] | [INFO] [stderr] 525 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:525:18 [INFO] [stderr] | [INFO] [stderr] 525 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:561:14 [INFO] [stderr] | [INFO] [stderr] 561 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:561:18 [INFO] [stderr] | [INFO] [stderr] 561 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:590:14 [INFO] [stderr] | [INFO] [stderr] 590 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:590:18 [INFO] [stderr] | [INFO] [stderr] 590 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:591:13 [INFO] [stderr] | [INFO] [stderr] 591 | let _2 = _1 + _1; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:640:14 [INFO] [stderr] | [INFO] [stderr] 640 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:640:18 [INFO] [stderr] | [INFO] [stderr] 640 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:652:14 [INFO] [stderr] | [INFO] [stderr] 652 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/transform3d.rs:652:18 [INFO] [stderr] | [INFO] [stderr] 652 | let (_0, _1): (T, T) = (Zero::zero(), One::one()); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/translation.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | let _0 = T::zero(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/translation.rs:271:13 [INFO] [stderr] | [INFO] [stderr] 271 | let _0 = T::zero(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: lint name `just_underscores_and_digits` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/transform2d.rs:10:45 [INFO] [stderr] | [INFO] [stderr] 10 | #![cfg_attr(feature = "cargo-clippy", allow(just_underscores_and_digits))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::just_underscores_and_digits` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `just_underscores_and_digits` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/transform3d.rs:10:45 [INFO] [stderr] | [INFO] [stderr] 10 | #![cfg_attr(feature = "cargo-clippy", allow(just_underscores_and_digits))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::just_underscores_and_digits` [INFO] [stderr] [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/transform3d.rs:58:48 [INFO] [stderr] | [INFO] [stderr] 58 | #[cfg_attr(feature = "cargo-clippy", allow(too_many_arguments))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/transform3d.rs:79:48 [INFO] [stderr] | [INFO] [stderr] 79 | #[cfg_attr(feature = "cargo-clippy", allow(too_many_arguments))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] [INFO] [stderr] warning: lint name `excessive_precision` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/trig.rs:37:61 [INFO] [stderr] | [INFO] [stderr] 37 | #![cfg_attr(feature = "cargo-clippy", allow(excessive_precision))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::excessive_precision` [INFO] [stderr] ... [INFO] [stderr] 72 | trig!(f32); [INFO] [stderr] | ----------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: lint name `excessive_precision` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/trig.rs:37:61 [INFO] [stderr] | [INFO] [stderr] 37 | #![cfg_attr(feature = "cargo-clippy", allow(excessive_precision))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::excessive_precision` [INFO] [stderr] ... [INFO] [stderr] 73 | trig!(f64); [INFO] [stderr] | ----------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/point.rs:887:32 [INFO] [stderr] | [INFO] [stderr] 887 | let x = i as f32 * 0.012345; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.012_345` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/point.rs:888:32 [INFO] [stderr] | [INFO] [stderr] 888 | let y = i as f32 * 0.987654; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.987_654` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/point.rs:932:32 [INFO] [stderr] | [INFO] [stderr] 932 | let x = i as f32 * 0.012345; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.012_345` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/point.rs:933:32 [INFO] [stderr] | [INFO] [stderr] 933 | let y = i as f32 * 0.987654; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.987_654` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rotation.rs:879:9 [INFO] [stderr] | [INFO] [stderr] 879 | 0.951056516295154, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0.951_056_516_295_154` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rotation.rs:880:9 [INFO] [stderr] | [INFO] [stderr] 880 | 0.309016994374947, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0.309_016_994_374_947` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rotation.rs:885:9 [INFO] [stderr] | [INFO] [stderr] 885 | 0.809016994374947, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0.809_016_994_374_947` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rotation.rs:886:9 [INFO] [stderr] | [INFO] [stderr] 886 | 0.587785252292473, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0.587_785_252_292_473` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rotation.rs:891:9 [INFO] [stderr] | [INFO] [stderr] 891 | 0.587785252292473, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0.587_785_252_292_473` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rotation.rs:892:9 [INFO] [stderr] | [INFO] [stderr] 892 | 0.809016994374947, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0.809_016_994_374_947` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rotation.rs:897:9 [INFO] [stderr] | [INFO] [stderr] 897 | 0.309016994374947, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0.309_016_994_374_947` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rotation.rs:898:9 [INFO] [stderr] | [INFO] [stderr] 898 | 0.951056516295154, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0.951_056_516_295_154` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rotation.rs:906:9 [INFO] [stderr] | [INFO] [stderr] 906 | 0.951056516295154, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0.951_056_516_295_154` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rotation.rs:908:10 [INFO] [stderr] | [INFO] [stderr] 908 | -0.309016994374947, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0.309_016_994_374_947` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rotation.rs:912:9 [INFO] [stderr] | [INFO] [stderr] 912 | 0.809016994374947, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0.809_016_994_374_947` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rotation.rs:914:10 [INFO] [stderr] | [INFO] [stderr] 914 | -0.587785252292473, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0.587_785_252_292_473` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rotation.rs:918:9 [INFO] [stderr] | [INFO] [stderr] 918 | 0.587785252292473, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0.587_785_252_292_473` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rotation.rs:920:10 [INFO] [stderr] | [INFO] [stderr] 920 | -0.809016994374947, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0.809_016_994_374_947` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rotation.rs:924:9 [INFO] [stderr] | [INFO] [stderr] 924 | 0.309016994374947, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0.309_016_994_374_947` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rotation.rs:926:10 [INFO] [stderr] | [INFO] [stderr] 926 | -0.951056516295154, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0.951_056_516_295_154` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unary minus has lower precedence than method call [INFO] [stderr] --> src/rotation.rs:945:42 [INFO] [stderr] | [INFO] [stderr] 945 | .approx_eq(&point3(0.5, 0.5, -0.5.sqrt())) [INFO] [stderr] | ^^^^^^^^^^^ help: consider adding parentheses to clarify your intent: `-(0.5.sqrt())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rotation.rs:949:74 [INFO] [stderr] | [INFO] [stderr] 949 | let r3 = Rotation3D::around_axis(vec3(0.5, 1.0, 2.0), Angle::radians(2.291288)); [INFO] [stderr] | ^^^^^^^^ help: consider: `2.291_288` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rotation.rs:951:10 [INFO] [stderr] | [INFO] [stderr] 951 | -0.58071821, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.580_718_21` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rotation.rs:952:9 [INFO] [stderr] | [INFO] [stderr] 952 | 0.81401868, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.814_018_68` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rotation.rs:953:10 [INFO] [stderr] | [INFO] [stderr] 953 | -0.01182979 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.011_829_79` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: lint name `just_underscores_and_digits` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/transform2d.rs:10:45 [INFO] [stderr] | [INFO] [stderr] 10 | #![cfg_attr(feature = "cargo-clippy", allow(just_underscores_and_digits))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::just_underscores_and_digits` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `just_underscores_and_digits` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/transform3d.rs:10:45 [INFO] [stderr] | [INFO] [stderr] 10 | #![cfg_attr(feature = "cargo-clippy", allow(just_underscores_and_digits))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::just_underscores_and_digits` [INFO] [stderr] [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/transform3d.rs:58:48 [INFO] [stderr] | [INFO] [stderr] 58 | #[cfg_attr(feature = "cargo-clippy", allow(too_many_arguments))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] [INFO] [stderr] warning: lint name `too_many_arguments` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/transform3d.rs:79:48 [INFO] [stderr] | [INFO] [stderr] 79 | #[cfg_attr(feature = "cargo-clippy", allow(too_many_arguments))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::too_many_arguments` [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/transform3d.rs:880:20 [INFO] [stderr] | [INFO] [stderr] 880 | 0.0, 2.22222222, 0.0, 0.0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2.222_222_22` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/transform3d.rs:882:20 [INFO] [stderr] | [INFO] [stderr] 882 | -1.0, -1.22222222, -0.0, 1.0 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1.222_222_22` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: lint name `excessive_precision` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/trig.rs:37:61 [INFO] [stderr] | [INFO] [stderr] 37 | #![cfg_attr(feature = "cargo-clippy", allow(excessive_precision))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::excessive_precision` [INFO] [stderr] ... [INFO] [stderr] 72 | trig!(f32); [INFO] [stderr] | ----------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: lint name `excessive_precision` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/trig.rs:37:61 [INFO] [stderr] | [INFO] [stderr] 37 | #![cfg_attr(feature = "cargo-clippy", allow(excessive_precision))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::excessive_precision` [INFO] [stderr] ... [INFO] [stderr] 73 | trig!(f64); [INFO] [stderr] | ----------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: lint name `just_underscores_and_digits` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/transform2d.rs:10:45 [INFO] [stderr] | [INFO] [stderr] 10 | #![cfg_attr(feature = "cargo-clippy", allow(just_underscores_and_digits))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::just_underscores_and_digits` [INFO] [stderr] [INFO] [stderr] warning: lint name `just_underscores_and_digits` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/transform2d.rs:10:45 [INFO] [stderr] | [INFO] [stderr] 10 | #![cfg_attr(feature = "cargo-clippy", allow(just_underscores_and_digits))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::just_underscores_and_digits` [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/rotation.rs:50:23 [INFO] [stderr] | [INFO] [stderr] 50 | pub fn to_degrees(self) -> T { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/transform3d.rs:527:26 [INFO] [stderr] | [INFO] [stderr] 527 | let mut result = self.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:951:16 [INFO] [stderr] | [INFO] [stderr] 951 | pub fn all(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:956:16 [INFO] [stderr] | [INFO] [stderr] 956 | pub fn any(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:961:17 [INFO] [stderr] | [INFO] [stderr] 961 | pub fn none(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:966:16 [INFO] [stderr] | [INFO] [stderr] 966 | pub fn and(&self, other: Self) -> Self { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:974:15 [INFO] [stderr] | [INFO] [stderr] 974 | pub fn or(&self, other: Self) -> Self { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:982:16 [INFO] [stderr] | [INFO] [stderr] 982 | pub fn not(&self) -> Self { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:990:37 [INFO] [stderr] | [INFO] [stderr] 990 | pub fn select_point(&self, a: &TypedPoint2D, b: &TypedPoint2D) -> TypedPoint2D { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:998:38 [INFO] [stderr] | [INFO] [stderr] 998 | pub fn select_vector(&self, a: &TypedVector2D, b: &TypedVector2D) -> TypedVector2D { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:1006:36 [INFO] [stderr] | [INFO] [stderr] 1006 | pub fn select_size(&self, a: &TypedSize2D, b: &TypedSize2D) -> TypedSize2D { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:1016:16 [INFO] [stderr] | [INFO] [stderr] 1016 | pub fn all(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:1021:16 [INFO] [stderr] | [INFO] [stderr] 1021 | pub fn any(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:1026:17 [INFO] [stderr] | [INFO] [stderr] 1026 | pub fn none(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:1031:16 [INFO] [stderr] | [INFO] [stderr] 1031 | pub fn and(&self, other: Self) -> Self { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:1040:15 [INFO] [stderr] | [INFO] [stderr] 1040 | pub fn or(&self, other: Self) -> Self { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:1049:16 [INFO] [stderr] | [INFO] [stderr] 1049 | pub fn not(&self) -> Self { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:1059:37 [INFO] [stderr] | [INFO] [stderr] 1059 | pub fn select_point(&self, a: &TypedPoint3D, b: &TypedPoint3D) -> TypedPoint3D { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:1068:38 [INFO] [stderr] | [INFO] [stderr] 1068 | pub fn select_vector(&self, a: &TypedVector3D, b: &TypedVector3D) -> TypedVector3D { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:1077:15 [INFO] [stderr] | [INFO] [stderr] 1077 | pub fn xy(&self) -> BoolVector2D { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:1085:15 [INFO] [stderr] | [INFO] [stderr] 1085 | pub fn xz(&self) -> BoolVector2D { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:1093:15 [INFO] [stderr] | [INFO] [stderr] 1093 | pub fn yz(&self) -> BoolVector2D { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/length.rs:300:24 [INFO] [stderr] | [INFO] [stderr] 300 | let one_foot = variable_length.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `variable_length` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/length.rs:303:9 [INFO] [stderr] | [INFO] [stderr] 303 | assert_eq!(one_foot.get(), 12.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/length.rs:303:9 [INFO] [stderr] | [INFO] [stderr] 303 | assert_eq!(one_foot.get(), 12.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/length.rs:304:9 [INFO] [stderr] | [INFO] [stderr] 304 | assert_eq!(variable_length.get(), 24.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/length.rs:304:9 [INFO] [stderr] | [INFO] [stderr] 304 | assert_eq!(variable_length.get(), 24.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/length.rs:337:9 [INFO] [stderr] | [INFO] [stderr] 337 | assert_eq!(measurement.get(), 15.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/length.rs:337:9 [INFO] [stderr] | [INFO] [stderr] 337 | assert_eq!(measurement.get(), 15.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/length.rs:357:9 [INFO] [stderr] | [INFO] [stderr] 357 | assert_eq!(measurement.get(), -5.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/length.rs:357:9 [INFO] [stderr] | [INFO] [stderr] 357 | assert_eq!(measurement.get(), -5.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rect.rs:619:17 [INFO] [stderr] | [INFO] [stderr] 619 | assert!(min(-1.0f32, 0.0f32) == -1.0f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(min(-1.0f32, 0.0f32) - -1.0f32).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rect.rs:619:17 [INFO] [stderr] | [INFO] [stderr] 619 | assert!(min(-1.0f32, 0.0f32) == -1.0f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/rotation.rs:50:23 [INFO] [stderr] | [INFO] [stderr] 50 | pub fn to_degrees(self) -> T { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/scale.rs:223:9 [INFO] [stderr] | [INFO] [stderr] 223 | assert_eq!(mm_per_cm.get(), 10.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/scale.rs:223:9 [INFO] [stderr] | [INFO] [stderr] 223 | assert_eq!(mm_per_cm.get(), 10.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/scale.rs:231:23 [INFO] [stderr] | [INFO] [stderr] 231 | assert_eq!(a, a.clone()); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/scale.rs:232:20 [INFO] [stderr] | [INFO] [stderr] 232 | assert_eq!(a.clone() + b.clone(), TypedScale::new(5)); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/scale.rs:232:32 [INFO] [stderr] | [INFO] [stderr] 232 | assert_eq!(a.clone() + b.clone(), TypedScale::new(5)); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/size.rs:429:9 [INFO] [stderr] | [INFO] [stderr] 429 | assert_eq!(p.area(), 3.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/size.rs:429:9 [INFO] [stderr] | [INFO] [stderr] 429 | assert_eq!(p.area(), 3.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/transform3d.rs:527:26 [INFO] [stderr] | [INFO] [stderr] 527 | let mut result = self.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/transform3d.rs:880:20 [INFO] [stderr] | [INFO] [stderr] 880 | 0.0, 2.22222222, 0.0, 0.0, [INFO] [stderr] | ^^^^^^^^^^ help: consider changing the type or truncating it to: `2.222_222_3` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/transform3d.rs:882:20 [INFO] [stderr] | [INFO] [stderr] 882 | -1.0, -1.22222222, -0.0, 1.0 [INFO] [stderr] | ^^^^^^^^^^ help: consider changing the type or truncating it to: `1.222_222_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::FRAC_PI_4` found. Consider using it directly [INFO] [stderr] --> src/transform3d.rs:890:58 [INFO] [stderr] | [INFO] [stderr] 890 | assert!(Mf32::create_rotation(0.0, 0.0, 1.0, rad(0.7854)).is_2d()); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::FRAC_PI_4` found. Consider using it directly [INFO] [stderr] --> src/transform3d.rs:891:59 [INFO] [stderr] | [INFO] [stderr] 891 | assert!(!Mf32::create_rotation(0.0, 1.0, 0.0, rad(0.7854)).is_2d()); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:951:16 [INFO] [stderr] | [INFO] [stderr] 951 | pub fn all(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:956:16 [INFO] [stderr] | [INFO] [stderr] 956 | pub fn any(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:961:17 [INFO] [stderr] | [INFO] [stderr] 961 | pub fn none(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:966:16 [INFO] [stderr] | [INFO] [stderr] 966 | pub fn and(&self, other: Self) -> Self { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:974:15 [INFO] [stderr] | [INFO] [stderr] 974 | pub fn or(&self, other: Self) -> Self { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:982:16 [INFO] [stderr] | [INFO] [stderr] 982 | pub fn not(&self) -> Self { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:990:37 [INFO] [stderr] | [INFO] [stderr] 990 | pub fn select_point(&self, a: &TypedPoint2D, b: &TypedPoint2D) -> TypedPoint2D { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:998:38 [INFO] [stderr] | [INFO] [stderr] 998 | pub fn select_vector(&self, a: &TypedVector2D, b: &TypedVector2D) -> TypedVector2D { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:1006:36 [INFO] [stderr] | [INFO] [stderr] 1006 | pub fn select_size(&self, a: &TypedSize2D, b: &TypedSize2D) -> TypedSize2D { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:1016:16 [INFO] [stderr] | [INFO] [stderr] 1016 | pub fn all(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:1021:16 [INFO] [stderr] | [INFO] [stderr] 1021 | pub fn any(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:1026:17 [INFO] [stderr] | [INFO] [stderr] 1026 | pub fn none(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:1031:16 [INFO] [stderr] | [INFO] [stderr] 1031 | pub fn and(&self, other: Self) -> Self { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:1040:15 [INFO] [stderr] | [INFO] [stderr] 1040 | pub fn or(&self, other: Self) -> Self { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:1049:16 [INFO] [stderr] | [INFO] [stderr] 1049 | pub fn not(&self) -> Self { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:1059:37 [INFO] [stderr] | [INFO] [stderr] 1059 | pub fn select_point(&self, a: &TypedPoint3D, b: &TypedPoint3D) -> TypedPoint3D { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:1068:38 [INFO] [stderr] | [INFO] [stderr] 1068 | pub fn select_vector(&self, a: &TypedVector3D, b: &TypedVector3D) -> TypedVector3D { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:1077:15 [INFO] [stderr] | [INFO] [stderr] 1077 | pub fn xy(&self) -> BoolVector2D { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:1085:15 [INFO] [stderr] | [INFO] [stderr] 1085 | pub fn xz(&self) -> BoolVector2D { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vector.rs:1093:15 [INFO] [stderr] | [INFO] [stderr] 1093 | pub fn yz(&self) -> BoolVector2D { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/vector.rs:1214:9 [INFO] [stderr] | [INFO] [stderr] 1214 | assert_eq!(p1.dot(p2), 103.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/vector.rs:1214:9 [INFO] [stderr] | [INFO] [stderr] 1214 | assert_eq!(p1.dot(p2), 103.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/vector.rs:1222:9 [INFO] [stderr] | [INFO] [stderr] 1222 | assert_eq!(r, -59.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/vector.rs:1222:9 [INFO] [stderr] | [INFO] [stderr] 1222 | assert_eq!(r, -59.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/vector.rs:1342:9 [INFO] [stderr] | [INFO] [stderr] 1342 | assert_eq!(p1.dot(p2), 918.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/vector.rs:1342:9 [INFO] [stderr] | [INFO] [stderr] 1342 | assert_eq!(p1.dot(p2), 918.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 12 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `euclid`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c8e4d563b2f348a43550f0e99a2c3a3617700888fae47a8c99fa419a41f6f371"` [INFO] running `"docker" "rm" "-f" "c8e4d563b2f348a43550f0e99a2c3a3617700888fae47a8c99fa419a41f6f371"` [INFO] [stdout] c8e4d563b2f348a43550f0e99a2c3a3617700888fae47a8c99fa419a41f6f371