[INFO] crate ethabi 6.1.0 is already in cache [INFO] extracting crate ethabi 6.1.0 into work/ex/clippy-test-run/sources/stable/reg/ethabi/6.1.0 [INFO] extracting crate ethabi 6.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ethabi/6.1.0 [INFO] validating manifest of ethabi-6.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ethabi-6.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ethabi-6.1.0 [INFO] finished frobbing ethabi-6.1.0 [INFO] frobbed toml for ethabi-6.1.0 written to work/ex/clippy-test-run/sources/stable/reg/ethabi/6.1.0/Cargo.toml [INFO] started frobbing ethabi-6.1.0 [INFO] finished frobbing ethabi-6.1.0 [INFO] frobbed toml for ethabi-6.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ethabi/6.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ethabi-6.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ethabi/6.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9f43242000969862c390ed32232848d254d62e282fefedcf863f006c5a912f29 [INFO] running `"docker" "start" "-a" "9f43242000969862c390ed32232848d254d62e282fefedcf863f006c5a912f29"` [INFO] [stderr] Checking error-chain v0.12.0 [INFO] [stderr] Checking ethereum-types-serialize v0.2.1 [INFO] [stderr] Checking uint v0.4.1 [INFO] [stderr] Checking fixed-hash v0.2.5 [INFO] [stderr] Checking ethbloom v0.5.0 [INFO] [stderr] Checking ethereum-types v0.4.0 [INFO] [stderr] Checking ethabi v6.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoder.rs:73:3 [INFO] [stderr] | [INFO] [stderr] 73 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoder.rs:202:5 [INFO] [stderr] | [INFO] [stderr] 202 | new_offset: new_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoder.rs:73:3 [INFO] [stderr] | [INFO] [stderr] 73 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoder.rs:202:5 [INFO] [stderr] | [INFO] [stderr] 202 | new_offset: new_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `new_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/param_type/mod.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | mod param_type; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/token/mod.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | mod token; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/param_type/reader.rs:22:7 [INFO] [stderr] | [INFO] [stderr] 22 | if num.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `num.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/token/strict.rs:11:3 [INFO] [stderr] | [INFO] [stderr] 11 | match hex.len() == 20 { [INFO] [stderr] | _________^ [INFO] [stderr] 12 | | false => Err(ErrorKind::InvalidData.into()), [INFO] [stderr] 13 | | true => { [INFO] [stderr] 14 | | let mut address = [0u8; 20]; [INFO] [stderr] ... | [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 11 | if hex.len() == 20 { [INFO] [stderr] 12 | let mut address = [0u8; 20]; [INFO] [stderr] 13 | address.copy_from_slice(&hex); [INFO] [stderr] 14 | Ok(address) [INFO] [stderr] 15 | } else { Err(ErrorKind::InvalidData.into()) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/token/strict.rs:40:3 [INFO] [stderr] | [INFO] [stderr] 40 | match hex.len() == len { [INFO] [stderr] | _________^ [INFO] [stderr] 41 | | true => Ok(hex), [INFO] [stderr] 42 | | false => Err(ErrorKind::InvalidData.into()), [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if hex.len() == len { Ok(hex) } else { Err(ErrorKind::InvalidData.into()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/token/strict.rs:48:3 [INFO] [stderr] | [INFO] [stderr] 48 | match hex.len() == 32 { [INFO] [stderr] | _________^ [INFO] [stderr] 49 | | true => { [INFO] [stderr] 50 | | let mut uint = [0u8; 32]; [INFO] [stderr] 51 | | uint.copy_from_slice(&hex); [INFO] [stderr] ... | [INFO] [stderr] 54 | | false => Err(ErrorKind::InvalidData.into()) [INFO] [stderr] 55 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 48 | if hex.len() == 32 { [INFO] [stderr] 49 | let mut uint = [0u8; 32]; [INFO] [stderr] 50 | uint.copy_from_slice(&hex); [INFO] [stderr] 51 | Ok(uint) [INFO] [stderr] 52 | } else { Err(ErrorKind::InvalidData.into()) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/token/strict.rs:60:3 [INFO] [stderr] | [INFO] [stderr] 60 | match hex.len() == 32 { [INFO] [stderr] | _________^ [INFO] [stderr] 61 | | true => { [INFO] [stderr] 62 | | let mut int = [0u8; 32]; [INFO] [stderr] 63 | | int.copy_from_slice(&hex); [INFO] [stderr] ... | [INFO] [stderr] 66 | | false => Err(ErrorKind::InvalidData.into()) [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 60 | if hex.len() == 32 { [INFO] [stderr] 61 | let mut int = [0u8; 32]; [INFO] [stderr] 62 | int.copy_from_slice(&hex); [INFO] [stderr] 63 | Ok(int) [INFO] [stderr] 64 | } else { Err(ErrorKind::InvalidData.into()) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/token/token.rs:120:20 [INFO] [stderr] | [INFO] [stderr] 120 | pub fn to_address(self) -> Option
{ [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/token/token.rs:128:24 [INFO] [stderr] | [INFO] [stderr] 128 | pub fn to_fixed_bytes(self) -> Option> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/token/token.rs:136:18 [INFO] [stderr] | [INFO] [stderr] 136 | pub fn to_bytes(self) -> Option> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/token/token.rs:144:16 [INFO] [stderr] | [INFO] [stderr] 144 | pub fn to_int(self) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/token/token.rs:152:17 [INFO] [stderr] | [INFO] [stderr] 152 | pub fn to_uint(self) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/token/token.rs:160:17 [INFO] [stderr] | [INFO] [stderr] 160 | pub fn to_bool(self) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/token/token.rs:168:19 [INFO] [stderr] | [INFO] [stderr] 168 | pub fn to_string(self) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/token/token.rs:176:24 [INFO] [stderr] | [INFO] [stderr] 176 | pub fn to_fixed_array(self) -> Option> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/token/token.rs:184:18 [INFO] [stderr] | [INFO] [stderr] 184 | pub fn to_array(self) -> Option> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/token/mod.rs:32:3 [INFO] [stderr] | [INFO] [stderr] 32 | match result.len() == len { [INFO] [stderr] | _________^ [INFO] [stderr] 33 | | true => Ok(result), [INFO] [stderr] 34 | | false => Err(ErrorKind::InvalidData.into()), [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if result.len() == len { Ok(result) } else { Err(ErrorKind::InvalidData.into()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> src/token/mod.rs:40:6 [INFO] [stderr] | [INFO] [stderr] 40 | if Some('[') != value.chars().next() || Some(']') != value.chars().last() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `!value.starts_with('[')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_next_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] [INFO] [stderr] warning: you should use the `ends_with` method [INFO] [stderr] --> src/token/mod.rs:40:43 [INFO] [stderr] | [INFO] [stderr] 40 | if Some('[') != value.chars().next() || Some(']') != value.chars().last() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `!value.ends_with(']')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_last_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/token/mod.rs:54:12 [INFO] [stderr] | [INFO] [stderr] 54 | '[' if ignore == false => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!ignore` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/token/mod.rs:57:12 [INFO] [stderr] | [INFO] [stderr] 57 | ']' if ignore == false => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!ignore` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/token/mod.rs:71:27 [INFO] [stderr] | [INFO] [stderr] 71 | ',' if nested == 1 && ignore == false => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!ignore` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:21:16 [INFO] [stderr] | [INFO] [stderr] 21 | let result = ((slice[28] as u32) << 24) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(slice[28])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:22:4 [INFO] [stderr] | [INFO] [stderr] 22 | ((slice[29] as u32) << 16) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(slice[29])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:23:4 [INFO] [stderr] | [INFO] [stderr] 23 | ((slice[30] as u32) << 8) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(slice[30])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:24:3 [INFO] [stderr] | [INFO] [stderr] 24 | (slice[31] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(slice[31])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/decoder.rs:40:42 [INFO] [stderr] | [INFO] [stderr] 40 | if !is_empty_bytes_valid_encoding && data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/decoder.rs:63:15 [INFO] [stderr] | [INFO] [stderr] 63 | let slice = try!(peek(slices, position + i)).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 63 | let slice = *(match $ expr { [INFO] [stderr] 64 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 65 | :: Err ( err ) => { [INFO] [stderr] 66 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 67 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/param_type/mod.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | mod param_type; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/encoder.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | let to_copy = match i == len - 1 { [INFO] [stderr] | _______________________^ [INFO] [stderr] 19 | | false => 32, [INFO] [stderr] 20 | | true => match bytes.len() % 32 { [INFO] [stderr] 21 | | 0 => 32, [INFO] [stderr] 22 | | x => x, [INFO] [stderr] 23 | | }, [INFO] [stderr] 24 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 18 | let to_copy = if i == len - 1 { match bytes.len() % 32 { [INFO] [stderr] 19 | 0 => 32, [INFO] [stderr] 20 | x => x, [INFO] [stderr] 21 | } } else { 32 }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/token/mod.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | mod token; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/event.rs:164:12 [INFO] [stderr] | [INFO] [stderr] 164 | value: named_tokens.get(&name).unwrap().clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&named_tokens[&name]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/param_type/reader.rs:22:7 [INFO] [stderr] | [INFO] [stderr] 22 | if num.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `num.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/token/strict.rs:11:3 [INFO] [stderr] | [INFO] [stderr] 11 | match hex.len() == 20 { [INFO] [stderr] | _________^ [INFO] [stderr] 12 | | false => Err(ErrorKind::InvalidData.into()), [INFO] [stderr] 13 | | true => { [INFO] [stderr] 14 | | let mut address = [0u8; 20]; [INFO] [stderr] ... | [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 11 | if hex.len() == 20 { [INFO] [stderr] 12 | let mut address = [0u8; 20]; [INFO] [stderr] 13 | address.copy_from_slice(&hex); [INFO] [stderr] 14 | Ok(address) [INFO] [stderr] 15 | } else { Err(ErrorKind::InvalidData.into()) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/token/strict.rs:40:3 [INFO] [stderr] | [INFO] [stderr] 40 | match hex.len() == len { [INFO] [stderr] | _________^ [INFO] [stderr] 41 | | true => Ok(hex), [INFO] [stderr] 42 | | false => Err(ErrorKind::InvalidData.into()), [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if hex.len() == len { Ok(hex) } else { Err(ErrorKind::InvalidData.into()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/token/strict.rs:48:3 [INFO] [stderr] | [INFO] [stderr] 48 | match hex.len() == 32 { [INFO] [stderr] | _________^ [INFO] [stderr] 49 | | true => { [INFO] [stderr] 50 | | let mut uint = [0u8; 32]; [INFO] [stderr] 51 | | uint.copy_from_slice(&hex); [INFO] [stderr] ... | [INFO] [stderr] 54 | | false => Err(ErrorKind::InvalidData.into()) [INFO] [stderr] 55 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 48 | if hex.len() == 32 { [INFO] [stderr] 49 | let mut uint = [0u8; 32]; [INFO] [stderr] 50 | uint.copy_from_slice(&hex); [INFO] [stderr] 51 | Ok(uint) [INFO] [stderr] 52 | } else { Err(ErrorKind::InvalidData.into()) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/token/strict.rs:60:3 [INFO] [stderr] | [INFO] [stderr] 60 | match hex.len() == 32 { [INFO] [stderr] | _________^ [INFO] [stderr] 61 | | true => { [INFO] [stderr] 62 | | let mut int = [0u8; 32]; [INFO] [stderr] 63 | | int.copy_from_slice(&hex); [INFO] [stderr] ... | [INFO] [stderr] 66 | | false => Err(ErrorKind::InvalidData.into()) [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 60 | if hex.len() == 32 { [INFO] [stderr] 61 | let mut int = [0u8; 32]; [INFO] [stderr] 62 | int.copy_from_slice(&hex); [INFO] [stderr] 63 | Ok(int) [INFO] [stderr] 64 | } else { Err(ErrorKind::InvalidData.into()) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/token/token.rs:120:20 [INFO] [stderr] | [INFO] [stderr] 120 | pub fn to_address(self) -> Option
{ [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/token/token.rs:128:24 [INFO] [stderr] | [INFO] [stderr] 128 | pub fn to_fixed_bytes(self) -> Option> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/token/token.rs:136:18 [INFO] [stderr] | [INFO] [stderr] 136 | pub fn to_bytes(self) -> Option> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/token/token.rs:144:16 [INFO] [stderr] | [INFO] [stderr] 144 | pub fn to_int(self) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/token/token.rs:152:17 [INFO] [stderr] | [INFO] [stderr] 152 | pub fn to_uint(self) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/token/token.rs:160:17 [INFO] [stderr] | [INFO] [stderr] 160 | pub fn to_bool(self) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/token/token.rs:168:19 [INFO] [stderr] | [INFO] [stderr] 168 | pub fn to_string(self) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/token/token.rs:176:24 [INFO] [stderr] | [INFO] [stderr] 176 | pub fn to_fixed_array(self) -> Option> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/token/token.rs:184:18 [INFO] [stderr] | [INFO] [stderr] 184 | pub fn to_array(self) -> Option> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/token/mod.rs:32:3 [INFO] [stderr] | [INFO] [stderr] 32 | match result.len() == len { [INFO] [stderr] | _________^ [INFO] [stderr] 33 | | true => Ok(result), [INFO] [stderr] 34 | | false => Err(ErrorKind::InvalidData.into()), [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if result.len() == len { Ok(result) } else { Err(ErrorKind::InvalidData.into()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> src/token/mod.rs:40:6 [INFO] [stderr] | [INFO] [stderr] 40 | if Some('[') != value.chars().next() || Some(']') != value.chars().last() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `!value.starts_with('[')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_next_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] [INFO] [stderr] warning: you should use the `ends_with` method [INFO] [stderr] --> src/token/mod.rs:40:43 [INFO] [stderr] | [INFO] [stderr] 40 | if Some('[') != value.chars().next() || Some(']') != value.chars().last() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `!value.ends_with(']')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_last_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/token/mod.rs:54:12 [INFO] [stderr] | [INFO] [stderr] 54 | '[' if ignore == false => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!ignore` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/token/mod.rs:57:12 [INFO] [stderr] | [INFO] [stderr] 57 | ']' if ignore == false => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!ignore` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/token/mod.rs:71:27 [INFO] [stderr] | [INFO] [stderr] 71 | ',' if nested == 1 && ignore == false => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!ignore` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:21:16 [INFO] [stderr] | [INFO] [stderr] 21 | let result = ((slice[28] as u32) << 24) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(slice[28])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:22:4 [INFO] [stderr] | [INFO] [stderr] 22 | ((slice[29] as u32) << 16) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(slice[29])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:23:4 [INFO] [stderr] | [INFO] [stderr] 23 | ((slice[30] as u32) << 8) + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(slice[30])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:24:3 [INFO] [stderr] | [INFO] [stderr] 24 | (slice[31] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(slice[31])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/decoder.rs:40:42 [INFO] [stderr] | [INFO] [stderr] 40 | if !is_empty_bytes_valid_encoding && data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/decoder.rs:63:15 [INFO] [stderr] | [INFO] [stderr] 63 | let slice = try!(peek(slices, position + i)).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 63 | let slice = *(match $ expr { [INFO] [stderr] 64 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 65 | :: Err ( err ) => { [INFO] [stderr] 66 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 67 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/encoder.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | let to_copy = match i == len - 1 { [INFO] [stderr] | _______________________^ [INFO] [stderr] 19 | | false => 32, [INFO] [stderr] 20 | | true => match bytes.len() % 32 { [INFO] [stderr] 21 | | 0 => 32, [INFO] [stderr] 22 | | x => x, [INFO] [stderr] 23 | | }, [INFO] [stderr] 24 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 18 | let to_copy = if i == len - 1 { match bytes.len() % 32 { [INFO] [stderr] 19 | 0 => 32, [INFO] [stderr] 20 | x => x, [INFO] [stderr] 21 | } } else { 32 }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/encoder.rs:176:24 [INFO] [stderr] | [INFO] [stderr] 176 | let encoded = encode(&vec![address]); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[address]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/encoder.rs:186:24 [INFO] [stderr] | [INFO] [stderr] 186 | let encoded = encode(&vec![addresses]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[addresses]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/encoder.rs:201:24 [INFO] [stderr] | [INFO] [stderr] 201 | let encoded = encode(&vec![addresses]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[addresses]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/encoder.rs:213:24 [INFO] [stderr] | [INFO] [stderr] 213 | let encoded = encode(&vec![address1, address2]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[address1, address2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/encoder.rs:230:24 [INFO] [stderr] | [INFO] [stderr] 230 | let encoded = encode(&vec![fixed]); [INFO] [stderr] | ^^^^^^^^^^^^ help: you can use a slice directly: `&[fixed]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/encoder.rs:253:24 [INFO] [stderr] | [INFO] [stderr] 253 | let encoded = encode(&vec![dynamic]); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[dynamic]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/encoder.rs:272:24 [INFO] [stderr] | [INFO] [stderr] 272 | let encoded = encode(&vec![dynamic]); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[dynamic]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/encoder.rs:295:24 [INFO] [stderr] | [INFO] [stderr] 295 | let encoded = encode(&vec![dynamic]); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[dynamic]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/encoder.rs:320:24 [INFO] [stderr] | [INFO] [stderr] 320 | let encoded = encode(&vec![fixed]); [INFO] [stderr] | ^^^^^^^^^^^^ help: you can use a slice directly: `&[fixed]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/encoder.rs:333:24 [INFO] [stderr] | [INFO] [stderr] 333 | let encoded = encode(&vec![ [INFO] [stderr] | ______________________________^ [INFO] [stderr] 334 | | Token::Array(vec![]), [INFO] [stderr] 335 | | Token::Array(vec![])] [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] help: you can use a slice directly [INFO] [stderr] | [INFO] [stderr] 333 | let encoded = encode(&[Token::Array(vec![]), [INFO] [stderr] 334 | Token::Array(vec![])] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/encoder.rs:346:24 [INFO] [stderr] | [INFO] [stderr] 346 | let encoded = encode(&vec![ [INFO] [stderr] | ______________________________^ [INFO] [stderr] 347 | | Token::Array(vec![Token::Array(vec![])]), [INFO] [stderr] 348 | | Token::Array(vec![Token::Array(vec![])]), [INFO] [stderr] 349 | | ]); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] help: you can use a slice directly [INFO] [stderr] | [INFO] [stderr] 346 | let encoded = encode(&[Token::Array(vec![Token::Array(vec![])]), [INFO] [stderr] 347 | Token::Array(vec![Token::Array(vec![])])]); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/encoder.rs:366:24 [INFO] [stderr] | [INFO] [stderr] 366 | let encoded = encode(&vec![bytes]); [INFO] [stderr] | ^^^^^^^^^^^^ help: you can use a slice directly: `&[bytes]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/encoder.rs:378:24 [INFO] [stderr] | [INFO] [stderr] 378 | let encoded = encode(&vec![bytes]); [INFO] [stderr] | ^^^^^^^^^^^^ help: you can use a slice directly: `&[bytes]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/encoder.rs:386:24 [INFO] [stderr] | [INFO] [stderr] 386 | let encoded = encode(&vec![s]); [INFO] [stderr] | ^^^^^^^^ help: you can use a slice directly: `&[s]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/encoder.rs:398:24 [INFO] [stderr] | [INFO] [stderr] 398 | let encoded = encode(&vec![bytes]); [INFO] [stderr] | ^^^^^^^^^^^^ help: you can use a slice directly: `&[bytes]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/encoder.rs:413:24 [INFO] [stderr] | [INFO] [stderr] 413 | let encoded = encode(&vec![bytes]); [INFO] [stderr] | ^^^^^^^^^^^^ help: you can use a slice directly: `&[bytes]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/encoder.rs:427:24 [INFO] [stderr] | [INFO] [stderr] 427 | let encoded = encode(&vec![bytes1, bytes2]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[bytes1, bytes2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/encoder.rs:443:24 [INFO] [stderr] | [INFO] [stderr] 443 | let encoded = encode(&vec![Token::Uint(uint.into())]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[Token::Uint(uint.into())]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/encoder.rs:452:24 [INFO] [stderr] | [INFO] [stderr] 452 | let encoded = encode(&vec![Token::Int(int.into())]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[Token::Int(int.into())]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/encoder.rs:459:24 [INFO] [stderr] | [INFO] [stderr] 459 | let encoded = encode(&vec![Token::Bool(true)]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[Token::Bool(true)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/encoder.rs:466:24 [INFO] [stderr] | [INFO] [stderr] 466 | let encoded = encode(&vec![Token::Bool(false)]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[Token::Bool(false)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/encoder.rs:477:24 [INFO] [stderr] | [INFO] [stderr] 477 | let encoded = encode(&vec![ [INFO] [stderr] | ______________________________^ [INFO] [stderr] 478 | | Token::Int(5.into()), [INFO] [stderr] 479 | | Token::Bytes(bytes.clone()), [INFO] [stderr] 480 | | Token::Int(3.into()), [INFO] [stderr] 481 | | Token::Bytes(bytes) [INFO] [stderr] 482 | | ]); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] help: you can use a slice directly [INFO] [stderr] | [INFO] [stderr] 477 | let encoded = encode(&[Token::Int(5.into()), [INFO] [stderr] 478 | Token::Bytes(bytes.clone()), [INFO] [stderr] 479 | Token::Int(3.into()), [INFO] [stderr] 480 | Token::Bytes(bytes)]); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/encoder.rs:508:24 [INFO] [stderr] | [INFO] [stderr] 508 | let encoded = encode(&vec![ [INFO] [stderr] | ______________________________^ [INFO] [stderr] 509 | | Token::Int(1.into()), [INFO] [stderr] 510 | | Token::String("gavofyork".to_owned()), [INFO] [stderr] 511 | | Token::Int(2.into()), [INFO] [stderr] ... | [INFO] [stderr] 518 | | ]) [INFO] [stderr] 519 | | ]); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] help: you can use a slice directly [INFO] [stderr] | [INFO] [stderr] 508 | let encoded = encode(&[Token::Int(1.into()), [INFO] [stderr] 509 | Token::String("gavofyork".to_owned()), [INFO] [stderr] 510 | Token::Int(2.into()), [INFO] [stderr] 511 | Token::Int(3.into()), [INFO] [stderr] 512 | Token::Int(4.into()), [INFO] [stderr] 513 | Token::Array(vec![ [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/event.rs:164:12 [INFO] [stderr] | [INFO] [stderr] 164 | value: named_tokens.get(&name).unwrap().clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&named_tokens[&name]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/function.rs:73:14 [INFO] [stderr] | [INFO] [stderr] 73 | let func = Function::from(interface); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Function::from()`: `interface` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.31s [INFO] running `"docker" "inspect" "9f43242000969862c390ed32232848d254d62e282fefedcf863f006c5a912f29"` [INFO] running `"docker" "rm" "-f" "9f43242000969862c390ed32232848d254d62e282fefedcf863f006c5a912f29"` [INFO] [stdout] 9f43242000969862c390ed32232848d254d62e282fefedcf863f006c5a912f29