[INFO] crate etcommon-bigint 0.2.10 is already in cache [INFO] extracting crate etcommon-bigint 0.2.10 into work/ex/clippy-test-run/sources/stable/reg/etcommon-bigint/0.2.10 [INFO] extracting crate etcommon-bigint 0.2.10 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/etcommon-bigint/0.2.10 [INFO] validating manifest of etcommon-bigint-0.2.10 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of etcommon-bigint-0.2.10 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing etcommon-bigint-0.2.10 [INFO] finished frobbing etcommon-bigint-0.2.10 [INFO] frobbed toml for etcommon-bigint-0.2.10 written to work/ex/clippy-test-run/sources/stable/reg/etcommon-bigint/0.2.10/Cargo.toml [INFO] started frobbing etcommon-bigint-0.2.10 [INFO] finished frobbing etcommon-bigint-0.2.10 [INFO] frobbed toml for etcommon-bigint-0.2.10 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/etcommon-bigint/0.2.10/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting etcommon-bigint-0.2.10 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/etcommon-bigint/0.2.10:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 701bad51c8edb0c20e5830541e63e0c5125c728c11fe03fef108841f2c59f06d [INFO] running `"docker" "start" "-a" "701bad51c8edb0c20e5830541e63e0c5125c728c11fe03fef108841f2c59f06d"` [INFO] [stderr] Checking etcommon-rlp v0.2.4 [INFO] [stderr] Checking etcommon-bigint v0.2.10 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mi256.rs:13:40 [INFO] [stderr] | [INFO] [stderr] 13 | const SIGN_BIT_MASK: M256 = M256(U256([0xffffffffffffffff, 0xffffffffffffffff, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mi256.rs:13:60 [INFO] [stderr] | [INFO] [stderr] 13 | const SIGN_BIT_MASK: M256 = M256(U256([0xffffffffffffffff, 0xffffffffffffffff, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mi256.rs:14:40 [INFO] [stderr] | [INFO] [stderr] 14 | 0xffffffffffffffff, 0x7fffffffffffffff])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mi256.rs:14:60 [INFO] [stderr] | [INFO] [stderr] 14 | 0xffffffffffffffff, 0x7fffffffffffffff])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x7fff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/mod.rs:494:19 [INFO] [stderr] | [INFO] [stderr] 494 | (a >> 32, a & 0xFFFFFFFF) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/mod.rs:548:19 [INFO] [stderr] | [INFO] [stderr] 548 | if (arr[0] & (0xffffffffu64 << 32)) != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xffff_ffffu64` [INFO] [stderr] ... [INFO] [stderr] 1183 | construct_uint!(U512, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/mod.rs:427:25 [INFO] [stderr] | [INFO] [stderr] 427 | ret[i + j] = (c_l & 0xFFFFFFFF) + (c_u << 32); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] ... [INFO] [stderr] 1183 | construct_uint!(U512, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/mod.rs:548:19 [INFO] [stderr] | [INFO] [stderr] 548 | if (arr[0] & (0xffffffffu64 << 32)) != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xffff_ffffu64` [INFO] [stderr] ... [INFO] [stderr] 1184 | construct_uint!(U256, 4); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/mod.rs:427:25 [INFO] [stderr] | [INFO] [stderr] 427 | ret[i + j] = (c_l & 0xFFFFFFFF) + (c_u << 32); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] ... [INFO] [stderr] 1184 | construct_uint!(U256, 4); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/mod.rs:548:19 [INFO] [stderr] | [INFO] [stderr] 548 | if (arr[0] & (0xffffffffu64 << 32)) != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xffff_ffffu64` [INFO] [stderr] ... [INFO] [stderr] 1185 | construct_uint!(U128, 2); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/mod.rs:427:25 [INFO] [stderr] | [INFO] [stderr] 427 | ret[i + j] = (c_l & 0xFFFFFFFF) + (c_u << 32); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] ... [INFO] [stderr] 1185 | construct_uint!(U128, 2); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/uint/mod.rs:1205:9 [INFO] [stderr] | [INFO] [stderr] 1205 | return l; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `l` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/mod.rs:1373:37 [INFO] [stderr] | [INFO] [stderr] 1373 | ret[i + j] = (c_l & 0xFFFFFFFF) + (c_u << 32); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mi256.rs:13:40 [INFO] [stderr] | [INFO] [stderr] 13 | const SIGN_BIT_MASK: M256 = M256(U256([0xffffffffffffffff, 0xffffffffffffffff, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mi256.rs:13:60 [INFO] [stderr] | [INFO] [stderr] 13 | const SIGN_BIT_MASK: M256 = M256(U256([0xffffffffffffffff, 0xffffffffffffffff, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mi256.rs:14:40 [INFO] [stderr] | [INFO] [stderr] 14 | 0xffffffffffffffff, 0x7fffffffffffffff])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mi256.rs:14:60 [INFO] [stderr] | [INFO] [stderr] 14 | 0xffffffffffffffff, 0x7fffffffffffffff])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x7fff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/mod.rs:494:19 [INFO] [stderr] | [INFO] [stderr] 494 | (a >> 32, a & 0xFFFFFFFF) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/mod.rs:548:19 [INFO] [stderr] | [INFO] [stderr] 548 | if (arr[0] & (0xffffffffu64 << 32)) != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xffff_ffffu64` [INFO] [stderr] ... [INFO] [stderr] 1183 | construct_uint!(U512, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/mod.rs:427:25 [INFO] [stderr] | [INFO] [stderr] 427 | ret[i + j] = (c_l & 0xFFFFFFFF) + (c_u << 32); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] ... [INFO] [stderr] 1183 | construct_uint!(U512, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/mod.rs:548:19 [INFO] [stderr] | [INFO] [stderr] 548 | if (arr[0] & (0xffffffffu64 << 32)) != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xffff_ffffu64` [INFO] [stderr] ... [INFO] [stderr] 1184 | construct_uint!(U256, 4); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/mod.rs:427:25 [INFO] [stderr] | [INFO] [stderr] 427 | ret[i + j] = (c_l & 0xFFFFFFFF) + (c_u << 32); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] ... [INFO] [stderr] 1184 | construct_uint!(U256, 4); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/mod.rs:548:19 [INFO] [stderr] | [INFO] [stderr] 548 | if (arr[0] & (0xffffffffu64 << 32)) != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xffff_ffffu64` [INFO] [stderr] ... [INFO] [stderr] 1185 | construct_uint!(U128, 2); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/mod.rs:427:25 [INFO] [stderr] | [INFO] [stderr] 427 | ret[i + j] = (c_l & 0xFFFFFFFF) + (c_u << 32); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] ... [INFO] [stderr] 1185 | construct_uint!(U128, 2); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/uint/mod.rs:1205:9 [INFO] [stderr] | [INFO] [stderr] 1205 | return l; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `l` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/mod.rs:1373:37 [INFO] [stderr] | [INFO] [stderr] 1373 | ret[i + j] = (c_l & 0xFFFFFFFF) + (c_u << 32); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:101:26 [INFO] [stderr] | [INFO] [stderr] 101 | U256([0x12f0, 1, 0x0910203040506077, 0x8090a0b0c0d0e0f0]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0910_2030_4050_6077` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:101:46 [INFO] [stderr] | [INFO] [stderr] 101 | U256([0x12f0, 1, 0x0910203040506077, 0x8090a0b0c0d0e0f0]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x8090_a0b0_c0d0_e0f0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:110:15 [INFO] [stderr] | [INFO] [stderr] 110 | U256([0x00192437100019fa, 0x243710, 0, 0]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0019_2437_1000_19fa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:110:35 [INFO] [stderr] | [INFO] [stderr] 110 | U256([0x00192437100019fa, 0x243710, 0, 0]), [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0024_3710` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:129:26 [INFO] [stderr] | [INFO] [stderr] 129 | U256([0x12f0, 1, 0x0910203040506077, 0x8090a0b0c0d0e0f0]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0910_2030_4050_6077` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:129:46 [INFO] [stderr] | [INFO] [stderr] 129 | U256([0x12f0, 1, 0x0910203040506077, 0x8090a0b0c0d0e0f0]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x8090_a0b0_c0d0_e0f0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:188:21 [INFO] [stderr] | [INFO] [stderr] 188 | let big = U256([0x8C8C3EE70C644118u64, 0x0209E7378231E632, 0, 0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x8C8C_3EE7_0C64_4118u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:188:44 [INFO] [stderr] | [INFO] [stderr] 188 | let big = U256([0x8C8C3EE70C644118u64, 0x0209E7378231E632, 0, 0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0209_E737_8231_E632` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:189:24 [INFO] [stderr] | [INFO] [stderr] 189 | let bigger = U256([0x9C8C3EE70C644118u64, 0x0209E7378231E632, 0, 0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x9C8C_3EE7_0C64_4118u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:189:47 [INFO] [stderr] | [INFO] [stderr] 189 | let bigger = U256([0x9C8C3EE70C644118u64, 0x0209E7378231E632, 0, 0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0209_E737_8231_E632` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:190:25 [INFO] [stderr] | [INFO] [stderr] 190 | let biggest = U256([0x5C8C3EE70C644118u64, 0x0209E7378231E632, 0, 1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x5C8C_3EE7_0C64_4118u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:190:48 [INFO] [stderr] | [INFO] [stderr] 190 | let biggest = U256([0x5C8C3EE70C644118u64, 0x0209E7378231E632, 0, 1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0209_E737_8231_E632` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:204:27 [INFO] [stderr] | [INFO] [stderr] 204 | let init = U256::from(0xDEADBEEFDEADBEEFu64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0xDEAD_BEEF_DEAD_BEEFu64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:208:27 [INFO] [stderr] | [INFO] [stderr] 208 | assert_eq!(add, U256([0xBD5B7DDFBD5B7DDEu64, 1, 0, 0])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0xBD5B_7DDF_BD5B_7DDEu64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:211:33 [INFO] [stderr] | [INFO] [stderr] 211 | assert_eq!(shl, U256([0u64, 0xDFBD5B7DDE000000, 0x1BD5B7D, 0])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xDFBD_5B7D_DE00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:211:53 [INFO] [stderr] | [INFO] [stderr] 211 | assert_eq!(shl, U256([0u64, 0xDFBD5B7DDE000000, 0x1BD5B7D, 0])); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x01BD_5B7D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:213:27 [INFO] [stderr] | [INFO] [stderr] 213 | assert_eq!(shr, U256([0x7DDE000000000000u64, 0x0001BD5B7DDFBD5B, 0, 0])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x7DDE_0000_0000_0000u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:213:50 [INFO] [stderr] | [INFO] [stderr] 213 | assert_eq!(shr, U256([0x7DDE000000000000u64, 0x0001BD5B7DDFBD5B, 0, 0])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0001_BD5B_7DDF_BD5B` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:218:15 [INFO] [stderr] | [INFO] [stderr] 218 | U256([0x7DDE000000000001u64, 0x0001BD5B7DDFBD5B, 0, 0]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x7DDE_0000_0000_0001u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:218:38 [INFO] [stderr] | [INFO] [stderr] 218 | U256([0x7DDE000000000001u64, 0x0001BD5B7DDFBD5B, 0, 0]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0001_BD5B_7DDF_BD5B` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:222:27 [INFO] [stderr] | [INFO] [stderr] 222 | assert_eq!(sub, U256([0x9F30411021524112u64, 0x0001BD5B7DDFBD5A, 0, 0])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x9F30_4110_2152_4112u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:222:50 [INFO] [stderr] | [INFO] [stderr] 222 | assert_eq!(sub, U256([0x9F30411021524112u64, 0x0001BD5B7DDFBD5A, 0, 0])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0001_BD5B_7DDF_BD5A` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:227:15 [INFO] [stderr] | [INFO] [stderr] 227 | U256([0x8C8C3EE70C644118u64, 0x0209E7378231E632, 0, 0]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x8C8C_3EE7_0C64_4118u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:227:38 [INFO] [stderr] | [INFO] [stderr] 227 | U256([0x8C8C3EE70C644118u64, 0x0209E7378231E632, 0, 0]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0209_E737_8231_E632` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:232:27 [INFO] [stderr] | [INFO] [stderr] 232 | assert_eq!(div, U256([0x9F30411021524112u64, 0x0001BD5B7DDFBD5A, 0, 0])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x9F30_4110_2152_4112u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:232:50 [INFO] [stderr] | [INFO] [stderr] 232 | assert_eq!(div, U256([0x9F30411021524112u64, 0x0001BD5B7DDFBD5A, 0, 0])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0001_BD5B_7DDF_BD5A` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:260:27 [INFO] [stderr] | [INFO] [stderr] 260 | let init = U256::from(0xDEADBEEFDEADBEEFu64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0xDEAD_BEEF_DEAD_BEEFu64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:262:37 [INFO] [stderr] | [INFO] [stderr] 262 | assert_eq!(init << 64, U256([0, 0xDEADBEEFDEADBEEF, 0, 0])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xDEAD_BEEF_DEAD_BEEF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:264:27 [INFO] [stderr] | [INFO] [stderr] 264 | assert_eq!(add, U256([0xDEADBEEFDEADBEEF, 0xDEADBEEFDEADBEEF, 0, 0])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xDEAD_BEEF_DEAD_BEEF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:264:47 [INFO] [stderr] | [INFO] [stderr] 264 | assert_eq!(add, U256([0xDEADBEEFDEADBEEF, 0xDEADBEEFDEADBEEF, 0, 0])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xDEAD_BEEF_DEAD_BEEF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:267:15 [INFO] [stderr] | [INFO] [stderr] 267 | U256([0xDEADBEEFDEADBEEF, 0xDEADBEEFDEADBEEF, 0, 0]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xDEAD_BEEF_DEAD_BEEF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:267:35 [INFO] [stderr] | [INFO] [stderr] 267 | U256([0xDEADBEEFDEADBEEF, 0xDEADBEEFDEADBEEF, 0, 0]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xDEAD_BEEF_DEAD_BEEF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:271:15 [INFO] [stderr] | [INFO] [stderr] 271 | U256([0xDEADBEEFDEADBEEF, 0xDEADBEEFDEADBEEF, 0, 0]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xDEAD_BEEF_DEAD_BEEF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:271:35 [INFO] [stderr] | [INFO] [stderr] 271 | U256([0xDEADBEEFDEADBEEF, 0xDEADBEEFDEADBEEF, 0, 0]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xDEAD_BEEF_DEAD_BEEF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:273:33 [INFO] [stderr] | [INFO] [stderr] 273 | assert_eq!(add >> 64, U256([0xDEADBEEFDEADBEEF, 0, 0, 0])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xDEAD_BEEF_DEAD_BEEF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:276:18 [INFO] [stderr] | [INFO] [stderr] 276 | U256([0, 0xDEADBEEFDEADBEEF, 0xDEADBEEFDEADBEEF, 0]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xDEAD_BEEF_DEAD_BEEF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:276:38 [INFO] [stderr] | [INFO] [stderr] 276 | U256([0, 0xDEADBEEFDEADBEEF, 0xDEADBEEFDEADBEEF, 0]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xDEAD_BEEF_DEAD_BEEF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/uint/tests.rs:288:43 [INFO] [stderr] | [INFO] [stderr] 288 | assert_eq!(U256::exp10(5), U256::from(100000u64)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/mod.rs:593:31 [INFO] [stderr] | [INFO] [stderr] 593 | assert_eq!(H128::from(0x1234567890abcdef), H128::from_str("00000000000000001234567890abcdef").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x1234_5678_90ab_cdef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/mod.rs:594:30 [INFO] [stderr] | [INFO] [stderr] 594 | assert_eq!(H64::from(0x1234567890abcdef), H64::from_str("1234567890abcdef").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x1234_5678_90ab_cdef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/mod.rs:595:30 [INFO] [stderr] | [INFO] [stderr] 595 | assert_eq!(H32::from(0x1234567890abcdef), H32::from_str("90abcdef").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x1234_5678_90ab_cdef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/mod.rs:600:30 [INFO] [stderr] | [INFO] [stderr] 600 | assert_eq!(H64::from(0x1234567890abcdef), H64::from("0x1234567890abcdef")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x1234_5678_90ab_cdef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/mod.rs:601:30 [INFO] [stderr] | [INFO] [stderr] 601 | assert_eq!(H64::from(0x1234567890abcdef), H64::from("1234567890abcdef")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x1234_5678_90ab_cdef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/mod.rs:602:30 [INFO] [stderr] | [INFO] [stderr] 602 | assert_eq!(H64::from(0x234567890abcdef), H64::from("0x234567890abcdef")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0x0234_5678_90ab_cdef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/mod.rs:607:23 [INFO] [stderr] | [INFO] [stderr] 607 | let u: U256 = 0x123456789abcdef0u64.into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x1234_5678_9abc_def0u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hash/mod.rs:620:22 [INFO] [stderr] | [INFO] [stderr] 620 | let v: u64 = 10298314; [INFO] [stderr] | ^^^^^^^^ help: consider: `10_298_314` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `H256FastMap` [INFO] [stderr] --> src/hash/mod.rs:541:1 [INFO] [stderr] | [INFO] [stderr] 541 | pub type H256FastMap = Map>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `H256FastSet` [INFO] [stderr] --> src/hash/mod.rs:544:1 [INFO] [stderr] | [INFO] [stderr] 544 | pub type H256FastSet = Set>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/m256.rs:89:31 [INFO] [stderr] | [INFO] [stderr] 89 | U256::from_str(s).map(|s| M256(s)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `M256` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/mi256.rs:36:25 [INFO] [stderr] | [INFO] [stderr] 36 | } else if val & SIGN_BIT_MASK.into() == val { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `SIGN_BIT_MASK` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/mi256.rs:90:38 [INFO] [stderr] | [INFO] [stderr] 90 | let d = (self.1 / other.1) & SIGN_BIT_MASK.into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `SIGN_BIT_MASK` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/mi256.rs:110:38 [INFO] [stderr] | [INFO] [stderr] 110 | let r = (self.1 % other.1) & SIGN_BIT_MASK.into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `SIGN_BIT_MASK` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/uint/mod.rs:727:7 [INFO] [stderr] | [INFO] [stderr] 727 | n.0[$n_words-1] = n.0[$n_words-1] & ((!0u64)>>1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `n.0[$n_words-1] &= ((!0u64)>>1)` [INFO] [stderr] ... [INFO] [stderr] 1183 | construct_uint!(U512, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/uint/mod.rs:444:12 [INFO] [stderr] | [INFO] [stderr] 444 | for i in 0..$n_words { [INFO] [stderr] | ^ help: try replacing the loop by: `res[..8].clone_from_slice(&ret[..8])` [INFO] [stderr] ... [INFO] [stderr] 1183 | construct_uint!(U512, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:834:13 [INFO] [stderr] | [INFO] [stderr] 834 | let o = other as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(other)` [INFO] [stderr] ... [INFO] [stderr] 1183 | construct_uint!(U512, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 860 | | [INFO] [stderr] 861 | | impl_map_from!($name, u8, u64); [INFO] [stderr] | |_____________________________________^ help: try: `u64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1183 | construct_uint!(U512, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 861 | | impl_map_from!($name, u8, u64); [INFO] [stderr] 862 | | impl_map_from!($name, u16, u64); [INFO] [stderr] | |______________________________________^ help: try: `u64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1183 | construct_uint!(U512, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 862 | | impl_map_from!($name, u16, u64); [INFO] [stderr] 863 | | impl_map_from!($name, u32, u64); [INFO] [stderr] | |______________________________________^ help: try: `u64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1183 | construct_uint!(U512, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/uint/mod.rs:868:5 [INFO] [stderr] | [INFO] [stderr] 868 | match value >= 0 { [INFO] [stderr] | _________________^ [INFO] [stderr] 869 | | true => From::from(value as u64), [INFO] [stderr] 870 | | false => { panic!("Unsigned integer can't be created from negative value"); } [INFO] [stderr] 871 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if value >= 0 { construct_uint!(U512, 8); } else { construct_uint!(U512, 8); }` [INFO] [stderr] ... [INFO] [stderr] 1183 | construct_uint!(U512, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 874 | | [INFO] [stderr] 875 | | impl_map_from!($name, i8, i64); [INFO] [stderr] | |_____________________________________^ help: try: `i64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1183 | construct_uint!(U512, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 875 | | impl_map_from!($name, i8, i64); [INFO] [stderr] 876 | | impl_map_from!($name, i16, i64); [INFO] [stderr] | |______________________________________^ help: try: `i64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1183 | construct_uint!(U512, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 876 | | impl_map_from!($name, i16, i64); [INFO] [stderr] 877 | | impl_map_from!($name, i32, i64); [INFO] [stderr] | |______________________________________^ help: try: `i64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1183 | construct_uint!(U512, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:888:18 [INFO] [stderr] | [INFO] [stderr] 888 | ret[pos] += (bytes[i] as u64) << ((rev % 8) * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[i])` [INFO] [stderr] ... [INFO] [stderr] 1183 | construct_uint!(U512, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/uint/mod.rs:957:29 [INFO] [stderr] | [INFO] [stderr] 957 | let mut shift = my_bits - your_bits; [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 1183 | construct_uint!(U512, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/uint/mod.rs:958:29 [INFO] [stderr] | [INFO] [stderr] 958 | shift_copy = shift_copy << shift; [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 1183 | construct_uint!(U512, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/uint/mod.rs:964:30 [INFO] [stderr] | [INFO] [stderr] 964 | shift_copy = shift_copy >> 1; [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 1183 | construct_uint!(U512, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/uint/mod.rs:1127:21 [INFO] [stderr] | [INFO] [stderr] 1127 | i = i - 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i -= 1` [INFO] [stderr] ... [INFO] [stderr] 1183 | construct_uint!(U512, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/uint/mod.rs:727:7 [INFO] [stderr] | [INFO] [stderr] 727 | n.0[$n_words-1] = n.0[$n_words-1] & ((!0u64)>>1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `n.0[$n_words-1] &= ((!0u64)>>1)` [INFO] [stderr] ... [INFO] [stderr] 1184 | construct_uint!(U256, 4); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/uint/mod.rs:444:12 [INFO] [stderr] | [INFO] [stderr] 444 | for i in 0..$n_words { [INFO] [stderr] | ^ help: try replacing the loop by: `res[..4].clone_from_slice(&ret[..4])` [INFO] [stderr] ... [INFO] [stderr] 1184 | construct_uint!(U256, 4); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:834:13 [INFO] [stderr] | [INFO] [stderr] 834 | let o = other as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(other)` [INFO] [stderr] ... [INFO] [stderr] 1184 | construct_uint!(U256, 4); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 860 | | [INFO] [stderr] 861 | | impl_map_from!($name, u8, u64); [INFO] [stderr] | |_____________________________________^ help: try: `u64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1184 | construct_uint!(U256, 4); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 861 | | impl_map_from!($name, u8, u64); [INFO] [stderr] 862 | | impl_map_from!($name, u16, u64); [INFO] [stderr] | |______________________________________^ help: try: `u64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1184 | construct_uint!(U256, 4); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 862 | | impl_map_from!($name, u16, u64); [INFO] [stderr] 863 | | impl_map_from!($name, u32, u64); [INFO] [stderr] | |______________________________________^ help: try: `u64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1184 | construct_uint!(U256, 4); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/uint/mod.rs:868:5 [INFO] [stderr] | [INFO] [stderr] 868 | match value >= 0 { [INFO] [stderr] | _________________^ [INFO] [stderr] 869 | | true => From::from(value as u64), [INFO] [stderr] 870 | | false => { panic!("Unsigned integer can't be created from negative value"); } [INFO] [stderr] 871 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if value >= 0 { construct_uint!(U256, 4); } else { construct_uint!(U256, 4); }` [INFO] [stderr] ... [INFO] [stderr] 1184 | construct_uint!(U256, 4); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 874 | | [INFO] [stderr] 875 | | impl_map_from!($name, i8, i64); [INFO] [stderr] | |_____________________________________^ help: try: `i64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1184 | construct_uint!(U256, 4); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 875 | | impl_map_from!($name, i8, i64); [INFO] [stderr] 876 | | impl_map_from!($name, i16, i64); [INFO] [stderr] | |______________________________________^ help: try: `i64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1184 | construct_uint!(U256, 4); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 876 | | impl_map_from!($name, i16, i64); [INFO] [stderr] 877 | | impl_map_from!($name, i32, i64); [INFO] [stderr] | |______________________________________^ help: try: `i64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1184 | construct_uint!(U256, 4); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:888:18 [INFO] [stderr] | [INFO] [stderr] 888 | ret[pos] += (bytes[i] as u64) << ((rev % 8) * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[i])` [INFO] [stderr] ... [INFO] [stderr] 1184 | construct_uint!(U256, 4); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/uint/mod.rs:957:29 [INFO] [stderr] | [INFO] [stderr] 957 | let mut shift = my_bits - your_bits; [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 1184 | construct_uint!(U256, 4); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/uint/mod.rs:958:29 [INFO] [stderr] | [INFO] [stderr] 958 | shift_copy = shift_copy << shift; [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 1184 | construct_uint!(U256, 4); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/uint/mod.rs:964:30 [INFO] [stderr] | [INFO] [stderr] 964 | shift_copy = shift_copy >> 1; [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 1184 | construct_uint!(U256, 4); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/uint/mod.rs:1127:21 [INFO] [stderr] | [INFO] [stderr] 1127 | i = i - 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i -= 1` [INFO] [stderr] ... [INFO] [stderr] 1184 | construct_uint!(U256, 4); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/uint/mod.rs:727:7 [INFO] [stderr] | [INFO] [stderr] 727 | n.0[$n_words-1] = n.0[$n_words-1] & ((!0u64)>>1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `n.0[$n_words-1] &= ((!0u64)>>1)` [INFO] [stderr] ... [INFO] [stderr] 1185 | construct_uint!(U128, 2); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/uint/mod.rs:444:12 [INFO] [stderr] | [INFO] [stderr] 444 | for i in 0..$n_words { [INFO] [stderr] | ^ help: try replacing the loop by: `res[..2].clone_from_slice(&ret[..2])` [INFO] [stderr] ... [INFO] [stderr] 1185 | construct_uint!(U128, 2); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:834:13 [INFO] [stderr] | [INFO] [stderr] 834 | let o = other as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(other)` [INFO] [stderr] ... [INFO] [stderr] 1185 | construct_uint!(U128, 2); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 860 | | [INFO] [stderr] 861 | | impl_map_from!($name, u8, u64); [INFO] [stderr] | |_____________________________________^ help: try: `u64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1185 | construct_uint!(U128, 2); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 861 | | impl_map_from!($name, u8, u64); [INFO] [stderr] 862 | | impl_map_from!($name, u16, u64); [INFO] [stderr] | |______________________________________^ help: try: `u64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1185 | construct_uint!(U128, 2); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 862 | | impl_map_from!($name, u16, u64); [INFO] [stderr] 863 | | impl_map_from!($name, u32, u64); [INFO] [stderr] | |______________________________________^ help: try: `u64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1185 | construct_uint!(U128, 2); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/uint/mod.rs:868:5 [INFO] [stderr] | [INFO] [stderr] 868 | match value >= 0 { [INFO] [stderr] | _________________^ [INFO] [stderr] 869 | | true => From::from(value as u64), [INFO] [stderr] 870 | | false => { panic!("Unsigned integer can't be created from negative value"); } [INFO] [stderr] 871 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if value >= 0 { construct_uint!(U128, 2); } else { construct_uint!(U128, 2); }` [INFO] [stderr] ... [INFO] [stderr] 1185 | construct_uint!(U128, 2); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 874 | | [INFO] [stderr] 875 | | impl_map_from!($name, i8, i64); [INFO] [stderr] | |_____________________________________^ help: try: `i64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1185 | construct_uint!(U128, 2); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 875 | | impl_map_from!($name, i8, i64); [INFO] [stderr] 876 | | impl_map_from!($name, i16, i64); [INFO] [stderr] | |______________________________________^ help: try: `i64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1185 | construct_uint!(U128, 2); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 876 | | impl_map_from!($name, i16, i64); [INFO] [stderr] 877 | | impl_map_from!($name, i32, i64); [INFO] [stderr] | |______________________________________^ help: try: `i64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1185 | construct_uint!(U128, 2); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:888:18 [INFO] [stderr] | [INFO] [stderr] 888 | ret[pos] += (bytes[i] as u64) << ((rev % 8) * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[i])` [INFO] [stderr] ... [INFO] [stderr] 1185 | construct_uint!(U128, 2); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/uint/mod.rs:957:29 [INFO] [stderr] | [INFO] [stderr] 957 | let mut shift = my_bits - your_bits; [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 1185 | construct_uint!(U128, 2); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/uint/mod.rs:958:29 [INFO] [stderr] | [INFO] [stderr] 958 | shift_copy = shift_copy << shift; [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 1185 | construct_uint!(U128, 2); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/uint/mod.rs:964:30 [INFO] [stderr] | [INFO] [stderr] 964 | shift_copy = shift_copy >> 1; [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 1185 | construct_uint!(U128, 2); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/uint/mod.rs:1127:21 [INFO] [stderr] | [INFO] [stderr] 1127 | i = i - 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i -= 1` [INFO] [stderr] ... [INFO] [stderr] 1185 | construct_uint!(U128, 2); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash/mod.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | ret |= (self.0[$size - 1 - i] as u64) << (i * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.0[$size - 1 - i])` [INFO] [stderr] ... [INFO] [stderr] 483 | impl_hash!(H32, 4); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/hash/mod.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | for i in 0..$size { [INFO] [stderr] | ^ help: try replacing the loop by: `ret[..4].clone_from_slice(&s[..4])` [INFO] [stderr] ... [INFO] [stderr] 483 | impl_hash!(H32, 4); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash/mod.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | ret |= (self.0[$size - 1 - i] as u64) << (i * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.0[$size - 1 - i])` [INFO] [stderr] ... [INFO] [stderr] 484 | impl_hash!(H64, 8); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/hash/mod.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | for i in 0..$size { [INFO] [stderr] | ^ help: try replacing the loop by: `ret[..8].clone_from_slice(&s[..8])` [INFO] [stderr] ... [INFO] [stderr] 484 | impl_hash!(H64, 8); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash/mod.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | ret |= (self.0[$size - 1 - i] as u64) << (i * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.0[$size - 1 - i])` [INFO] [stderr] ... [INFO] [stderr] 485 | impl_hash!(H128, 16); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/hash/mod.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | for i in 0..$size { [INFO] [stderr] | ^ help: try replacing the loop by: `ret[..16].clone_from_slice(&s[..16])` [INFO] [stderr] ... [INFO] [stderr] 485 | impl_hash!(H128, 16); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash/mod.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | ret |= (self.0[$size - 1 - i] as u64) << (i * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.0[$size - 1 - i])` [INFO] [stderr] ... [INFO] [stderr] 486 | impl_hash!(H160, 20); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/hash/mod.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | for i in 0..$size { [INFO] [stderr] | ^ help: try replacing the loop by: `ret[..20].clone_from_slice(&s[..20])` [INFO] [stderr] ... [INFO] [stderr] 486 | impl_hash!(H160, 20); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash/mod.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | ret |= (self.0[$size - 1 - i] as u64) << (i * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.0[$size - 1 - i])` [INFO] [stderr] ... [INFO] [stderr] 487 | impl_hash!(H256, 32); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/hash/mod.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | for i in 0..$size { [INFO] [stderr] | ^ help: try replacing the loop by: `ret[..32].clone_from_slice(&s[..32])` [INFO] [stderr] ... [INFO] [stderr] 487 | impl_hash!(H256, 32); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash/mod.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | ret |= (self.0[$size - 1 - i] as u64) << (i * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.0[$size - 1 - i])` [INFO] [stderr] ... [INFO] [stderr] 488 | impl_hash!(H264, 33); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/hash/mod.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | for i in 0..$size { [INFO] [stderr] | ^ help: try replacing the loop by: `ret[..33].clone_from_slice(&s[..33])` [INFO] [stderr] ... [INFO] [stderr] 488 | impl_hash!(H264, 33); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash/mod.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | ret |= (self.0[$size - 1 - i] as u64) << (i * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.0[$size - 1 - i])` [INFO] [stderr] ... [INFO] [stderr] 489 | impl_hash!(H512, 64); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/hash/mod.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | for i in 0..$size { [INFO] [stderr] | ^ help: try replacing the loop by: `ret[..64].clone_from_slice(&s[..64])` [INFO] [stderr] ... [INFO] [stderr] 489 | impl_hash!(H512, 64); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash/mod.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | ret |= (self.0[$size - 1 - i] as u64) << (i * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.0[$size - 1 - i])` [INFO] [stderr] ... [INFO] [stderr] 490 | impl_hash!(H520, 65); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/hash/mod.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | for i in 0..$size { [INFO] [stderr] | ^ help: try replacing the loop by: `ret[..65].clone_from_slice(&s[..65])` [INFO] [stderr] ... [INFO] [stderr] 490 | impl_hash!(H520, 65); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash/mod.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | ret |= (self.0[$size - 1 - i] as u64) << (i * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.0[$size - 1 - i])` [INFO] [stderr] ... [INFO] [stderr] 491 | impl_hash!(H1024, 128); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/hash/mod.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | for i in 0..$size { [INFO] [stderr] | ^ help: try replacing the loop by: `ret[..128].clone_from_slice(&s[..128])` [INFO] [stderr] ... [INFO] [stderr] 491 | impl_hash!(H1024, 128); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash/mod.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | ret |= (self.0[$size - 1 - i] as u64) << (i * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.0[$size - 1 - i])` [INFO] [stderr] ... [INFO] [stderr] 492 | impl_hash!(H2048, 256); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/hash/mod.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | for i in 0..$size { [INFO] [stderr] | ^ help: try replacing the loop by: `ret[..256].clone_from_slice(&s[..256])` [INFO] [stderr] ... [INFO] [stderr] 492 | impl_hash!(H2048, 256); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/bytes.rs:12:18 [INFO] [stderr] | [INFO] [stderr] 12 | for i in 0..value.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try replacing the loop by: `ret[..value.len()].clone_from_slice(&value[..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `bytes` [INFO] [stderr] --> src/bytes.rs:41:26 [INFO] [stderr] | [INFO] [stderr] 41 | for i in 0..bytes.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 41 | for (i, ) in bytes.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/bytes.rs:41:26 [INFO] [stderr] | [INFO] [stderr] 41 | for i in 0..bytes.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try replacing the loop by: `ret.1[..bytes.len()].clone_from_slice(&bytes[..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/gas.rs:69:31 [INFO] [stderr] | [INFO] [stderr] 69 | U256::from_str(s).map(|s| Gas(s)) [INFO] [stderr] | ^^^^^^^^^^ help: remove closure as shown: `Gas` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: aborting due to 9 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `etcommon-bigint`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: type alias is never used: `H256FastMap` [INFO] [stderr] --> src/hash/mod.rs:541:1 [INFO] [stderr] | [INFO] [stderr] 541 | pub type H256FastMap = Map>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `H256FastSet` [INFO] [stderr] --> src/hash/mod.rs:544:1 [INFO] [stderr] | [INFO] [stderr] 544 | pub type H256FastSet = Set>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/m256.rs:89:31 [INFO] [stderr] | [INFO] [stderr] 89 | U256::from_str(s).map(|s| M256(s)) [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `M256` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/mi256.rs:36:25 [INFO] [stderr] | [INFO] [stderr] 36 | } else if val & SIGN_BIT_MASK.into() == val { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `SIGN_BIT_MASK` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/mi256.rs:90:38 [INFO] [stderr] | [INFO] [stderr] 90 | let d = (self.1 / other.1) & SIGN_BIT_MASK.into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `SIGN_BIT_MASK` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/mi256.rs:110:38 [INFO] [stderr] | [INFO] [stderr] 110 | let r = (self.1 % other.1) & SIGN_BIT_MASK.into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `SIGN_BIT_MASK` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/uint/mod.rs:727:7 [INFO] [stderr] | [INFO] [stderr] 727 | n.0[$n_words-1] = n.0[$n_words-1] & ((!0u64)>>1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `n.0[$n_words-1] &= ((!0u64)>>1)` [INFO] [stderr] ... [INFO] [stderr] 1183 | construct_uint!(U512, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/uint/mod.rs:444:12 [INFO] [stderr] | [INFO] [stderr] 444 | for i in 0..$n_words { [INFO] [stderr] | ^ help: try replacing the loop by: `res[..8].clone_from_slice(&ret[..8])` [INFO] [stderr] ... [INFO] [stderr] 1183 | construct_uint!(U512, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:834:13 [INFO] [stderr] | [INFO] [stderr] 834 | let o = other as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(other)` [INFO] [stderr] ... [INFO] [stderr] 1183 | construct_uint!(U512, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 860 | | [INFO] [stderr] 861 | | impl_map_from!($name, u8, u64); [INFO] [stderr] | |_____________________________________^ help: try: `u64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1183 | construct_uint!(U512, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 861 | | impl_map_from!($name, u8, u64); [INFO] [stderr] 862 | | impl_map_from!($name, u16, u64); [INFO] [stderr] | |______________________________________^ help: try: `u64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1183 | construct_uint!(U512, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 862 | | impl_map_from!($name, u16, u64); [INFO] [stderr] 863 | | impl_map_from!($name, u32, u64); [INFO] [stderr] | |______________________________________^ help: try: `u64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1183 | construct_uint!(U512, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/uint/mod.rs:868:5 [INFO] [stderr] | [INFO] [stderr] 868 | match value >= 0 { [INFO] [stderr] | _________________^ [INFO] [stderr] 869 | | true => From::from(value as u64), [INFO] [stderr] 870 | | false => { panic!("Unsigned integer can't be created from negative value"); } [INFO] [stderr] 871 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if value >= 0 { construct_uint!(U512, 8); } else { construct_uint!(U512, 8); }` [INFO] [stderr] ... [INFO] [stderr] 1183 | construct_uint!(U512, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 874 | | [INFO] [stderr] 875 | | impl_map_from!($name, i8, i64); [INFO] [stderr] | |_____________________________________^ help: try: `i64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1183 | construct_uint!(U512, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 875 | | impl_map_from!($name, i8, i64); [INFO] [stderr] 876 | | impl_map_from!($name, i16, i64); [INFO] [stderr] | |______________________________________^ help: try: `i64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1183 | construct_uint!(U512, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 876 | | impl_map_from!($name, i16, i64); [INFO] [stderr] 877 | | impl_map_from!($name, i32, i64); [INFO] [stderr] | |______________________________________^ help: try: `i64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1183 | construct_uint!(U512, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:888:18 [INFO] [stderr] | [INFO] [stderr] 888 | ret[pos] += (bytes[i] as u64) << ((rev % 8) * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[i])` [INFO] [stderr] ... [INFO] [stderr] 1183 | construct_uint!(U512, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/uint/mod.rs:957:29 [INFO] [stderr] | [INFO] [stderr] 957 | let mut shift = my_bits - your_bits; [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 1183 | construct_uint!(U512, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/uint/mod.rs:958:29 [INFO] [stderr] | [INFO] [stderr] 958 | shift_copy = shift_copy << shift; [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 1183 | construct_uint!(U512, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/uint/mod.rs:964:30 [INFO] [stderr] | [INFO] [stderr] 964 | shift_copy = shift_copy >> 1; [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 1183 | construct_uint!(U512, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/uint/mod.rs:1127:21 [INFO] [stderr] | [INFO] [stderr] 1127 | i = i - 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i -= 1` [INFO] [stderr] ... [INFO] [stderr] 1183 | construct_uint!(U512, 8); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/uint/mod.rs:727:7 [INFO] [stderr] | [INFO] [stderr] 727 | n.0[$n_words-1] = n.0[$n_words-1] & ((!0u64)>>1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `n.0[$n_words-1] &= ((!0u64)>>1)` [INFO] [stderr] ... [INFO] [stderr] 1184 | construct_uint!(U256, 4); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/uint/mod.rs:444:12 [INFO] [stderr] | [INFO] [stderr] 444 | for i in 0..$n_words { [INFO] [stderr] | ^ help: try replacing the loop by: `res[..4].clone_from_slice(&ret[..4])` [INFO] [stderr] ... [INFO] [stderr] 1184 | construct_uint!(U256, 4); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:834:13 [INFO] [stderr] | [INFO] [stderr] 834 | let o = other as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(other)` [INFO] [stderr] ... [INFO] [stderr] 1184 | construct_uint!(U256, 4); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 860 | | [INFO] [stderr] 861 | | impl_map_from!($name, u8, u64); [INFO] [stderr] | |_____________________________________^ help: try: `u64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1184 | construct_uint!(U256, 4); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 861 | | impl_map_from!($name, u8, u64); [INFO] [stderr] 862 | | impl_map_from!($name, u16, u64); [INFO] [stderr] | |______________________________________^ help: try: `u64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1184 | construct_uint!(U256, 4); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 862 | | impl_map_from!($name, u16, u64); [INFO] [stderr] 863 | | impl_map_from!($name, u32, u64); [INFO] [stderr] | |______________________________________^ help: try: `u64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1184 | construct_uint!(U256, 4); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/uint/mod.rs:868:5 [INFO] [stderr] | [INFO] [stderr] 868 | match value >= 0 { [INFO] [stderr] | _________________^ [INFO] [stderr] 869 | | true => From::from(value as u64), [INFO] [stderr] 870 | | false => { panic!("Unsigned integer can't be created from negative value"); } [INFO] [stderr] 871 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if value >= 0 { construct_uint!(U256, 4); } else { construct_uint!(U256, 4); }` [INFO] [stderr] ... [INFO] [stderr] 1184 | construct_uint!(U256, 4); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 874 | | [INFO] [stderr] 875 | | impl_map_from!($name, i8, i64); [INFO] [stderr] | |_____________________________________^ help: try: `i64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1184 | construct_uint!(U256, 4); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 875 | | impl_map_from!($name, i8, i64); [INFO] [stderr] 876 | | impl_map_from!($name, i16, i64); [INFO] [stderr] | |______________________________________^ help: try: `i64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1184 | construct_uint!(U256, 4); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 876 | | impl_map_from!($name, i16, i64); [INFO] [stderr] 877 | | impl_map_from!($name, i32, i64); [INFO] [stderr] | |______________________________________^ help: try: `i64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1184 | construct_uint!(U256, 4); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:888:18 [INFO] [stderr] | [INFO] [stderr] 888 | ret[pos] += (bytes[i] as u64) << ((rev % 8) * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[i])` [INFO] [stderr] ... [INFO] [stderr] 1184 | construct_uint!(U256, 4); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/uint/mod.rs:957:29 [INFO] [stderr] | [INFO] [stderr] 957 | let mut shift = my_bits - your_bits; [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 1184 | construct_uint!(U256, 4); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/uint/mod.rs:958:29 [INFO] [stderr] | [INFO] [stderr] 958 | shift_copy = shift_copy << shift; [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 1184 | construct_uint!(U256, 4); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/uint/mod.rs:964:30 [INFO] [stderr] | [INFO] [stderr] 964 | shift_copy = shift_copy >> 1; [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 1184 | construct_uint!(U256, 4); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/uint/mod.rs:1127:21 [INFO] [stderr] | [INFO] [stderr] 1127 | i = i - 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i -= 1` [INFO] [stderr] ... [INFO] [stderr] 1184 | construct_uint!(U256, 4); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/uint/mod.rs:727:7 [INFO] [stderr] | [INFO] [stderr] 727 | n.0[$n_words-1] = n.0[$n_words-1] & ((!0u64)>>1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `n.0[$n_words-1] &= ((!0u64)>>1)` [INFO] [stderr] ... [INFO] [stderr] 1185 | construct_uint!(U128, 2); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/uint/mod.rs:444:12 [INFO] [stderr] | [INFO] [stderr] 444 | for i in 0..$n_words { [INFO] [stderr] | ^ help: try replacing the loop by: `res[..2].clone_from_slice(&ret[..2])` [INFO] [stderr] ... [INFO] [stderr] 1185 | construct_uint!(U128, 2); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:834:13 [INFO] [stderr] | [INFO] [stderr] 834 | let o = other as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(other)` [INFO] [stderr] ... [INFO] [stderr] 1185 | construct_uint!(U128, 2); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 860 | | [INFO] [stderr] 861 | | impl_map_from!($name, u8, u64); [INFO] [stderr] | |_____________________________________^ help: try: `u64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1185 | construct_uint!(U128, 2); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 861 | | impl_map_from!($name, u8, u64); [INFO] [stderr] 862 | | impl_map_from!($name, u16, u64); [INFO] [stderr] | |______________________________________^ help: try: `u64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1185 | construct_uint!(U128, 2); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 862 | | impl_map_from!($name, u16, u64); [INFO] [stderr] 863 | | impl_map_from!($name, u32, u64); [INFO] [stderr] | |______________________________________^ help: try: `u64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1185 | construct_uint!(U128, 2); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/uint/mod.rs:868:5 [INFO] [stderr] | [INFO] [stderr] 868 | match value >= 0 { [INFO] [stderr] | _________________^ [INFO] [stderr] 869 | | true => From::from(value as u64), [INFO] [stderr] 870 | | false => { panic!("Unsigned integer can't be created from negative value"); } [INFO] [stderr] 871 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if value >= 0 { construct_uint!(U128, 2); } else { construct_uint!(U128, 2); }` [INFO] [stderr] ... [INFO] [stderr] 1185 | construct_uint!(U128, 2); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 874 | | [INFO] [stderr] 875 | | impl_map_from!($name, i8, i64); [INFO] [stderr] | |_____________________________________^ help: try: `i64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1185 | construct_uint!(U128, 2); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 875 | | impl_map_from!($name, i8, i64); [INFO] [stderr] 876 | | impl_map_from!($name, i16, i64); [INFO] [stderr] | |______________________________________^ help: try: `i64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1185 | construct_uint!(U128, 2); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | From::from(value as $to) [INFO] [stderr] | ____________________________^ [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 876 | | impl_map_from!($name, i16, i64); [INFO] [stderr] 877 | | impl_map_from!($name, i32, i64); [INFO] [stderr] | |______________________________________^ help: try: `i64::from(value)` [INFO] [stderr] ... [INFO] [stderr] 1185 | construct_uint!(U128, 2); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/uint/mod.rs:888:18 [INFO] [stderr] | [INFO] [stderr] 888 | ret[pos] += (bytes[i] as u64) << ((rev % 8) * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(bytes[i])` [INFO] [stderr] ... [INFO] [stderr] 1185 | construct_uint!(U128, 2); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/uint/mod.rs:957:29 [INFO] [stderr] | [INFO] [stderr] 957 | let mut shift = my_bits - your_bits; [INFO] [stderr] | ^ [INFO] [stderr] ... [INFO] [stderr] 1185 | construct_uint!(U128, 2); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/uint/mod.rs:958:29 [INFO] [stderr] | [INFO] [stderr] 958 | shift_copy = shift_copy << shift; [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 1185 | construct_uint!(U128, 2); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/uint/mod.rs:964:30 [INFO] [stderr] | [INFO] [stderr] 964 | shift_copy = shift_copy >> 1; [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 1185 | construct_uint!(U128, 2); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/uint/mod.rs:1127:21 [INFO] [stderr] | [INFO] [stderr] 1127 | i = i - 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i -= 1` [INFO] [stderr] ... [INFO] [stderr] 1185 | construct_uint!(U128, 2); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `<=` [INFO] [stderr] --> src/uint/tests.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | assert!(biggest <= biggest); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `<=` [INFO] [stderr] --> src/uint/tests.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | assert!(small <= small); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `add` [INFO] [stderr] --> src/uint/tests.rs:266:9 [INFO] [stderr] | [INFO] [stderr] 266 | add >> 0, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `add` [INFO] [stderr] --> src/uint/tests.rs:270:9 [INFO] [stderr] | [INFO] [stderr] 270 | add << 0, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/uint/tests.rs:940:1 [INFO] [stderr] | [INFO] [stderr] 940 | / fn u256_multi_full_mul() { [INFO] [stderr] 941 | | let result = U256([0, 0, 0, 0]).full_mul(U256([0, 0, 0, 0])); [INFO] [stderr] 942 | | assert_eq!(U512([0, 0, 0, 0, 0, 0, 0, 0]), result); [INFO] [stderr] 943 | | [INFO] [stderr] ... | [INFO] [stderr] 1266 | | assert_eq!(U512([5, 16, 34, 60, 61, 52, 32, 0]), result); [INFO] [stderr] 1267 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash/mod.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | ret |= (self.0[$size - 1 - i] as u64) << (i * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.0[$size - 1 - i])` [INFO] [stderr] ... [INFO] [stderr] 483 | impl_hash!(H32, 4); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/hash/mod.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | for i in 0..$size { [INFO] [stderr] | ^ help: try replacing the loop by: `ret[..4].clone_from_slice(&s[..4])` [INFO] [stderr] ... [INFO] [stderr] 483 | impl_hash!(H32, 4); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash/mod.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | ret |= (self.0[$size - 1 - i] as u64) << (i * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.0[$size - 1 - i])` [INFO] [stderr] ... [INFO] [stderr] 484 | impl_hash!(H64, 8); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/hash/mod.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | for i in 0..$size { [INFO] [stderr] | ^ help: try replacing the loop by: `ret[..8].clone_from_slice(&s[..8])` [INFO] [stderr] ... [INFO] [stderr] 484 | impl_hash!(H64, 8); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash/mod.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | ret |= (self.0[$size - 1 - i] as u64) << (i * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.0[$size - 1 - i])` [INFO] [stderr] ... [INFO] [stderr] 485 | impl_hash!(H128, 16); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/hash/mod.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | for i in 0..$size { [INFO] [stderr] | ^ help: try replacing the loop by: `ret[..16].clone_from_slice(&s[..16])` [INFO] [stderr] ... [INFO] [stderr] 485 | impl_hash!(H128, 16); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash/mod.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | ret |= (self.0[$size - 1 - i] as u64) << (i * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.0[$size - 1 - i])` [INFO] [stderr] ... [INFO] [stderr] 486 | impl_hash!(H160, 20); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/hash/mod.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | for i in 0..$size { [INFO] [stderr] | ^ help: try replacing the loop by: `ret[..20].clone_from_slice(&s[..20])` [INFO] [stderr] ... [INFO] [stderr] 486 | impl_hash!(H160, 20); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash/mod.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | ret |= (self.0[$size - 1 - i] as u64) << (i * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.0[$size - 1 - i])` [INFO] [stderr] ... [INFO] [stderr] 487 | impl_hash!(H256, 32); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/hash/mod.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | for i in 0..$size { [INFO] [stderr] | ^ help: try replacing the loop by: `ret[..32].clone_from_slice(&s[..32])` [INFO] [stderr] ... [INFO] [stderr] 487 | impl_hash!(H256, 32); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash/mod.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | ret |= (self.0[$size - 1 - i] as u64) << (i * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.0[$size - 1 - i])` [INFO] [stderr] ... [INFO] [stderr] 488 | impl_hash!(H264, 33); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/hash/mod.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | for i in 0..$size { [INFO] [stderr] | ^ help: try replacing the loop by: `ret[..33].clone_from_slice(&s[..33])` [INFO] [stderr] ... [INFO] [stderr] 488 | impl_hash!(H264, 33); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash/mod.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | ret |= (self.0[$size - 1 - i] as u64) << (i * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.0[$size - 1 - i])` [INFO] [stderr] ... [INFO] [stderr] 489 | impl_hash!(H512, 64); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/hash/mod.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | for i in 0..$size { [INFO] [stderr] | ^ help: try replacing the loop by: `ret[..64].clone_from_slice(&s[..64])` [INFO] [stderr] ... [INFO] [stderr] 489 | impl_hash!(H512, 64); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash/mod.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | ret |= (self.0[$size - 1 - i] as u64) << (i * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.0[$size - 1 - i])` [INFO] [stderr] ... [INFO] [stderr] 490 | impl_hash!(H520, 65); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/hash/mod.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | for i in 0..$size { [INFO] [stderr] | ^ help: try replacing the loop by: `ret[..65].clone_from_slice(&s[..65])` [INFO] [stderr] ... [INFO] [stderr] 490 | impl_hash!(H520, 65); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash/mod.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | ret |= (self.0[$size - 1 - i] as u64) << (i * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.0[$size - 1 - i])` [INFO] [stderr] ... [INFO] [stderr] 491 | impl_hash!(H1024, 128); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/hash/mod.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | for i in 0..$size { [INFO] [stderr] | ^ help: try replacing the loop by: `ret[..128].clone_from_slice(&s[..128])` [INFO] [stderr] ... [INFO] [stderr] 491 | impl_hash!(H1024, 128); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/hash/mod.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | ret |= (self.0[$size - 1 - i] as u64) << (i * 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.0[$size - 1 - i])` [INFO] [stderr] ... [INFO] [stderr] 492 | impl_hash!(H2048, 256); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/hash/mod.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | for i in 0..$size { [INFO] [stderr] | ^ help: try replacing the loop by: `ret[..256].clone_from_slice(&s[..256])` [INFO] [stderr] ... [INFO] [stderr] 492 | impl_hash!(H2048, 256); [INFO] [stderr] | ----------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> src/hash/mod.rs:565:17 [INFO] [stderr] | [INFO] [stderr] 565 | assert!(h == h); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/hash/mod.rs:577:20 [INFO] [stderr] | [INFO] [stderr] 577 | assert_eq!(&a | &b, c); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 577 | assert_eq!(a | b, c); [INFO] [stderr] | ^ ^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/hash/mod.rs:586:28 [INFO] [stderr] | [INFO] [stderr] 586 | let h = H256::from(address.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `address` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/bytes.rs:12:18 [INFO] [stderr] | [INFO] [stderr] 12 | for i in 0..value.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try replacing the loop by: `ret[..value.len()].clone_from_slice(&value[..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `bytes` [INFO] [stderr] --> src/bytes.rs:41:26 [INFO] [stderr] | [INFO] [stderr] 41 | for i in 0..bytes.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 41 | for (i, ) in bytes.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/bytes.rs:41:26 [INFO] [stderr] | [INFO] [stderr] 41 | for i in 0..bytes.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try replacing the loop by: `ret.1[..bytes.len()].clone_from_slice(&bytes[..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/gas.rs:69:31 [INFO] [stderr] | [INFO] [stderr] 69 | U256::from_str(s).map(|s| Gas(s)) [INFO] [stderr] | ^^^^^^^^^^ help: remove closure as shown: `Gas` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: aborting due to 12 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `etcommon-bigint`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "701bad51c8edb0c20e5830541e63e0c5125c728c11fe03fef108841f2c59f06d"` [INFO] running `"docker" "rm" "-f" "701bad51c8edb0c20e5830541e63e0c5125c728c11fe03fef108841f2c59f06d"` [INFO] [stdout] 701bad51c8edb0c20e5830541e63e0c5125c728c11fe03fef108841f2c59f06d