[INFO] crate estree 0.0.5 is already in cache [INFO] extracting crate estree 0.0.5 into work/ex/clippy-test-run/sources/stable/reg/estree/0.0.5 [INFO] extracting crate estree 0.0.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/estree/0.0.5 [INFO] validating manifest of estree-0.0.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of estree-0.0.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing estree-0.0.5 [INFO] removed path dependency easter from estree-0.0.5 [INFO] removed path dependency joker from estree-0.0.5 [INFO] removed path dependency unjson from estree-0.0.5 [INFO] finished frobbing estree-0.0.5 [INFO] frobbed toml for estree-0.0.5 written to work/ex/clippy-test-run/sources/stable/reg/estree/0.0.5/Cargo.toml [INFO] started frobbing estree-0.0.5 [INFO] removed path dependency easter from estree-0.0.5 [INFO] removed path dependency joker from estree-0.0.5 [INFO] removed path dependency unjson from estree-0.0.5 [INFO] finished frobbing estree-0.0.5 [INFO] frobbed toml for estree-0.0.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/estree/0.0.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting estree-0.0.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/estree/0.0.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 72ef01fbc4de6dfd317c539485f93acb391bd76e5e047318d2f9951182149171 [INFO] running `"docker" "start" "-a" "72ef01fbc4de6dfd317c539485f93acb391bd76e5e047318d2f9951182149171"` [INFO] [stderr] Checking unjson v0.0.5 [INFO] [stderr] Checking joker v0.0.5 [INFO] [stderr] Checking easter v0.0.5 [INFO] [stderr] Checking estree v0.0.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stmt.rs:228:35 [INFO] [stderr] | [INFO] [stderr] 228 | Ok(Case { location: None, test: test, body: body }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `test` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stmt.rs:228:47 [INFO] [stderr] | [INFO] [stderr] 228 | Ok(Case { location: None, test: test, body: body }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stmt.rs:235:36 [INFO] [stderr] | [INFO] [stderr] 235 | Ok(Catch { location: None, param: param, body: body }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `param` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stmt.rs:235:50 [INFO] [stderr] | [INFO] [stderr] 235 | Ok(Catch { location: None, param: param, body: body }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:42:29 [INFO] [stderr] | [INFO] [stderr] 42 | pattern: pattern, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pattern` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:162:21 [INFO] [stderr] | [INFO] [stderr] 162 | pattern: pattern, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pattern` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fun.rs:29:34 [INFO] [stderr] | [INFO] [stderr] 29 | Ok(Fun { location: None, id: id, params: params, body: body }) [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fun.rs:29:42 [INFO] [stderr] | [INFO] [stderr] 29 | Ok(Fun { location: None, id: id, params: params, body: body }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fun.rs:29:58 [INFO] [stderr] | [INFO] [stderr] 29 | Ok(Fun { location: None, id: id, params: params, body: body }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/obj.rs:38:35 [INFO] [stderr] | [INFO] [stderr] 38 | Ok(Prop { location: None, key: key, val: val }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/obj.rs:38:45 [INFO] [stderr] | [INFO] [stderr] 38 | Ok(Prop { location: None, key: key, val: val }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prog.rs:13:37 [INFO] [stderr] | [INFO] [stderr] 13 | Ok(Script { location: None, body: body }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stmt.rs:228:35 [INFO] [stderr] | [INFO] [stderr] 228 | Ok(Case { location: None, test: test, body: body }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `test` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stmt.rs:228:47 [INFO] [stderr] | [INFO] [stderr] 228 | Ok(Case { location: None, test: test, body: body }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stmt.rs:235:36 [INFO] [stderr] | [INFO] [stderr] 235 | Ok(Catch { location: None, param: param, body: body }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `param` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/stmt.rs:235:50 [INFO] [stderr] | [INFO] [stderr] 235 | Ok(Catch { location: None, param: param, body: body }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:42:29 [INFO] [stderr] | [INFO] [stderr] 42 | pattern: pattern, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pattern` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/expr.rs:162:21 [INFO] [stderr] | [INFO] [stderr] 162 | pattern: pattern, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pattern` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fun.rs:29:34 [INFO] [stderr] | [INFO] [stderr] 29 | Ok(Fun { location: None, id: id, params: params, body: body }) [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fun.rs:29:42 [INFO] [stderr] | [INFO] [stderr] 29 | Ok(Fun { location: None, id: id, params: params, body: body }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fun.rs:29:58 [INFO] [stderr] | [INFO] [stderr] 29 | Ok(Fun { location: None, id: id, params: params, body: body }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/obj.rs:38:35 [INFO] [stderr] | [INFO] [stderr] 38 | Ok(Prop { location: None, key: key, val: val }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/obj.rs:38:45 [INFO] [stderr] | [INFO] [stderr] 38 | Ok(Prop { location: None, key: key, val: val }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prog.rs:13:37 [INFO] [stderr] | [INFO] [stderr] 13 | Ok(Script { location: None, body: body }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/obj.rs:49:20 [INFO] [stderr] | [INFO] [stderr] 49 | _ => { return type_error("identifier, number literal, or string literal", Ty::Object); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `type_error("identifier, number literal, or string literal", Ty::Object)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/obj.rs:49:20 [INFO] [stderr] | [INFO] [stderr] 49 | _ => { return type_error("identifier, number literal, or string literal", Ty::Object); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `type_error("identifier, number literal, or string literal", Ty::Object)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | / match self { [INFO] [stderr] 24 | | &Error::Json(ref err) => { [INFO] [stderr] 25 | | fmt.write_fmt(format_args!("{}", err)) [INFO] [stderr] 26 | | } [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 23 | match *self { [INFO] [stderr] 24 | Error::Json(ref err) => { [INFO] [stderr] 25 | fmt.write_fmt(format_args!("{}", err)) [INFO] [stderr] 26 | } [INFO] [stderr] 27 | Error::InvalidTypeTag(ref actual) => { [INFO] [stderr] 28 | fmt.write_fmt(format_args!("expected node type tag, got {}", actual)) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | / match self { [INFO] [stderr] 24 | | &Error::Json(ref err) => { [INFO] [stderr] 25 | | fmt.write_fmt(format_args!("{}", err)) [INFO] [stderr] 26 | | } [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 23 | match *self { [INFO] [stderr] 24 | Error::Json(ref err) => { [INFO] [stderr] 25 | fmt.write_fmt(format_args!("{}", err)) [INFO] [stderr] 26 | } [INFO] [stderr] 27 | Error::InvalidTypeTag(ref actual) => { [INFO] [stderr] 28 | fmt.write_fmt(format_args!("expected node type tag, got {}", actual)) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.11s [INFO] running `"docker" "inspect" "72ef01fbc4de6dfd317c539485f93acb391bd76e5e047318d2f9951182149171"` [INFO] running `"docker" "rm" "-f" "72ef01fbc4de6dfd317c539485f93acb391bd76e5e047318d2f9951182149171"` [INFO] [stdout] 72ef01fbc4de6dfd317c539485f93acb391bd76e5e047318d2f9951182149171