[INFO] crate essrpc_macros 0.1.0 is already in cache [INFO] extracting crate essrpc_macros 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/essrpc_macros/0.1.0 [INFO] extracting crate essrpc_macros 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/essrpc_macros/0.1.0 [INFO] validating manifest of essrpc_macros-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of essrpc_macros-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing essrpc_macros-0.1.0 [INFO] finished frobbing essrpc_macros-0.1.0 [INFO] frobbed toml for essrpc_macros-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/essrpc_macros/0.1.0/Cargo.toml [INFO] started frobbing essrpc_macros-0.1.0 [INFO] finished frobbing essrpc_macros-0.1.0 [INFO] frobbed toml for essrpc_macros-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/essrpc_macros/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting essrpc_macros-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/essrpc_macros/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 487378cd0a2a47641384acd295c623f6be75b5db32e628a39dbdd897d94159c1 [INFO] running `"docker" "start" "-a" "487378cd0a2a47641384acd295c623f6be75b5db32e628a39dbdd897d94159c1"` [INFO] [stderr] Checking essrpc_macros v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:68:8 [INFO] [stderr] | [INFO] [stderr] 68 | if !first.is_some() || (match first.unwrap().value() { [INFO] [stderr] | ________^ [INFO] [stderr] 69 | | FnArg::SelfRef(_) => false, [INFO] [stderr] 70 | | _ => true [INFO] [stderr] 71 | | }) { [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 68 | if first.is_none() || (match first.unwrap().value() { [INFO] [stderr] 69 | FnArg::SelfRef(_) => false, [INFO] [stderr] 70 | _ => true [INFO] [stderr] 71 | }) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the variable `mcnt` is used as a loop counter. Consider using `for (mcnt, item) in methods.enumerate()` or similar iterators [INFO] [stderr] --> src/lib.rs:116:19 [INFO] [stderr] | [INFO] [stderr] 116 | for method in methods { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `mcnt` is used as a loop counter. Consider using `for (mcnt, item) in methods.enumerate()` or similar iterators [INFO] [stderr] --> src/lib.rs:151:19 [INFO] [stderr] | [INFO] [stderr] 151 | for method in methods { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:68:8 [INFO] [stderr] | [INFO] [stderr] 68 | if !first.is_some() || (match first.unwrap().value() { [INFO] [stderr] | ________^ [INFO] [stderr] 69 | | FnArg::SelfRef(_) => false, [INFO] [stderr] 70 | | _ => true [INFO] [stderr] 71 | | }) { [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 68 | if first.is_none() || (match first.unwrap().value() { [INFO] [stderr] 69 | FnArg::SelfRef(_) => false, [INFO] [stderr] 70 | _ => true [INFO] [stderr] 71 | }) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the variable `mcnt` is used as a loop counter. Consider using `for (mcnt, item) in methods.enumerate()` or similar iterators [INFO] [stderr] --> src/lib.rs:116:19 [INFO] [stderr] | [INFO] [stderr] 116 | for method in methods { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `mcnt` is used as a loop counter. Consider using `for (mcnt, item) in methods.enumerate()` or similar iterators [INFO] [stderr] --> src/lib.rs:151:19 [INFO] [stderr] | [INFO] [stderr] 151 | for method in methods { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.42s [INFO] running `"docker" "inspect" "487378cd0a2a47641384acd295c623f6be75b5db32e628a39dbdd897d94159c1"` [INFO] running `"docker" "rm" "-f" "487378cd0a2a47641384acd295c623f6be75b5db32e628a39dbdd897d94159c1"` [INFO] [stdout] 487378cd0a2a47641384acd295c623f6be75b5db32e628a39dbdd897d94159c1