[INFO] crate essrpc 0.1.2 is already in cache [INFO] extracting crate essrpc 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/essrpc/0.1.2 [INFO] extracting crate essrpc 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/essrpc/0.1.2 [INFO] validating manifest of essrpc-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of essrpc-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing essrpc-0.1.2 [INFO] finished frobbing essrpc-0.1.2 [INFO] frobbed toml for essrpc-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/essrpc/0.1.2/Cargo.toml [INFO] started frobbing essrpc-0.1.2 [INFO] finished frobbing essrpc-0.1.2 [INFO] frobbed toml for essrpc-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/essrpc/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting essrpc-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/essrpc/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8b5c17e02928a9104711680f875a875d637be2a13f9e4df4f31ae0ed900e0ffc [INFO] running `"docker" "start" "-a" "8b5c17e02928a9104711680f875a875d637be2a13f9e4df4f31ae0ed900e0ffc"` [INFO] [stderr] Compiling essrpc_macros v0.1.0 [INFO] [stderr] Checking essrpc v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transports/mod.rs:29:19 [INFO] [stderr] | [INFO] [stderr] 29 | ReadWrite{r: r, w: w} [INFO] [stderr] | ^^^^ help: replace it with: `r` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transports/mod.rs:29:25 [INFO] [stderr] | [INFO] [stderr] 29 | ReadWrite{r: r, w: w} [INFO] [stderr] | ^^^^ help: replace it with: `w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:190:62 [INFO] [stderr] | [INFO] [stderr] 190 | GenericSerializableError{description: e.to_string(), cause: cause} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cause` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:202:62 [INFO] [stderr] | [INFO] [stderr] 202 | GenericSerializableError{description: e.to_string(), cause: cause} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cause` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:234:18 [INFO] [stderr] | [INFO] [stderr] 234 | RPCError{kind: kind, msg: msg.into(), cause: None} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:239:18 [INFO] [stderr] | [INFO] [stderr] 239 | RPCError{kind: kind, msg: msg.into(), cause: Some(Box::new(GenericSerializableError::new(cause)))} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transports/mod.rs:29:19 [INFO] [stderr] | [INFO] [stderr] 29 | ReadWrite{r: r, w: w} [INFO] [stderr] | ^^^^ help: replace it with: `r` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transports/mod.rs:29:25 [INFO] [stderr] | [INFO] [stderr] 29 | ReadWrite{r: r, w: w} [INFO] [stderr] | ^^^^ help: replace it with: `w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:190:62 [INFO] [stderr] | [INFO] [stderr] 190 | GenericSerializableError{description: e.to_string(), cause: cause} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cause` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:202:62 [INFO] [stderr] | [INFO] [stderr] 202 | GenericSerializableError{description: e.to_string(), cause: cause} [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cause` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:234:18 [INFO] [stderr] | [INFO] [stderr] 234 | RPCError{kind: kind, msg: msg.into(), cause: None} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:239:18 [INFO] [stderr] | [INFO] [stderr] 239 | RPCError{kind: kind, msg: msg.into(), cause: Some(Box::new(GenericSerializableError::new(cause)))} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use as_ref() instead [INFO] [stderr] --> src/lib.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | / match self.cause { [INFO] [stderr] 208 | | Some(ref e) => Some(e), [INFO] [stderr] 209 | | None => None [INFO] [stderr] 210 | | } [INFO] [stderr] | |_________^ help: try this: `self.cause.as_ref()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_as_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_as_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:243:5 [INFO] [stderr] | [INFO] [stderr] 243 | / pub fn cause<'a>(&'a self) -> Option<&'a GenericSerializableError> { [INFO] [stderr] 244 | | match self.cause { [INFO] [stderr] 245 | | None => None, [INFO] [stderr] 246 | | Some(ref e) => Some(&e) [INFO] [stderr] 247 | | } [INFO] [stderr] 248 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use as_ref() instead [INFO] [stderr] --> src/lib.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | / match self.cause { [INFO] [stderr] 208 | | Some(ref e) => Some(e), [INFO] [stderr] 209 | | None => None [INFO] [stderr] 210 | | } [INFO] [stderr] | |_________^ help: try this: `self.cause.as_ref()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_as_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_as_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:243:5 [INFO] [stderr] | [INFO] [stderr] 243 | / pub fn cause<'a>(&'a self) -> Option<&'a GenericSerializableError> { [INFO] [stderr] 244 | | match self.cause { [INFO] [stderr] 245 | | None => None, [INFO] [stderr] 246 | | Some(ref e) => Some(&e) [INFO] [stderr] 247 | | } [INFO] [stderr] 248 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error[E0432]: unresolved imports `essrpc::transports::BincodeTransport`, `essrpc::transports::JSONTransport` [INFO] [stderr] --> tests/basic.rs:13:26 [INFO] [stderr] | [INFO] [stderr] 13 | use essrpc::transports::{BincodeTransport, JSONTransport}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ no `JSONTransport` in `transports` [INFO] [stderr] | | [INFO] [stderr] | no `BincodeTransport` in `transports` [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0432`. [INFO] [stderr] error: Could not compile `essrpc`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "8b5c17e02928a9104711680f875a875d637be2a13f9e4df4f31ae0ed900e0ffc"` [INFO] running `"docker" "rm" "-f" "8b5c17e02928a9104711680f875a875d637be2a13f9e4df4f31ae0ed900e0ffc"` [INFO] [stdout] 8b5c17e02928a9104711680f875a875d637be2a13f9e4df4f31ae0ed900e0ffc