[INFO] crate ess 0.4.1 is already in cache [INFO] extracting crate ess 0.4.1 into work/ex/clippy-test-run/sources/stable/reg/ess/0.4.1 [INFO] extracting crate ess 0.4.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ess/0.4.1 [INFO] validating manifest of ess-0.4.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ess-0.4.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ess-0.4.1 [INFO] finished frobbing ess-0.4.1 [INFO] frobbed toml for ess-0.4.1 written to work/ex/clippy-test-run/sources/stable/reg/ess/0.4.1/Cargo.toml [INFO] started frobbing ess-0.4.1 [INFO] finished frobbing ess-0.4.1 [INFO] frobbed toml for ess-0.4.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ess/0.4.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ess-0.4.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ess/0.4.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a1013d62aaac48cab4bef0437da37e8ba20f80ad14c724b3e5c3f989ed3f230a [INFO] running `"docker" "start" "-a" "a1013d62aaac48cab4bef0437da37e8ba20f80ad14c724b3e5c3f989ed3f230a"` [INFO] [stderr] Checking ess v0.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `parser::ParseResult::*` [INFO] [stderr] --> src/parser.rs:461:9 [INFO] [stderr] | [INFO] [stderr] 461 | use parser::ParseResult::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: using a reference to `Cow` is not recommended. [INFO] [stderr] --> src/sexp.rs:49:35 [INFO] [stderr] | [INFO] [stderr] 49 | fn extend_cow<'a, T: ?Sized>(cow: &Cow<'a, T>) -> Cow<'static, T> [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&T` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> src/parser.rs:217:16 [INFO] [stderr] | [INFO] [stderr] 217 | if input[1..].chars().next() == Some('@') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `input[1..].starts_with('@')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_next_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/parser.rs:406:29 [INFO] [stderr] | [INFO] [stderr] 406 | Sexp::Str(input[1..i+1].into(), (0, i+2).offset(start_loc))); [INFO] [stderr] | ^^^^^^ help: use: `1..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: using a reference to `Cow` is not recommended. [INFO] [stderr] --> src/sexp.rs:49:35 [INFO] [stderr] | [INFO] [stderr] 49 | fn extend_cow<'a, T: ?Sized>(cow: &Cow<'a, T>) -> Cow<'static, T> [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&T` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> src/parser.rs:217:16 [INFO] [stderr] | [INFO] [stderr] 217 | if input[1..].chars().next() == Some('@') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `input[1..].starts_with('@')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_next_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/parser.rs:406:29 [INFO] [stderr] | [INFO] [stderr] 406 | Sexp::Str(input[1..i+1].into(), (0, i+2).offset(start_loc))); [INFO] [stderr] | ^^^^^^ help: use: `1..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.56s [INFO] running `"docker" "inspect" "a1013d62aaac48cab4bef0437da37e8ba20f80ad14c724b3e5c3f989ed3f230a"` [INFO] running `"docker" "rm" "-f" "a1013d62aaac48cab4bef0437da37e8ba20f80ad14c724b3e5c3f989ed3f230a"` [INFO] [stdout] a1013d62aaac48cab4bef0437da37e8ba20f80ad14c724b3e5c3f989ed3f230a