[INFO] crate escape_string 0.1.1 is already in cache [INFO] extracting crate escape_string 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/escape_string/0.1.1 [INFO] extracting crate escape_string 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/escape_string/0.1.1 [INFO] validating manifest of escape_string-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of escape_string-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing escape_string-0.1.1 [INFO] finished frobbing escape_string-0.1.1 [INFO] frobbed toml for escape_string-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/escape_string/0.1.1/Cargo.toml [INFO] started frobbing escape_string-0.1.1 [INFO] finished frobbing escape_string-0.1.1 [INFO] frobbed toml for escape_string-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/escape_string/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting escape_string-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/escape_string/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5150d1baf853816ab0a5e8b5c7df80d5ab2dbe605a2877517ffdac884e4ca565 [INFO] running `"docker" "start" "-a" "5150d1baf853816ab0a5e8b5c7df80d5ab2dbe605a2877517ffdac884e4ca565"` [INFO] [stderr] Checking escape_string v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / pub fn split_one_bytes<'a>(bytes: &'a [u8]) [INFO] [stderr] 7 | | -> Option<(Cow<'a, [u8]>, &'a [u8])> [INFO] [stderr] 8 | | { [INFO] [stderr] 9 | | let mut start = 0usize; [INFO] [stderr] ... | [INFO] [stderr] 78 | | } [INFO] [stderr] 79 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:26:7 [INFO] [stderr] | [INFO] [stderr] 26 | if !owned.is_some() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `owned.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:93:1 [INFO] [stderr] | [INFO] [stderr] 93 | / pub fn split_one<'a>(text: &'a str) [INFO] [stderr] 94 | | -> Option<(Cow<'a, str>, &'a str)> [INFO] [stderr] 95 | | { [INFO] [stderr] 96 | | if let Some((one, remainder)) = split_one_bytes(text.as_bytes()) [INFO] [stderr] ... | [INFO] [stderr] 112 | | } [INFO] [stderr] 113 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/lib.rs:123:3 [INFO] [stderr] | [INFO] [stderr] 123 | if s.is_none() { return None; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace_it_with: `s?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:131:1 [INFO] [stderr] | [INFO] [stderr] 131 | / pub fn escape<'a>(text: &'a str) [INFO] [stderr] 132 | | -> Cow<'a, str> [INFO] [stderr] 133 | | { [INFO] [stderr] 134 | | let bytes = text.as_bytes(); [INFO] [stderr] ... | [INFO] [stderr] 176 | | } [INFO] [stderr] 177 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / pub fn split_one_bytes<'a>(bytes: &'a [u8]) [INFO] [stderr] 7 | | -> Option<(Cow<'a, [u8]>, &'a [u8])> [INFO] [stderr] 8 | | { [INFO] [stderr] 9 | | let mut start = 0usize; [INFO] [stderr] ... | [INFO] [stderr] 78 | | } [INFO] [stderr] 79 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:26:7 [INFO] [stderr] | [INFO] [stderr] 26 | if !owned.is_some() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `owned.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:93:1 [INFO] [stderr] | [INFO] [stderr] 93 | / pub fn split_one<'a>(text: &'a str) [INFO] [stderr] 94 | | -> Option<(Cow<'a, str>, &'a str)> [INFO] [stderr] 95 | | { [INFO] [stderr] 96 | | if let Some((one, remainder)) = split_one_bytes(text.as_bytes()) [INFO] [stderr] ... | [INFO] [stderr] 112 | | } [INFO] [stderr] 113 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/lib.rs:123:3 [INFO] [stderr] | [INFO] [stderr] 123 | if s.is_none() { return None; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace_it_with: `s?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:131:1 [INFO] [stderr] | [INFO] [stderr] 131 | / pub fn escape<'a>(text: &'a str) [INFO] [stderr] 132 | | -> Cow<'a, str> [INFO] [stderr] 133 | | { [INFO] [stderr] 134 | | let bytes = text.as_bytes(); [INFO] [stderr] ... | [INFO] [stderr] 176 | | } [INFO] [stderr] 177 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.90s [INFO] running `"docker" "inspect" "5150d1baf853816ab0a5e8b5c7df80d5ab2dbe605a2877517ffdac884e4ca565"` [INFO] running `"docker" "rm" "-f" "5150d1baf853816ab0a5e8b5c7df80d5ab2dbe605a2877517ffdac884e4ca565"` [INFO] [stdout] 5150d1baf853816ab0a5e8b5c7df80d5ab2dbe605a2877517ffdac884e4ca565