[INFO] crate error-chain 0.12.0 is already in cache [INFO] extracting crate error-chain 0.12.0 into work/ex/clippy-test-run/sources/stable/reg/error-chain/0.12.0 [INFO] extracting crate error-chain 0.12.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/error-chain/0.12.0 [INFO] validating manifest of error-chain-0.12.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of error-chain-0.12.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing error-chain-0.12.0 [INFO] finished frobbing error-chain-0.12.0 [INFO] frobbed toml for error-chain-0.12.0 written to work/ex/clippy-test-run/sources/stable/reg/error-chain/0.12.0/Cargo.toml [INFO] started frobbing error-chain-0.12.0 [INFO] finished frobbing error-chain-0.12.0 [INFO] frobbed toml for error-chain-0.12.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/error-chain/0.12.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting error-chain-0.12.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/error-chain/0.12.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5436c8f038dbebee2771fe9d12d48419c5e4f6ce2e80a95d11f401cc4bb6a49f [INFO] running `"docker" "start" "-a" "5436c8f038dbebee2771fe9d12d48419c5e4f6ce2e80a95d11f401cc4bb6a49f"` [INFO] [stderr] Checking error-chain v0.12.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:678:13 [INFO] [stderr] | [INFO] [stderr] 678 | backtrace: backtrace, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `backtrace` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:678:13 [INFO] [stderr] | [INFO] [stderr] 678 | backtrace: backtrace, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `backtrace` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `backtrace::imp::InternalBacktrace` [INFO] [stderr] --> src/backtrace.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new() -> InternalBacktrace { [INFO] [stderr] 36 | | static ENABLED: AtomicUsize = ATOMIC_USIZE_INIT; [INFO] [stderr] 37 | | [INFO] [stderr] 38 | | match ENABLED.load(Ordering::SeqCst) { [INFO] [stderr] ... | [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | #[derive(Default)] [INFO] [stderr] 17 | pub struct InternalBacktrace { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/backtrace.rs:55:31 [INFO] [stderr] | [INFO] [stderr] 55 | resolved: Mutex::new(false), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/backtrace.rs:68:32 [INFO] [stderr] | [INFO] [stderr] 68 | let mut resolved = bt.resolved.lock().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:609:5 [INFO] [stderr] | [INFO] [stderr] 609 | / fn display_chain<'a>(&'a self) -> DisplayChain<'a, Self> { [INFO] [stderr] 610 | | DisplayChain(self) [INFO] [stderr] 611 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `backtrace::imp::InternalBacktrace` [INFO] [stderr] --> src/backtrace.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new() -> InternalBacktrace { [INFO] [stderr] 36 | | static ENABLED: AtomicUsize = ATOMIC_USIZE_INIT; [INFO] [stderr] 37 | | [INFO] [stderr] 38 | | match ENABLED.load(Ordering::SeqCst) { [INFO] [stderr] ... | [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | #[derive(Default)] [INFO] [stderr] 17 | pub struct InternalBacktrace { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/backtrace.rs:55:31 [INFO] [stderr] | [INFO] [stderr] 55 | resolved: Mutex::new(false), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/backtrace.rs:68:32 [INFO] [stderr] | [INFO] [stderr] 68 | let mut resolved = bt.resolved.lock().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:609:5 [INFO] [stderr] | [INFO] [stderr] 609 | / fn display_chain<'a>(&'a self) -> DisplayChain<'a, Self> { [INFO] [stderr] 610 | | DisplayChain(self) [INFO] [stderr] 611 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> tests/tests.rs:487:5 [INFO] [stderr] | [INFO] [stderr] 487 | / match Error::from("Test") { [INFO] [stderr] 488 | | Error(ErrorKind::Msg(_), _) => {}, [INFO] [stderr] 489 | | _ => {}, [INFO] [stderr] 490 | | } [INFO] [stderr] | |_____^ help: try this: `if let Error(ErrorKind::Msg(_), _) = Error::from("Test") {}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.41s [INFO] running `"docker" "inspect" "5436c8f038dbebee2771fe9d12d48419c5e4f6ce2e80a95d11f401cc4bb6a49f"` [INFO] running `"docker" "rm" "-f" "5436c8f038dbebee2771fe9d12d48419c5e4f6ce2e80a95d11f401cc4bb6a49f"` [INFO] [stdout] 5436c8f038dbebee2771fe9d12d48419c5e4f6ce2e80a95d11f401cc4bb6a49f