[INFO] crate erl_tokenize 0.3.7 is already in cache [INFO] extracting crate erl_tokenize 0.3.7 into work/ex/clippy-test-run/sources/stable/reg/erl_tokenize/0.3.7 [INFO] extracting crate erl_tokenize 0.3.7 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/erl_tokenize/0.3.7 [INFO] validating manifest of erl_tokenize-0.3.7 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of erl_tokenize-0.3.7 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing erl_tokenize-0.3.7 [INFO] finished frobbing erl_tokenize-0.3.7 [INFO] frobbed toml for erl_tokenize-0.3.7 written to work/ex/clippy-test-run/sources/stable/reg/erl_tokenize/0.3.7/Cargo.toml [INFO] started frobbing erl_tokenize-0.3.7 [INFO] finished frobbing erl_tokenize-0.3.7 [INFO] frobbed toml for erl_tokenize-0.3.7 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/erl_tokenize/0.3.7/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting erl_tokenize-0.3.7 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/erl_tokenize/0.3.7:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d25536fcb747af4cf02d0ebe14aef21dc0022cba857eadb957d091e7c91c1818 [INFO] running `"docker" "start" "-a" "d25536fcb747af4cf02d0ebe14aef21dc0022cba857eadb957d091e7c91c1818"` [INFO] [stderr] Checking erl_tokenize v0.3.7 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokens.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/tokens.rs:75:35 [INFO] [stderr] | [INFO] [stderr] 75 | (value, unsafe { text.slice_unchecked(0, 1 + end + 1) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/tokens.rs:75:35 [INFO] [stderr] | [INFO] [stderr] 75 | (value, unsafe { text.slice_unchecked(0, 1 + end + 1) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/tokens.rs:83:44 [INFO] [stderr] | [INFO] [stderr] 83 | let text_slice = unsafe { text.slice_unchecked(0, end) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/tokens.rs:83:44 [INFO] [stderr] | [INFO] [stderr] 83 | let text_slice = unsafe { text.slice_unchecked(0, end) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/tokens.rs:215:34 [INFO] [stderr] | [INFO] [stderr] 215 | let text = unsafe { text.slice_unchecked(0, end) }.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/tokens.rs:215:34 [INFO] [stderr] | [INFO] [stderr] 215 | let text = unsafe { text.slice_unchecked(0, end) }.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/tokens.rs:311:34 [INFO] [stderr] | [INFO] [stderr] 311 | let text = unsafe { text.slice_unchecked(0, end) }.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/tokens.rs:311:34 [INFO] [stderr] | [INFO] [stderr] 311 | let text = unsafe { text.slice_unchecked(0, end) }.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/tokens.rs:329:30 [INFO] [stderr] | [INFO] [stderr] 329 | unsafe { self.text().slice_unchecked(1, self.text.len()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/tokens.rs:329:30 [INFO] [stderr] | [INFO] [stderr] 329 | unsafe { self.text().slice_unchecked(1, self.text.len()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/tokens.rs:448:34 [INFO] [stderr] | [INFO] [stderr] 448 | let text = unsafe { text.slice_unchecked(0, end) }.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/tokens.rs:448:34 [INFO] [stderr] | [INFO] [stderr] 448 | let text = unsafe { text.slice_unchecked(0, end) }.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/tokens.rs:556:46 [INFO] [stderr] | [INFO] [stderr] 556 | radix = track!(unsafe { text.slice_unchecked(0, i) }.parse().map_err( [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/tokens.rs:556:46 [INFO] [stderr] | [INFO] [stderr] 556 | radix = track!(unsafe { text.slice_unchecked(0, i) }.parse().map_err( [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/tokens.rs:571:35 [INFO] [stderr] | [INFO] [stderr] 571 | let input = unsafe { text.slice_unchecked(start, end) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/tokens.rs:571:35 [INFO] [stderr] | [INFO] [stderr] 571 | let input = unsafe { text.slice_unchecked(start, end) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/tokens.rs:578:34 [INFO] [stderr] | [INFO] [stderr] 578 | let text = unsafe { text.slice_unchecked(0, end) }.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/tokens.rs:578:34 [INFO] [stderr] | [INFO] [stderr] 578 | let text = unsafe { text.slice_unchecked(0, end) }.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/tokens.rs:821:34 [INFO] [stderr] | [INFO] [stderr] 821 | let text = unsafe { text.slice_unchecked(0, 1 + end + 1) }.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] --> src/tokens.rs:821:34 [INFO] [stderr] | [INFO] [stderr] 821 | let text = unsafe { text.slice_unchecked(0, 1 + end + 1) }.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/tokens.rs:844:32 [INFO] [stderr] | [INFO] [stderr] 844 | unsafe { self.text.slice_unchecked(1, len - 1) } [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/tokens.rs:844:32 [INFO] [stderr] | [INFO] [stderr] 844 | unsafe { self.text.slice_unchecked(1, len - 1) } [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/tokens.rs:1091:34 [INFO] [stderr] | [INFO] [stderr] 1091 | let text = unsafe { text.slice_unchecked(0, end) }.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/tokens.rs:1091:34 [INFO] [stderr] | [INFO] [stderr] 1091 | let text = unsafe { text.slice_unchecked(0, end) }.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/position.rs:61:34 [INFO] [stderr] | [INFO] [stderr] 61 | text = unsafe { text.slice_unchecked(i + 1, len) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/position.rs:61:34 [INFO] [stderr] | [INFO] [stderr] 61 | text = unsafe { text.slice_unchecked(i + 1, len) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/tokenizer.rs:94:36 [INFO] [stderr] | [INFO] [stderr] 94 | self.text.as_ref().slice_unchecked( [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/tokenizer.rs:94:36 [INFO] [stderr] | [INFO] [stderr] 94 | self.text.as_ref().slice_unchecked( [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/util.rs:42:40 [INFO] [stderr] | [INFO] [stderr] 42 | let maybe_escaped = unsafe { input.slice_unchecked(0, maybe_end).contains('\\') }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/util.rs:42:40 [INFO] [stderr] | [INFO] [stderr] 42 | let maybe_escaped = unsafe { input.slice_unchecked(0, maybe_end).contains('\\') }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/util.rs:47:36 [INFO] [stderr] | [INFO] [stderr] 47 | let slice = unsafe { input.slice_unchecked(0, maybe_end) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/util.rs:47:36 [INFO] [stderr] | [INFO] [stderr] 47 | let slice = unsafe { input.slice_unchecked(0, maybe_end) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/tokens.rs:80:64 [INFO] [stderr] | [INFO] [stderr] 80 | tail.find(|c| !util::is_atom_non_head_char(c)).unwrap_or( [INFO] [stderr] | ________________________________________________________________^ [INFO] [stderr] 81 | | tail.len(), [INFO] [stderr] 82 | | ); [INFO] [stderr] | |_________________^ help: try this: `unwrap_or_else(|| tail.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/tokens.rs:204:42 [INFO] [stderr] | [INFO] [stderr] 204 | let (_, c) = track!(chars.next().ok_or(ErrorKind::UnexpectedEos.error()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::UnexpectedEos.error())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/tokens.rs:208:52 [INFO] [stderr] | [INFO] [stderr] 208 | let end = chars.next().map(|(i, _)| i).unwrap_or(text.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| text.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/tokens.rs:212:52 [INFO] [stderr] | [INFO] [stderr] 212 | let end = chars.next().map(|(i, _)| i).unwrap_or(text.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| text.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/tokens.rs:310:35 [INFO] [stderr] | [INFO] [stderr] 310 | let end = text.find('\n').unwrap_or(text.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| text.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/tokens.rs:447:48 [INFO] [stderr] | [INFO] [stderr] 447 | let end = chars.next().map(|(i, _)| i).unwrap_or(text.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| text.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/tokens.rs:80:64 [INFO] [stderr] | [INFO] [stderr] 80 | tail.find(|c| !util::is_atom_non_head_char(c)).unwrap_or( [INFO] [stderr] | ________________________________________________________________^ [INFO] [stderr] 81 | | tail.len(), [INFO] [stderr] 82 | | ); [INFO] [stderr] | |_________________^ help: try this: `unwrap_or_else(|| tail.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/tokens.rs:570:49 [INFO] [stderr] | [INFO] [stderr] 570 | let end = chars.peek().map(|&(i, _)| i).unwrap_or(text.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| text.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/tokens.rs:204:42 [INFO] [stderr] | [INFO] [stderr] 204 | let (_, c) = track!(chars.next().ok_or(ErrorKind::UnexpectedEos.error()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::UnexpectedEos.error())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/tokens.rs:208:52 [INFO] [stderr] | [INFO] [stderr] 208 | let end = chars.next().map(|(i, _)| i).unwrap_or(text.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| text.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/tokens.rs:212:52 [INFO] [stderr] | [INFO] [stderr] 212 | let end = chars.next().map(|(i, _)| i).unwrap_or(text.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| text.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/tokens.rs:310:35 [INFO] [stderr] | [INFO] [stderr] 310 | let end = text.find('\n').unwrap_or(text.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| text.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/tokens.rs:927:9 [INFO] [stderr] | [INFO] [stderr] 927 | / let mut symbol = None; [INFO] [stderr] 928 | | if bytes.len() >= 3 { [INFO] [stderr] 929 | | symbol = match &bytes[0..3] { [INFO] [stderr] 930 | | b"=:=" => Some(Symbol::ExactEq), [INFO] [stderr] ... | [INFO] [stderr] 934 | | }; [INFO] [stderr] 935 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 927 | let symbol = if bytes.len() >= 3 { match &bytes[0..3] { [INFO] [stderr] 928 | b"=:=" => Some(Symbol::ExactEq), [INFO] [stderr] 929 | b"=/=" => Some(Symbol::ExactNotEq), [INFO] [stderr] 930 | b"..." => Some(Symbol::TripleDot), [INFO] [stderr] 931 | _ => None, [INFO] [stderr] 932 | } } else { None }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/tokens.rs:958:32 [INFO] [stderr] | [INFO] [stderr] 958 | if symbol.is_none() && bytes.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bytes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/tokens.rs:447:48 [INFO] [stderr] | [INFO] [stderr] 447 | let end = chars.next().map(|(i, _)| i).unwrap_or(text.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| text.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/tokens.rs:1085:45 [INFO] [stderr] | [INFO] [stderr] 1085 | let (_, head) = track!(chars.next().ok_or(ErrorKind::InvalidInput.error()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::InvalidInput.error())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/tokens.rs:1090:14 [INFO] [stderr] | [INFO] [stderr] 1090 | .unwrap_or(text.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| text.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/tokens.rs:570:49 [INFO] [stderr] | [INFO] [stderr] 570 | let end = chars.peek().map(|&(i, _)| i).unwrap_or(text.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| text.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/values.rs:93:19 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn as_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/values.rs:254:19 [INFO] [stderr] | [INFO] [stderr] 254 | pub fn as_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/tokens.rs:927:9 [INFO] [stderr] | [INFO] [stderr] 927 | / let mut symbol = None; [INFO] [stderr] 928 | | if bytes.len() >= 3 { [INFO] [stderr] 929 | | symbol = match &bytes[0..3] { [INFO] [stderr] 930 | | b"=:=" => Some(Symbol::ExactEq), [INFO] [stderr] ... | [INFO] [stderr] 934 | | }; [INFO] [stderr] 935 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 927 | let symbol = if bytes.len() >= 3 { match &bytes[0..3] { [INFO] [stderr] 928 | b"=:=" => Some(Symbol::ExactEq), [INFO] [stderr] 929 | b"=/=" => Some(Symbol::ExactNotEq), [INFO] [stderr] 930 | b"..." => Some(Symbol::TripleDot), [INFO] [stderr] 931 | _ => None, [INFO] [stderr] 932 | } } else { None }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/tokens.rs:958:32 [INFO] [stderr] | [INFO] [stderr] 958 | if symbol.is_none() && bytes.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bytes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/values.rs:321:20 [INFO] [stderr] | [INFO] [stderr] 321 | pub fn as_char(&self) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/values.rs:332:19 [INFO] [stderr] | [INFO] [stderr] 332 | pub fn as_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/tokens.rs:1085:45 [INFO] [stderr] | [INFO] [stderr] 1085 | let (_, head) = track!(chars.next().ok_or(ErrorKind::InvalidInput.error()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::InvalidInput.error())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/tokens.rs:1090:14 [INFO] [stderr] | [INFO] [stderr] 1090 | .unwrap_or(text.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| text.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/values.rs:93:19 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn as_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `position::Position` [INFO] [stderr] --> src/position.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Position { [INFO] [stderr] 15 | | Position { [INFO] [stderr] 16 | | filepath: None, [INFO] [stderr] 17 | | line: 1, [INFO] [stderr] ... | [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/values.rs:254:19 [INFO] [stderr] | [INFO] [stderr] 254 | pub fn as_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/values.rs:321:20 [INFO] [stderr] | [INFO] [stderr] 321 | pub fn as_char(&self) -> char { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/values.rs:332:19 [INFO] [stderr] | [INFO] [stderr] 332 | pub fn as_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/token.rs:43:47 [INFO] [stderr] | [INFO] [stderr] 43 | let head = track!(text.chars().nth(0).ok_or(ErrorKind::UnexpectedEos.error()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::UnexpectedEos.error())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/util.rs:39:51 [INFO] [stderr] | [INFO] [stderr] 39 | let maybe_end = track!(input.find(terminator).ok_or( [INFO] [stderr] | ___________________________________________________^ [INFO] [stderr] 40 | | Error::from(ErrorKind::InvalidInput), [INFO] [stderr] 41 | | ))?; [INFO] [stderr] | |_____^ help: try this: `ok_or_else(|| Error::from(ErrorKind::InvalidInput))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/util.rs:73:38 [INFO] [stderr] | [INFO] [stderr] 73 | let (_, c) = track!(chars.next().ok_or(ErrorKind::UnexpectedEos.error()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::UnexpectedEos.error())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/util.rs:85:46 [INFO] [stderr] | [INFO] [stderr] 85 | let (_, c) = track!(chars.next().ok_or(ErrorKind::UnexpectedEos.error()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::UnexpectedEos.error())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/util.rs:89:46 [INFO] [stderr] | [INFO] [stderr] 89 | let (_, c) = track!(chars.next().ok_or(ErrorKind::UnexpectedEos.error()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::UnexpectedEos.error())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/util.rs:95:62 [INFO] [stderr] | [INFO] [stderr] 95 | buf.push(track!(chars.next().map(|(_, c)| c).ok_or( [INFO] [stderr] | ______________________________________________________________^ [INFO] [stderr] 96 | | ErrorKind::UnexpectedEos.error(), [INFO] [stderr] 97 | | ))?); [INFO] [stderr] | |_________________^ help: try this: `ok_or_else(|| ErrorKind::UnexpectedEos.error())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/util.rs:101:41 [INFO] [stderr] | [INFO] [stderr] 101 | track!(char::from_u32(code).ok_or(ErrorKind::InvalidInput.into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::InvalidInput.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/util.rs:114:38 [INFO] [stderr] | [INFO] [stderr] 114 | track!(char::from_u32(n).ok_or(ErrorKind::InvalidInput.into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::InvalidInput.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `position::Position` [INFO] [stderr] --> src/position.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Position { [INFO] [stderr] 15 | | Position { [INFO] [stderr] 16 | | filepath: None, [INFO] [stderr] 17 | | line: 1, [INFO] [stderr] ... | [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/token.rs:43:47 [INFO] [stderr] | [INFO] [stderr] 43 | let head = track!(text.chars().nth(0).ok_or(ErrorKind::UnexpectedEos.error()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::UnexpectedEos.error())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/util.rs:39:51 [INFO] [stderr] | [INFO] [stderr] 39 | let maybe_end = track!(input.find(terminator).ok_or( [INFO] [stderr] | ___________________________________________________^ [INFO] [stderr] 40 | | Error::from(ErrorKind::InvalidInput), [INFO] [stderr] 41 | | ))?; [INFO] [stderr] | |_____^ help: try this: `ok_or_else(|| Error::from(ErrorKind::InvalidInput))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/util.rs:73:38 [INFO] [stderr] | [INFO] [stderr] 73 | let (_, c) = track!(chars.next().ok_or(ErrorKind::UnexpectedEos.error()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::UnexpectedEos.error())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/util.rs:85:46 [INFO] [stderr] | [INFO] [stderr] 85 | let (_, c) = track!(chars.next().ok_or(ErrorKind::UnexpectedEos.error()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::UnexpectedEos.error())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/util.rs:89:46 [INFO] [stderr] | [INFO] [stderr] 89 | let (_, c) = track!(chars.next().ok_or(ErrorKind::UnexpectedEos.error()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::UnexpectedEos.error())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/util.rs:95:62 [INFO] [stderr] | [INFO] [stderr] 95 | buf.push(track!(chars.next().map(|(_, c)| c).ok_or( [INFO] [stderr] | ______________________________________________________________^ [INFO] [stderr] 96 | | ErrorKind::UnexpectedEos.error(), [INFO] [stderr] 97 | | ))?); [INFO] [stderr] | |_________________^ help: try this: `ok_or_else(|| ErrorKind::UnexpectedEos.error())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/util.rs:101:41 [INFO] [stderr] | [INFO] [stderr] 101 | track!(char::from_u32(code).ok_or(ErrorKind::InvalidInput.into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::InvalidInput.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/util.rs:114:38 [INFO] [stderr] | [INFO] [stderr] 114 | track!(char::from_u32(n).ok_or(ErrorKind::InvalidInput.into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::InvalidInput.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/tokenize.rs:42:33 [INFO] [stderr] | [INFO] [stderr] 42 | duration.as_secs() as f64 + (duration.subsec_nanos() as f64) / 1_000_000_000.0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.67s [INFO] running `"docker" "inspect" "d25536fcb747af4cf02d0ebe14aef21dc0022cba857eadb957d091e7c91c1818"` [INFO] running `"docker" "rm" "-f" "d25536fcb747af4cf02d0ebe14aef21dc0022cba857eadb957d091e7c91c1818"` [INFO] [stdout] d25536fcb747af4cf02d0ebe14aef21dc0022cba857eadb957d091e7c91c1818