[INFO] crate equuleus 0.1.0 is already in cache [INFO] extracting crate equuleus 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/equuleus/0.1.0 [INFO] extracting crate equuleus 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/equuleus/0.1.0 [INFO] validating manifest of equuleus-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of equuleus-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing equuleus-0.1.0 [INFO] finished frobbing equuleus-0.1.0 [INFO] frobbed toml for equuleus-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/equuleus/0.1.0/Cargo.toml [INFO] started frobbing equuleus-0.1.0 [INFO] finished frobbing equuleus-0.1.0 [INFO] frobbed toml for equuleus-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/equuleus/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting equuleus-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/equuleus/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bd4439812b9b6c7ced74f1adf5d1085f6867963d0439b8fabe41cb3fdefee8b0 [INFO] running `"docker" "start" "-a" "bd4439812b9b6c7ced74f1adf5d1085f6867963d0439b8fabe41cb3fdefee8b0"` [INFO] [stderr] Checking equuleus v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tty.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | slave: slave, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slave` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tty.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | slave: slave, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `slave` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/app.rs:11:21 [INFO] [stderr] | [INFO] [stderr] 11 | pub const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/app.rs:12:18 [INFO] [stderr] | [INFO] [stderr] 12 | pub const NAME: &'static str = env!("CARGO_PKG_NAME"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/app.rs:13:25 [INFO] [stderr] | [INFO] [stderr] 13 | pub const DESCRIPTION: &'static str = env!("CARGO_PKG_DESCRIPTION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/app.rs:14:22 [INFO] [stderr] | [INFO] [stderr] 14 | pub const HOMEPAGE: &'static str = env!("CARGO_PKG_HOMEPAGE"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/app.rs:15:21 [INFO] [stderr] | [INFO] [stderr] 15 | pub const AUTHORS: &'static str = env!("CARGO_PKG_AUTHORS"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/app.rs:16:20 [INFO] [stderr] | [INFO] [stderr] 16 | pub const BANNER: &'static str = include_str!("banner.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tty.rs:15:91 [INFO] [stderr] | [INFO] [stderr] 15 | pub static ref BaudRate: Vec = vec![1200, 2400, 4800, 9600, 19200, 38400, 57600, 115200]; [INFO] [stderr] | ^^^^^^ help: consider: `115_200` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/app.rs:11:21 [INFO] [stderr] | [INFO] [stderr] 11 | pub const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/app.rs:12:18 [INFO] [stderr] | [INFO] [stderr] 12 | pub const NAME: &'static str = env!("CARGO_PKG_NAME"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/app.rs:13:25 [INFO] [stderr] | [INFO] [stderr] 13 | pub const DESCRIPTION: &'static str = env!("CARGO_PKG_DESCRIPTION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/app.rs:14:22 [INFO] [stderr] | [INFO] [stderr] 14 | pub const HOMEPAGE: &'static str = env!("CARGO_PKG_HOMEPAGE"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/app.rs:15:21 [INFO] [stderr] | [INFO] [stderr] 15 | pub const AUTHORS: &'static str = env!("CARGO_PKG_AUTHORS"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/app.rs:16:20 [INFO] [stderr] | [INFO] [stderr] 16 | pub const BANNER: &'static str = include_str!("banner.txt"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tty.rs:15:91 [INFO] [stderr] | [INFO] [stderr] 15 | pub static ref BaudRate: Vec = vec![1200, 2400, 4800, 9600, 19200, 38400, 57600, 115200]; [INFO] [stderr] | ^^^^^^ help: consider: `115_200` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/app.rs:165:30 [INFO] [stderr] | [INFO] [stderr] 165 | settings.baud_rate = matches [INFO] [stderr] | ______________________________^ [INFO] [stderr] 166 | | .value_of("baud_rate") [INFO] [stderr] 167 | | .unwrap_or("9600") [INFO] [stderr] 168 | | .parse::() [INFO] [stderr] 169 | | .unwrap() [INFO] [stderr] 170 | | .into(); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 165 | settings.baud_rate = matches [INFO] [stderr] 166 | .value_of("baud_rate") [INFO] [stderr] 167 | .unwrap_or("9600") [INFO] [stderr] 168 | .parse::() [INFO] [stderr] 169 | .unwrap(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/tty.rs:118:11 [INFO] [stderr] | [INFO] [stderr] 118 | name: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/tty.rs:156:11 [INFO] [stderr] | [INFO] [stderr] 156 | name: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/app.rs:165:30 [INFO] [stderr] | [INFO] [stderr] 165 | settings.baud_rate = matches [INFO] [stderr] | ______________________________^ [INFO] [stderr] 166 | | .value_of("baud_rate") [INFO] [stderr] 167 | | .unwrap_or("9600") [INFO] [stderr] 168 | | .parse::() [INFO] [stderr] 169 | | .unwrap() [INFO] [stderr] 170 | | .into(); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into()` [INFO] [stderr] | [INFO] [stderr] 165 | settings.baud_rate = matches [INFO] [stderr] 166 | .value_of("baud_rate") [INFO] [stderr] 167 | .unwrap_or("9600") [INFO] [stderr] 168 | .parse::() [INFO] [stderr] 169 | .unwrap(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/tty.rs:118:11 [INFO] [stderr] | [INFO] [stderr] 118 | name: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/tty.rs:156:11 [INFO] [stderr] | [INFO] [stderr] 156 | name: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.10s [INFO] running `"docker" "inspect" "bd4439812b9b6c7ced74f1adf5d1085f6867963d0439b8fabe41cb3fdefee8b0"` [INFO] running `"docker" "rm" "-f" "bd4439812b9b6c7ced74f1adf5d1085f6867963d0439b8fabe41cb3fdefee8b0"` [INFO] [stdout] bd4439812b9b6c7ced74f1adf5d1085f6867963d0439b8fabe41cb3fdefee8b0