[INFO] crate epitech_api 0.1.15 is already in cache [INFO] extracting crate epitech_api 0.1.15 into work/ex/clippy-test-run/sources/stable/reg/epitech_api/0.1.15 [INFO] extracting crate epitech_api 0.1.15 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/epitech_api/0.1.15 [INFO] validating manifest of epitech_api-0.1.15 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of epitech_api-0.1.15 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing epitech_api-0.1.15 [INFO] finished frobbing epitech_api-0.1.15 [INFO] frobbed toml for epitech_api-0.1.15 written to work/ex/clippy-test-run/sources/stable/reg/epitech_api/0.1.15/Cargo.toml [INFO] started frobbing epitech_api-0.1.15 [INFO] finished frobbing epitech_api-0.1.15 [INFO] frobbed toml for epitech_api-0.1.15 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/epitech_api/0.1.15/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting epitech_api-0.1.15 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/epitech_api/0.1.15:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ce5f3066d7308bd4b785d35b4071ced0169801f394044f509ad7fedd160d5d08 [INFO] running `"docker" "start" "-a" "ce5f3066d7308bd4b785d35b4071ced0169801f394044f509ad7fedd160d5d08"` [INFO] [stderr] Checking epitech_api v0.1.15 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `EpitechClientBuilder` [INFO] [stderr] --> src/lib.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | / pub fn new() -> EpitechClientBuilder { [INFO] [stderr] 94 | | EpitechClientBuilder { [INFO] [stderr] 95 | | autologin: String::default(), [INFO] [stderr] 96 | | retry_count: 5, [INFO] [stderr] 97 | | } [INFO] [stderr] 98 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:101:22 [INFO] [stderr] | [INFO] [stderr] 101 | pub fn autologin<'a, T: Into>(mut self, autologin: T) -> EpitechClientBuilder { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:177:37 [INFO] [stderr] | [INFO] [stderr] 177 | let b = string.contains("?"); [INFO] [stderr] | ^^^ help: try using a char instead: `'?'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `StudentListFetchBuilder` [INFO] [stderr] --> src/lib.rs:299:5 [INFO] [stderr] | [INFO] [stderr] 299 | / pub fn new() -> StudentListFetchBuilder { [INFO] [stderr] 300 | | StudentListFetchBuilder { [INFO] [stderr] 301 | | client: EpitechClient::default(), [INFO] [stderr] 302 | | location: None, [INFO] [stderr] ... | [INFO] [stderr] 308 | | } [INFO] [stderr] 309 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 70 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `StudentDataFetchBuilder` [INFO] [stderr] --> src/lib.rs:387:5 [INFO] [stderr] | [INFO] [stderr] 387 | / pub fn new() -> StudentDataFetchBuilder { [INFO] [stderr] 388 | | StudentDataFetchBuilder { [INFO] [stderr] 389 | | client: EpitechClient::default(), [INFO] [stderr] 390 | | login: None, [INFO] [stderr] 391 | | } [INFO] [stderr] 392 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 81 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:406:19 [INFO] [stderr] | [INFO] [stderr] 406 | pub fn client<'a>(mut self, client: EpitechClient) -> StudentDataFetchBuilder { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:482:19 [INFO] [stderr] | [INFO] [stderr] 482 | let ret = constants::LOCATION_TABLE [INFO] [stderr] | ___________________^ [INFO] [stderr] 483 | | .get(self) [INFO] [stderr] 484 | | .map(|val| *val) [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 482 | let ret = constants::LOCATION_TABLE [INFO] [stderr] 483 | .get(self).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:504:19 [INFO] [stderr] | [INFO] [stderr] 504 | let ret = constants::PROMO_TABLE [INFO] [stderr] | ___________________^ [INFO] [stderr] 505 | | .get(self) [INFO] [stderr] 506 | | .map(|val| *val) [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 504 | let ret = constants::PROMO_TABLE [INFO] [stderr] 505 | .get(self).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/lib.rs:593:34 [INFO] [stderr] | [INFO] [stderr] 593 | list.append(&mut ret.unwrap_or(Vec::default())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ret.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:596:17 [INFO] [stderr] | [INFO] [stderr] 596 | assert!(list.len() != 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!list.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `EpitechClientBuilder` [INFO] [stderr] --> src/lib.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | / pub fn new() -> EpitechClientBuilder { [INFO] [stderr] 94 | | EpitechClientBuilder { [INFO] [stderr] 95 | | autologin: String::default(), [INFO] [stderr] 96 | | retry_count: 5, [INFO] [stderr] 97 | | } [INFO] [stderr] 98 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:101:22 [INFO] [stderr] | [INFO] [stderr] 101 | pub fn autologin<'a, T: Into>(mut self, autologin: T) -> EpitechClientBuilder { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:177:37 [INFO] [stderr] | [INFO] [stderr] 177 | let b = string.contains("?"); [INFO] [stderr] | ^^^ help: try using a char instead: `'?'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `StudentListFetchBuilder` [INFO] [stderr] --> src/lib.rs:299:5 [INFO] [stderr] | [INFO] [stderr] 299 | / pub fn new() -> StudentListFetchBuilder { [INFO] [stderr] 300 | | StudentListFetchBuilder { [INFO] [stderr] 301 | | client: EpitechClient::default(), [INFO] [stderr] 302 | | location: None, [INFO] [stderr] ... | [INFO] [stderr] 308 | | } [INFO] [stderr] 309 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 70 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `StudentDataFetchBuilder` [INFO] [stderr] --> src/lib.rs:387:5 [INFO] [stderr] | [INFO] [stderr] 387 | / pub fn new() -> StudentDataFetchBuilder { [INFO] [stderr] 388 | | StudentDataFetchBuilder { [INFO] [stderr] 389 | | client: EpitechClient::default(), [INFO] [stderr] 390 | | login: None, [INFO] [stderr] 391 | | } [INFO] [stderr] 392 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 81 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:406:19 [INFO] [stderr] | [INFO] [stderr] 406 | pub fn client<'a>(mut self, client: EpitechClient) -> StudentDataFetchBuilder { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:482:19 [INFO] [stderr] | [INFO] [stderr] 482 | let ret = constants::LOCATION_TABLE [INFO] [stderr] | ___________________^ [INFO] [stderr] 483 | | .get(self) [INFO] [stderr] 484 | | .map(|val| *val) [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 482 | let ret = constants::LOCATION_TABLE [INFO] [stderr] 483 | .get(self).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:504:19 [INFO] [stderr] | [INFO] [stderr] 504 | let ret = constants::PROMO_TABLE [INFO] [stderr] | ___________________^ [INFO] [stderr] 505 | | .get(self) [INFO] [stderr] 506 | | .map(|val| *val) [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 504 | let ret = constants::PROMO_TABLE [INFO] [stderr] 505 | .get(self).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.56s [INFO] running `"docker" "inspect" "ce5f3066d7308bd4b785d35b4071ced0169801f394044f509ad7fedd160d5d08"` [INFO] running `"docker" "rm" "-f" "ce5f3066d7308bd4b785d35b4071ced0169801f394044f509ad7fedd160d5d08"` [INFO] [stdout] ce5f3066d7308bd4b785d35b4071ced0169801f394044f509ad7fedd160d5d08