[INFO] crate environmental 1.0.0 is already in cache [INFO] extracting crate environmental 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/environmental/1.0.0 [INFO] extracting crate environmental 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/environmental/1.0.0 [INFO] validating manifest of environmental-1.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of environmental-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing environmental-1.0.0 [INFO] finished frobbing environmental-1.0.0 [INFO] frobbed toml for environmental-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/environmental/1.0.0/Cargo.toml [INFO] started frobbing environmental-1.0.0 [INFO] finished frobbing environmental-1.0.0 [INFO] frobbed toml for environmental-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/environmental/1.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting environmental-1.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/environmental/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1e636e8c2ceee223f9ad79aff12e7aa84b9e18406f3f6a1c7d4d67800bd222d4 [INFO] running `"docker" "start" "-a" "1e636e8c2ceee223f9ad79aff12e7aa84b9e18406f3f6a1c7d4d67800bd222d4"` [INFO] [stderr] Checking environmental v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/lib.rs:346:16 [INFO] [stderr] | [INFO] [stderr] 346 | self.iter().fold(0, |a, c| a + c) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/lib.rs:370:16 [INFO] [stderr] | [INFO] [stderr] 370 | self.iter().fold(1, |a, c| a * c) + P::plus42() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/lib.rs:236:6 [INFO] [stderr] | [INFO] [stderr] 236 | $crate::imp::transmute::<&mut $t, &mut ($t<$concretetype> + 'static)>(protected) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(protected as *mut dyn tests::use_generic_trait::Multiplier as *mut (dyn tests::use_generic_trait::Multiplier + 'static))` [INFO] [stderr] ... [INFO] [stderr] 381 | environmental!(foo: trait Multiplier); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.72s [INFO] running `"docker" "inspect" "1e636e8c2ceee223f9ad79aff12e7aa84b9e18406f3f6a1c7d4d67800bd222d4"` [INFO] running `"docker" "rm" "-f" "1e636e8c2ceee223f9ad79aff12e7aa84b9e18406f3f6a1c7d4d67800bd222d4"` [INFO] [stdout] 1e636e8c2ceee223f9ad79aff12e7aa84b9e18406f3f6a1c7d4d67800bd222d4