[INFO] crate enum-kinds-macros 0.2.1 is already in cache [INFO] extracting crate enum-kinds-macros 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/enum-kinds-macros/0.2.1 [INFO] extracting crate enum-kinds-macros 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/enum-kinds-macros/0.2.1 [INFO] validating manifest of enum-kinds-macros-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of enum-kinds-macros-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing enum-kinds-macros-0.2.1 [INFO] finished frobbing enum-kinds-macros-0.2.1 [INFO] frobbed toml for enum-kinds-macros-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/enum-kinds-macros/0.2.1/Cargo.toml [INFO] started frobbing enum-kinds-macros-0.2.1 [INFO] finished frobbing enum-kinds-macros-0.2.1 [INFO] frobbed toml for enum-kinds-macros-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/enum-kinds-macros/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting enum-kinds-macros-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/enum-kinds-macros/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f7a324abca2e2c2270eb05e9a8ca86d9c91ca5290b8e5c03ad5bcb4ce6ed47f8 [INFO] running `"docker" "start" "-a" "f7a324abca2e2c2270eb05e9a8ca86d9c91ca5290b8e5c03ad5bcb4ce6ed47f8"` [INFO] [stderr] Checking enum-kinds-traits v0.1.2 [INFO] [stderr] Compiling enum-kinds-macros v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:73:33 [INFO] [stderr] | [INFO] [stderr] 73 | return Some(ident.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:84:59 [INFO] [stderr] | [INFO] [stderr] 84 | fn create_kind_enum(definition: &DeriveInput, kind_ident: &Ident) -> Tokens { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:85:26 [INFO] [stderr] | [INFO] [stderr] 85 | let variant_idents = match &definition.data { [INFO] [stderr] | __________________________^ [INFO] [stderr] 86 | | &Data::Enum(DataEnum { ref variants, .. }) => { [INFO] [stderr] 87 | | variants.iter().map(|ref v| v.ident.clone()) [INFO] [stderr] 88 | | } [INFO] [stderr] ... | [INFO] [stderr] 91 | | } [INFO] [stderr] 92 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 85 | let variant_idents = match definition.data { [INFO] [stderr] 86 | Data::Enum(DataEnum { ref variants, .. }) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:87:41 [INFO] [stderr] | [INFO] [stderr] 87 | variants.iter().map(|ref v| v.ident.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `v.ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:104:54 [INFO] [stderr] | [INFO] [stderr] 104 | fn create_impl(definition: &DeriveInput, kind_ident: &Ident) -> Tokens { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:108:16 [INFO] [stderr] | [INFO] [stderr] 108 | let arms = match &definition.data { [INFO] [stderr] | ________________^ [INFO] [stderr] 109 | | &Data::Enum(DataEnum { ref variants, .. }) => { [INFO] [stderr] 110 | | variants.iter().map(|ref v| { [INFO] [stderr] 111 | | let variant = &v.ident; [INFO] [stderr] ... | [INFO] [stderr] 127 | | } [INFO] [stderr] 128 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 108 | let arms = match definition.data { [INFO] [stderr] 109 | Data::Enum(DataEnum { ref variants, .. }) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:73:33 [INFO] [stderr] | [INFO] [stderr] 73 | return Some(ident.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:84:59 [INFO] [stderr] | [INFO] [stderr] 84 | fn create_kind_enum(definition: &DeriveInput, kind_ident: &Ident) -> Tokens { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:85:26 [INFO] [stderr] | [INFO] [stderr] 85 | let variant_idents = match &definition.data { [INFO] [stderr] | __________________________^ [INFO] [stderr] 86 | | &Data::Enum(DataEnum { ref variants, .. }) => { [INFO] [stderr] 87 | | variants.iter().map(|ref v| v.ident.clone()) [INFO] [stderr] 88 | | } [INFO] [stderr] ... | [INFO] [stderr] 91 | | } [INFO] [stderr] 92 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 85 | let variant_idents = match definition.data { [INFO] [stderr] 86 | Data::Enum(DataEnum { ref variants, .. }) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:87:41 [INFO] [stderr] | [INFO] [stderr] 87 | variants.iter().map(|ref v| v.ident.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `v.ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:104:54 [INFO] [stderr] | [INFO] [stderr] 104 | fn create_impl(definition: &DeriveInput, kind_ident: &Ident) -> Tokens { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:108:16 [INFO] [stderr] | [INFO] [stderr] 108 | let arms = match &definition.data { [INFO] [stderr] | ________________^ [INFO] [stderr] 109 | | &Data::Enum(DataEnum { ref variants, .. }) => { [INFO] [stderr] 110 | | variants.iter().map(|ref v| { [INFO] [stderr] 111 | | let variant = &v.ident; [INFO] [stderr] ... | [INFO] [stderr] 127 | | } [INFO] [stderr] 128 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 108 | let arms = match definition.data { [INFO] [stderr] 109 | Data::Enum(DataEnum { ref variants, .. }) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> tests/kinds.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | let foo = NamedEnum::Foo { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.29s [INFO] running `"docker" "inspect" "f7a324abca2e2c2270eb05e9a8ca86d9c91ca5290b8e5c03ad5bcb4ce6ed47f8"` [INFO] running `"docker" "rm" "-f" "f7a324abca2e2c2270eb05e9a8ca86d9c91ca5290b8e5c03ad5bcb4ce6ed47f8"` [INFO] [stdout] f7a324abca2e2c2270eb05e9a8ca86d9c91ca5290b8e5c03ad5bcb4ce6ed47f8