[INFO] crate enum-error-derive 0.1.1 is already in cache [INFO] extracting crate enum-error-derive 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/enum-error-derive/0.1.1 [INFO] extracting crate enum-error-derive 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/enum-error-derive/0.1.1 [INFO] validating manifest of enum-error-derive-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of enum-error-derive-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing enum-error-derive-0.1.1 [INFO] finished frobbing enum-error-derive-0.1.1 [INFO] frobbed toml for enum-error-derive-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/enum-error-derive/0.1.1/Cargo.toml [INFO] started frobbing enum-error-derive-0.1.1 [INFO] finished frobbing enum-error-derive-0.1.1 [INFO] frobbed toml for enum-error-derive-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/enum-error-derive/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting enum-error-derive-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/enum-error-derive/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ef2d5d964d952e334e7a8a9a2fb668e8618ab70c90f03e6c34e4d1c2139a85d8 [INFO] running `"docker" "start" "-a" "ef2d5d964d952e334e7a8a9a2fb668e8618ab70c90f03e6c34e4d1c2139a85d8"` [INFO] [stderr] Compiling enum-error-derive v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:17:50 [INFO] [stderr] | [INFO] [stderr] 17 | fn impl_from_traits(name: &syn::Ident, variants: &Vec) -> quote::Tokens { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[syn::Variant]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:38:44 [INFO] [stderr] | [INFO] [stderr] 38 | fn impl_error(name: &syn::Ident, variants: &Vec) -> quote::Tokens { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[syn::Variant]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:55:46 [INFO] [stderr] | [INFO] [stderr] 55 | fn impl_display(name: &syn::Ident, variants: &Vec) -> quote::Tokens { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[syn::Variant]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | let ref variants = match ast.body { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 74 | let variants = &(match ast.body { [INFO] [stderr] 75 | syn::Body::Enum(ref variants) => variants, [INFO] [stderr] 76 | syn::Body::Struct(_) => unreachable!(), [INFO] [stderr] 77 | }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:17:50 [INFO] [stderr] | [INFO] [stderr] 17 | fn impl_from_traits(name: &syn::Ident, variants: &Vec) -> quote::Tokens { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[syn::Variant]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:38:44 [INFO] [stderr] | [INFO] [stderr] 38 | fn impl_error(name: &syn::Ident, variants: &Vec) -> quote::Tokens { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[syn::Variant]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:55:46 [INFO] [stderr] | [INFO] [stderr] 55 | fn impl_display(name: &syn::Ident, variants: &Vec) -> quote::Tokens { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[syn::Variant]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | let ref variants = match ast.body { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 74 | let variants = &(match ast.body { [INFO] [stderr] 75 | syn::Body::Enum(ref variants) => variants, [INFO] [stderr] 76 | syn::Body::Struct(_) => unreachable!(), [INFO] [stderr] 77 | }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.26s [INFO] running `"docker" "inspect" "ef2d5d964d952e334e7a8a9a2fb668e8618ab70c90f03e6c34e4d1c2139a85d8"` [INFO] running `"docker" "rm" "-f" "ef2d5d964d952e334e7a8a9a2fb668e8618ab70c90f03e6c34e4d1c2139a85d8"` [INFO] [stdout] ef2d5d964d952e334e7a8a9a2fb668e8618ab70c90f03e6c34e4d1c2139a85d8