[INFO] crate entity_store_helper 0.15.0 is already in cache
[INFO] extracting crate entity_store_helper 0.15.0 into work/ex/clippy-test-run/sources/stable/reg/entity_store_helper/0.15.0
[INFO] extracting crate entity_store_helper 0.15.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/entity_store_helper/0.15.0
[INFO] validating manifest of entity_store_helper-0.15.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of entity_store_helper-0.15.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing entity_store_helper-0.15.0
[INFO] finished frobbing entity_store_helper-0.15.0
[INFO] frobbed toml for entity_store_helper-0.15.0 written to work/ex/clippy-test-run/sources/stable/reg/entity_store_helper/0.15.0/Cargo.toml
[INFO] started frobbing entity_store_helper-0.15.0
[INFO] finished frobbing entity_store_helper-0.15.0
[INFO] frobbed toml for entity_store_helper-0.15.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/entity_store_helper/0.15.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting entity_store_helper-0.15.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/entity_store_helper/0.15.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 758752feb2987cffa379f9c63570db787985406c1de13edfe4919eafb9d61a15
[INFO] running `"docker" "start" "-a" "758752feb2987cffa379f9c63570db787985406c1de13edfe4919eafb9d61a15"`
[INFO] [stderr]     Checking grid_2d v0.8.0
[INFO] [stderr]     Checking direction v0.15.1
[INFO] [stderr]     Checking entity_store_helper v0.15.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/neighbour_count.rs:28:16
[INFO] [stderr]    |
[INFO] [stderr] 28 |     pub fn get(&self, direction: Direction) -> u8 {
[INFO] [stderr]    |                ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/neighbour_count.rs:32:16
[INFO] [stderr]    |
[INFO] [stderr] 32 |     pub fn has(&self, direction: Direction) -> bool {
[INFO] [stderr]    |                ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/neighbour_count.rs:36:23
[INFO] [stderr]    |
[INFO] [stderr] 36 |     pub fn bitmap_raw(&self) -> u8 {
[INFO] [stderr]    |                       ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `((self.neighbours[0] != 0) as u8)`
[INFO] [stderr]   --> src/neighbour_count.rs:37:9
[INFO] [stderr]    |
[INFO] [stderr] 37 |         (((self.neighbours[0] != 0) as u8) << 0) |
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/neighbour_count.rs:47:19
[INFO] [stderr]    |
[INFO] [stderr] 47 |     pub fn bitmap(&self) -> DirectionBitmap {
[INFO] [stderr]    |                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `id_allocator::IdAllocator<T>`
[INFO] [stderr]   --> src/id_allocator.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 | /     pub fn new() -> Self {
[INFO] [stderr] 11 | |         Self {
[INFO] [stderr] 12 | |             next: T::zero(),
[INFO] [stderr] 13 | |             free_list: Vec::new(),
[INFO] [stderr] 14 | |         }
[INFO] [stderr] 15 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 9  | impl Default for id_allocator::IdAllocator<T> {
[INFO] [stderr] 10 |     fn default() -> Self {
[INFO] [stderr] 11 |         Self::new()
[INFO] [stderr] 12 |     }
[INFO] [stderr] 13 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/neighbour_count.rs:28:16
[INFO] [stderr]    |
[INFO] [stderr] 28 |     pub fn get(&self, direction: Direction) -> u8 {
[INFO] [stderr]    |                ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/neighbour_count.rs:32:16
[INFO] [stderr]    |
[INFO] [stderr] 32 |     pub fn has(&self, direction: Direction) -> bool {
[INFO] [stderr]    |                ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/neighbour_count.rs:36:23
[INFO] [stderr]    |
[INFO] [stderr] 36 |     pub fn bitmap_raw(&self) -> u8 {
[INFO] [stderr]    |                       ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `((self.neighbours[0] != 0) as u8)`
[INFO] [stderr]   --> src/neighbour_count.rs:37:9
[INFO] [stderr]    |
[INFO] [stderr] 37 |         (((self.neighbours[0] != 0) as u8) << 0) |
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/neighbour_count.rs:47:19
[INFO] [stderr]    |
[INFO] [stderr] 47 |     pub fn bitmap(&self) -> DirectionBitmap {
[INFO] [stderr]    |                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `id_allocator::IdAllocator<T>`
[INFO] [stderr]   --> src/id_allocator.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 | /     pub fn new() -> Self {
[INFO] [stderr] 11 | |         Self {
[INFO] [stderr] 12 | |             next: T::zero(),
[INFO] [stderr] 13 | |             free_list: Vec::new(),
[INFO] [stderr] 14 | |         }
[INFO] [stderr] 15 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 9  | impl Default for id_allocator::IdAllocator<T> {
[INFO] [stderr] 10 |     fn default() -> Self {
[INFO] [stderr] 11 |         Self::new()
[INFO] [stderr] 12 |     }
[INFO] [stderr] 13 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 4.11s
[INFO] running `"docker" "inspect" "758752feb2987cffa379f9c63570db787985406c1de13edfe4919eafb9d61a15"`
[INFO] running `"docker" "rm" "-f" "758752feb2987cffa379f9c63570db787985406c1de13edfe4919eafb9d61a15"`
[INFO] [stdout] 758752feb2987cffa379f9c63570db787985406c1de13edfe4919eafb9d61a15