[INFO] crate enimda 0.4.1 is already in cache [INFO] extracting crate enimda 0.4.1 into work/ex/clippy-test-run/sources/stable/reg/enimda/0.4.1 [INFO] extracting crate enimda 0.4.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/enimda/0.4.1 [INFO] validating manifest of enimda-0.4.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of enimda-0.4.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing enimda-0.4.1 [INFO] finished frobbing enimda-0.4.1 [INFO] frobbed toml for enimda-0.4.1 written to work/ex/clippy-test-run/sources/stable/reg/enimda/0.4.1/Cargo.toml [INFO] started frobbing enimda-0.4.1 [INFO] finished frobbing enimda-0.4.1 [INFO] frobbed toml for enimda-0.4.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/enimda/0.4.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting enimda-0.4.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/enimda/0.4.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b2d139f192bb91b6b9536cd7ab0dec3b7a35f5f110a0a8036e6add49fa15214a [INFO] running `"docker" "start" "-a" "b2d139f192bb91b6b9536cd7ab0dec3b7a35f5f110a0a8036e6add49fa15214a"` [INFO] [stderr] Checking rgb v0.7.2 [INFO] [stderr] Checking gif-dispose v1.0.2 [INFO] [stderr] Checking image-utils v0.2.0 [INFO] [stderr] Checking enimda v0.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/utils.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | let f = x as f32 / len; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/utils.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | let f = x as f32 / len; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/utils.rs:25:15 [INFO] [stderr] | [INFO] [stderr] 25 | -> Result<(f32, ImageBuffer, Vec>), Box> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/utils.rs:29:15 [INFO] [stderr] | [INFO] [stderr] 29 | let mul = match size > 0 && (w > size || h > size) { [INFO] [stderr] | _______________^ [INFO] [stderr] 30 | | true => { [INFO] [stderr] 31 | | conv = conv.resize(size, size, FilterType::Lanczos3); [INFO] [stderr] 32 | | match w > h { [INFO] [stderr] ... | [INFO] [stderr] 37 | | false => 1.0, [INFO] [stderr] 38 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 29 | let mul = if size > 0 && (w > size || h > size) { [INFO] [stderr] 30 | conv = conv.resize(size, size, FilterType::Lanczos3); [INFO] [stderr] 31 | match w > h { [INFO] [stderr] 32 | true => w as f32 / size as f32, [INFO] [stderr] 33 | false => h as f32 / size as f32, [INFO] [stderr] 34 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/utils.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | / match w > h { [INFO] [stderr] 33 | | true => w as f32 / size as f32, [INFO] [stderr] 34 | | false => h as f32 / size as f32, [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if w > h { w as f32 / size as f32 } else { h as f32 / size as f32 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/utils.rs:46:8 [INFO] [stderr] | [INFO] [stderr] 46 | Ok(match limit > 0 { [INFO] [stderr] | ________^ [INFO] [stderr] 47 | | true => { [INFO] [stderr] 48 | | let (w, h) = conv.dimensions(); [INFO] [stderr] 49 | | let rows = slice(w, limit)?; [INFO] [stderr] ... | [INFO] [stderr] 56 | | false => conv.clone(), [INFO] [stderr] 57 | | }) [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 46 | Ok(if limit > 0 { [INFO] [stderr] 47 | let (w, h) = conv.dimensions(); [INFO] [stderr] 48 | let rows = slice(w, limit)?; [INFO] [stderr] 49 | let mut strips: ImageBuffer, Vec> = ImageBuffer::new(rows.len() as u32, h); [INFO] [stderr] 50 | for (i, row) in rows.iter().enumerate() { [INFO] [stderr] 51 | strips.copy_from(&conv.sub_image(*row, 0, 1, h), i as u32, 0); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/utils.rs:114:28 [INFO] [stderr] | [INFO] [stderr] 114 | let diff = match lower != 0.0 { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 115 | | true => upper as f32 / lower as f32, [INFO] [stderr] 116 | | false => delta, [INFO] [stderr] 117 | | }; [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if lower != 0.0 { upper as f32 / lower as f32 } else { delta }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/utils.rs:25:15 [INFO] [stderr] | [INFO] [stderr] 25 | -> Result<(f32, ImageBuffer, Vec>), Box> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/utils.rs:29:15 [INFO] [stderr] | [INFO] [stderr] 29 | let mul = match size > 0 && (w > size || h > size) { [INFO] [stderr] | _______________^ [INFO] [stderr] 30 | | true => { [INFO] [stderr] 31 | | conv = conv.resize(size, size, FilterType::Lanczos3); [INFO] [stderr] 32 | | match w > h { [INFO] [stderr] ... | [INFO] [stderr] 37 | | false => 1.0, [INFO] [stderr] 38 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 29 | let mul = if size > 0 && (w > size || h > size) { [INFO] [stderr] 30 | conv = conv.resize(size, size, FilterType::Lanczos3); [INFO] [stderr] 31 | match w > h { [INFO] [stderr] 32 | true => w as f32 / size as f32, [INFO] [stderr] 33 | false => h as f32 / size as f32, [INFO] [stderr] 34 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/utils.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | / match w > h { [INFO] [stderr] 33 | | true => w as f32 / size as f32, [INFO] [stderr] 34 | | false => h as f32 / size as f32, [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if w > h { w as f32 / size as f32 } else { h as f32 / size as f32 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/utils.rs:46:8 [INFO] [stderr] | [INFO] [stderr] 46 | Ok(match limit > 0 { [INFO] [stderr] | ________^ [INFO] [stderr] 47 | | true => { [INFO] [stderr] 48 | | let (w, h) = conv.dimensions(); [INFO] [stderr] 49 | | let rows = slice(w, limit)?; [INFO] [stderr] ... | [INFO] [stderr] 56 | | false => conv.clone(), [INFO] [stderr] 57 | | }) [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 46 | Ok(if limit > 0 { [INFO] [stderr] 47 | let (w, h) = conv.dimensions(); [INFO] [stderr] 48 | let rows = slice(w, limit)?; [INFO] [stderr] 49 | let mut strips: ImageBuffer, Vec> = ImageBuffer::new(rows.len() as u32, h); [INFO] [stderr] 50 | for (i, row) in rows.iter().enumerate() { [INFO] [stderr] 51 | strips.copy_from(&conv.sub_image(*row, 0, 1, h), i as u32, 0); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/utils.rs:114:28 [INFO] [stderr] | [INFO] [stderr] 114 | let diff = match lower != 0.0 { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 115 | | true => upper as f32 / lower as f32, [INFO] [stderr] 116 | | false => delta, [INFO] [stderr] 117 | | }; [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if lower != 0.0 { upper as f32 / lower as f32 } else { delta }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.34s [INFO] running `"docker" "inspect" "b2d139f192bb91b6b9536cd7ab0dec3b7a35f5f110a0a8036e6add49fa15214a"` [INFO] running `"docker" "rm" "-f" "b2d139f192bb91b6b9536cd7ab0dec3b7a35f5f110a0a8036e6add49fa15214a"` [INFO] [stdout] b2d139f192bb91b6b9536cd7ab0dec3b7a35f5f110a0a8036e6add49fa15214a