[INFO] crate english-numbers 0.3.3 is already in cache [INFO] extracting crate english-numbers 0.3.3 into work/ex/clippy-test-run/sources/stable/reg/english-numbers/0.3.3 [INFO] extracting crate english-numbers 0.3.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/english-numbers/0.3.3 [INFO] validating manifest of english-numbers-0.3.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of english-numbers-0.3.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing english-numbers-0.3.3 [INFO] finished frobbing english-numbers-0.3.3 [INFO] frobbed toml for english-numbers-0.3.3 written to work/ex/clippy-test-run/sources/stable/reg/english-numbers/0.3.3/Cargo.toml [INFO] started frobbing english-numbers-0.3.3 [INFO] finished frobbing english-numbers-0.3.3 [INFO] frobbed toml for english-numbers-0.3.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/english-numbers/0.3.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting english-numbers-0.3.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/english-numbers/0.3.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0e1c180c079ea38c3afa4afbb6b87caf52dcc627e48d09c9ac2b39e83c48364c [INFO] running `"docker" "start" "-a" "0e1c180c079ea38c3afa4afbb6b87caf52dcc627e48d09c9ac2b39e83c48364c"` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] Checking english-numbers v0.3.3 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/groups.rs:156:29 [INFO] [stderr] | [INFO] [stderr] 156 | (None, None) => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/groups.rs:157:34 [INFO] [stderr] | [INFO] [stderr] 157 | (Some(hun), None) => return Some(hun), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(hun)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/groups.rs:160:17 [INFO] [stderr] | [INFO] [stderr] 160 | return Some(ten) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(ten)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/groups.rs:169:17 [INFO] [stderr] | [INFO] [stderr] 169 | return Some(hun) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(hun)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hundreds.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / return Some(Words::new(vec![Word::Number(match self.0 [INFO] [stderr] 22 | | { [INFO] [stderr] 23 | | 1 => "one", [INFO] [stderr] 24 | | 2 => "two", [INFO] [stderr] ... | [INFO] [stderr] 34 | | Word::Space, [INFO] [stderr] 35 | | Word::Number("hundred".to_owned())])) [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 21 | Some(Words::new(vec![Word::Number(match self.0 [INFO] [stderr] 22 | { [INFO] [stderr] 23 | 1 => "one", [INFO] [stderr] 24 | 2 => "two", [INFO] [stderr] 25 | 3 => "three", [INFO] [stderr] 26 | 4 => "four", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tens.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | / return Some(Words::new(vec![Word::Number(match self.0 * 10 + self.1 [INFO] [stderr] 29 | | { [INFO] [stderr] 30 | | 1 => "one", [INFO] [stderr] 31 | | 2 => "two", [INFO] [stderr] ... | [INFO] [stderr] 49 | | _ => unreachable!() [INFO] [stderr] 50 | | }.to_owned())])) [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 28 | Some(Words::new(vec![Word::Number(match self.0 * 10 + self.1 [INFO] [stderr] 29 | { [INFO] [stderr] 30 | 1 => "one", [INFO] [stderr] 31 | 2 => "two", [INFO] [stderr] 32 | 3 => "three", [INFO] [stderr] 33 | 4 => "four", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tens.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | return Some(Words::new(vec![Word::Number(tens.to_owned())])) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Words::new(vec![Word::Number(tens.to_owned())]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tens.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | / return Some(Words::new(vec![ [INFO] [stderr] 89 | | Word::Number(tens.to_owned()), [INFO] [stderr] 90 | | Word::Dash, [INFO] [stderr] 91 | | Word::Number(ones.to_owned()) [INFO] [stderr] 92 | | ])) [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 88 | Some(Words::new(vec![ [INFO] [stderr] 89 | Word::Number(tens.to_owned()), [INFO] [stderr] 90 | Word::Dash, [INFO] [stderr] 91 | Word::Number(ones.to_owned()) [INFO] [stderr] 92 | ])) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/groups.rs:26:30 [INFO] [stderr] | [INFO] [stderr] 26 | .map(|chunk| chunk.into_iter() [INFO] [stderr] | ______________________________^ [INFO] [stderr] 27 | | .map(|c| *c) [INFO] [stderr] | |________________________________^ help: Consider calling the dedicated `cloned` method: `chunk.into_iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/groups.rs:26:36 [INFO] [stderr] | [INFO] [stderr] 26 | .map(|chunk| chunk.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/groups.rs:35:22 [INFO] [stderr] | [INFO] [stderr] 35 | .map(|n| Group::new(n)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Group::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/groups.rs:95:12 [INFO] [stderr] | [INFO] [stderr] 95 | if built.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `built.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/groups.rs:186:9 [INFO] [stderr] | [INFO] [stderr] 186 | / match val >= 0 [INFO] [stderr] 187 | | { [INFO] [stderr] 188 | | true => Sign::Positive, [INFO] [stderr] 189 | | false => Sign::Negative [INFO] [stderr] 190 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if val >= 0 { Sign::Positive } else { Sign::Negative }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/words.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | / match self [INFO] [stderr] 45 | | { [INFO] [stderr] 46 | | &Word::Number(ref n) => if fmt.title_case && n.len() > 0 [INFO] [stderr] 47 | | { [INFO] [stderr] ... | [INFO] [stderr] 104 | | } [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 44 | match *self [INFO] [stderr] 45 | { [INFO] [stderr] 46 | Word::Number(ref n) => if fmt.title_case && n.len() > 0 [INFO] [stderr] 47 | { [INFO] [stderr] 48 | let first = n.chars().nth(0).unwrap().to_string().to_uppercase(); [INFO] [stderr] 49 | let last = &n[1..n.len()]; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/words.rs:46:58 [INFO] [stderr] | [INFO] [stderr] 46 | &Word::Number(ref n) => if fmt.title_case && n.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!n.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/groups.rs:156:29 [INFO] [stderr] | [INFO] [stderr] 156 | (None, None) => return None, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/groups.rs:157:34 [INFO] [stderr] | [INFO] [stderr] 157 | (Some(hun), None) => return Some(hun), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(hun)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/groups.rs:160:17 [INFO] [stderr] | [INFO] [stderr] 160 | return Some(ten) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(ten)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/groups.rs:169:17 [INFO] [stderr] | [INFO] [stderr] 169 | return Some(hun) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(hun)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hundreds.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / return Some(Words::new(vec![Word::Number(match self.0 [INFO] [stderr] 22 | | { [INFO] [stderr] 23 | | 1 => "one", [INFO] [stderr] 24 | | 2 => "two", [INFO] [stderr] ... | [INFO] [stderr] 34 | | Word::Space, [INFO] [stderr] 35 | | Word::Number("hundred".to_owned())])) [INFO] [stderr] | |_____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 21 | Some(Words::new(vec![Word::Number(match self.0 [INFO] [stderr] 22 | { [INFO] [stderr] 23 | 1 => "one", [INFO] [stderr] 24 | 2 => "two", [INFO] [stderr] 25 | 3 => "three", [INFO] [stderr] 26 | 4 => "four", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tens.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | / return Some(Words::new(vec![Word::Number(match self.0 * 10 + self.1 [INFO] [stderr] 29 | | { [INFO] [stderr] 30 | | 1 => "one", [INFO] [stderr] 31 | | 2 => "two", [INFO] [stderr] ... | [INFO] [stderr] 49 | | _ => unreachable!() [INFO] [stderr] 50 | | }.to_owned())])) [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 28 | Some(Words::new(vec![Word::Number(match self.0 * 10 + self.1 [INFO] [stderr] 29 | { [INFO] [stderr] 30 | 1 => "one", [INFO] [stderr] 31 | 2 => "two", [INFO] [stderr] 32 | 3 => "three", [INFO] [stderr] 33 | 4 => "four", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tens.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | return Some(Words::new(vec![Word::Number(tens.to_owned())])) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Words::new(vec![Word::Number(tens.to_owned())]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tens.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | / return Some(Words::new(vec![ [INFO] [stderr] 89 | | Word::Number(tens.to_owned()), [INFO] [stderr] 90 | | Word::Dash, [INFO] [stderr] 91 | | Word::Number(ones.to_owned()) [INFO] [stderr] 92 | | ])) [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 88 | Some(Words::new(vec![ [INFO] [stderr] 89 | Word::Number(tens.to_owned()), [INFO] [stderr] 90 | Word::Dash, [INFO] [stderr] 91 | Word::Number(ones.to_owned()) [INFO] [stderr] 92 | ])) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:89:44 [INFO] [stderr] | [INFO] [stderr] 89 | let g9223372036854775807 = Groups::new(9223372036854775807); // i64::MAX [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:112:28 [INFO] [stderr] | [INFO] [stderr] 112 | assert_eq!(Groups::new(1000000).build(true).build(Formatting::all()), "One Milliard"); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:113:28 [INFO] [stderr] | [INFO] [stderr] 113 | assert_eq!(Groups::new(1000000000).build(true).build(Formatting::all()), "One Million"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:114:28 [INFO] [stderr] | [INFO] [stderr] 114 | assert_eq!(Groups::new(1000000000000).build(true).build(Formatting::all()), "One Thousand Million"); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_000_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:115:28 [INFO] [stderr] | [INFO] [stderr] 115 | assert_eq!(Groups::new(1000000000000000).build(true).build(Formatting::all()), "One Billion"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `1_000_000_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:116:28 [INFO] [stderr] | [INFO] [stderr] 116 | assert_eq!(Groups::new(1000000000000000000).build(true).build(Formatting::all()), "One Thousand Billion"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `1_000_000_000_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:126:32 [INFO] [stderr] | [INFO] [stderr] 126 | assert_eq!(convert_all_fmt(100000), "One Hundred Thousand"); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:127:32 [INFO] [stderr] | [INFO] [stderr] 127 | assert_eq!(convert_all_fmt(1000000), "One Million"); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/groups.rs:26:30 [INFO] [stderr] | [INFO] [stderr] 26 | .map(|chunk| chunk.into_iter() [INFO] [stderr] | ______________________________^ [INFO] [stderr] 27 | | .map(|c| *c) [INFO] [stderr] | |________________________________^ help: Consider calling the dedicated `cloned` method: `chunk.into_iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/groups.rs:26:36 [INFO] [stderr] | [INFO] [stderr] 26 | .map(|chunk| chunk.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/groups.rs:35:22 [INFO] [stderr] | [INFO] [stderr] 35 | .map(|n| Group::new(n)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Group::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/groups.rs:95:12 [INFO] [stderr] | [INFO] [stderr] 95 | if built.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `built.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/groups.rs:186:9 [INFO] [stderr] | [INFO] [stderr] 186 | / match val >= 0 [INFO] [stderr] 187 | | { [INFO] [stderr] 188 | | true => Sign::Positive, [INFO] [stderr] 189 | | false => Sign::Negative [INFO] [stderr] 190 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if val >= 0 { Sign::Positive } else { Sign::Negative }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/words.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | / match self [INFO] [stderr] 45 | | { [INFO] [stderr] 46 | | &Word::Number(ref n) => if fmt.title_case && n.len() > 0 [INFO] [stderr] 47 | | { [INFO] [stderr] ... | [INFO] [stderr] 104 | | } [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 44 | match *self [INFO] [stderr] 45 | { [INFO] [stderr] 46 | Word::Number(ref n) => if fmt.title_case && n.len() > 0 [INFO] [stderr] 47 | { [INFO] [stderr] 48 | let first = n.chars().nth(0).unwrap().to_string().to_uppercase(); [INFO] [stderr] 49 | let last = &n[1..n.len()]; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/words.rs:46:58 [INFO] [stderr] | [INFO] [stderr] 46 | &Word::Number(ref n) => if fmt.title_case && n.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!n.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.69s [INFO] running `"docker" "inspect" "0e1c180c079ea38c3afa4afbb6b87caf52dcc627e48d09c9ac2b39e83c48364c"` [INFO] running `"docker" "rm" "-f" "0e1c180c079ea38c3afa4afbb6b87caf52dcc627e48d09c9ac2b39e83c48364c"` [INFO] [stdout] 0e1c180c079ea38c3afa4afbb6b87caf52dcc627e48d09c9ac2b39e83c48364c