[INFO] crate engiffen 0.8.1 is already in cache [INFO] extracting crate engiffen 0.8.1 into work/ex/clippy-test-run/sources/stable/reg/engiffen/0.8.1 [INFO] extracting crate engiffen 0.8.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/engiffen/0.8.1 [INFO] validating manifest of engiffen-0.8.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of engiffen-0.8.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing engiffen-0.8.1 [INFO] finished frobbing engiffen-0.8.1 [INFO] frobbed toml for engiffen-0.8.1 written to work/ex/clippy-test-run/sources/stable/reg/engiffen/0.8.1/Cargo.toml [INFO] started frobbing engiffen-0.8.1 [INFO] finished frobbing engiffen-0.8.1 [INFO] frobbed toml for engiffen-0.8.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/engiffen/0.8.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting engiffen-0.8.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/engiffen/0.8.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 223e4e64a96f7e872f33395f88bf9278cb7e191d39cd7d3bff03869a269a4759 [INFO] running `"docker" "start" "-a" "223e4e64a96f7e872f33395f88bf9278cb7e191d39cd7d3bff03869a269a4759"` [INFO] [stderr] Checking lab v0.4.4 [INFO] [stderr] Checking png v0.7.0 [INFO] [stderr] Checking image v0.13.0 [INFO] [stderr] Checking engiffen v0.8.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:210:9 [INFO] [stderr] | [INFO] [stderr] 210 | pixels: pixels, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `pixels` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:283:9 [INFO] [stderr] | [INFO] [stderr] 283 | palette: palette, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `palette` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:284:9 [INFO] [stderr] | [INFO] [stderr] 284 | transparency: transparency, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transparency` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:288:9 [INFO] [stderr] | [INFO] [stderr] 288 | delay: delay, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `delay` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:210:9 [INFO] [stderr] | [INFO] [stderr] 210 | pixels: pixels, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `pixels` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:283:9 [INFO] [stderr] | [INFO] [stderr] 283 | palette: palette, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `palette` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:284:9 [INFO] [stderr] | [INFO] [stderr] 284 | transparency: transparency, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transparency` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:288:9 [INFO] [stderr] | [INFO] [stderr] 288 | delay: delay, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `delay` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:301:13 [INFO] [stderr] | [INFO] [stderr] 301 | / if sample_rate > 1 { [INFO] [stderr] 302 | | if n % sample_rate != 0 || (n / width) % sample_rate != 0 { [INFO] [stderr] 303 | | continue; [INFO] [stderr] 304 | | } [INFO] [stderr] 305 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 301 | if sample_rate > 1 && (n % sample_rate != 0 || (n / width) % sample_rate != 0) { [INFO] [stderr] 302 | continue; [INFO] [stderr] 303 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:301:13 [INFO] [stderr] | [INFO] [stderr] 301 | / if sample_rate > 1 { [INFO] [stderr] 302 | | if n % sample_rate != 0 || (n / width) % sample_rate != 0 { [INFO] [stderr] 303 | | continue; [INFO] [stderr] 304 | | } [INFO] [stderr] 305 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 301 | if sample_rate > 1 && (n % sample_rate != 0 || (n / width) % sample_rate != 0) { [INFO] [stderr] 302 | continue; [INFO] [stderr] 303 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:232:14 [INFO] [stderr] | [INFO] [stderr] 232 | .map(|path| load_image(path)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `load_image` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:264:13 [INFO] [stderr] | [INFO] [stderr] 264 | let ref first = imgs[0]; [INFO] [stderr] | ----^^^^^^^^^----------- help: try: `let first = &imgs[0];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:355:15 [INFO] [stderr] | [INFO] [stderr] 355 | }).reduce(|| FnvHashMap::default(), |mut acc, fr| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `FnvHashMap::default` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:232:14 [INFO] [stderr] | [INFO] [stderr] 232 | .map(|path| load_image(path)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `load_image` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:264:13 [INFO] [stderr] | [INFO] [stderr] 264 | let ref first = imgs[0]; [INFO] [stderr] | ----^^^^^^^^^----------- help: try: `let first = &imgs[0];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:355:15 [INFO] [stderr] | [INFO] [stderr] 355 | }).reduce(|| FnvHashMap::default(), |mut acc, fr| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `FnvHashMap::default` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/lib.rs:455:13 [INFO] [stderr] | [INFO] [stderr] 455 | Err(_) => panic!("Test should have successfully made a gif."), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/lib.rs:474:13 [INFO] [stderr] | [INFO] [stderr] 474 | Err(_) => panic!("Test should have successfully made a gif."), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse_args.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse_args.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | fps: fps, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `fps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse_args.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | out_file: out_file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `out_file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse_args.rs:176:9 [INFO] [stderr] | [INFO] [stderr] 176 | quantizer: quantizer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `quantizer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse_args.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | modifiers: modifiers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `modifiers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse_args.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse_args.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | fps: fps, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `fps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse_args.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | out_file: out_file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `out_file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse_args.rs:176:9 [INFO] [stderr] | [INFO] [stderr] 176 | quantizer: quantizer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `quantizer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse_args.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | modifiers: modifiers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `modifiers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parse_args.rs:159:12 [INFO] [stderr] | [INFO] [stderr] 159 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 160 | | if matches.free.len() == 1 { [INFO] [stderr] 161 | | #[cfg(feature = "globbing")] [INFO] [stderr] 162 | | { [INFO] [stderr] ... | [INFO] [stderr] 169 | | } [INFO] [stderr] 170 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 159 | } else if matches.free.len() == 1 { [INFO] [stderr] 160 | #[cfg(feature = "globbing")] [INFO] [stderr] 161 | { [INFO] [stderr] 162 | glob::Pattern::new(&matches.free[0])?; [INFO] [stderr] 163 | Glob(matches.free[0].clone()) [INFO] [stderr] 164 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:110:83 [INFO] [stderr] | [INFO] [stderr] 110 | let ms = duration.as_secs() * 1000 + duration.subsec_nanos() as u64 / 1000000; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parse_args.rs:159:12 [INFO] [stderr] | [INFO] [stderr] 159 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 160 | | if matches.free.len() == 1 { [INFO] [stderr] 161 | | #[cfg(feature = "globbing")] [INFO] [stderr] 162 | | { [INFO] [stderr] ... | [INFO] [stderr] 169 | | } [INFO] [stderr] 170 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 159 | } else if matches.free.len() == 1 { [INFO] [stderr] 160 | #[cfg(feature = "globbing")] [INFO] [stderr] 161 | { [INFO] [stderr] 162 | glob::Pattern::new(&matches.free[0])?; [INFO] [stderr] 163 | Glob(matches.free[0].clone()) [INFO] [stderr] 164 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:110:83 [INFO] [stderr] | [INFO] [stderr] 110 | let ms = duration.as_secs() * 1000 + duration.subsec_nanos() as u64 / 1000000; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the `m @ _` pattern can be written as just `m` [INFO] [stderr] --> src/parse_args.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | m @ _ => printerr!("Ignoring unknown modifier `{}`", m), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/parse_args.rs:145:20 [INFO] [stderr] | [INFO] [stderr] 145 | let out_file = matches.opt_str("o").map(|f| f.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `matches.opt_str("o").cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/main.rs:65:46 [INFO] [stderr] | [INFO] [stderr] 65 | SourceImages::List(ref list) => list.into_iter().map(PathBuf::from).collect(), [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:110:50 [INFO] [stderr] | [INFO] [stderr] 110 | let ms = duration.as_secs() * 1000 + duration.subsec_nanos() as u64 / 1000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:111:33 [INFO] [stderr] | [INFO] [stderr] 111 | let filename = file.unwrap_or("to stdout".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "to stdout".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the `m @ _` pattern can be written as just `m` [INFO] [stderr] --> src/parse_args.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | m @ _ => printerr!("Ignoring unknown modifier `{}`", m), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/parse_args.rs:145:20 [INFO] [stderr] | [INFO] [stderr] 145 | let out_file = matches.opt_str("o").map(|f| f.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `matches.opt_str("o").cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parse_args.rs:208:20 [INFO] [stderr] | [INFO] [stderr] 208 | args.split(" ").map(|s| s.to_owned()).collect() [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/parse_args.rs:329:13 [INFO] [stderr] | [INFO] [stderr] 329 | Err(_) => panic!("Wrong error type returned"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/main.rs:65:46 [INFO] [stderr] | [INFO] [stderr] 65 | SourceImages::List(ref list) => list.into_iter().map(PathBuf::from).collect(), [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:110:50 [INFO] [stderr] | [INFO] [stderr] 110 | let ms = duration.as_secs() * 1000 + duration.subsec_nanos() as u64 / 1000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:111:33 [INFO] [stderr] | [INFO] [stderr] 111 | let filename = file.unwrap_or("to stdout".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "to stdout".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.74s [INFO] running `"docker" "inspect" "223e4e64a96f7e872f33395f88bf9278cb7e191d39cd7d3bff03869a269a4759"` [INFO] running `"docker" "rm" "-f" "223e4e64a96f7e872f33395f88bf9278cb7e191d39cd7d3bff03869a269a4759"` [INFO] [stdout] 223e4e64a96f7e872f33395f88bf9278cb7e191d39cd7d3bff03869a269a4759