[INFO] crate enet 0.2.0 is already in cache [INFO] extracting crate enet 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/enet/0.2.0 [INFO] extracting crate enet 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/enet/0.2.0 [INFO] validating manifest of enet-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of enet-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing enet-0.2.0 [INFO] finished frobbing enet-0.2.0 [INFO] frobbed toml for enet-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/enet/0.2.0/Cargo.toml [INFO] started frobbing enet-0.2.0 [INFO] finished frobbing enet-0.2.0 [INFO] frobbed toml for enet-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/enet/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting enet-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/enet/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 89bb631a2b6e2eba152b7e3ac3ce8692c5a6628d01c4aec300df8d3c43c1ba83 [INFO] running `"docker" "start" "-a" "89bb631a2b6e2eba152b7e3ac3ce8692c5a6628d01c4aec300df8d3c43c1ba83"` [INFO] [stderr] Compiling bindgen v0.35.0 [INFO] [stderr] Compiling clang-sys v0.22.0 [INFO] [stderr] Compiling enet-sys v0.2.1 [INFO] [stderr] Checking enet v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/address.rs:63:43 [INFO] [stderr] | [INFO] [stderr] 63 | pub(crate) fn from_enet_address(addr: &ENetAddress) -> Address { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `ENetAddress` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `addr.host` [INFO] [stderr] --> src/address.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | (addr.host >> 0) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/event.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | / match self { [INFO] [stderr] 56 | | // Seemingly, the lifetime of an ENetPeer ends with the end of the Disconnect event. [INFO] [stderr] 57 | | // However, this is *not really clear* in the ENet docs! [INFO] [stderr] 58 | | // It looks like the Peer *might* live longer, but not shorter, so it should be safe [INFO] [stderr] ... | [INFO] [stderr] 61 | | _ => (), [INFO] [stderr] 62 | | } [INFO] [stderr] | |_________^ help: try this: `if let Event::Disconnect(peer, _) = self { peer.set_data(None) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/address.rs:63:43 [INFO] [stderr] | [INFO] [stderr] 63 | pub(crate) fn from_enet_address(addr: &ENetAddress) -> Address { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `ENetAddress` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `addr.host` [INFO] [stderr] --> src/address.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | (addr.host >> 0) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/host.rs:49:34 [INFO] [stderr] | [INFO] [stderr] 49 | pub(in crate) fn to_enet_u32(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/event.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | / match self { [INFO] [stderr] 56 | | // Seemingly, the lifetime of an ENetPeer ends with the end of the Disconnect event. [INFO] [stderr] 57 | | // However, this is *not really clear* in the ENet docs! [INFO] [stderr] 58 | | // It looks like the Peer *might* live longer, but not shorter, so it should be safe [INFO] [stderr] ... | [INFO] [stderr] 61 | | _ => (), [INFO] [stderr] 62 | | } [INFO] [stderr] | |_________^ help: try this: `if let Event::Disconnect(peer, _) = self { peer.set_data(None) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the slice [INFO] [stderr] --> src/host.rs:139:19 [INFO] [stderr] | [INFO] [stderr] 139 | raw_peers.into_iter().map(|rp| Peer::new(rp)) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/host.rs:49:34 [INFO] [stderr] | [INFO] [stderr] 49 | pub(in crate) fn to_enet_u32(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/packet.rs:29:24 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn is_reliable(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/packet.rs:38:25 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn is_sequenced(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/packet.rs:46:21 [INFO] [stderr] | [INFO] [stderr] 46 | fn to_sys_flags(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/packet.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | / pub fn data<'a>(&'a self) -> &'a [u8] { [INFO] [stderr] 82 | | unsafe { std::slice::from_raw_parts((*self.inner).data, (*self.inner).dataLength) } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the slice [INFO] [stderr] --> src/host.rs:139:19 [INFO] [stderr] | [INFO] [stderr] 139 | raw_peers.into_iter().map(|rp| Peer::new(rp)) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/packet.rs:29:24 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn is_reliable(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/packet.rs:38:25 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn is_sequenced(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/packet.rs:46:21 [INFO] [stderr] | [INFO] [stderr] 46 | fn to_sys_flags(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/peer.rs:161:31 [INFO] [stderr] | [INFO] [stderr] 161 | Duration::from_millis(unsafe { (*self.inner).roundTripTime } as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(unsafe { (*self.inner).roundTripTime })` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/packet.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | / pub fn data<'a>(&'a self) -> &'a [u8] { [INFO] [stderr] 82 | | unsafe { std::slice::from_raw_parts((*self.inner).data, (*self.inner).dataLength) } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/peer.rs:161:31 [INFO] [stderr] | [INFO] [stderr] 161 | Duration::from_millis(unsafe { (*self.inner).roundTripTime } as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(unsafe { (*self.inner).roundTripTime })` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 40.99s [INFO] running `"docker" "inspect" "89bb631a2b6e2eba152b7e3ac3ce8692c5a6628d01c4aec300df8d3c43c1ba83"` [INFO] running `"docker" "rm" "-f" "89bb631a2b6e2eba152b7e3ac3ce8692c5a6628d01c4aec300df8d3c43c1ba83"` [INFO] [stdout] 89bb631a2b6e2eba152b7e3ac3ce8692c5a6628d01c4aec300df8d3c43c1ba83