[INFO] crate encoding_rs_io 0.1.3 is already in cache [INFO] extracting crate encoding_rs_io 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/encoding_rs_io/0.1.3 [INFO] extracting crate encoding_rs_io 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/encoding_rs_io/0.1.3 [INFO] validating manifest of encoding_rs_io-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of encoding_rs_io-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing encoding_rs_io-0.1.3 [INFO] finished frobbing encoding_rs_io-0.1.3 [INFO] frobbed toml for encoding_rs_io-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/encoding_rs_io/0.1.3/Cargo.toml [INFO] started frobbing encoding_rs_io-0.1.3 [INFO] finished frobbing encoding_rs_io-0.1.3 [INFO] frobbed toml for encoding_rs_io-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/encoding_rs_io/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting encoding_rs_io-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/encoding_rs_io/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b30be80943e9992b40b120890936172f7f939f6099293276d0a684d846c620fd [INFO] running `"docker" "start" "-a" "b30be80943e9992b40b120890936172f7f939f6099293276d0a684d846c620fd"` [INFO] [stderr] Checking encoding_rs_io v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | BomPeeker { rdr: rdr, bom: None, nread: 0 } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rdr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:172:13 [INFO] [stderr] | [INFO] [stderr] 172 | has_detected: has_detected, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `has_detected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | BomPeeker { rdr: rdr, bom: None, nread: 0 } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rdr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:172:13 [INFO] [stderr] | [INFO] [stderr] 172 | has_detected: has_detected, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `has_detected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/util.rs:237:5 [INFO] [stderr] | [INFO] [stderr] 237 | / fn tiny_utf16_normal() { [INFO] [stderr] 238 | | let enc = Encoding::for_label(b"utf-16le").unwrap(); [INFO] [stderr] 239 | | let mut dec = enc.new_decoder_with_bom_removal(); [INFO] [stderr] 240 | | let mut bytes = &b"f\x00o\x00o\x00b\x00a\x00r\x00b\x00a\x00z\x00"[..]; [INFO] [stderr] ... | [INFO] [stderr] 278 | | assert_eq!(tiny.read(&mut tmp).unwrap(), 0); [INFO] [stderr] 279 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:703:47 [INFO] [stderr] | [INFO] [stderr] 703 | let enc = Encoding::for_label($enc.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"does not exist"` [INFO] [stderr] ... [INFO] [stderr] 713 | test_trans_simple!(trans_simple_auto, "does not exist", b"\xD0\x96", "Ж"); [INFO] [stderr] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:703:47 [INFO] [stderr] | [INFO] [stderr] 703 | let enc = Encoding::for_label($enc.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"utf-8"` [INFO] [stderr] ... [INFO] [stderr] 714 | test_trans_simple!(trans_simple_utf8, "utf-8", b"\xD0\x96", "Ж"); [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:703:47 [INFO] [stderr] | [INFO] [stderr] 703 | let enc = Encoding::for_label($enc.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"utf-16le"` [INFO] [stderr] ... [INFO] [stderr] 715 | test_trans_simple!(trans_simple_utf16le, "utf-16le", b"\x16\x04", "Ж"); [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:703:47 [INFO] [stderr] | [INFO] [stderr] 703 | let enc = Encoding::for_label($enc.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"utf-16be"` [INFO] [stderr] ... [INFO] [stderr] 716 | test_trans_simple!(trans_simple_utf16be, "utf-16be", b"\x04\x16", "Ж"); [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:703:47 [INFO] [stderr] | [INFO] [stderr] 703 | let enc = Encoding::for_label($enc.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"chinese"` [INFO] [stderr] ... [INFO] [stderr] 717 | test_trans_simple!(trans_simple_chinese, "chinese", b"\xA7\xA8", "Ж"); [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:703:47 [INFO] [stderr] | [INFO] [stderr] 703 | let enc = Encoding::for_label($enc.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"korean"` [INFO] [stderr] ... [INFO] [stderr] 718 | test_trans_simple!(trans_simple_korean, "korean", b"\xAC\xA8", "Ж"); [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:703:47 [INFO] [stderr] | [INFO] [stderr] 703 | let enc = Encoding::for_label($enc.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"big5-hkscs"` [INFO] [stderr] ... [INFO] [stderr] 719 | / test_trans_simple!( [INFO] [stderr] 720 | | trans_simple_big5_hkscs, "big5-hkscs", b"\xC7\xFA", "Ж"); [INFO] [stderr] | |_________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:703:47 [INFO] [stderr] | [INFO] [stderr] 703 | let enc = Encoding::for_label($enc.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"gbk"` [INFO] [stderr] ... [INFO] [stderr] 721 | test_trans_simple!(trans_simple_gbk, "gbk", b"\xA7\xA8", "Ж"); [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:703:47 [INFO] [stderr] | [INFO] [stderr] 703 | let enc = Encoding::for_label($enc.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"sjis"` [INFO] [stderr] ... [INFO] [stderr] 722 | test_trans_simple!(trans_simple_sjis, "sjis", b"\x84\x47", "Ж"); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:703:47 [INFO] [stderr] | [INFO] [stderr] 703 | let enc = Encoding::for_label($enc.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"euc-jp"` [INFO] [stderr] ... [INFO] [stderr] 723 | test_trans_simple!(trans_simple_eucjp, "euc-jp", b"\xA7\xA8", "Ж"); [INFO] [stderr] | ------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:703:47 [INFO] [stderr] | [INFO] [stderr] 703 | let enc = Encoding::for_label($enc.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"latin1"` [INFO] [stderr] ... [INFO] [stderr] 724 | test_trans_simple!(trans_simple_latin1, "latin1", b"\xA9", "©"); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.02s [INFO] running `"docker" "inspect" "b30be80943e9992b40b120890936172f7f939f6099293276d0a684d846c620fd"` [INFO] running `"docker" "rm" "-f" "b30be80943e9992b40b120890936172f7f939f6099293276d0a684d846c620fd"` [INFO] [stdout] b30be80943e9992b40b120890936172f7f939f6099293276d0a684d846c620fd