[INFO] crate ena 0.11.0 is already in cache [INFO] extracting crate ena 0.11.0 into work/ex/clippy-test-run/sources/stable/reg/ena/0.11.0 [INFO] extracting crate ena 0.11.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ena/0.11.0 [INFO] validating manifest of ena-0.11.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ena-0.11.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ena-0.11.0 [INFO] finished frobbing ena-0.11.0 [INFO] frobbed toml for ena-0.11.0 written to work/ex/clippy-test-run/sources/stable/reg/ena/0.11.0/Cargo.toml [INFO] started frobbing ena-0.11.0 [INFO] finished frobbing ena-0.11.0 [INFO] frobbed toml for ena-0.11.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ena/0.11.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ena-0.11.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ena/0.11.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e233396067bd51199c09a6a80f33f2db85bf7d6501af765cf19a72a8584a2de8 [INFO] running `"docker" "start" "-a" "e233396067bd51199c09a6a80f33f2db85bf7d6501af765cf19a72a8584a2de8"` [INFO] [stderr] Checking ena v0.11.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snapshot_vec.rs:178:20 [INFO] [stderr] | [INFO] [stderr] 178 | Snapshot { length: length } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/unify/mod.rs:207:13 [INFO] [stderr] | [INFO] [stderr] 207 | parent: parent, // this is a root [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/unify/mod.rs:208:13 [INFO] [stderr] | [INFO] [stderr] 208 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/unify/mod.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | rank: rank, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rank` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/snapshot_vec.rs:178:20 [INFO] [stderr] | [INFO] [stderr] 178 | Snapshot { length: length } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/unify/mod.rs:207:13 [INFO] [stderr] | [INFO] [stderr] 207 | parent: parent, // this is a root [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/unify/mod.rs:208:13 [INFO] [stderr] | [INFO] [stderr] 208 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/unify/mod.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | rank: rank, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rank` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: item `snapshot_vec::SnapshotVec` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/snapshot_vec.rs:85:1 [INFO] [stderr] | [INFO] [stderr] 85 | / impl SnapshotVec { [INFO] [stderr] 86 | | pub fn new() -> Self { [INFO] [stderr] 87 | | Self::default() [INFO] [stderr] 88 | | } [INFO] [stderr] ... | [INFO] [stderr] 232 | | } [INFO] [stderr] 233 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/snapshot_vec.rs:271:63 [INFO] [stderr] | [INFO] [stderr] 271 | self.undo_log.extend((initial_len..final_len).map(|len| NewElem(len))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `NewElem` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: trait `UnificationStore` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/unify/backing_vec.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | / pub trait UnificationStore: [INFO] [stderr] 17 | | ops::Index>> + Clone + Default [INFO] [stderr] 18 | | { [INFO] [stderr] 19 | | type Key: UnifyKey; [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `unify::UnificationTable` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/unify/mod.rs:240:1 [INFO] [stderr] | [INFO] [stderr] 240 | / impl UnificationTable { [INFO] [stderr] 241 | | pub fn new() -> Self { [INFO] [stderr] 242 | | Self::default() [INFO] [stderr] 243 | | } [INFO] [stderr] ... | [INFO] [stderr] 409 | | } [INFO] [stderr] 410 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/unify/mod.rs:482:12 [INFO] [stderr] | [INFO] [stderr] 482 | Ok(self.unify_roots(root_a, root_b, combined)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 482 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: item `snapshot_vec::SnapshotVec` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/snapshot_vec.rs:85:1 [INFO] [stderr] | [INFO] [stderr] 85 | / impl SnapshotVec { [INFO] [stderr] 86 | | pub fn new() -> Self { [INFO] [stderr] 87 | | Self::default() [INFO] [stderr] 88 | | } [INFO] [stderr] ... | [INFO] [stderr] 232 | | } [INFO] [stderr] 233 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/snapshot_vec.rs:271:63 [INFO] [stderr] | [INFO] [stderr] 271 | self.undo_log.extend((initial_len..final_len).map(|len| NewElem(len))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `NewElem` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: trait `UnificationStore` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/unify/backing_vec.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | / pub trait UnificationStore: [INFO] [stderr] 17 | | ops::Index>> + Clone + Default [INFO] [stderr] 18 | | { [INFO] [stderr] 19 | | type Key: UnifyKey; [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `unify::UnificationTable` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/unify/mod.rs:240:1 [INFO] [stderr] | [INFO] [stderr] 240 | / impl UnificationTable { [INFO] [stderr] 241 | | pub fn new() -> Self { [INFO] [stderr] 242 | | Self::default() [INFO] [stderr] 243 | | } [INFO] [stderr] ... | [INFO] [stderr] 409 | | } [INFO] [stderr] 410 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/unify/mod.rs:482:12 [INFO] [stderr] | [INFO] [stderr] 482 | Ok(self.unify_roots(root_a, root_b, combined)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 482 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.52s [INFO] running `"docker" "inspect" "e233396067bd51199c09a6a80f33f2db85bf7d6501af765cf19a72a8584a2de8"` [INFO] running `"docker" "rm" "-f" "e233396067bd51199c09a6a80f33f2db85bf7d6501af765cf19a72a8584a2de8"` [INFO] [stdout] e233396067bd51199c09a6a80f33f2db85bf7d6501af765cf19a72a8584a2de8