[INFO] crate emitbrown 0.1.3 is already in cache [INFO] extracting crate emitbrown 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/emitbrown/0.1.3 [INFO] extracting crate emitbrown 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/emitbrown/0.1.3 [INFO] validating manifest of emitbrown-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of emitbrown-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing emitbrown-0.1.3 [INFO] finished frobbing emitbrown-0.1.3 [INFO] frobbed toml for emitbrown-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/emitbrown/0.1.3/Cargo.toml [INFO] started frobbing emitbrown-0.1.3 [INFO] finished frobbing emitbrown-0.1.3 [INFO] frobbed toml for emitbrown-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/emitbrown/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting emitbrown-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/emitbrown/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2b3b51a7baca21c26974f4fa25b220f2512a2d902a05f129d1ef9b3cc3172286 [INFO] running `"docker" "start" "-a" "2b3b51a7baca21c26974f4fa25b220f2512a2d902a05f129d1ef9b3cc3172286"` [INFO] [stderr] Checking hashbrown v0.1.8 [INFO] [stderr] Checking emitbrown v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Emitter<'callback, T>` [INFO] [stderr] --> src/lib.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> Emitter<'callback, T> { [INFO] [stderr] 19 | | Emitter { [INFO] [stderr] 20 | | events: HashMap::new() [INFO] [stderr] 21 | | } [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | / match self.events.get_mut(&event_name) { [INFO] [stderr] 29 | | Some(callbacks) => callbacks.push(callback), [INFO] [stderr] 30 | | None => (), [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(callbacks) = self.events.get_mut(&event_name) { callbacks.push(callback) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | / match self.events.get_mut(&event_name) { [INFO] [stderr] 44 | | Some(callbacks) => { [INFO] [stderr] 45 | | for callback in callbacks.iter_mut() { [INFO] [stderr] 46 | | (*callback)(event_data); [INFO] [stderr] ... | [INFO] [stderr] 49 | | _ => { ; } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 43 | if let Some(callbacks) = self.events.get_mut(&event_name) { [INFO] [stderr] 44 | for callback in callbacks.iter_mut() { [INFO] [stderr] 45 | (*callback)(event_data); [INFO] [stderr] 46 | } [INFO] [stderr] 47 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Emitter<'callback, T>` [INFO] [stderr] --> src/lib.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> Emitter<'callback, T> { [INFO] [stderr] 19 | | Emitter { [INFO] [stderr] 20 | | events: HashMap::new() [INFO] [stderr] 21 | | } [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | / match self.events.get_mut(&event_name) { [INFO] [stderr] 29 | | Some(callbacks) => callbacks.push(callback), [INFO] [stderr] 30 | | None => (), [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(callbacks) = self.events.get_mut(&event_name) { callbacks.push(callback) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | / match self.events.get_mut(&event_name) { [INFO] [stderr] 44 | | Some(callbacks) => { [INFO] [stderr] 45 | | for callback in callbacks.iter_mut() { [INFO] [stderr] 46 | | (*callback)(event_data); [INFO] [stderr] ... | [INFO] [stderr] 49 | | _ => { ; } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 43 | if let Some(callbacks) = self.events.get_mut(&event_name) { [INFO] [stderr] 44 | for callback in callbacks.iter_mut() { [INFO] [stderr] 45 | (*callback)(event_data); [INFO] [stderr] 46 | } [INFO] [stderr] 47 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> tests/emitbrown.rs:134:28 [INFO] [stderr] | [INFO] [stderr] 134 | if data.bar != "HAHAHA".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"HAHAHA"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.17s [INFO] running `"docker" "inspect" "2b3b51a7baca21c26974f4fa25b220f2512a2d902a05f129d1ef9b3cc3172286"` [INFO] running `"docker" "rm" "-f" "2b3b51a7baca21c26974f4fa25b220f2512a2d902a05f129d1ef9b3cc3172286"` [INFO] [stdout] 2b3b51a7baca21c26974f4fa25b220f2512a2d902a05f129d1ef9b3cc3172286