[INFO] crate embedded_types 0.3.2 is already in cache [INFO] extracting crate embedded_types 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/embedded_types/0.3.2 [INFO] extracting crate embedded_types 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/embedded_types/0.3.2 [INFO] validating manifest of embedded_types-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of embedded_types-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing embedded_types-0.3.2 [INFO] finished frobbing embedded_types-0.3.2 [INFO] frobbed toml for embedded_types-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/embedded_types/0.3.2/Cargo.toml [INFO] started frobbing embedded_types-0.3.2 [INFO] finished frobbing embedded_types-0.3.2 [INFO] frobbed toml for embedded_types-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/embedded_types/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting embedded_types-0.3.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/embedded_types/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3e53171cb9348a58ea6a7a32032b6dc04d25aa1036a180aaf2328d865e38605f [INFO] running `"docker" "start" "-a" "3e53171cb9348a58ea6a7a32032b6dc04d25aa1036a180aaf2328d865e38605f"` [INFO] [stderr] Checking embedded_types v0.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/io/mod.rs:160:45 [INFO] [stderr] | [INFO] [stderr] 160 | write!(test_buffer, "This {} a {}", "is", "test").unwrap(); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/io/mod.rs:160:51 [INFO] [stderr] | [INFO] [stderr] 160 | write!(test_buffer, "This {} a {}", "is", "test").unwrap(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/can/mod.rs:99:14 [INFO] [stderr] | [INFO] [stderr] 99 | Self{id: id, dlc: 0, data: [0; 8]} [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/can/mod.rs:122:14 [INFO] [stderr] | [INFO] [stderr] 122 | Self{id: id, dlc: 0, data: [0; 8]} [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/can/mod.rs:182:14 [INFO] [stderr] | [INFO] [stderr] 182 | Self{id: id, dlc: 0} [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/can/mod.rs:197:14 [INFO] [stderr] | [INFO] [stderr] 197 | Self{id: id, dlc: 0} [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/io/mod.rs:160:45 [INFO] [stderr] | [INFO] [stderr] 160 | write!(test_buffer, "This {} a {}", "is", "test").unwrap(); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/io/mod.rs:160:51 [INFO] [stderr] | [INFO] [stderr] 160 | write!(test_buffer, "This {} a {}", "is", "test").unwrap(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/can/mod.rs:99:14 [INFO] [stderr] | [INFO] [stderr] 99 | Self{id: id, dlc: 0, data: [0; 8]} [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/can/mod.rs:122:14 [INFO] [stderr] | [INFO] [stderr] 122 | Self{id: id, dlc: 0, data: [0; 8]} [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/can/mod.rs:182:14 [INFO] [stderr] | [INFO] [stderr] 182 | Self{id: id, dlc: 0} [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/can/mod.rs:197:14 [INFO] [stderr] | [INFO] [stderr] 197 | Self{id: id, dlc: 0} [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/can/mod.rs:47:30 [INFO] [stderr] | [INFO] [stderr] 47 | ID::BaseID(x) => u16::from(x) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(u16::from(x))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/can/mod.rs:190:15 [INFO] [stderr] | [INFO] [stderr] 190 | pub fn id(&self) -> BaseID { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/can/mod.rs:205:15 [INFO] [stderr] | [INFO] [stderr] 205 | pub fn id(&self) -> ExtendedID { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/io/mod.rs:162:67 [INFO] [stderr] | [INFO] [stderr] 162 | assert_eq!(test_buffer.buffer[..test_buffer.index].len(), "This is a test".as_bytes().len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"This is a test"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/io/mod.rs:163:62 [INFO] [stderr] | [INFO] [stderr] 163 | assert_eq!(&test_buffer.buffer[..test_buffer.index], "This is a test".as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"This is a test"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/can/mod.rs:47:30 [INFO] [stderr] | [INFO] [stderr] 47 | ID::BaseID(x) => u16::from(x) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(u16::from(x))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/can/mod.rs:190:15 [INFO] [stderr] | [INFO] [stderr] 190 | pub fn id(&self) -> BaseID { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/can/mod.rs:205:15 [INFO] [stderr] | [INFO] [stderr] 205 | pub fn id(&self) -> ExtendedID { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.04s [INFO] running `"docker" "inspect" "3e53171cb9348a58ea6a7a32032b6dc04d25aa1036a180aaf2328d865e38605f"` [INFO] running `"docker" "rm" "-f" "3e53171cb9348a58ea6a7a32032b6dc04d25aa1036a180aaf2328d865e38605f"` [INFO] [stdout] 3e53171cb9348a58ea6a7a32032b6dc04d25aa1036a180aaf2328d865e38605f