[INFO] crate embedded-hal-mock 0.4.0 is already in cache [INFO] extracting crate embedded-hal-mock 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/embedded-hal-mock/0.4.0 [INFO] extracting crate embedded-hal-mock 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/embedded-hal-mock/0.4.0 [INFO] validating manifest of embedded-hal-mock-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of embedded-hal-mock-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing embedded-hal-mock-0.4.0 [INFO] finished frobbing embedded-hal-mock-0.4.0 [INFO] frobbed toml for embedded-hal-mock-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/embedded-hal-mock/0.4.0/Cargo.toml [INFO] started frobbing embedded-hal-mock-0.4.0 [INFO] finished frobbing embedded-hal-mock-0.4.0 [INFO] frobbed toml for embedded-hal-mock-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/embedded-hal-mock/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting embedded-hal-mock-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/embedded-hal-mock/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c700911e9debc5027fae592440dad48c2d45d1ee79816d8580a1afa82a23fed0 [INFO] running `"docker" "start" "-a" "c700911e9debc5027fae592440dad48c2d45d1ee79816d8580a1afa82a23fed0"` [INFO] [stderr] Checking embedded-hal-mock v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/common.rs:35:15 [INFO] [stderr] | [INFO] [stderr] 35 | e.1 = expected.into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `expected` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/common.rs:35:15 [INFO] [stderr] | [INFO] [stderr] 35 | e.1 = expected.into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `expected` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/i2c.rs:157:25 [INFO] [stderr] | [INFO] [stderr] 157 | i2c.write(0xaa, &vec![10, 12]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: you can use a slice directly: `&[10, 12]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/i2c.rs:196:25 [INFO] [stderr] | [INFO] [stderr] 196 | i2c.write(0xaa, &vec![1, 2]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ help: you can use a slice directly: `&[1, 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/i2c.rs:212:25 [INFO] [stderr] | [INFO] [stderr] 212 | i2c.write(0xaa, &vec![1, 3]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ help: you can use a slice directly: `&[1, 3]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: The function/method `write` doesn't need a mutable reference [INFO] [stderr] --> src/i2c.rs:224:25 [INFO] [stderr] | [INFO] [stderr] 224 | i2c.write(0xaa, &mut buff).unwrap(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/i2c.rs:253:25 [INFO] [stderr] | [INFO] [stderr] 253 | i2c.write(0xaa, &vec![10, 12]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: you can use a slice directly: `&[10, 12]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/i2c.rs:267:25 [INFO] [stderr] | [INFO] [stderr] 267 | i2c.write(0xaa, &vec![10, 12]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: you can use a slice directly: `&[10, 12]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/spi.rs:130:19 [INFO] [stderr] | [INFO] [stderr] 130 | spi.write(&vec![10, 12]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: you can use a slice directly: `&[10, 12]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/spi.rs:159:19 [INFO] [stderr] | [INFO] [stderr] 159 | spi.write(&vec![1, 2]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ help: you can use a slice directly: `&[1, 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/spi.rs:175:19 [INFO] [stderr] | [INFO] [stderr] 175 | spi.write(&vec![10, 12, 12]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[10, 12, 12]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/spi.rs:220:19 [INFO] [stderr] | [INFO] [stderr] 220 | spi.write(&vec![10, 12, 12]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[10, 12, 12]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/spi.rs:235:19 [INFO] [stderr] | [INFO] [stderr] 235 | spi.write(&vec![10, 12, 12]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[10, 12, 12]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.42s [INFO] running `"docker" "inspect" "c700911e9debc5027fae592440dad48c2d45d1ee79816d8580a1afa82a23fed0"` [INFO] running `"docker" "rm" "-f" "c700911e9debc5027fae592440dad48c2d45d1ee79816d8580a1afa82a23fed0"` [INFO] [stdout] c700911e9debc5027fae592440dad48c2d45d1ee79816d8580a1afa82a23fed0