[INFO] crate embed_js_build 0.1.4 is already in cache [INFO] extracting crate embed_js_build 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/embed_js_build/0.1.4 [INFO] extracting crate embed_js_build 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/embed_js_build/0.1.4 [INFO] validating manifest of embed_js_build-0.1.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of embed_js_build-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing embed_js_build-0.1.4 [INFO] finished frobbing embed_js_build-0.1.4 [INFO] frobbed toml for embed_js_build-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/embed_js_build/0.1.4/Cargo.toml [INFO] started frobbing embed_js_build-0.1.4 [INFO] finished frobbing embed_js_build-0.1.4 [INFO] frobbed toml for embed_js_build-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/embed_js_build/0.1.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting embed_js_build-0.1.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/embed_js_build/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 34b34c1be9dd230f24a80c6677227566dc0d106de93bf154f56896c11e542aca [INFO] running `"docker" "start" "-a" "34b34c1be9dd230f24a80c6677227566dc0d106de93bf154f56896c11e542aca"` [INFO] [stderr] Checking cpp_synom v0.12.0 [INFO] [stderr] Checking parity-wasm v0.17.0 [INFO] [stderr] Checking cpp_syn v0.12.0 [INFO] [stderr] Checking cpp_synmap v0.3.0 [INFO] [stderr] Checking embed_js_common v0.3.0 [INFO] [stderr] Checking embed_js_build v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:259:41 [INFO] [stderr] | [INFO] [stderr] 259 | while d_pieces[i].ends_with("\\") && i != d_pieces.len() - 1 { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:313:13 [INFO] [stderr] | [INFO] [stderr] 313 | / match *section { [INFO] [stderr] 314 | | Section::Export(ref mut exports) => { [INFO] [stderr] 315 | | exports.entries_mut().push(ExportEntry::new("__table".to_string(), Internal::Table(0))); [INFO] [stderr] 316 | | break; [INFO] [stderr] 317 | | } [INFO] [stderr] 318 | | _ => {} [INFO] [stderr] 319 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 313 | if let Section::Export(ref mut exports) = *section { [INFO] [stderr] 314 | exports.entries_mut().push(ExportEntry::new("__table".to_string(), Internal::Table(0))); [INFO] [stderr] 315 | break; [INFO] [stderr] 316 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:259:41 [INFO] [stderr] | [INFO] [stderr] 259 | while d_pieces[i].ends_with("\\") && i != d_pieces.len() - 1 { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\\'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:313:13 [INFO] [stderr] | [INFO] [stderr] 313 | / match *section { [INFO] [stderr] 314 | | Section::Export(ref mut exports) => { [INFO] [stderr] 315 | | exports.entries_mut().push(ExportEntry::new("__table".to_string(), Internal::Table(0))); [INFO] [stderr] 316 | | break; [INFO] [stderr] 317 | | } [INFO] [stderr] 318 | | _ => {} [INFO] [stderr] 319 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 313 | if let Section::Export(ref mut exports) = *section { [INFO] [stderr] 314 | exports.entries_mut().push(ExportEntry::new("__table".to_string(), Internal::Table(0))); [INFO] [stderr] 315 | break; [INFO] [stderr] 316 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.34s [INFO] running `"docker" "inspect" "34b34c1be9dd230f24a80c6677227566dc0d106de93bf154f56896c11e542aca"` [INFO] running `"docker" "rm" "-f" "34b34c1be9dd230f24a80c6677227566dc0d106de93bf154f56896c11e542aca"` [INFO] [stdout] 34b34c1be9dd230f24a80c6677227566dc0d106de93bf154f56896c11e542aca