[INFO] crate elliptic 0.5.0 is already in cache [INFO] extracting crate elliptic 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/elliptic/0.5.0 [INFO] extracting crate elliptic 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/elliptic/0.5.0 [INFO] validating manifest of elliptic-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of elliptic-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing elliptic-0.5.0 [INFO] finished frobbing elliptic-0.5.0 [INFO] frobbed toml for elliptic-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/elliptic/0.5.0/Cargo.toml [INFO] started frobbing elliptic-0.5.0 [INFO] finished frobbing elliptic-0.5.0 [INFO] frobbed toml for elliptic-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/elliptic/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting elliptic-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/elliptic/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 86e8cc9084cec81793b5cc6aaccf229e0619eb0430e3c3ae32a1c70896eafec9 [INFO] running `"docker" "start" "-a" "86e8cc9084cec81793b5cc6aaccf229e0619eb0430e3c3ae32a1c70896eafec9"` [INFO] [stderr] Compiling elliptic-sys v0.3.0 [INFO] [stderr] Checking elliptic v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/curve25519.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / if result == 0 { [INFO] [stderr] 39 | | true [INFO] [stderr] 40 | | } else { [INFO] [stderr] 41 | | false [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `result == 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/curve25519.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / if result == 0 { [INFO] [stderr] 39 | | true [INFO] [stderr] 40 | | } else { [INFO] [stderr] 41 | | false [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `result == 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.11s [INFO] running `"docker" "inspect" "86e8cc9084cec81793b5cc6aaccf229e0619eb0430e3c3ae32a1c70896eafec9"` [INFO] running `"docker" "rm" "-f" "86e8cc9084cec81793b5cc6aaccf229e0619eb0430e3c3ae32a1c70896eafec9"` [INFO] [stdout] 86e8cc9084cec81793b5cc6aaccf229e0619eb0430e3c3ae32a1c70896eafec9