[INFO] crate ellipsis 0.1.0 is already in cache
[INFO] extracting crate ellipsis 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/ellipsis/0.1.0
[INFO] extracting crate ellipsis 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ellipsis/0.1.0
[INFO] validating manifest of ellipsis-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ellipsis-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ellipsis-0.1.0
[INFO] finished frobbing ellipsis-0.1.0
[INFO] frobbed toml for ellipsis-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/ellipsis/0.1.0/Cargo.toml
[INFO] started frobbing ellipsis-0.1.0
[INFO] finished frobbing ellipsis-0.1.0
[INFO] frobbed toml for ellipsis-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ellipsis/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ellipsis-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ellipsis/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 047a0cf3fdbaaf37d208745c3c5295600ca8dea35963679d2a411a0aef9a8a94
[INFO] running `"docker" "start" "-a" "047a0cf3fdbaaf37d208745c3c5295600ca8dea35963679d2a411a0aef9a8a94"`
[INFO] [stderr]     Checking git2 v0.7.5
[INFO] [stderr]     Checking ellipsis v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/lib.rs:90:12
[INFO] [stderr]    |
[INFO] [stderr] 90 |       } else {
[INFO] [stderr]    |  ____________^
[INFO] [stderr] 91 | |
[INFO] [stderr] 92 | |         if let Some(myhome) = env::home_dir() {
[INFO] [stderr] 93 | |             Some(myhome.join(".ellipsis"))
[INFO] [stderr] ...  |
[INFO] [stderr] 96 | |         }
[INFO] [stderr] 97 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 90 |     } else if let Some(myhome) = env::home_dir() {
[INFO] [stderr] 91 |     Some(myhome.join(".ellipsis"))
[INFO] [stderr] 92 | } else {
[INFO] [stderr] 93 |     None
[INFO] [stderr] 94 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/link/mod.rs:57:28
[INFO] [stderr]    |
[INFO] [stderr] 57 |                 let home = env::home_dir()
[INFO] [stderr]    |                            ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/unlink/mod.rs:50:28
[INFO] [stderr]    |
[INFO] [stderr] 50 |                 let home = env::home_dir()
[INFO] [stderr]    |                            ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/lib.rs:92:31
[INFO] [stderr]    |
[INFO] [stderr] 92 |         if let Some(myhome) = env::home_dir() {
[INFO] [stderr]    |                               ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/lib.rs:90:12
[INFO] [stderr]    |
[INFO] [stderr] 90 |       } else {
[INFO] [stderr]    |  ____________^
[INFO] [stderr] 91 | |
[INFO] [stderr] 92 | |         if let Some(myhome) = env::home_dir() {
[INFO] [stderr] 93 | |             Some(myhome.join(".ellipsis"))
[INFO] [stderr] ...  |
[INFO] [stderr] 96 | |         }
[INFO] [stderr] 97 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 90 |     } else if let Some(myhome) = env::home_dir() {
[INFO] [stderr] 91 |     Some(myhome.join(".ellipsis"))
[INFO] [stderr] 92 | } else {
[INFO] [stderr] 93 |     None
[INFO] [stderr] 94 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/link/mod.rs:57:28
[INFO] [stderr]    |
[INFO] [stderr] 57 |                 let home = env::home_dir()
[INFO] [stderr]    |                            ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/unlink/mod.rs:50:28
[INFO] [stderr]    |
[INFO] [stderr] 50 |                 let home = env::home_dir()
[INFO] [stderr]    |                            ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/lib.rs:92:31
[INFO] [stderr]    |
[INFO] [stderr] 92 |         if let Some(myhome) = env::home_dir() {
[INFO] [stderr]    |                               ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/link/mod.rs:48:22
[INFO] [stderr]    |
[INFO] [stderr] 48 |         let source = path::PathBuf::from(home_dir().unwrap())
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `path::PathBuf::from()`: `home_dir().unwrap()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:115:28
[INFO] [stderr]     |
[INFO] [stderr] 115 |         env::var("EDITOR").unwrap_or(String::from("vi")))
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("vi"))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/link/mod.rs:48:22
[INFO] [stderr]    |
[INFO] [stderr] 48 |         let source = path::PathBuf::from(home_dir().unwrap())
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `path::PathBuf::from()`: `home_dir().unwrap()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:115:28
[INFO] [stderr]     |
[INFO] [stderr] 115 |         env::var("EDITOR").unwrap_or(String::from("vi")))
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("vi"))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 12.75s
[INFO] running `"docker" "inspect" "047a0cf3fdbaaf37d208745c3c5295600ca8dea35963679d2a411a0aef9a8a94"`
[INFO] running `"docker" "rm" "-f" "047a0cf3fdbaaf37d208745c3c5295600ca8dea35963679d2a411a0aef9a8a94"`
[INFO] [stdout] 047a0cf3fdbaaf37d208745c3c5295600ca8dea35963679d2a411a0aef9a8a94