[INFO] crate eliza 1.0.0 is already in cache
[INFO] extracting crate eliza 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/eliza/1.0.0
[INFO] extracting crate eliza 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/eliza/1.0.0
[INFO] validating manifest of eliza-1.0.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of eliza-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing eliza-1.0.0
[INFO] finished frobbing eliza-1.0.0
[INFO] frobbed toml for eliza-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/eliza/1.0.0/Cargo.toml
[INFO] started frobbing eliza-1.0.0
[INFO] finished frobbing eliza-1.0.0
[INFO] frobbed toml for eliza-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/eliza/1.0.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting eliza-1.0.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/eliza/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] f7827eab06c127362c07432e5845f7c62224524b2e89419256ed45c2a7ba3665
[INFO] running `"docker" "start" "-a" "f7827eab06c127362c07432e5845f7c62224524b2e89419256ed45c2a7ba3665"`
[INFO] [stderr]     Checking eliza v1.0.0 (/opt/crater/workdir)
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/alphabet.rs:38:9
[INFO] [stderr]    |
[INFO] [stderr] 38 |         text.chars().into_iter()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `text.chars()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]   --> src/alphabet.rs:51:14
[INFO] [stderr]    |
[INFO] [stderr] 51 |             .or(ALPHABET_UPPER.iter().position(|&a| a == c))
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| ALPHABET_UPPER.iter().position(|&a| a == c))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/alphabet.rs:59:9
[INFO] [stderr]    |
[INFO] [stderr] 59 | /         match is_uppercase {
[INFO] [stderr] 60 | |             true => Some(ALPHABET_UPPER[index]),
[INFO] [stderr] 61 | |             false => Some(ALPHABET_LOWER[index])
[INFO] [stderr] 62 | |         }
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if is_uppercase { Some(ALPHABET_UPPER[index]) } else { Some(ALPHABET_LOWER[index]) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/alphabet.rs:103:9
[INFO] [stderr]     |
[INFO] [stderr] 103 | /         match is_uppercase {
[INFO] [stderr] 104 | |             true => Some(ALPHABET_UPPER[index]),
[INFO] [stderr] 105 | |             false => Some(ALPHABET_LOWER[index])
[INFO] [stderr] 106 | |         }
[INFO] [stderr]     | |_________^ help: consider using an if/else expression: `if is_uppercase { Some(ALPHABET_UPPER[index]) } else { Some(ALPHABET_LOWER[index]) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/lib.rs:185:13
[INFO] [stderr]     |
[INFO] [stderr] 185 | /             match self.rule_usage.contains_key(&key) {
[INFO] [stderr] 186 | |                 true => {
[INFO] [stderr] 187 | |                     //If it has already been used, get its usage count
[INFO] [stderr] 188 | |                     let usage = self.rule_usage[&key];
[INFO] [stderr] ...   |
[INFO] [stderr] 206 | |                 }
[INFO] [stderr] 207 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 185 |             if self.rule_usage.contains_key(&key) {
[INFO] [stderr] 186 |     //If it has already been used, get its usage count
[INFO] [stderr] 187 |     let usage = self.rule_usage[&key];
[INFO] [stderr] 188 |     if let Some(c) = count {
[INFO] [stderr] 189 |         if usage < c {
[INFO] [stderr] 190 |             //The usage is less than the running total
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/lib.rs:214:17
[INFO] [stderr]     |
[INFO] [stderr] 214 |                 *usage = *usage + 1;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^ help: replace it with: `*usage += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:281:23
[INFO] [stderr]     |
[INFO] [stderr] 281 |         if w.contains("@"){
[INFO] [stderr]     |                       ^^^ help: try using a char instead: `'@'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:311:23
[INFO] [stderr]     |
[INFO] [stderr] 311 |         if w.contains("$"){
[INFO] [stderr]     |                       ^^^ help: try using a char instead: `'$'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/lib.rs:381:5
[INFO] [stderr]     |
[INFO] [stderr] 381 | /     match statement.contains("GOTO"){
[INFO] [stderr] 382 | |         true => Some(statement.replace("GOTO", "").replace(char::is_whitespace, "")),
[INFO] [stderr] 383 | |         false => None,
[INFO] [stderr] 384 | |     }
[INFO] [stderr]     | |_____^ help: consider using an if/else expression: `if statement.contains("GOTO") { Some(statement.replace("GOTO", "").replace(char::is_whitespace, "")) } else { None }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/alphabet.rs:38:9
[INFO] [stderr]    |
[INFO] [stderr] 38 |         text.chars().into_iter()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `text.chars()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]   --> src/alphabet.rs:51:14
[INFO] [stderr]    |
[INFO] [stderr] 51 |             .or(ALPHABET_UPPER.iter().position(|&a| a == c))
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| ALPHABET_UPPER.iter().position(|&a| a == c))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/alphabet.rs:59:9
[INFO] [stderr]    |
[INFO] [stderr] 59 | /         match is_uppercase {
[INFO] [stderr] 60 | |             true => Some(ALPHABET_UPPER[index]),
[INFO] [stderr] 61 | |             false => Some(ALPHABET_LOWER[index])
[INFO] [stderr] 62 | |         }
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if is_uppercase { Some(ALPHABET_UPPER[index]) } else { Some(ALPHABET_LOWER[index]) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/alphabet.rs:103:9
[INFO] [stderr]     |
[INFO] [stderr] 103 | /         match is_uppercase {
[INFO] [stderr] 104 | |             true => Some(ALPHABET_UPPER[index]),
[INFO] [stderr] 105 | |             false => Some(ALPHABET_LOWER[index])
[INFO] [stderr] 106 | |         }
[INFO] [stderr]     | |_________^ help: consider using an if/else expression: `if is_uppercase { Some(ALPHABET_UPPER[index]) } else { Some(ALPHABET_LOWER[index]) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/lib.rs:185:13
[INFO] [stderr]     |
[INFO] [stderr] 185 | /             match self.rule_usage.contains_key(&key) {
[INFO] [stderr] 186 | |                 true => {
[INFO] [stderr] 187 | |                     //If it has already been used, get its usage count
[INFO] [stderr] 188 | |                     let usage = self.rule_usage[&key];
[INFO] [stderr] ...   |
[INFO] [stderr] 206 | |                 }
[INFO] [stderr] 207 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 185 |             if self.rule_usage.contains_key(&key) {
[INFO] [stderr] 186 |     //If it has already been used, get its usage count
[INFO] [stderr] 187 |     let usage = self.rule_usage[&key];
[INFO] [stderr] 188 |     if let Some(c) = count {
[INFO] [stderr] 189 |         if usage < c {
[INFO] [stderr] 190 |             //The usage is less than the running total
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/lib.rs:214:17
[INFO] [stderr]     |
[INFO] [stderr] 214 |                 *usage = *usage + 1;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^ help: replace it with: `*usage += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:281:23
[INFO] [stderr]     |
[INFO] [stderr] 281 |         if w.contains("@"){
[INFO] [stderr]     |                       ^^^ help: try using a char instead: `'@'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:311:23
[INFO] [stderr]     |
[INFO] [stderr] 311 |         if w.contains("$"){
[INFO] [stderr]     |                       ^^^ help: try using a char instead: `'$'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/lib.rs:381:5
[INFO] [stderr]     |
[INFO] [stderr] 381 | /     match statement.contains("GOTO"){
[INFO] [stderr] 382 | |         true => Some(statement.replace("GOTO", "").replace(char::is_whitespace, "")),
[INFO] [stderr] 383 | |         false => None,
[INFO] [stderr] 384 | |     }
[INFO] [stderr]     | |_____^ help: consider using an if/else expression: `if statement.contains("GOTO") { Some(statement.replace("GOTO", "").replace(char::is_whitespace, "")) } else { None }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]    --> src/lib.rs:441:50
[INFO] [stderr]     |
[INFO] [stderr] 441 |         assert_eq!("first", e.get_reassembly("", &vec!("first".to_string(), "second".to_string(), "third".to_string(), "fourth".to_string())).unwrap());
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["first".to_string(), "second".to_string(), "third".to_string(), "fourth".to_string()]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_vec)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]    --> src/lib.rs:458:50
[INFO] [stderr]     |
[INFO] [stderr] 458 |         assert_eq!("third", e.get_reassembly("", &vec!("first".to_string(), "second".to_string(), "third".to_string(), "fourth".to_string())).unwrap());
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["first".to_string(), "second".to_string(), "third".to_string(), "fourth".to_string()]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]    --> src/lib.rs:474:51
[INFO] [stderr]     |
[INFO] [stderr] 474 |         assert_eq!("fourth", e.get_reassembly("", &vec!("first".to_string(), "second".to_string(), "third".to_string(), "fourth".to_string())).unwrap());
[INFO] [stderr]     |                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["first".to_string(), "second".to_string(), "third".to_string(), "fourth".to_string()]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 5.31s
[INFO] running `"docker" "inspect" "f7827eab06c127362c07432e5845f7c62224524b2e89419256ed45c2a7ba3665"`
[INFO] running `"docker" "rm" "-f" "f7827eab06c127362c07432e5845f7c62224524b2e89419256ed45c2a7ba3665"`
[INFO] [stdout] f7827eab06c127362c07432e5845f7c62224524b2e89419256ed45c2a7ba3665