[INFO] crate elfkit 0.0.6 is already in cache [INFO] extracting crate elfkit 0.0.6 into work/ex/clippy-test-run/sources/stable/reg/elfkit/0.0.6 [INFO] extracting crate elfkit 0.0.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/elfkit/0.0.6 [INFO] validating manifest of elfkit-0.0.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of elfkit-0.0.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing elfkit-0.0.6 [INFO] finished frobbing elfkit-0.0.6 [INFO] frobbed toml for elfkit-0.0.6 written to work/ex/clippy-test-run/sources/stable/reg/elfkit/0.0.6/Cargo.toml [INFO] started frobbing elfkit-0.0.6 [INFO] finished frobbing elfkit-0.0.6 [INFO] frobbed toml for elfkit-0.0.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/elfkit/0.0.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting elfkit-0.0.6 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/elfkit/0.0.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b66e7423d1c64d2edbfbd101bba7e1fe8d08445cf6c7960325af2024125c0b92 [INFO] running `"docker" "start" "-a" "b66e7423d1c64d2edbfbd101bba7e1fe8d08445cf6c7960325af2024125c0b92"` [INFO] [stderr] Checking elfkit v0.0.6 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elf.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elf.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elf.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | segments: segments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elf.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | sections: sections, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sections` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elf.rs:661:21 [INFO] [stderr] | [INFO] [stderr] 661 | cause: cause, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `cause` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/loader.rs:186:29 [INFO] [stderr] | [INFO] [stderr] 186 | name: name, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/loader.rs:300:13 [INFO] [stderr] | [INFO] [stderr] 300 | name: name, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/loader.rs:301:13 [INFO] [stderr] | [INFO] [stderr] 301 | elf: elf, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `elf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/loader.rs:303:13 [INFO] [stderr] | [INFO] [stderr] 303 | bloom: bloom, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bloom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbolic_linker.rs:159:17 [INFO] [stderr] | [INFO] [stderr] 159 | relocs: relocs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `relocs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbolic_linker.rs:209:61 [INFO] [stderr] | [INFO] [stderr] 209 | self.symtab.push(LinkableSymbol{sym: sym, obj: lid_base}); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sym` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbolic_linker.rs:221:65 [INFO] [stderr] | [INFO] [stderr] 221 | self.symtab[i] = LinkableSymbol{sym: sym, obj: lid_base}; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sym` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbolic_linker.rs:229:61 [INFO] [stderr] | [INFO] [stderr] 229 | self.symtab.push(LinkableSymbol{sym: sym, obj: lid_base}); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sym` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbolic_linker.rs:238:53 [INFO] [stderr] | [INFO] [stderr] 238 | self.symtab.push(LinkableSymbol{sym: sym, obj: lid_base}); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sym` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbolic_linker.rs:258:69 [INFO] [stderr] | [INFO] [stderr] 258 | self.symtab[i] = LinkableSymbol{sym: sym, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sym` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbolic_linker.rs:264:69 [INFO] [stderr] | [INFO] [stderr] 264 | self.symtab.push(LinkableSymbol{sym: sym, obj: lid_base + shndx as usize}); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sym` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbolic_linker.rs:276:74 [INFO] [stderr] | [INFO] [stderr] 276 | self.symtab[*i] = LinkableSymbol{sym: sym, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sym` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbolic_linker.rs:283:69 [INFO] [stderr] | [INFO] [stderr] 283 | self.symtab.push(LinkableSymbol{sym: sym, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sym` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbolic_linker.rs:293:61 [INFO] [stderr] | [INFO] [stderr] 293 | self.symtab.push(LinkableSymbol{sym: sym, obj: lid_base + shndx as usize}); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sym` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/relocation.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | addr: addr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/relocation.rs:167:17 [INFO] [stderr] | [INFO] [stderr] 167 | sym: sym, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sym` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/relocation.rs:168:17 [INFO] [stderr] | [INFO] [stderr] 168 | rtype: rtype, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rtype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/section.rs:212:13 [INFO] [stderr] | [INFO] [stderr] 212 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/section.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/section.rs:215:17 [INFO] [stderr] | [INFO] [stderr] 215 | shtype: shtype, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `shtype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/section.rs:216:17 [INFO] [stderr] | [INFO] [stderr] 216 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/section.rs:220:17 [INFO] [stderr] | [INFO] [stderr] 220 | link: link, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `link` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/section.rs:221:17 [INFO] [stderr] | [INFO] [stderr] 221 | info: info, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/strtab.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | shndx: shndx, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shndx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | stype: stype, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | bind: bind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | vis: vis, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | _name: _name, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol.rs:270:13 [INFO] [stderr] | [INFO] [stderr] 270 | link: link, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `link` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elf.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elf.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elf.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | segments: segments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elf.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | sections: sections, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sections` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/elf.rs:661:21 [INFO] [stderr] | [INFO] [stderr] 661 | cause: cause, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `cause` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/loader.rs:186:29 [INFO] [stderr] | [INFO] [stderr] 186 | name: name, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/loader.rs:300:13 [INFO] [stderr] | [INFO] [stderr] 300 | name: name, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/loader.rs:301:13 [INFO] [stderr] | [INFO] [stderr] 301 | elf: elf, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `elf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/loader.rs:303:13 [INFO] [stderr] | [INFO] [stderr] 303 | bloom: bloom, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bloom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbolic_linker.rs:159:17 [INFO] [stderr] | [INFO] [stderr] 159 | relocs: relocs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `relocs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbolic_linker.rs:209:61 [INFO] [stderr] | [INFO] [stderr] 209 | self.symtab.push(LinkableSymbol{sym: sym, obj: lid_base}); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sym` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbolic_linker.rs:221:65 [INFO] [stderr] | [INFO] [stderr] 221 | self.symtab[i] = LinkableSymbol{sym: sym, obj: lid_base}; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sym` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbolic_linker.rs:229:61 [INFO] [stderr] | [INFO] [stderr] 229 | self.symtab.push(LinkableSymbol{sym: sym, obj: lid_base}); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sym` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbolic_linker.rs:238:53 [INFO] [stderr] | [INFO] [stderr] 238 | self.symtab.push(LinkableSymbol{sym: sym, obj: lid_base}); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sym` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbolic_linker.rs:258:69 [INFO] [stderr] | [INFO] [stderr] 258 | self.symtab[i] = LinkableSymbol{sym: sym, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sym` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbolic_linker.rs:264:69 [INFO] [stderr] | [INFO] [stderr] 264 | self.symtab.push(LinkableSymbol{sym: sym, obj: lid_base + shndx as usize}); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sym` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbolic_linker.rs:276:74 [INFO] [stderr] | [INFO] [stderr] 276 | self.symtab[*i] = LinkableSymbol{sym: sym, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sym` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbolic_linker.rs:283:69 [INFO] [stderr] | [INFO] [stderr] 283 | self.symtab.push(LinkableSymbol{sym: sym, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sym` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbolic_linker.rs:293:61 [INFO] [stderr] | [INFO] [stderr] 293 | self.symtab.push(LinkableSymbol{sym: sym, obj: lid_base + shndx as usize}); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sym` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/relocation.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | addr: addr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/relocation.rs:167:17 [INFO] [stderr] | [INFO] [stderr] 167 | sym: sym, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sym` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/relocation.rs:168:17 [INFO] [stderr] | [INFO] [stderr] 168 | rtype: rtype, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rtype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/section.rs:212:13 [INFO] [stderr] | [INFO] [stderr] 212 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/section.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/section.rs:215:17 [INFO] [stderr] | [INFO] [stderr] 215 | shtype: shtype, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `shtype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/section.rs:216:17 [INFO] [stderr] | [INFO] [stderr] 216 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/section.rs:220:17 [INFO] [stderr] | [INFO] [stderr] 220 | link: link, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `link` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/section.rs:221:17 [INFO] [stderr] | [INFO] [stderr] 221 | info: info, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/strtab.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | shndx: shndx, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shndx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | stype: stype, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | bind: bind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | vis: vis, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | _name: _name, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symbol.rs:270:13 [INFO] [stderr] | [INFO] [stderr] 270 | link: link, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `link` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/elf.rs:363:13 [INFO] [stderr] | [INFO] [stderr] 363 | / if s1.header.shtype != s2.header.shtype { [INFO] [stderr] 364 | | if s1.header.shtype == types::SectionType::NOBITS { [INFO] [stderr] 365 | | return std::cmp::Ordering::Greater; [INFO] [stderr] 366 | | } [INFO] [stderr] 367 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 363 | if s1.header.shtype != s2.header.shtype && s1.header.shtype == types::SectionType::NOBITS { [INFO] [stderr] 364 | return std::cmp::Ordering::Greater; [INFO] [stderr] 365 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf.rs:462:36 [INFO] [stderr] | [INFO] [stderr] 462 | if (voff - poff) % 0x200000 != 0 { [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf.rs:478:33 [INFO] [stderr] | [INFO] [stderr] 478 | align: 0x200000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf.rs:481:29 [INFO] [stderr] | [INFO] [stderr] 481 | voff += 0x200000 - ((voff - poff) % 0x200000); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf.rs:481:57 [INFO] [stderr] | [INFO] [stderr] 481 | voff += 0x200000 - ((voff - poff) % 0x200000); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf.rs:509:37 [INFO] [stderr] | [INFO] [stderr] 509 | align: 0x200000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf.rs:511:33 [INFO] [stderr] | [INFO] [stderr] 511 | voff += 0x200000 - ((voff - poff) % 0x200000); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf.rs:511:61 [INFO] [stderr] | [INFO] [stderr] 511 | voff += 0x200000 - ((voff - poff) % 0x200000); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf.rs:594:25 [INFO] [stderr] | [INFO] [stderr] 594 | align: 0x200000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/elf.rs:606:9 [INFO] [stderr] | [INFO] [stderr] 606 | ///TODO this is shitty, because we need to replicate all the alignment code [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_doc_comments)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/elf.rs:704:12 [INFO] [stderr] | [INFO] [stderr] 704 | Ok((r)) [INFO] [stderr] | ^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/elf.rs:704:12 [INFO] [stderr] | [INFO] [stderr] 704 | Ok((r)) [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/elf.rs:714:13 [INFO] [stderr] | [INFO] [stderr] 714 | / if sec.header.flags.contains(types::SectionFlags::INFO_LINK) { [INFO] [stderr] 715 | | if sec.header.info > at as u32 { [INFO] [stderr] 716 | | sec.header.info += 1; [INFO] [stderr] 717 | | } [INFO] [stderr] 718 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 714 | if sec.header.flags.contains(types::SectionFlags::INFO_LINK) && sec.header.info > at as u32 { [INFO] [stderr] 715 | sec.header.info += 1; [INFO] [stderr] 716 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf.rs:735:35 [INFO] [stderr] | [INFO] [stderr] 735 | sec.header.link = 999999; [INFO] [stderr] | ^^^^^^ help: consider: `999_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/elf.rs:737:13 [INFO] [stderr] | [INFO] [stderr] 737 | / if sec.header.flags.contains(types::SectionFlags::INFO_LINK) { [INFO] [stderr] 738 | | if sec.header.info == from as u32 { [INFO] [stderr] 739 | | sec.header.info = 999999; [INFO] [stderr] 740 | | } [INFO] [stderr] 741 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 737 | if sec.header.flags.contains(types::SectionFlags::INFO_LINK) && sec.header.info == from as u32 { [INFO] [stderr] 738 | sec.header.info = 999999; [INFO] [stderr] 739 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf.rs:739:39 [INFO] [stderr] | [INFO] [stderr] 739 | sec.header.info = 999999; [INFO] [stderr] | ^^^^^^ help: consider: `999_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf.rs:746:35 [INFO] [stderr] | [INFO] [stderr] 746 | if sec.header.link == 999999 { [INFO] [stderr] | ^^^^^^ help: consider: `999_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/elf.rs:749:13 [INFO] [stderr] | [INFO] [stderr] 749 | / if sec.header.flags.contains(types::SectionFlags::INFO_LINK) { [INFO] [stderr] 750 | | if sec.header.info == 999999 { [INFO] [stderr] 751 | | sec.header.info = to as u32; [INFO] [stderr] 752 | | } [INFO] [stderr] 753 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 749 | if sec.header.flags.contains(types::SectionFlags::INFO_LINK) && sec.header.info == 999999 { [INFO] [stderr] 750 | sec.header.info = to as u32; [INFO] [stderr] 751 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf.rs:750:39 [INFO] [stderr] | [INFO] [stderr] 750 | if sec.header.info == 999999 { [INFO] [stderr] | ^^^^^^ help: consider: `999_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filetype.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | return Ok(FileType::Unknown); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(FileType::Unknown)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/loader.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/loader.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/loader.rs:335:42 [INFO] [stderr] | [INFO] [stderr] 335 | let mut a1 = FnvHasher::with_key(0xcbf29ce484222325); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xcbf2_9ce4_8422_2325` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/loader.rs:336:42 [INFO] [stderr] | [INFO] [stderr] 336 | let mut a2 = FnvHasher::with_key(0x84222325b444f000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x8422_2325_b444_f000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/symbolic_linker.rs:198:21 [INFO] [stderr] | [INFO] [stderr] 198 | / if sym.bind == types::SymbolBind::LOCAL { [INFO] [stderr] 199 | | if sym.name.len() > 0 { [INFO] [stderr] 200 | | panic!("local undefined symbol {:?}", sym); [INFO] [stderr] 201 | | } [INFO] [stderr] 202 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 198 | if sym.bind == types::SymbolBind::LOCAL && sym.name.len() > 0 { [INFO] [stderr] 199 | panic!("local undefined symbol {:?}", sym); [INFO] [stderr] 200 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/relocation.rs:150:33 [INFO] [stderr] | [INFO] [stderr] 150 | let rtype = (info & 0xffffffff) as u32; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/relocation.rs:191:12 [INFO] [stderr] | [INFO] [stderr] 191 | Ok((8+8+8)) [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/relocation.rs:191:12 [INFO] [stderr] | [INFO] [stderr] 191 | Ok((8+8+8)) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symbol.rs:235:5 [INFO] [stderr] | [INFO] [stderr] 235 | return h; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `h` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/symbol.rs:229:17 [INFO] [stderr] | [INFO] [stderr] 229 | g = h & 0xf0000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xf000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:34:35 [INFO] [stderr] | [INFO] [stderr] 34 | const MASKOS = 0x0ff00000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0ff0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:36:35 [INFO] [stderr] | [INFO] [stderr] 36 | const MASKPROC = 0xf0000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xf000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:45:35 [INFO] [stderr] | [INFO] [stderr] 45 | const MIPS_GPREL = 0x10000000; // [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:102:35 [INFO] [stderr] | [INFO] [stderr] 102 | const MIPS_NOREORDER = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:105:35 [INFO] [stderr] | [INFO] [stderr] 105 | const MIPS_PIC = 0x00000002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:112:35 [INFO] [stderr] | [INFO] [stderr] 112 | const MIPS_CPIC = 0x00000004; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:116:35 [INFO] [stderr] | [INFO] [stderr] 116 | const MIPS_ARCH = 0xf0000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xf000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:118:35 [INFO] [stderr] | [INFO] [stderr] 118 | const MIPS_ARCH_32 = 0x50000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:119:35 [INFO] [stderr] | [INFO] [stderr] 119 | const MIPS_ARCH_64 = 0x60000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:120:35 [INFO] [stderr] | [INFO] [stderr] 120 | const MIPS_ARCH_32R2 = 0x70000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:121:35 [INFO] [stderr] | [INFO] [stderr] 121 | const MIPS_ARCH_64R2 = 0x80000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:125:35 [INFO] [stderr] | [INFO] [stderr] 125 | const MIPS_ABI_O32 = 0x00001000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:128:35 [INFO] [stderr] | [INFO] [stderr] 128 | const MIPS_ABI_O64 = 0x00002000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_2000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:130:42 [INFO] [stderr] | [INFO] [stderr] 130 | const ARM_EABI_VER1 = 0x01000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:131:42 [INFO] [stderr] | [INFO] [stderr] 131 | const ARM_EABI_VER2 = 0x02000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0200_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:132:42 [INFO] [stderr] | [INFO] [stderr] 132 | const ARM_EABI_VER3 = 0x03000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0300_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:133:42 [INFO] [stderr] | [INFO] [stderr] 133 | const ARM_EABI_VER4 = 0x04000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0400_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:134:42 [INFO] [stderr] | [INFO] [stderr] 134 | const ARM_EABI_VER5 = 0x05000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0500_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:135:39 [INFO] [stderr] | [INFO] [stderr] 135 | const ARM_ABI_FLOAT_HARD = 0x00000400; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:136:39 [INFO] [stderr] | [INFO] [stderr] 136 | const ARM_ABI_FLOAT_SOFT = 0x00000200; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/elf.rs:363:13 [INFO] [stderr] | [INFO] [stderr] 363 | / if s1.header.shtype != s2.header.shtype { [INFO] [stderr] 364 | | if s1.header.shtype == types::SectionType::NOBITS { [INFO] [stderr] 365 | | return std::cmp::Ordering::Greater; [INFO] [stderr] 366 | | } [INFO] [stderr] 367 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 363 | if s1.header.shtype != s2.header.shtype && s1.header.shtype == types::SectionType::NOBITS { [INFO] [stderr] 364 | return std::cmp::Ordering::Greater; [INFO] [stderr] 365 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf.rs:462:36 [INFO] [stderr] | [INFO] [stderr] 462 | if (voff - poff) % 0x200000 != 0 { [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf.rs:478:33 [INFO] [stderr] | [INFO] [stderr] 478 | align: 0x200000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf.rs:481:29 [INFO] [stderr] | [INFO] [stderr] 481 | voff += 0x200000 - ((voff - poff) % 0x200000); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf.rs:481:57 [INFO] [stderr] | [INFO] [stderr] 481 | voff += 0x200000 - ((voff - poff) % 0x200000); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf.rs:509:37 [INFO] [stderr] | [INFO] [stderr] 509 | align: 0x200000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf.rs:511:33 [INFO] [stderr] | [INFO] [stderr] 511 | voff += 0x200000 - ((voff - poff) % 0x200000); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf.rs:511:61 [INFO] [stderr] | [INFO] [stderr] 511 | voff += 0x200000 - ((voff - poff) % 0x200000); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf.rs:594:25 [INFO] [stderr] | [INFO] [stderr] 594 | align: 0x200000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0020_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/elf.rs:606:9 [INFO] [stderr] | [INFO] [stderr] 606 | ///TODO this is shitty, because we need to replicate all the alignment code [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_doc_comments)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:230:57 [INFO] [stderr] | [INFO] [stderr] 230 | pub const GNU_ATTRIBUTES: SectionType = SectionType(0x6ffffff5); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fff5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/elf.rs:704:12 [INFO] [stderr] | [INFO] [stderr] 704 | Ok((r)) [INFO] [stderr] | ^^^ help: remove these parentheses [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:232:51 [INFO] [stderr] | [INFO] [stderr] 232 | pub const GNU_HASH: SectionType = SectionType(0x6ffffff6); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fff6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:234:54 [INFO] [stderr] | [INFO] [stderr] 234 | pub const GNU_LIBLIST: SectionType = SectionType(0x6ffffff7); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fff7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/elf.rs:704:12 [INFO] [stderr] | [INFO] [stderr] 704 | Ok((r)) [INFO] [stderr] | ^^^ [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] | [INFO] [stderr] --> src/types.rs:236:51 [INFO] [stderr] | [INFO] [stderr] 236 | pub const CHECKSUM: SectionType = SectionType(0x6ffffff8); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fff8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:237:52 [INFO] [stderr] | [INFO] [stderr] 237 | pub const SUNW_MOVE: SectionType = SectionType(0x6ffffffa); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:238:54 [INFO] [stderr] | [INFO] [stderr] 238 | pub const SUNW_COMDAT: SectionType = SectionType(0x6ffffffb); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:239:55 [INFO] [stderr] | [INFO] [stderr] 239 | pub const SUNW_SYMINFO: SectionType = SectionType(0x6ffffffc); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/elf.rs:714:13 [INFO] [stderr] | [INFO] [stderr] 714 | / if sec.header.flags.contains(types::SectionFlags::INFO_LINK) { [INFO] [stderr] 715 | | if sec.header.info > at as u32 { [INFO] [stderr] 716 | | sec.header.info += 1; [INFO] [stderr] 717 | | } [INFO] [stderr] 718 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:241:53 [INFO] [stderr] | [INFO] [stderr] 241 | pub const GNU_VERDEF: SectionType = SectionType(0x6ffffffd); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffd` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 714 | if sec.header.flags.contains(types::SectionFlags::INFO_LINK) && sec.header.info > at as u32 { [INFO] [stderr] 715 | sec.header.info += 1; [INFO] [stderr] 716 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:243:54 [INFO] [stderr] | [INFO] [stderr] 243 | pub const GNU_VERNEED: SectionType = SectionType(0x6ffffffe); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf.rs:735:35 [INFO] [stderr] | [INFO] [stderr] 735 | sec.header.link = 999999; [INFO] [stderr] | ^^^^^^ help: consider: `999_999` [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:245:53 [INFO] [stderr] | [INFO] [stderr] 245 | pub const GNU_VERSYM: SectionType = SectionType(0x6fffffff); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:248:52 [INFO] [stderr] | [INFO] [stderr] 248 | pub const ARM_EXIDX: SectionType = SectionType(0x70000001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:249:57 [INFO] [stderr] | [INFO] [stderr] 249 | pub const ARM_PREEMPTMAP: SectionType = SectionType(0x70000002); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/elf.rs:737:13 [INFO] [stderr] | [INFO] [stderr] 737 | / if sec.header.flags.contains(types::SectionFlags::INFO_LINK) { [INFO] [stderr] 738 | | if sec.header.info == from as u32 { [INFO] [stderr] 739 | | sec.header.info = 999999; [INFO] [stderr] 740 | | } [INFO] [stderr] 741 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:250:57 [INFO] [stderr] | [INFO] [stderr] 250 | pub const ARM_ATTRIBUTES: SectionType = SectionType(0x70000003); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:251:59 [INFO] [stderr] | [INFO] [stderr] 251 | pub const ARM_DEBUGOVERLAY: SectionType = SectionType(0x70000004); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 737 | if sec.header.flags.contains(types::SectionFlags::INFO_LINK) && sec.header.info == from as u32 { [INFO] [stderr] 738 | sec.header.info = 999999; [INFO] [stderr] 739 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:252:61 [INFO] [stderr] | [INFO] [stderr] 252 | pub const ARM_OVERLAYSECTION: SectionType = SectionType(0x70000005); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0005` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:255:55 [INFO] [stderr] | [INFO] [stderr] 255 | pub const MIPS_LIBLIST: SectionType = SectionType(0x70000001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf.rs:739:39 [INFO] [stderr] | [INFO] [stderr] 739 | sec.header.info = 999999; [INFO] [stderr] | ^^^^^^ help: consider: `999_999` [INFO] [stderr] | [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:256:56 [INFO] [stderr] | [INFO] [stderr] 256 | pub const MIPS_CONFLICT: SectionType = SectionType(0x70000002); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:257:53 [INFO] [stderr] | [INFO] [stderr] 257 | pub const MIPS_GPTAB: SectionType = SectionType(0x70000003); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:258:53 [INFO] [stderr] | [INFO] [stderr] 258 | pub const MIPS_UCODE: SectionType = SectionType(0x70000004); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf.rs:746:35 [INFO] [stderr] | [INFO] [stderr] 746 | if sec.header.link == 999999 { [INFO] [stderr] | ^^^^^^ help: consider: `999_999` [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:259:53 [INFO] [stderr] | [INFO] [stderr] 259 | pub const MIPS_DEBUG: SectionType = SectionType(0x70000005); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0005` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:260:55 [INFO] [stderr] | [INFO] [stderr] 260 | pub const MIPS_REGINFO: SectionType = SectionType(0x70000006); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0006` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:263:53 [INFO] [stderr] | [INFO] [stderr] 263 | pub const RELINKABLE: SectionType = SectionType(0x6fffff01); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_ff01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/elf.rs:749:13 [INFO] [stderr] | [INFO] [stderr] 749 | / if sec.header.flags.contains(types::SectionFlags::INFO_LINK) { [INFO] [stderr] 750 | | if sec.header.info == 999999 { [INFO] [stderr] 751 | | sec.header.info = to as u32; [INFO] [stderr] 752 | | } [INFO] [stderr] 753 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 749 | if sec.header.flags.contains(types::SectionFlags::INFO_LINK) && sec.header.info == 999999 { [INFO] [stderr] 750 | sec.header.info = to as u32; [INFO] [stderr] 751 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/elf.rs:750:39 [INFO] [stderr] | [INFO] [stderr] 750 | if sec.header.info == 999999 { [INFO] [stderr] | ^^^^^^ help: consider: `999_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filetype.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | return Ok(FileType::Unknown); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(FileType::Unknown)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/loader.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/loader.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/loader.rs:335:42 [INFO] [stderr] | [INFO] [stderr] 335 | let mut a1 = FnvHasher::with_key(0xcbf29ce484222325); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xcbf2_9ce4_8422_2325` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/loader.rs:336:42 [INFO] [stderr] | [INFO] [stderr] 336 | let mut a2 = FnvHasher::with_key(0x84222325b444f000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x8422_2325_b444_f000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/symbolic_linker.rs:198:21 [INFO] [stderr] | [INFO] [stderr] 198 | / if sym.bind == types::SymbolBind::LOCAL { [INFO] [stderr] 199 | | if sym.name.len() > 0 { [INFO] [stderr] 200 | | panic!("local undefined symbol {:?}", sym); [INFO] [stderr] 201 | | } [INFO] [stderr] 202 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 198 | if sym.bind == types::SymbolBind::LOCAL && sym.name.len() > 0 { [INFO] [stderr] 199 | panic!("local undefined symbol {:?}", sym); [INFO] [stderr] 200 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/relocation.rs:150:33 [INFO] [stderr] | [INFO] [stderr] 150 | let rtype = (info & 0xffffffff) as u32; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/relocation.rs:191:12 [INFO] [stderr] | [INFO] [stderr] 191 | Ok((8+8+8)) [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/relocation.rs:191:12 [INFO] [stderr] | [INFO] [stderr] 191 | Ok((8+8+8)) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:819:20 [INFO] [stderr] | [INFO] [stderr] 819 | GNU_EH_FRAME = 0x6474e550, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6474_e550` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:821:17 [INFO] [stderr] | [INFO] [stderr] 821 | GNU_STACK = 0x6474e551, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6474_e551` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:823:17 [INFO] [stderr] | [INFO] [stderr] 823 | GNU_RELRO = 0x6474e552, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6474_e552` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:825:17 [INFO] [stderr] | [INFO] [stderr] 825 | PAX_FLAGS = 0x65041580, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6504_1580` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:827:15 [INFO] [stderr] | [INFO] [stderr] 827 | SUNWBSS = 0x6ffffffa, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:829:17 [INFO] [stderr] | [INFO] [stderr] 829 | SUNWSTACK = 0x6ffffffb, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:831:12 [INFO] [stderr] | [INFO] [stderr] 831 | CPU0 = 0x70000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:832:12 [INFO] [stderr] | [INFO] [stderr] 832 | CPU1 = 0x70000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:833:12 [INFO] [stderr] | [INFO] [stderr] 833 | CPU2 = 0x70000002, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:834:12 [INFO] [stderr] | [INFO] [stderr] 834 | CPU3 = 0x70000003, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:916:21 [INFO] [stderr] | [INFO] [stderr] 916 | GNU_PRELINKED = 0x6ffffdf5, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fdf5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symbol.rs:235:5 [INFO] [stderr] | [INFO] [stderr] 235 | return h; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `h` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/symbol.rs:229:17 [INFO] [stderr] | [INFO] [stderr] 229 | g = h & 0xf0000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xf000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:918:22 [INFO] [stderr] | [INFO] [stderr] 918 | GNU_CONFLICTSZ = 0x6ffffdf6, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fdf6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:920:21 [INFO] [stderr] | [INFO] [stderr] 920 | GNU_LIBLISTSZ = 0x6ffffdf7, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fdf7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:921:16 [INFO] [stderr] | [INFO] [stderr] 921 | CHECKSUM = 0x6ffffdf8, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fdf8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:922:16 [INFO] [stderr] | [INFO] [stderr] 922 | PLTPADSZ = 0x6ffffdf9, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fdf9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:923:15 [INFO] [stderr] | [INFO] [stderr] 923 | MOVEENT = 0x6ffffdfa, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fdfa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:924:14 [INFO] [stderr] | [INFO] [stderr] 924 | MOVESZ = 0x6ffffdfb, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fdfb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:926:17 [INFO] [stderr] | [INFO] [stderr] 926 | FEATURE_1 = 0x6ffffdfc, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fdfc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:928:17 [INFO] [stderr] | [INFO] [stderr] 928 | POSFLAG_1 = 0x6ffffdfd, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fdfd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:930:15 [INFO] [stderr] | [INFO] [stderr] 930 | SYMINSZ = 0x6ffffdfe, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fdfe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:932:16 [INFO] [stderr] | [INFO] [stderr] 932 | SYMINENT = 0x6ffffdff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fdff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:935:16 [INFO] [stderr] | [INFO] [stderr] 935 | GNU_HASH = 0x6ffffef5, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fef5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:936:19 [INFO] [stderr] | [INFO] [stderr] 936 | TLSDESC_PLT = 0x6ffffef6, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fef6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:937:19 [INFO] [stderr] | [INFO] [stderr] 937 | TLSDESC_GOT = 0x6ffffef7, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fef7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:939:20 [INFO] [stderr] | [INFO] [stderr] 939 | GNU_CONFLICT = 0x6ffffef8, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fef8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:941:19 [INFO] [stderr] | [INFO] [stderr] 941 | GNU_LIBLIST = 0x6ffffef9, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fef9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:943:14 [INFO] [stderr] | [INFO] [stderr] 943 | CONFIG = 0x6ffffefa, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fefa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:945:16 [INFO] [stderr] | [INFO] [stderr] 945 | DEPAUDIT = 0x6ffffefb, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fefb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:947:13 [INFO] [stderr] | [INFO] [stderr] 947 | AUDIT = 0x6ffffefc, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fefc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:949:14 [INFO] [stderr] | [INFO] [stderr] 949 | PLTPAD = 0x6ffffefd, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fefd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:951:15 [INFO] [stderr] | [INFO] [stderr] 951 | MOVETAB = 0x6ffffefe, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fefe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:953:15 [INFO] [stderr] | [INFO] [stderr] 953 | SYMINFO = 0x6ffffeff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_feff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:955:14 [INFO] [stderr] | [INFO] [stderr] 955 | VERSYM = 0x6ffffff0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fff0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:956:17 [INFO] [stderr] | [INFO] [stderr] 956 | RELACOUNT = 0x6ffffff9, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fff9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:957:16 [INFO] [stderr] | [INFO] [stderr] 957 | RELCOUNT = 0x6ffffffa, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:959:15 [INFO] [stderr] | [INFO] [stderr] 959 | FLAGS_1 = 0x6ffffffb, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:961:14 [INFO] [stderr] | [INFO] [stderr] 961 | VERDEF = 0x6ffffffc, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:963:17 [INFO] [stderr] | [INFO] [stderr] 963 | VERDEFNUM = 0x6ffffffd, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:965:15 [INFO] [stderr] | [INFO] [stderr] 965 | VERNEED = 0x6ffffffe, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:967:18 [INFO] [stderr] | [INFO] [stderr] 967 | VERNEEDNUM = 0x6fffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:969:17 [INFO] [stderr] | [INFO] [stderr] 969 | AUXILIARY = 0x7ffffffd, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_fffd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:971:14 [INFO] [stderr] | [INFO] [stderr] 971 | FILTER = 0x7fffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:973:24 [INFO] [stderr] | [INFO] [stderr] 973 | MIPS_RLD_VERSION = 0x70000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:974:23 [INFO] [stderr] | [INFO] [stderr] 974 | MIPS_TIME_STAMP = 0x70000002, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:975:22 [INFO] [stderr] | [INFO] [stderr] 975 | MIPS_ICHECKSUM = 0x70000003, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:976:21 [INFO] [stderr] | [INFO] [stderr] 976 | MIPS_IVERSION = 0x70000004, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:977:18 [INFO] [stderr] | [INFO] [stderr] 977 | MIPS_FLAGS = 0x70000005, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0005` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:978:25 [INFO] [stderr] | [INFO] [stderr] 978 | MIPS_BASE_ADDRESS = 0x70000006, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0006` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:979:21 [INFO] [stderr] | [INFO] [stderr] 979 | MIPS_CONFLICT = 0x70000008, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0008` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:980:20 [INFO] [stderr] | [INFO] [stderr] 980 | MIPS_LIBLIST = 0x70000009, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0009` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:981:24 [INFO] [stderr] | [INFO] [stderr] 981 | MIPS_LOCAL_GOTNO = 0x7000000A, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_000A` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:982:23 [INFO] [stderr] | [INFO] [stderr] 982 | MIPS_CONFLICTNO = 0x7000000B, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_000B` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:983:22 [INFO] [stderr] | [INFO] [stderr] 983 | MIPS_LIBLISTNO = 0x70000010, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:984:21 [INFO] [stderr] | [INFO] [stderr] 984 | MIPS_SYMTABNO = 0x70000011, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:985:23 [INFO] [stderr] | [INFO] [stderr] 985 | MIPS_UNREFEXTNO = 0x70000012, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0012` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:986:19 [INFO] [stderr] | [INFO] [stderr] 986 | MIPS_GOTSYM = 0x70000013, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0013` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:987:21 [INFO] [stderr] | [INFO] [stderr] 987 | MIPS_HIPAGENO = 0x70000014, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0014` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:988:20 [INFO] [stderr] | [INFO] [stderr] 988 | MIPS_RLD_MAP = 0x70000016, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0016` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:989:24 [INFO] [stderr] | [INFO] [stderr] 989 | MIPS_RLD_MAP_REL = 0x70000035, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0035` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:34:35 [INFO] [stderr] | [INFO] [stderr] 34 | const MASKOS = 0x0ff00000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0ff0_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:36:35 [INFO] [stderr] | [INFO] [stderr] 36 | const MASKPROC = 0xf0000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xf000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:45:35 [INFO] [stderr] | [INFO] [stderr] 45 | const MIPS_GPREL = 0x10000000; // [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:102:35 [INFO] [stderr] | [INFO] [stderr] 102 | const MIPS_NOREORDER = 0x00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:105:35 [INFO] [stderr] | [INFO] [stderr] 105 | const MIPS_PIC = 0x00000002; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:112:35 [INFO] [stderr] | [INFO] [stderr] 112 | const MIPS_CPIC = 0x00000004; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:116:35 [INFO] [stderr] | [INFO] [stderr] 116 | const MIPS_ARCH = 0xf0000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xf000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:118:35 [INFO] [stderr] | [INFO] [stderr] 118 | const MIPS_ARCH_32 = 0x50000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x5000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:119:35 [INFO] [stderr] | [INFO] [stderr] 119 | const MIPS_ARCH_64 = 0x60000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:120:35 [INFO] [stderr] | [INFO] [stderr] 120 | const MIPS_ARCH_32R2 = 0x70000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:121:35 [INFO] [stderr] | [INFO] [stderr] 121 | const MIPS_ARCH_64R2 = 0x80000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:125:35 [INFO] [stderr] | [INFO] [stderr] 125 | const MIPS_ABI_O32 = 0x00001000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:128:35 [INFO] [stderr] | [INFO] [stderr] 128 | const MIPS_ABI_O64 = 0x00002000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_2000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:130:42 [INFO] [stderr] | [INFO] [stderr] 130 | const ARM_EABI_VER1 = 0x01000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:131:42 [INFO] [stderr] | [INFO] [stderr] 131 | const ARM_EABI_VER2 = 0x02000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0200_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:132:42 [INFO] [stderr] | [INFO] [stderr] 132 | const ARM_EABI_VER3 = 0x03000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0300_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:133:42 [INFO] [stderr] | [INFO] [stderr] 133 | const ARM_EABI_VER4 = 0x04000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0400_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:134:42 [INFO] [stderr] | [INFO] [stderr] 134 | const ARM_EABI_VER5 = 0x05000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0500_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:135:39 [INFO] [stderr] | [INFO] [stderr] 135 | const ARM_ABI_FLOAT_HARD = 0x00000400; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:136:39 [INFO] [stderr] | [INFO] [stderr] 136 | const ARM_ABI_FLOAT_SOFT = 0x00000200; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:230:57 [INFO] [stderr] | [INFO] [stderr] 230 | pub const GNU_ATTRIBUTES: SectionType = SectionType(0x6ffffff5); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fff5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:232:51 [INFO] [stderr] | [INFO] [stderr] 232 | pub const GNU_HASH: SectionType = SectionType(0x6ffffff6); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fff6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:234:54 [INFO] [stderr] | [INFO] [stderr] 234 | pub const GNU_LIBLIST: SectionType = SectionType(0x6ffffff7); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fff7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:236:51 [INFO] [stderr] | [INFO] [stderr] 236 | pub const CHECKSUM: SectionType = SectionType(0x6ffffff8); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fff8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:237:52 [INFO] [stderr] | [INFO] [stderr] 237 | pub const SUNW_MOVE: SectionType = SectionType(0x6ffffffa); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:238:54 [INFO] [stderr] | [INFO] [stderr] 238 | pub const SUNW_COMDAT: SectionType = SectionType(0x6ffffffb); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:239:55 [INFO] [stderr] | [INFO] [stderr] 239 | pub const SUNW_SYMINFO: SectionType = SectionType(0x6ffffffc); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:241:53 [INFO] [stderr] | [INFO] [stderr] 241 | pub const GNU_VERDEF: SectionType = SectionType(0x6ffffffd); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:243:54 [INFO] [stderr] | [INFO] [stderr] 243 | pub const GNU_VERNEED: SectionType = SectionType(0x6ffffffe); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:245:53 [INFO] [stderr] | [INFO] [stderr] 245 | pub const GNU_VERSYM: SectionType = SectionType(0x6fffffff); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:248:52 [INFO] [stderr] | [INFO] [stderr] 248 | pub const ARM_EXIDX: SectionType = SectionType(0x70000001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:249:57 [INFO] [stderr] | [INFO] [stderr] 249 | pub const ARM_PREEMPTMAP: SectionType = SectionType(0x70000002); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:250:57 [INFO] [stderr] | [INFO] [stderr] 250 | pub const ARM_ATTRIBUTES: SectionType = SectionType(0x70000003); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:251:59 [INFO] [stderr] | [INFO] [stderr] 251 | pub const ARM_DEBUGOVERLAY: SectionType = SectionType(0x70000004); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:252:61 [INFO] [stderr] | [INFO] [stderr] 252 | pub const ARM_OVERLAYSECTION: SectionType = SectionType(0x70000005); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0005` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:255:55 [INFO] [stderr] | [INFO] [stderr] 255 | pub const MIPS_LIBLIST: SectionType = SectionType(0x70000001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:256:56 [INFO] [stderr] | [INFO] [stderr] 256 | pub const MIPS_CONFLICT: SectionType = SectionType(0x70000002); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:257:53 [INFO] [stderr] | [INFO] [stderr] 257 | pub const MIPS_GPTAB: SectionType = SectionType(0x70000003); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:258:53 [INFO] [stderr] | [INFO] [stderr] 258 | pub const MIPS_UCODE: SectionType = SectionType(0x70000004); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:259:53 [INFO] [stderr] | [INFO] [stderr] 259 | pub const MIPS_DEBUG: SectionType = SectionType(0x70000005); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0005` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:260:55 [INFO] [stderr] | [INFO] [stderr] 260 | pub const MIPS_REGINFO: SectionType = SectionType(0x70000006); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0006` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:263:53 [INFO] [stderr] | [INFO] [stderr] 263 | pub const RELINKABLE: SectionType = SectionType(0x6fffff01); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_ff01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:819:20 [INFO] [stderr] | [INFO] [stderr] 819 | GNU_EH_FRAME = 0x6474e550, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6474_e550` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:821:17 [INFO] [stderr] | [INFO] [stderr] 821 | GNU_STACK = 0x6474e551, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6474_e551` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:823:17 [INFO] [stderr] | [INFO] [stderr] 823 | GNU_RELRO = 0x6474e552, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6474_e552` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:825:17 [INFO] [stderr] | [INFO] [stderr] 825 | PAX_FLAGS = 0x65041580, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6504_1580` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:827:15 [INFO] [stderr] | [INFO] [stderr] 827 | SUNWBSS = 0x6ffffffa, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:829:17 [INFO] [stderr] | [INFO] [stderr] 829 | SUNWSTACK = 0x6ffffffb, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:831:12 [INFO] [stderr] | [INFO] [stderr] 831 | CPU0 = 0x70000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:832:12 [INFO] [stderr] | [INFO] [stderr] 832 | CPU1 = 0x70000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:833:12 [INFO] [stderr] | [INFO] [stderr] 833 | CPU2 = 0x70000002, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:834:12 [INFO] [stderr] | [INFO] [stderr] 834 | CPU3 = 0x70000003, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:916:21 [INFO] [stderr] | [INFO] [stderr] 916 | GNU_PRELINKED = 0x6ffffdf5, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fdf5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:918:22 [INFO] [stderr] | [INFO] [stderr] 918 | GNU_CONFLICTSZ = 0x6ffffdf6, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fdf6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:920:21 [INFO] [stderr] | [INFO] [stderr] 920 | GNU_LIBLISTSZ = 0x6ffffdf7, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fdf7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:921:16 [INFO] [stderr] | [INFO] [stderr] 921 | CHECKSUM = 0x6ffffdf8, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fdf8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:922:16 [INFO] [stderr] | [INFO] [stderr] 922 | PLTPADSZ = 0x6ffffdf9, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fdf9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:923:15 [INFO] [stderr] | [INFO] [stderr] 923 | MOVEENT = 0x6ffffdfa, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fdfa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:924:14 [INFO] [stderr] | [INFO] [stderr] 924 | MOVESZ = 0x6ffffdfb, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fdfb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:926:17 [INFO] [stderr] | [INFO] [stderr] 926 | FEATURE_1 = 0x6ffffdfc, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fdfc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:928:17 [INFO] [stderr] | [INFO] [stderr] 928 | POSFLAG_1 = 0x6ffffdfd, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fdfd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:930:15 [INFO] [stderr] | [INFO] [stderr] 930 | SYMINSZ = 0x6ffffdfe, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fdfe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:932:16 [INFO] [stderr] | [INFO] [stderr] 932 | SYMINENT = 0x6ffffdff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fdff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:935:16 [INFO] [stderr] | [INFO] [stderr] 935 | GNU_HASH = 0x6ffffef5, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fef5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:936:19 [INFO] [stderr] | [INFO] [stderr] 936 | TLSDESC_PLT = 0x6ffffef6, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fef6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:937:19 [INFO] [stderr] | [INFO] [stderr] 937 | TLSDESC_GOT = 0x6ffffef7, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fef7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:939:20 [INFO] [stderr] | [INFO] [stderr] 939 | GNU_CONFLICT = 0x6ffffef8, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fef8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:941:19 [INFO] [stderr] | [INFO] [stderr] 941 | GNU_LIBLIST = 0x6ffffef9, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fef9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:943:14 [INFO] [stderr] | [INFO] [stderr] 943 | CONFIG = 0x6ffffefa, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fefa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:945:16 [INFO] [stderr] | [INFO] [stderr] 945 | DEPAUDIT = 0x6ffffefb, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fefb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:947:13 [INFO] [stderr] | [INFO] [stderr] 947 | AUDIT = 0x6ffffefc, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fefc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:949:14 [INFO] [stderr] | [INFO] [stderr] 949 | PLTPAD = 0x6ffffefd, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fefd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:951:15 [INFO] [stderr] | [INFO] [stderr] 951 | MOVETAB = 0x6ffffefe, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fefe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:953:15 [INFO] [stderr] | [INFO] [stderr] 953 | SYMINFO = 0x6ffffeff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_feff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:955:14 [INFO] [stderr] | [INFO] [stderr] 955 | VERSYM = 0x6ffffff0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fff0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:956:17 [INFO] [stderr] | [INFO] [stderr] 956 | RELACOUNT = 0x6ffffff9, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fff9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:957:16 [INFO] [stderr] | [INFO] [stderr] 957 | RELCOUNT = 0x6ffffffa, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:959:15 [INFO] [stderr] | [INFO] [stderr] 959 | FLAGS_1 = 0x6ffffffb, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:961:14 [INFO] [stderr] | [INFO] [stderr] 961 | VERDEF = 0x6ffffffc, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:963:17 [INFO] [stderr] | [INFO] [stderr] 963 | VERDEFNUM = 0x6ffffffd, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:965:15 [INFO] [stderr] | [INFO] [stderr] 965 | VERNEED = 0x6ffffffe, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_fffe` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:967:18 [INFO] [stderr] | [INFO] [stderr] 967 | VERNEEDNUM = 0x6fffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:969:17 [INFO] [stderr] | [INFO] [stderr] 969 | AUXILIARY = 0x7ffffffd, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_fffd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:971:14 [INFO] [stderr] | [INFO] [stderr] 971 | FILTER = 0x7fffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:973:24 [INFO] [stderr] | [INFO] [stderr] 973 | MIPS_RLD_VERSION = 0x70000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:974:23 [INFO] [stderr] | [INFO] [stderr] 974 | MIPS_TIME_STAMP = 0x70000002, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:975:22 [INFO] [stderr] | [INFO] [stderr] 975 | MIPS_ICHECKSUM = 0x70000003, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:976:21 [INFO] [stderr] | [INFO] [stderr] 976 | MIPS_IVERSION = 0x70000004, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:977:18 [INFO] [stderr] | [INFO] [stderr] 977 | MIPS_FLAGS = 0x70000005, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0005` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:978:25 [INFO] [stderr] | [INFO] [stderr] 978 | MIPS_BASE_ADDRESS = 0x70000006, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0006` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:979:21 [INFO] [stderr] | [INFO] [stderr] 979 | MIPS_CONFLICT = 0x70000008, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0008` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:980:20 [INFO] [stderr] | [INFO] [stderr] 980 | MIPS_LIBLIST = 0x70000009, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0009` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:981:24 [INFO] [stderr] | [INFO] [stderr] 981 | MIPS_LOCAL_GOTNO = 0x7000000A, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_000A` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:982:23 [INFO] [stderr] | [INFO] [stderr] 982 | MIPS_CONFLICTNO = 0x7000000B, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_000B` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:983:22 [INFO] [stderr] | [INFO] [stderr] 983 | MIPS_LIBLISTNO = 0x70000010, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:984:21 [INFO] [stderr] | [INFO] [stderr] 984 | MIPS_SYMTABNO = 0x70000011, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:985:23 [INFO] [stderr] | [INFO] [stderr] 985 | MIPS_UNREFEXTNO = 0x70000012, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0012` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:986:19 [INFO] [stderr] | [INFO] [stderr] 986 | MIPS_GOTSYM = 0x70000013, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0013` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:987:21 [INFO] [stderr] | [INFO] [stderr] 987 | MIPS_HIPAGENO = 0x70000014, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0014` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:988:20 [INFO] [stderr] | [INFO] [stderr] 988 | MIPS_RLD_MAP = 0x70000016, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0016` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types.rs:989:24 [INFO] [stderr] | [INFO] [stderr] 989 | MIPS_RLD_MAP_REL = 0x70000035, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0035` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/dynamic.rs:47:23 [INFO] [stderr] | [INFO] [stderr] 47 | link: any.map(|v|v.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `any.cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:70:30 [INFO] [stderr] | [INFO] [stderr] 70 | Ok(v) => Ok(v as u64), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(v)` [INFO] [stderr] | [INFO] [stderr] ::: src/dynamic.rs:53:29 [INFO] [stderr] | [INFO] [stderr] 53 | while let Ok(tag) = elf_read_uclass!(eh, io) { [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:70:30 [INFO] [stderr] | [INFO] [stderr] 70 | Ok(v) => Ok(v as u64), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(v)` [INFO] [stderr] | [INFO] [stderr] ::: src/dynamic.rs:54:23 [INFO] [stderr] | [INFO] [stderr] 54 | let val = elf_read_uclass!(eh, io)?; [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/dynamic.rs:141:27 [INFO] [stderr] | [INFO] [stderr] 141 | link: any.map(|v|v.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `any.cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/elf.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | for ref mut sec in &mut sections { [INFO] [stderr] | ^^^^^^^^^^^ ------------- help: try: `let sec = &mut &mut sections;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/elf.rs:103:24 [INFO] [stderr] | [INFO] [stderr] 103 | let link = sec.header.link.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `sec.header.link` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/elf.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | / match self.sections.iter().position(|s| s.name == b".shstrtab") { [INFO] [stderr] 133 | | Some(i) => { [INFO] [stderr] 134 | | self.header.shstrndx = i as u16; [INFO] [stderr] 135 | | let mut shstrtab = std::mem::replace( [INFO] [stderr] ... | [INFO] [stderr] 149 | | None => {} [INFO] [stderr] 150 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 132 | if let Some(i) = self.sections.iter().position(|s| s.name == b".shstrtab") { [INFO] [stderr] 133 | self.header.shstrndx = i as u16; [INFO] [stderr] 134 | let mut shstrtab = std::mem::replace( [INFO] [stderr] 135 | &mut self.sections[self.header.shstrndx as usize].content, [INFO] [stderr] 136 | SectionContent::default(), [INFO] [stderr] 137 | ); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/elf.rs:154:15 [INFO] [stderr] | [INFO] [stderr] 154 | while dirty.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!dirty.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/elf.rs:178:25 [INFO] [stderr] | [INFO] [stderr] 178 | pub fn to_writer(&mut self, mut io: R) -> Result<(), Error> [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/elf.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | io.write(&vec![0; off])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/elf.rs:189:12 [INFO] [stderr] | [INFO] [stderr] 189 | if self.segments.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.segments.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/elf.rs:320:13 [INFO] [stderr] | [INFO] [stderr] 320 | / match sec.header.shtype { [INFO] [stderr] 321 | | types::SectionType::RELA => { [INFO] [stderr] 322 | | if sec.header.link != shndx as u32{ [INFO] [stderr] 323 | | continue; [INFO] [stderr] ... | [INFO] [stderr] 339 | | _ => {}, [INFO] [stderr] 340 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 320 | if let types::SectionType::RELA = sec.header.shtype { [INFO] [stderr] 321 | if sec.header.link != shndx as u32{ [INFO] [stderr] 322 | continue; [INFO] [stderr] 323 | } [INFO] [stderr] 324 | for reloc in sec.content.as_relocations_mut().unwrap().iter_mut() { [INFO] [stderr] 325 | if let Some(secsym) = symtab_sec.get(&(reloc.sym as usize)) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/elf.rs:418:5 [INFO] [stderr] | [INFO] [stderr] 418 | / pub fn layout(self: &mut Elf) -> Result<(), Error> { [INFO] [stderr] 419 | | self.sync_all()?; [INFO] [stderr] 420 | | [INFO] [stderr] 421 | | let dbg_old_segments_count = self.segments.len(); [INFO] [stderr] ... | [INFO] [stderr] 667 | | Ok(()) [INFO] [stderr] 668 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf.rs:604:25 [INFO] [stderr] | [INFO] [stderr] 604 | let mut hoff = (self.header.phnum as u64 * self.header.phentsize as u64) + self.header.ehsize as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.header.phnum)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf.rs:604:52 [INFO] [stderr] | [INFO] [stderr] 604 | let mut hoff = (self.header.phnum as u64 * self.header.phentsize as u64) + self.header.ehsize as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.header.phentsize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf.rs:604:84 [INFO] [stderr] | [INFO] [stderr] 604 | let mut hoff = (self.header.phnum as u64 * self.header.phentsize as u64) + self.header.ehsize as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.header.ehsize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf.rs:639:21 [INFO] [stderr] | [INFO] [stderr] 639 | filesz: self.header.phnum as u64 * self.header.phentsize as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.header.phnum)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf.rs:639:48 [INFO] [stderr] | [INFO] [stderr] 639 | filesz: self.header.phnum as u64 * self.header.phentsize as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.header.phentsize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf.rs:642:21 [INFO] [stderr] | [INFO] [stderr] 642 | memsz: self.header.phnum as u64 * self.header.phentsize as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.header.phnum)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf.rs:642:48 [INFO] [stderr] | [INFO] [stderr] 642 | memsz: self.header.phnum as u64 * self.header.phentsize as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.header.phentsize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `dbg_old_addresses` [INFO] [stderr] --> src/elf.rs:648:18 [INFO] [stderr] | [INFO] [stderr] 648 | for i in 0..self.sections.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 648 | for (i, ) in dbg_old_addresses.iter().enumerate().take(self.sections.len()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/elf.rs:651:17 [INFO] [stderr] | [INFO] [stderr] 651 | / let mut cause = String::from("preceeding section or header has changed in size"); [INFO] [stderr] 652 | | if dbg_old_segments_count != self.segments.len() { [INFO] [stderr] 653 | | cause = format!("number of segments changed from {} to {}", [INFO] [stderr] 654 | | dbg_old_segments_count, self.segments.len()); [INFO] [stderr] 655 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let cause = if dbg_old_segments_count != self.segments.len() { $ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) ) } else { String::from("preceeding section or header has changed in size") };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/filetype.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | io.read(&mut magic)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/filetype.rs:19:30 [INFO] [stderr] | [INFO] [stderr] 19 | if magic[0..4] == [0x7F, 'E' as u8, 'L' as u8, 'F' as u8] { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'E' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/filetype.rs:19:41 [INFO] [stderr] | [INFO] [stderr] 19 | if magic[0..4] == [0x7F, 'E' as u8, 'L' as u8, 'F' as u8] { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'L' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/filetype.rs:19:52 [INFO] [stderr] | [INFO] [stderr] 19 | if magic[0..4] == [0x7F, 'E' as u8, 'L' as u8, 'F' as u8] { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'F' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/filetype.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | '!' as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'!' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/filetype.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | '<' as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'<' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/filetype.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | 'a' as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/filetype.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | 'r' as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'r' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/filetype.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | 'c' as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'c' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/filetype.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | 'h' as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'h' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/filetype.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | '>' as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'>' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/header.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | if let Err(_) = io.read_exact(&mut b) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 66 | | return Err(Error::InvalidMagic); [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________- help: try this: `if io.read_exact(&mut b).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:176:24 [INFO] [stderr] | [INFO] [stderr] 176 | Ok(r.read_u32::()? as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(r.read_u32::()?)` [INFO] [stderr] | [INFO] [stderr] ::: src/header.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / elf_dispatch_uclass!(r => { [INFO] [stderr] 117 | | r.entry = read_uclass(io)?; [INFO] [stderr] 118 | | r.phoff = read_uclass(io)?; [INFO] [stderr] 119 | | r.shoff = read_uclass(io)?; [INFO] [stderr] 120 | | }); [INFO] [stderr] | |_______________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:176:24 [INFO] [stderr] | [INFO] [stderr] 176 | Ok(r.read_u32::()? as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(r.read_u32::()?)` [INFO] [stderr] | [INFO] [stderr] ::: src/header.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / elf_dispatch_uclass!(r => { [INFO] [stderr] 117 | | r.entry = read_uclass(io)?; [INFO] [stderr] 118 | | r.phoff = read_uclass(io)?; [INFO] [stderr] 119 | | r.shoff = read_uclass(io)?; [INFO] [stderr] 120 | | }); [INFO] [stderr] | |_______________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/header.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | w.write(&self.ident_magic)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/header.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | w.write(&[self.ident_class.to_u8().unwrap()])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/header.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | w.write(&[self.ident_endianness.to_u8().unwrap()])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/header.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | w.write(&[self.ident_version.to_u8().unwrap()])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/header.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | w.write(&[self.ident_abi.to_u8().unwrap()])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/header.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | w.write(&[0; 8])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/loader.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / Elf{ [INFO] [stderr] 36 | | hash: String, [INFO] [stderr] 37 | | name: String, [INFO] [stderr] 38 | | elf: Elf, [INFO] [stderr] ... | [INFO] [stderr] 41 | | symbols: Vec, [INFO] [stderr] 42 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/loader.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / Elf{ [INFO] [stderr] 36 | | hash: String, [INFO] [stderr] 37 | | name: String, [INFO] [stderr] 38 | | elf: Elf, [INFO] [stderr] ... | [INFO] [stderr] 41 | | symbols: Vec, [INFO] [stderr] 42 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/loader.rs:55:34 [INFO] [stderr] | [INFO] [stderr] 55 | fn load_if(self, needles: &Vec<&[u8]>, e: &E) -> (Vec,Vec) [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[&[u8]]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/loader.rs:74:28 [INFO] [stderr] | [INFO] [stderr] 74 | .partition(|o| if let &State::Object{..} = o {false} else {true}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 74 | .partition(|o| if let State::Object{..} = *o {false} else {true}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/loader.rs:80:43 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn load_if (mut self, needles: &Vec<&[u8]>, e: &E) -> Vec [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[&[u8]]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/loader.rs:83:96 [INFO] [stderr] | [INFO] [stderr] 83 | if needles.iter().map(|needle|self.contains(needle, BloomFilter::hash(needle))).any(|e|e==true) { [INFO] [stderr] | ^^^^^^^ help: try simplifying it as shown: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/loader.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | / match self { [INFO] [stderr] 92 | | &mut State::Error{..} => true, [INFO] [stderr] 93 | | &mut State::Path {..} => true, [INFO] [stderr] 94 | | &mut State::Archive{ref mut archive, ..} => { [INFO] [stderr] ... | [INFO] [stderr] 127 | | &mut State::Object{..} => false, [INFO] [stderr] 128 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 91 | match *self { [INFO] [stderr] 92 | State::Error{..} => true, [INFO] [stderr] 93 | State::Path {..} => true, [INFO] [stderr] 94 | State::Archive{ref mut archive, ..} => { [INFO] [stderr] 95 | let symbols = match archive.symbols() { [INFO] [stderr] 96 | Ok(v) => v, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/loader.rs:176:21 [INFO] [stderr] | [INFO] [stderr] 176 | / match &entry { [INFO] [stderr] 177 | | &Ok(ref entry) => name += [INFO] [stderr] 178 | | &(String::from("::") + [INFO] [stderr] 179 | | &String::from_utf8_lossy(&entry.header().identifier())), [INFO] [stderr] 180 | | _ => {}, [INFO] [stderr] 181 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 176 | if let &Ok(ref entry) = &entry { name += [INFO] [stderr] 177 | &(String::from("::") + [INFO] [stderr] 178 | &String::from_utf8_lossy(&entry.header().identifier())) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/loader.rs:176:21 [INFO] [stderr] | [INFO] [stderr] 176 | / match &entry { [INFO] [stderr] 177 | | &Ok(ref entry) => name += [INFO] [stderr] 178 | | &(String::from("::") + [INFO] [stderr] 179 | | &String::from_utf8_lossy(&entry.header().identifier())), [INFO] [stderr] 180 | | _ => {}, [INFO] [stderr] 181 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 176 | match entry { [INFO] [stderr] 177 | Ok(ref entry) => name += [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/loader.rs:216:85 [INFO] [stderr] | [INFO] [stderr] 216 | sections.push((i, sec, relocs.remove(&i).unwrap_or_else(||Vec::new()))); [INFO] [stderr] | ^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/loader.rs:268:23 [INFO] [stderr] | [INFO] [stderr] 268 | if let Some(_) = symbols { [INFO] [stderr] | ________________- ^^^^^^^ [INFO] [stderr] 269 | | return Err(Error::MultipleSymbolSections); [INFO] [stderr] 270 | | } [INFO] [stderr] | |________________- help: try this: `if symbols.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/loader.rs:294:16 [INFO] [stderr] | [INFO] [stderr] 294 | if let None = symbols { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 295 | | return Err(Error::MissingSymtabSection); [INFO] [stderr] 296 | | } [INFO] [stderr] | |_________- help: try this: `if symbols.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/symbolic_linker.rs:73:16 [INFO] [stderr] | [INFO] [stderr] 73 | if matches.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `matches.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/symbolic_linker.rs:144:31 [INFO] [stderr] | [INFO] [stderr] 144 | let name = name.split("/").last().unwrap().to_owned(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/symbolic_linker.rs:199:28 [INFO] [stderr] | [INFO] [stderr] 199 | if sym.name.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!sym.name.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/symbolic_linker.rs:367:20 [INFO] [stderr] | [INFO] [stderr] 367 | if let Some(_) = symtab_remap[i] { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 368 | | symtab_remap[i] = Some(symtab.len()); [INFO] [stderr] 369 | | symtab.push(link); [INFO] [stderr] 370 | | } [INFO] [stderr] | |_____________- help: try this: `if symtab_remap[i].is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/symbolic_linker.rs:373:25 [INFO] [stderr] | [INFO] [stderr] 373 | for (_, obj) in &mut self.objects { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 373 | for obj in self.objects.values_mut() { [INFO] [stderr] | ^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/dynamic.rs:47:23 [INFO] [stderr] | [INFO] [stderr] 47 | link: any.map(|v|v.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `any.cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:70:30 [INFO] [stderr] | [INFO] [stderr] 70 | Ok(v) => Ok(v as u64), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(v)` [INFO] [stderr] | [INFO] [stderr] ::: src/dynamic.rs:53:29 [INFO] [stderr] | [INFO] [stderr] 53 | while let Ok(tag) = elf_read_uclass!(eh, io) { [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:70:30 [INFO] [stderr] | [INFO] [stderr] 70 | Ok(v) => Ok(v as u64), [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(v)` [INFO] [stderr] | [INFO] [stderr] ::: src/dynamic.rs:54:23 [INFO] [stderr] | [INFO] [stderr] 54 | let val = elf_read_uclass!(eh, io)?; [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/dynamic.rs:141:27 [INFO] [stderr] | [INFO] [stderr] 141 | link: any.map(|v|v.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `any.cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:176:24 [INFO] [stderr] | [INFO] [stderr] 176 | Ok(r.read_u32::()? as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(r.read_u32::()?)` [INFO] [stderr] | [INFO] [stderr] ::: src/section.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | / elf_dispatch_uclass!(eh => { [INFO] [stderr] 45 | | let reb = read_uclass(io)?; [INFO] [stderr] 46 | | r.flags = match types::SectionFlags::from_bits(reb) { [INFO] [stderr] 47 | | Some(v) => v, [INFO] [stderr] ... | [INFO] [stderr] 57 | | Ok(r) [INFO] [stderr] 58 | | }) [INFO] [stderr] | |______________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:176:24 [INFO] [stderr] | [INFO] [stderr] 176 | Ok(r.read_u32::()? as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(r.read_u32::()?)` [INFO] [stderr] | [INFO] [stderr] ::: src/section.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | / elf_dispatch_uclass!(eh => { [INFO] [stderr] 45 | | let reb = read_uclass(io)?; [INFO] [stderr] 46 | | r.flags = match types::SectionFlags::from_bits(reb) { [INFO] [stderr] 47 | | Some(v) => v, [INFO] [stderr] ... | [INFO] [stderr] 57 | | Ok(r) [INFO] [stderr] 58 | | }) [INFO] [stderr] | |______________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/elf.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | for ref mut sec in &mut sections { [INFO] [stderr] | ^^^^^^^^^^^ ------------- help: try: `let sec = &mut &mut sections;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/elf.rs:103:24 [INFO] [stderr] | [INFO] [stderr] 103 | let link = sec.header.link.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `sec.header.link` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/elf.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | / match self.sections.iter().position(|s| s.name == b".shstrtab") { [INFO] [stderr] 133 | | Some(i) => { [INFO] [stderr] 134 | | self.header.shstrndx = i as u16; [INFO] [stderr] 135 | | let mut shstrtab = std::mem::replace( [INFO] [stderr] ... | [INFO] [stderr] 149 | | None => {} [INFO] [stderr] 150 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 132 | if let Some(i) = self.sections.iter().position(|s| s.name == b".shstrtab") { [INFO] [stderr] 133 | self.header.shstrndx = i as u16; [INFO] [stderr] 134 | let mut shstrtab = std::mem::replace( [INFO] [stderr] 135 | &mut self.sections[self.header.shstrndx as usize].content, [INFO] [stderr] 136 | SectionContent::default(), [INFO] [stderr] 137 | ); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/elf.rs:154:15 [INFO] [stderr] | [INFO] [stderr] 154 | while dirty.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!dirty.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/elf.rs:178:25 [INFO] [stderr] | [INFO] [stderr] 178 | pub fn to_writer(&mut self, mut io: R) -> Result<(), Error> [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/elf.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | io.write(&vec![0; off])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] [INFO] [stderr] --> src/section.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | / match self { [INFO] [stderr] 101 | | &mut SectionContent::Dynamic(ref mut v) => Some(v), [INFO] [stderr] 102 | | _ => None, [INFO] [stderr] 103 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 100 | match *self { [INFO] [stderr] 101 | SectionContent::Dynamic(ref mut v) => Some(v), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/elf.rs:189:12 [INFO] [stderr] | [INFO] [stderr] 189 | if self.segments.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.segments.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/section.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | / match self { [INFO] [stderr] 107 | | &SectionContent::Dynamic(ref v) => Some(v), [INFO] [stderr] 108 | | _ => None, [INFO] [stderr] 109 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 106 | match *self { [INFO] [stderr] 107 | SectionContent::Dynamic(ref v) => Some(v), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/section.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | / match self { [INFO] [stderr] 119 | | &mut SectionContent::Strtab(ref mut v) => Some(v), [INFO] [stderr] 120 | | _ => None, [INFO] [stderr] 121 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 118 | match *self { [INFO] [stderr] 119 | SectionContent::Strtab(ref mut v) => Some(v), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/section.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &SectionContent::Symbols(ref v) => Some(v), [INFO] [stderr] 126 | | _ => None, [INFO] [stderr] 127 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 124 | match *self { [INFO] [stderr] 125 | SectionContent::Symbols(ref v) => Some(v), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/section.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | / match self { [INFO] [stderr] 131 | | &mut SectionContent::Symbols(ref mut v) => Some(v), [INFO] [stderr] 132 | | _ => None, [INFO] [stderr] 133 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 130 | match *self { [INFO] [stderr] 131 | SectionContent::Symbols(ref mut v) => Some(v), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/section.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | / match self { [INFO] [stderr] 143 | | &SectionContent::Relocations(ref v) => Some(v), [INFO] [stderr] 144 | | _ => None, [INFO] [stderr] 145 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 142 | match *self { [INFO] [stderr] 143 | SectionContent::Relocations(ref v) => Some(v), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/section.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | / match self { [INFO] [stderr] 149 | | &mut SectionContent::Relocations(ref mut v) => Some(v), [INFO] [stderr] 150 | | _ => None, [INFO] [stderr] 151 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 148 | match *self { [INFO] [stderr] 149 | SectionContent::Relocations(ref mut v) => Some(v), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/section.rs:160:9 [INFO] [stderr] | [INFO] [stderr] 160 | / match self { [INFO] [stderr] 161 | | &SectionContent::Raw(ref v) => Some(v), [INFO] [stderr] 162 | | _ => None, [INFO] [stderr] 163 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 160 | match *self { [INFO] [stderr] 161 | SectionContent::Raw(ref v) => Some(v), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/section.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | / match self { [INFO] [stderr] 167 | | &mut SectionContent::Raw(ref mut v) => Some(v), [INFO] [stderr] 168 | | _ => None, [INFO] [stderr] 169 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 166 | match *self { [INFO] [stderr] 167 | SectionContent::Raw(ref mut v) => Some(v), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/section.rs:178:9 [INFO] [stderr] | [INFO] [stderr] 178 | / match self { [INFO] [stderr] 179 | | &SectionContent::Unloaded => panic!("cannot size unloaded section"), [INFO] [stderr] 180 | | &SectionContent::None => 0, [INFO] [stderr] 181 | | &SectionContent::Raw(ref v) => v.len(), [INFO] [stderr] ... | [INFO] [stderr] 185 | | &SectionContent::Relocations(ref v) => v.len() * Relocation::entsize(eh), [INFO] [stderr] 186 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 178 | match *self { [INFO] [stderr] 179 | SectionContent::Unloaded => panic!("cannot size unloaded section"), [INFO] [stderr] 180 | SectionContent::None => 0, [INFO] [stderr] 181 | SectionContent::Raw(ref v) => v.len(), [INFO] [stderr] 182 | SectionContent::Dynamic(ref v) => v.len() * Dynamic::entsize(eh), [INFO] [stderr] 183 | SectionContent::Strtab(ref v) => v.len(eh), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/section.rs:272:9 [INFO] [stderr] | [INFO] [stderr] 272 | &mut self, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/elf.rs:320:13 [INFO] [stderr] | [INFO] [stderr] 320 | / match sec.header.shtype { [INFO] [stderr] 321 | | types::SectionType::RELA => { [INFO] [stderr] 322 | | if sec.header.link != shndx as u32{ [INFO] [stderr] 323 | | continue; [INFO] [stderr] ... | [INFO] [stderr] 339 | | _ => {}, [INFO] [stderr] 340 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 320 | if let types::SectionType::RELA = sec.header.shtype { [INFO] [stderr] 321 | if sec.header.link != shndx as u32{ [INFO] [stderr] 322 | continue; [INFO] [stderr] 323 | } [INFO] [stderr] 324 | for reloc in sec.content.as_relocations_mut().unwrap().iter_mut() { [INFO] [stderr] 325 | if let Some(secsym) = symtab_sec.get(&(reloc.sym as usize)) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/elf.rs:418:5 [INFO] [stderr] | [INFO] [stderr] 418 | / pub fn layout(self: &mut Elf) -> Result<(), Error> { [INFO] [stderr] 419 | | self.sync_all()?; [INFO] [stderr] 420 | | [INFO] [stderr] 421 | | let dbg_old_segments_count = self.segments.len(); [INFO] [stderr] ... | [INFO] [stderr] 667 | | Ok(()) [INFO] [stderr] 668 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/section.rs:322:9 [INFO] [stderr] | [INFO] [stderr] 322 | / match self.content { [INFO] [stderr] 323 | | SectionContent::Unloaded => return Ok(()), [INFO] [stderr] 324 | | _ => {}, [INFO] [stderr] 325 | | }; [INFO] [stderr] | |_________^ help: try this: `if let SectionContent::Unloaded = self.content { return Ok(()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/section.rs:328:18 [INFO] [stderr] | [INFO] [stderr] 328 | let rs = match &self.content { [INFO] [stderr] | __________________^ [INFO] [stderr] 329 | | &SectionContent::Unloaded => { [INFO] [stderr] 330 | | return Err(Error::WritingUnloadedSection); [INFO] [stderr] 331 | | }, [INFO] [stderr] ... | [INFO] [stderr] 361 | | } [INFO] [stderr] 362 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 328 | let rs = match self.content { [INFO] [stderr] 329 | SectionContent::Unloaded => { [INFO] [stderr] 330 | return Err(Error::WritingUnloadedSection); [INFO] [stderr] 331 | }, [INFO] [stderr] 332 | SectionContent::Relocations(ref vv) => { [INFO] [stderr] 333 | let mut rs = 0; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/segment.rs:42:67 [INFO] [stderr] | [INFO] [stderr] 42 | r.flags = types::SegmentFlags::from_bits_truncate(elf_read_u32!(eh, io)? as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elf_read_u32!(eh, io)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/segment.rs:51:28 [INFO] [stderr] | [INFO] [stderr] 51 | r.offset = elf_read_u32!(eh, io)? as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elf_read_u32!(eh, io)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/segment.rs:52:27 [INFO] [stderr] | [INFO] [stderr] 52 | r.vaddr = elf_read_u32!(eh, io)? as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elf_read_u32!(eh, io)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/segment.rs:53:27 [INFO] [stderr] | [INFO] [stderr] 53 | r.paddr = elf_read_u32!(eh, io)? as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elf_read_u32!(eh, io)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/segment.rs:54:28 [INFO] [stderr] | [INFO] [stderr] 54 | r.filesz = elf_read_u32!(eh, io)? as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elf_read_u32!(eh, io)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/segment.rs:55:27 [INFO] [stderr] | [INFO] [stderr] 55 | r.memsz = elf_read_u32!(eh, io)? as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elf_read_u32!(eh, io)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/segment.rs:56:67 [INFO] [stderr] | [INFO] [stderr] 56 | r.flags = types::SegmentFlags::from_bits_truncate(elf_read_u32!(eh, io)? as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elf_read_u32!(eh, io)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/segment.rs:57:27 [INFO] [stderr] | [INFO] [stderr] 57 | r.align = elf_read_u32!(eh, io)? as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elf_read_u32!(eh, io)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf.rs:604:25 [INFO] [stderr] | [INFO] [stderr] 604 | let mut hoff = (self.header.phnum as u64 * self.header.phentsize as u64) + self.header.ehsize as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.header.phnum)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf.rs:604:52 [INFO] [stderr] | [INFO] [stderr] 604 | let mut hoff = (self.header.phnum as u64 * self.header.phentsize as u64) + self.header.ehsize as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.header.phentsize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf.rs:604:84 [INFO] [stderr] | [INFO] [stderr] 604 | let mut hoff = (self.header.phnum as u64 * self.header.phentsize as u64) + self.header.ehsize as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.header.ehsize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf.rs:639:21 [INFO] [stderr] | [INFO] [stderr] 639 | filesz: self.header.phnum as u64 * self.header.phentsize as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.header.phnum)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf.rs:639:48 [INFO] [stderr] | [INFO] [stderr] 639 | filesz: self.header.phnum as u64 * self.header.phentsize as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.header.phentsize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf.rs:642:21 [INFO] [stderr] | [INFO] [stderr] 642 | memsz: self.header.phnum as u64 * self.header.phentsize as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.header.phnum)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/elf.rs:642:48 [INFO] [stderr] | [INFO] [stderr] 642 | memsz: self.header.phnum as u64 * self.header.phentsize as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.header.phentsize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `dbg_old_addresses` [INFO] [stderr] --> src/elf.rs:648:18 [INFO] [stderr] | [INFO] [stderr] 648 | for i in 0..self.sections.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 648 | for (i, ) in dbg_old_addresses.iter().enumerate().take(self.sections.len()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/elf.rs:651:17 [INFO] [stderr] | [INFO] [stderr] 651 | / let mut cause = String::from("preceeding section or header has changed in size"); [INFO] [stderr] 652 | | if dbg_old_segments_count != self.segments.len() { [INFO] [stderr] 653 | | cause = format!("number of segments changed from {} to {}", [INFO] [stderr] 654 | | dbg_old_segments_count, self.segments.len()); [INFO] [stderr] 655 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let cause = if dbg_old_segments_count != self.segments.len() { $ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) ) } else { String::from("preceeding section or header has changed in size") };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/strtab.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | io.write(&self.data)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/strtab.rs:57:12 [INFO] [stderr] | [INFO] [stderr] 57 | if self.data.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/strtab.rs:60:12 [INFO] [stderr] | [INFO] [stderr] 60 | if ns.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ns.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/filetype.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | io.read(&mut magic)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/filetype.rs:19:30 [INFO] [stderr] | [INFO] [stderr] 19 | if magic[0..4] == [0x7F, 'E' as u8, 'L' as u8, 'F' as u8] { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'E' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/filetype.rs:19:41 [INFO] [stderr] | [INFO] [stderr] 19 | if magic[0..4] == [0x7F, 'E' as u8, 'L' as u8, 'F' as u8] { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'L' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/filetype.rs:19:52 [INFO] [stderr] | [INFO] [stderr] 19 | if magic[0..4] == [0x7F, 'E' as u8, 'L' as u8, 'F' as u8] { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'F' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/filetype.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | '!' as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'!' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/filetype.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | '<' as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'<' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/filetype.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | 'a' as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/filetype.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | 'r' as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'r' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/filetype.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | 'c' as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'c' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/filetype.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | 'h' as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'h' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/filetype.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | '>' as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'>' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/header.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | if let Err(_) = io.read_exact(&mut b) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 66 | | return Err(Error::InvalidMagic); [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________- help: try this: `if io.read_exact(&mut b).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:176:24 [INFO] [stderr] | [INFO] [stderr] 176 | Ok(r.read_u32::()? as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(r.read_u32::()?)` [INFO] [stderr] | [INFO] [stderr] ::: src/header.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / elf_dispatch_uclass!(r => { [INFO] [stderr] 117 | | r.entry = read_uclass(io)?; [INFO] [stderr] 118 | | r.phoff = read_uclass(io)?; [INFO] [stderr] 119 | | r.shoff = read_uclass(io)?; [INFO] [stderr] 120 | | }); [INFO] [stderr] | |_______________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/symbol.rs:131:23 [INFO] [stderr] | [INFO] [stderr] 131 | link: any.map(|v|v.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `any.cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/symbol.rs:160:74 [INFO] [stderr] | [INFO] [stderr] 160 | Symbol::from_val(tab, _name, info, other, shndx, value as u64, size as u64)? [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/symbol.rs:160:88 [INFO] [stderr] | [INFO] [stderr] 160 | Symbol::from_val(tab, _name, info, other, shndx, value as u64, size as u64)? [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(size)` [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:176:24 [INFO] [stderr] | [INFO] [stderr] 176 | Ok(r.read_u32::()? as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(r.read_u32::()?)` [INFO] [stderr] | [INFO] [stderr] ::: src/header.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / elf_dispatch_uclass!(r => { [INFO] [stderr] 117 | | r.entry = read_uclass(io)?; [INFO] [stderr] 118 | | r.phoff = read_uclass(io)?; [INFO] [stderr] 119 | | r.shoff = read_uclass(io)?; [INFO] [stderr] 120 | | }); [INFO] [stderr] | |_______________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/symbol.rs:191:17 [INFO] [stderr] | [INFO] [stderr] 191 | io.write(&[info, other])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/symbol.rs:201:17 [INFO] [stderr] | [INFO] [stderr] 201 | io.write(&[info, other])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/header.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | w.write(&self.ident_magic)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/header.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | w.write(&[self.ident_class.to_u8().unwrap()])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/header.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | w.write(&[self.ident_endianness.to_u8().unwrap()])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/header.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | w.write(&[self.ident_version.to_u8().unwrap()])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/symbol.rs:216:23 [INFO] [stderr] | [INFO] [stderr] 216 | link: any.map(|v|v.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `any.cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/header.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | w.write(&[self.ident_abi.to_u8().unwrap()])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symbol.rs:223:21 [INFO] [stderr] | [INFO] [stderr] 223 | pub fn sysv_hash(s: &String) -> u64 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/header.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | w.write(&[0; 8])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/symbol.rs:228:24 [INFO] [stderr] | [INFO] [stderr] 228 | h = (h << 4) + byte as u64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/symbol.rs:239:38 [INFO] [stderr] | [INFO] [stderr] 239 | pub fn symhash(eh: &Header, symbols: &Vec, link: u32) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Symbol]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/symbol.rs:240:13 [INFO] [stderr] | [INFO] [stderr] 240 | assert!(symbols.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!symbols.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/loader.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / Elf{ [INFO] [stderr] 36 | | hash: String, [INFO] [stderr] 37 | | name: String, [INFO] [stderr] 38 | | elf: Elf, [INFO] [stderr] ... | [INFO] [stderr] 41 | | symbols: Vec, [INFO] [stderr] 42 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/loader.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / Elf{ [INFO] [stderr] 36 | | hash: String, [INFO] [stderr] 37 | | name: String, [INFO] [stderr] 38 | | elf: Elf, [INFO] [stderr] ... | [INFO] [stderr] 41 | | symbols: Vec, [INFO] [stderr] 42 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/loader.rs:55:34 [INFO] [stderr] | [INFO] [stderr] 55 | fn load_if(self, needles: &Vec<&[u8]>, e: &E) -> (Vec,Vec) [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[&[u8]]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/loader.rs:74:28 [INFO] [stderr] | [INFO] [stderr] 74 | .partition(|o| if let &State::Object{..} = o {false} else {true}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 74 | .partition(|o| if let State::Object{..} = *o {false} else {true}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/loader.rs:80:43 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn load_if (mut self, needles: &Vec<&[u8]>, e: &E) -> Vec [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[&[u8]]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/loader.rs:83:96 [INFO] [stderr] | [INFO] [stderr] 83 | if needles.iter().map(|needle|self.contains(needle, BloomFilter::hash(needle))).any(|e|e==true) { [INFO] [stderr] | ^^^^^^^ help: try simplifying it as shown: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/loader.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | / match self { [INFO] [stderr] 92 | | &mut State::Error{..} => true, [INFO] [stderr] 93 | | &mut State::Path {..} => true, [INFO] [stderr] 94 | | &mut State::Archive{ref mut archive, ..} => { [INFO] [stderr] ... | [INFO] [stderr] 127 | | &mut State::Object{..} => false, [INFO] [stderr] 128 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 91 | match *self { [INFO] [stderr] 92 | State::Error{..} => true, [INFO] [stderr] 93 | State::Path {..} => true, [INFO] [stderr] 94 | State::Archive{ref mut archive, ..} => { [INFO] [stderr] 95 | let symbols = match archive.symbols() { [INFO] [stderr] 96 | Ok(v) => v, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/loader.rs:176:21 [INFO] [stderr] | [INFO] [stderr] 176 | / match &entry { [INFO] [stderr] 177 | | &Ok(ref entry) => name += [INFO] [stderr] 178 | | &(String::from("::") + [INFO] [stderr] 179 | | &String::from_utf8_lossy(&entry.header().identifier())), [INFO] [stderr] 180 | | _ => {}, [INFO] [stderr] 181 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 176 | if let &Ok(ref entry) = &entry { name += [INFO] [stderr] 177 | &(String::from("::") + [INFO] [stderr] 178 | &String::from_utf8_lossy(&entry.header().identifier())) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/loader.rs:176:21 [INFO] [stderr] | [INFO] [stderr] 176 | / match &entry { [INFO] [stderr] 177 | | &Ok(ref entry) => name += [INFO] [stderr] 178 | | &(String::from("::") + [INFO] [stderr] 179 | | &String::from_utf8_lossy(&entry.header().identifier())), [INFO] [stderr] 180 | | _ => {}, [INFO] [stderr] 181 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 176 | match entry { [INFO] [stderr] 177 | Ok(ref entry) => name += [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/loader.rs:216:85 [INFO] [stderr] | [INFO] [stderr] 216 | sections.push((i, sec, relocs.remove(&i).unwrap_or_else(||Vec::new()))); [INFO] [stderr] | ^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/types.rs:10:35 [INFO] [stderr] | [INFO] [stderr] 10 | const WRITE = (1 << 0); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/loader.rs:268:23 [INFO] [stderr] | [INFO] [stderr] 268 | if let Some(_) = symbols { [INFO] [stderr] | ________________- ^^^^^^^ [INFO] [stderr] 269 | | return Err(Error::MultipleSymbolSections); [INFO] [stderr] 270 | | } [INFO] [stderr] | |________________- help: try this: `if symbols.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/loader.rs:294:16 [INFO] [stderr] | [INFO] [stderr] 294 | if let None = symbols { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 295 | | return Err(Error::MissingSymtabSection); [INFO] [stderr] 296 | | } [INFO] [stderr] | |_________- help: try this: `if symbols.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/symbolic_linker.rs:73:16 [INFO] [stderr] | [INFO] [stderr] 73 | if matches.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `matches.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/symbolic_linker.rs:144:31 [INFO] [stderr] | [INFO] [stderr] 144 | let name = name.split("/").last().unwrap().to_owned(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/symbolic_linker.rs:199:28 [INFO] [stderr] | [INFO] [stderr] 199 | if sym.name.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!sym.name.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/symbolic_linker.rs:367:20 [INFO] [stderr] | [INFO] [stderr] 367 | if let Some(_) = symtab_remap[i] { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 368 | | symtab_remap[i] = Some(symtab.len()); [INFO] [stderr] 369 | | symtab.push(link); [INFO] [stderr] 370 | | } [INFO] [stderr] | |_____________- help: try this: `if symtab_remap[i].is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/symbolic_linker.rs:373:25 [INFO] [stderr] | [INFO] [stderr] 373 | for (_, obj) in &mut self.objects { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 373 | for obj in self.objects.values_mut() { [INFO] [stderr] | ^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/types.rs:145:28 [INFO] [stderr] | [INFO] [stderr] 145 | const EXECUTABLE = (1 << 0); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/types.rs:155:31 [INFO] [stderr] | [INFO] [stderr] 155 | let dstr = dstr.split("|") [INFO] [stderr] | ^^^ help: try using a char instead: `'|'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:176:24 [INFO] [stderr] | [INFO] [stderr] 176 | Ok(r.read_u32::()? as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(r.read_u32::()?)` [INFO] [stderr] | [INFO] [stderr] ::: src/section.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | / elf_dispatch_uclass!(eh => { [INFO] [stderr] 45 | | let reb = read_uclass(io)?; [INFO] [stderr] 46 | | r.flags = match types::SectionFlags::from_bits(reb) { [INFO] [stderr] 47 | | Some(v) => v, [INFO] [stderr] ... | [INFO] [stderr] 57 | | Ok(r) [INFO] [stderr] 58 | | }) [INFO] [stderr] | |______________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:176:24 [INFO] [stderr] | [INFO] [stderr] 176 | Ok(r.read_u32::()? as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(r.read_u32::()?)` [INFO] [stderr] | [INFO] [stderr] ::: src/section.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | / elf_dispatch_uclass!(eh => { [INFO] [stderr] 45 | | let reb = read_uclass(io)?; [INFO] [stderr] 46 | | r.flags = match types::SectionFlags::from_bits(reb) { [INFO] [stderr] 47 | | Some(v) => v, [INFO] [stderr] ... | [INFO] [stderr] 57 | | Ok(r) [INFO] [stderr] 58 | | }) [INFO] [stderr] | |______________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/section.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | / match self { [INFO] [stderr] 101 | | &mut SectionContent::Dynamic(ref mut v) => Some(v), [INFO] [stderr] 102 | | _ => None, [INFO] [stderr] 103 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 100 | match *self { [INFO] [stderr] 101 | SectionContent::Dynamic(ref mut v) => Some(v), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/section.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | / match self { [INFO] [stderr] 107 | | &SectionContent::Dynamic(ref v) => Some(v), [INFO] [stderr] 108 | | _ => None, [INFO] [stderr] 109 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 106 | match *self { [INFO] [stderr] 107 | SectionContent::Dynamic(ref v) => Some(v), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/section.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | / match self { [INFO] [stderr] 119 | | &mut SectionContent::Strtab(ref mut v) => Some(v), [INFO] [stderr] 120 | | _ => None, [INFO] [stderr] 121 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 118 | match *self { [INFO] [stderr] 119 | SectionContent::Strtab(ref mut v) => Some(v), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/section.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &SectionContent::Symbols(ref v) => Some(v), [INFO] [stderr] 126 | | _ => None, [INFO] [stderr] 127 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 124 | match *self { [INFO] [stderr] 125 | SectionContent::Symbols(ref v) => Some(v), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/section.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | / match self { [INFO] [stderr] 131 | | &mut SectionContent::Symbols(ref mut v) => Some(v), [INFO] [stderr] 132 | | _ => None, [INFO] [stderr] 133 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 130 | match *self { [INFO] [stderr] 131 | SectionContent::Symbols(ref mut v) => Some(v), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/section.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | / match self { [INFO] [stderr] 143 | | &SectionContent::Relocations(ref v) => Some(v), [INFO] [stderr] 144 | | _ => None, [INFO] [stderr] 145 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 142 | match *self { [INFO] [stderr] 143 | SectionContent::Relocations(ref v) => Some(v), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/section.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | / match self { [INFO] [stderr] 149 | | &mut SectionContent::Relocations(ref mut v) => Some(v), [INFO] [stderr] 150 | | _ => None, [INFO] [stderr] 151 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 148 | match *self { [INFO] [stderr] 149 | SectionContent::Relocations(ref mut v) => Some(v), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/section.rs:160:9 [INFO] [stderr] | [INFO] [stderr] 160 | / match self { [INFO] [stderr] 161 | | &SectionContent::Raw(ref v) => Some(v), [INFO] [stderr] 162 | | _ => None, [INFO] [stderr] 163 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 160 | match *self { [INFO] [stderr] 161 | SectionContent::Raw(ref v) => Some(v), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/section.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | / match self { [INFO] [stderr] 167 | | &mut SectionContent::Raw(ref mut v) => Some(v), [INFO] [stderr] 168 | | _ => None, [INFO] [stderr] 169 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 166 | match *self { [INFO] [stderr] 167 | SectionContent::Raw(ref mut v) => Some(v), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/section.rs:178:9 [INFO] [stderr] | [INFO] [stderr] 178 | / match self { [INFO] [stderr] 179 | | &SectionContent::Unloaded => panic!("cannot size unloaded section"), [INFO] [stderr] 180 | | &SectionContent::None => 0, [INFO] [stderr] 181 | | &SectionContent::Raw(ref v) => v.len(), [INFO] [stderr] ... | [INFO] [stderr] 185 | | &SectionContent::Relocations(ref v) => v.len() * Relocation::entsize(eh), [INFO] [stderr] 186 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 178 | match *self { [INFO] [stderr] 179 | SectionContent::Unloaded => panic!("cannot size unloaded section"), [INFO] [stderr] 180 | SectionContent::None => 0, [INFO] [stderr] 181 | SectionContent::Raw(ref v) => v.len(), [INFO] [stderr] 182 | SectionContent::Dynamic(ref v) => v.len() * Dynamic::entsize(eh), [INFO] [stderr] 183 | SectionContent::Strtab(ref v) => v.len(eh), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/section.rs:272:9 [INFO] [stderr] | [INFO] [stderr] 272 | &mut self, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/section.rs:322:9 [INFO] [stderr] | [INFO] [stderr] 322 | / match self.content { [INFO] [stderr] 323 | | SectionContent::Unloaded => return Ok(()), [INFO] [stderr] 324 | | _ => {}, [INFO] [stderr] 325 | | }; [INFO] [stderr] | |_________^ help: try this: `if let SectionContent::Unloaded = self.content { return Ok(()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/section.rs:328:18 [INFO] [stderr] | [INFO] [stderr] 328 | let rs = match &self.content { [INFO] [stderr] | __________________^ [INFO] [stderr] 329 | | &SectionContent::Unloaded => { [INFO] [stderr] 330 | | return Err(Error::WritingUnloadedSection); [INFO] [stderr] 331 | | }, [INFO] [stderr] ... | [INFO] [stderr] 361 | | } [INFO] [stderr] 362 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 328 | let rs = match self.content { [INFO] [stderr] 329 | SectionContent::Unloaded => { [INFO] [stderr] 330 | return Err(Error::WritingUnloadedSection); [INFO] [stderr] 331 | }, [INFO] [stderr] 332 | SectionContent::Relocations(ref vv) => { [INFO] [stderr] 333 | let mut rs = 0; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/segment.rs:42:67 [INFO] [stderr] | [INFO] [stderr] 42 | r.flags = types::SegmentFlags::from_bits_truncate(elf_read_u32!(eh, io)? as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elf_read_u32!(eh, io)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/segment.rs:51:28 [INFO] [stderr] | [INFO] [stderr] 51 | r.offset = elf_read_u32!(eh, io)? as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elf_read_u32!(eh, io)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/segment.rs:52:27 [INFO] [stderr] | [INFO] [stderr] 52 | r.vaddr = elf_read_u32!(eh, io)? as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elf_read_u32!(eh, io)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/segment.rs:53:27 [INFO] [stderr] | [INFO] [stderr] 53 | r.paddr = elf_read_u32!(eh, io)? as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elf_read_u32!(eh, io)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/segment.rs:54:28 [INFO] [stderr] | [INFO] [stderr] 54 | r.filesz = elf_read_u32!(eh, io)? as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elf_read_u32!(eh, io)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/segment.rs:55:27 [INFO] [stderr] | [INFO] [stderr] 55 | r.memsz = elf_read_u32!(eh, io)? as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elf_read_u32!(eh, io)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/segment.rs:56:67 [INFO] [stderr] | [INFO] [stderr] 56 | r.flags = types::SegmentFlags::from_bits_truncate(elf_read_u32!(eh, io)? as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elf_read_u32!(eh, io)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/segment.rs:57:27 [INFO] [stderr] | [INFO] [stderr] 57 | r.align = elf_read_u32!(eh, io)? as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elf_read_u32!(eh, io)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/strtab.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | io.write(&self.data)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/strtab.rs:57:12 [INFO] [stderr] | [INFO] [stderr] 57 | if self.data.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/strtab.rs:60:12 [INFO] [stderr] | [INFO] [stderr] 60 | if ns.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ns.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/symbol.rs:131:23 [INFO] [stderr] | [INFO] [stderr] 131 | link: any.map(|v|v.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `any.cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/symbol.rs:160:74 [INFO] [stderr] | [INFO] [stderr] 160 | Symbol::from_val(tab, _name, info, other, shndx, value as u64, size as u64)? [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/symbol.rs:160:88 [INFO] [stderr] | [INFO] [stderr] 160 | Symbol::from_val(tab, _name, info, other, shndx, value as u64, size as u64)? [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/symbol.rs:191:17 [INFO] [stderr] | [INFO] [stderr] 191 | io.write(&[info, other])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/symbol.rs:201:17 [INFO] [stderr] | [INFO] [stderr] 201 | io.write(&[info, other])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/symbol.rs:216:23 [INFO] [stderr] | [INFO] [stderr] 216 | link: any.map(|v|v.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `any.cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symbol.rs:223:21 [INFO] [stderr] | [INFO] [stderr] 223 | pub fn sysv_hash(s: &String) -> u64 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/symbol.rs:228:24 [INFO] [stderr] | [INFO] [stderr] 228 | h = (h << 4) + byte as u64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/symbol.rs:239:38 [INFO] [stderr] | [INFO] [stderr] 239 | pub fn symhash(eh: &Header, symbols: &Vec, link: u32) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Symbol]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/symbol.rs:240:13 [INFO] [stderr] | [INFO] [stderr] 240 | assert!(symbols.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!symbols.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/types.rs:10:35 [INFO] [stderr] | [INFO] [stderr] 10 | const WRITE = (1 << 0); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/types.rs:1006:31 [INFO] [stderr] | [INFO] [stderr] 1006 | const NOW = 1 << 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/types.rs:145:28 [INFO] [stderr] | [INFO] [stderr] 145 | const EXECUTABLE = (1 << 0); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/types.rs:155:31 [INFO] [stderr] | [INFO] [stderr] 155 | let dstr = dstr.split("|") [INFO] [stderr] | ^^^ help: try using a char instead: `'|'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to 11 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `elfkit`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/types.rs:1006:31 [INFO] [stderr] | [INFO] [stderr] 1006 | const NOW = 1 << 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: aborting due to 11 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `elfkit`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "b66e7423d1c64d2edbfbd101bba7e1fe8d08445cf6c7960325af2024125c0b92"` [INFO] running `"docker" "rm" "-f" "b66e7423d1c64d2edbfbd101bba7e1fe8d08445cf6c7960325af2024125c0b92"` [INFO] [stdout] b66e7423d1c64d2edbfbd101bba7e1fe8d08445cf6c7960325af2024125c0b92