[INFO] crate elf2tab 0.3.0 is already in cache
[INFO] extracting crate elf2tab 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/elf2tab/0.3.0
[INFO] extracting crate elf2tab 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/elf2tab/0.3.0
[INFO] validating manifest of elf2tab-0.3.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of elf2tab-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing elf2tab-0.3.0
[INFO] finished frobbing elf2tab-0.3.0
[INFO] frobbed toml for elf2tab-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/elf2tab/0.3.0/Cargo.toml
[INFO] started frobbing elf2tab-0.3.0
[INFO] finished frobbing elf2tab-0.3.0
[INFO] frobbed toml for elf2tab-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/elf2tab/0.3.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting elf2tab-0.3.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/elf2tab/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b6b6038a38eb46faf7ca19b2b1662533b200cccebe2c41985b8dadce4e08aa88
[INFO] running `"docker" "start" "-a" "b6b6038a38eb46faf7ca19b2b1662533b200cccebe2c41985b8dadce4e08aa88"`
[INFO] [stderr]     Checking elf2tab v0.3.0 (/opt/crater/workdir)
[INFO] [stderr] warning: All variants have the same prefix: `TbfHeader`
[INFO] [stderr]   --> src/header.rs:14:1
[INFO] [stderr]    |
[INFO] [stderr] 14 | / enum TbfHeaderTypes {
[INFO] [stderr] 15 | |     TbfHeaderMain = 1,
[INFO] [stderr] 16 | |     TbfHeaderWriteableFlashRegions = 2,
[INFO] [stderr] 17 | |     TbfHeaderPackageName = 3,
[INFO] [stderr] 18 | |     TbfHeaderPicOption1 = 4,
[INFO] [stderr] 19 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::enum_variant_names)] on by default
[INFO] [stderr]    = help: remove the prefixes and use full paths to the variants instead of glob imports
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/header.rs:180:21
[INFO] [stderr]     |
[INFO] [stderr] 180 |         let flags = 0x00000001;
[INFO] [stderr]     |                     ^^^^^^^^^^ help: consider: `0x0000_0001`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: All variants have the same prefix: `TbfHeader`
[INFO] [stderr]   --> src/header.rs:14:1
[INFO] [stderr]    |
[INFO] [stderr] 14 | / enum TbfHeaderTypes {
[INFO] [stderr] 15 | |     TbfHeaderMain = 1,
[INFO] [stderr] 16 | |     TbfHeaderWriteableFlashRegions = 2,
[INFO] [stderr] 17 | |     TbfHeaderPackageName = 3,
[INFO] [stderr] 18 | |     TbfHeaderPicOption1 = 4,
[INFO] [stderr] 19 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::enum_variant_names)] on by default
[INFO] [stderr]    = help: remove the prefixes and use full paths to the variants instead of glob imports
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/header.rs:180:21
[INFO] [stderr]     |
[INFO] [stderr] 180 |         let flags = 0x00000001;
[INFO] [stderr]     |                     ^^^^^^^^^^ help: consider: `0x0000_0001`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/util.rs:40:1
[INFO] [stderr]    |
[INFO] [stderr] 40 | / pub unsafe fn as_byte_slice<'a, T: Copy>(input: &'a T) -> &'a [u8] {
[INFO] [stderr] 41 | |     slice::from_raw_parts(input as *const T as *const u8, mem::size_of::<T>())
[INFO] [stderr] 42 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/header.rs:164:36
[INFO] [stderr]     |
[INFO] [stderr] 164 |         self.package_name_pad = if package_name.len() > 0 {
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!package_name.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/header.rs:189:12
[INFO] [stderr]     |
[INFO] [stderr] 189 |         if self.package_name.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.package_name.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/util.rs:40:1
[INFO] [stderr]    |
[INFO] [stderr] 40 | / pub unsafe fn as_byte_slice<'a, T: Copy>(input: &'a T) -> &'a [u8] {
[INFO] [stderr] 41 | |     slice::from_raw_parts(input as *const T as *const u8, mem::size_of::<T>())
[INFO] [stderr] 42 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/header.rs:241:12
[INFO] [stderr]     |
[INFO] [stderr] 241 |         if self.package_name.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.package_name.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `wordbuf`
[INFO] [stderr]    --> src/header.rs:273:22
[INFO] [stderr]     |
[INFO] [stderr] 273 |             for i in 0..count {
[INFO] [stderr]     |                      ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 273 |             for (i, <item>) in wordbuf.iter().enumerate().take(count) {
[INFO] [stderr]     |                 ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/header.rs:274:25
[INFO] [stderr]     |
[INFO] [stderr] 274 |                 word |= (wordbuf[i] as u32) << (8 * i);
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(wordbuf[i])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `checksum`
[INFO] [stderr]    --> src/header.rs:285:23
[INFO] [stderr]     |
[INFO] [stderr] 285 |         wordbuf[0] = ((checksum >> 0) & 0xFF) as u8;
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/header.rs:289:9
[INFO] [stderr]     |
[INFO] [stderr] 289 |         header_buf.write(&wordbuf)?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/header.rs:164:36
[INFO] [stderr]     |
[INFO] [stderr] 164 |         self.package_name_pad = if package_name.len() > 0 {
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!package_name.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/header.rs:189:12
[INFO] [stderr]     |
[INFO] [stderr] 189 |         if self.package_name.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.package_name.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/header.rs:241:12
[INFO] [stderr]     |
[INFO] [stderr] 241 |         if self.package_name.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.package_name.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/main.rs:162:24
[INFO] [stderr]     |
[INFO] [stderr] 162 |     let package_name = package_name.unwrap_or(String::new());
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `package_name.unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `wordbuf`
[INFO] [stderr]    --> src/header.rs:273:22
[INFO] [stderr]     |
[INFO] [stderr] 273 |             for i in 0..count {
[INFO] [stderr]     |                      ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 273 |             for (i, <item>) in wordbuf.iter().enumerate().take(count) {
[INFO] [stderr]     |                 ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/header.rs:274:25
[INFO] [stderr]     |
[INFO] [stderr] 274 |                 word |= (wordbuf[i] as u32) << (8 * i);
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(wordbuf[i])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `checksum`
[INFO] [stderr]    --> src/header.rs:285:23
[INFO] [stderr]     |
[INFO] [stderr] 285 |         wordbuf[0] = ((checksum >> 0) & 0xFF) as u8;
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/header.rs:289:9
[INFO] [stderr]     |
[INFO] [stderr] 289 |         header_buf.write(&wordbuf)?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:326:23
[INFO] [stderr]     |
[INFO] [stderr] 326 |         if verbose && rel_data.len() > 0 {
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!rel_data.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:335:12
[INFO] [stderr]     |
[INFO] [stderr] 335 |         if rel_data.len() > 0 && align4needed!(binary_index) != 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!rel_data.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]    --> src/main.rs:162:24
[INFO] [stderr]     |
[INFO] [stderr] 162 |     let package_name = package_name.unwrap_or(String::new());
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `package_name.unwrap_or_default()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `elf2tab`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:326:23
[INFO] [stderr]     |
[INFO] [stderr] 326 |         if verbose && rel_data.len() > 0 {
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!rel_data.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:335:12
[INFO] [stderr]     |
[INFO] [stderr] 335 |         if rel_data.len() > 0 && align4needed!(binary_index) != 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!rel_data.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `elf2tab`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "b6b6038a38eb46faf7ca19b2b1662533b200cccebe2c41985b8dadce4e08aa88"`
[INFO] running `"docker" "rm" "-f" "b6b6038a38eb46faf7ca19b2b1662533b200cccebe2c41985b8dadce4e08aa88"`
[INFO] [stdout] b6b6038a38eb46faf7ca19b2b1662533b200cccebe2c41985b8dadce4e08aa88