[INFO] crate elementtree 0.5.0 is already in cache
[INFO] extracting crate elementtree 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/elementtree/0.5.0
[INFO] extracting crate elementtree 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/elementtree/0.5.0
[INFO] validating manifest of elementtree-0.5.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of elementtree-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing elementtree-0.5.0
[INFO] finished frobbing elementtree-0.5.0
[INFO] frobbed toml for elementtree-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/elementtree/0.5.0/Cargo.toml
[INFO] started frobbing elementtree-0.5.0
[INFO] finished frobbing elementtree-0.5.0
[INFO] frobbed toml for elementtree-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/elementtree/0.5.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting elementtree-0.5.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/elementtree/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ada8e036369b6d5e807b8c0ad0783dee17ec506977b87d0319681db35c00acf3
[INFO] running `"docker" "start" "-a" "ada8e036369b6d5e807b8c0ad0783dee17ec506977b87d0319681db35c00acf3"`
[INFO] [stderr]     Checking elementtree v0.5.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:261:13
[INFO] [stderr]     |
[INFO] [stderr] 261 |             ns: ns,
[INFO] [stderr]     |             ^^^^^^ help: replace it with: `ns`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:521:13
[INFO] [stderr]     |
[INFO] [stderr] 521 |             line: line,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `line`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:522:13
[INFO] [stderr]     |
[INFO] [stderr] 522 |             column: column,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `column`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:740:13
[INFO] [stderr]     |
[INFO] [stderr] 740 |             nsmap: nsmap,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `nsmap`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:865:13
[INFO] [stderr]     |
[INFO] [stderr] 865 |             name: name,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:261:13
[INFO] [stderr]     |
[INFO] [stderr] 261 |             ns: ns,
[INFO] [stderr]     |             ^^^^^^ help: replace it with: `ns`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:521:13
[INFO] [stderr]     |
[INFO] [stderr] 521 |             line: line,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `line`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:522:13
[INFO] [stderr]     |
[INFO] [stderr] 522 |             column: column,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `column`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:740:13
[INFO] [stderr]     |
[INFO] [stderr] 740 |             nsmap: nsmap,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `nsmap`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:865:13
[INFO] [stderr]     |
[INFO] [stderr] 865 |             name: name,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:649:22
[INFO] [stderr]     |
[INFO] [stderr] 649 |             err => { return Err(err).unwrap(); }
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(err).unwrap()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]     --> src/lib.rs:1197:9
[INFO] [stderr]      |
[INFO] [stderr] 1197 | /         if self.get_namespace_prefix(url).is_none() {
[INFO] [stderr] 1198 | |             if self.get_nsmap_mut().register_if_missing(url, prefix) {
[INFO] [stderr] 1199 | |                 self.emit_nsmap = true;
[INFO] [stderr] 1200 | |             }
[INFO] [stderr] 1201 | |         }
[INFO] [stderr]      | |_________^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]      |
[INFO] [stderr] 1197 |         if self.get_namespace_prefix(url).is_none() && self.get_nsmap_mut().register_if_missing(url, prefix) {
[INFO] [stderr] 1198 |     self.emit_nsmap = true;
[INFO] [stderr] 1199 | }
[INFO] [stderr]      |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:649:22
[INFO] [stderr]     |
[INFO] [stderr] 649 |             err => { return Err(err).unwrap(); }
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(err).unwrap()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]     --> src/lib.rs:1197:9
[INFO] [stderr]      |
[INFO] [stderr] 1197 | /         if self.get_namespace_prefix(url).is_none() {
[INFO] [stderr] 1198 | |             if self.get_nsmap_mut().register_if_missing(url, prefix) {
[INFO] [stderr] 1199 | |                 self.emit_nsmap = true;
[INFO] [stderr] 1200 | |             }
[INFO] [stderr] 1201 | |         }
[INFO] [stderr]      | |_________^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]      |
[INFO] [stderr] 1197 |         if self.get_namespace_prefix(url).is_none() && self.get_nsmap_mut().register_if_missing(url, prefix) {
[INFO] [stderr] 1198 |     self.emit_nsmap = true;
[INFO] [stderr] 1199 | }
[INFO] [stderr]      |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:312:24
[INFO] [stderr]     |
[INFO] [stderr] 312 |                     if ns.len() > 0 {
[INFO] [stderr]     |                        ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!ns.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:572:9
[INFO] [stderr]     |
[INFO] [stderr] 572 | /         match self {
[INFO] [stderr] 573 | |             &Error::MalformedXml { pos, .. } => Some(pos),
[INFO] [stderr] 574 | |             &Error::UnexpectedEvent { pos, .. } => Some(pos),
[INFO] [stderr] 575 | |             _ => None,
[INFO] [stderr] 576 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 572 |         match *self {
[INFO] [stderr] 573 |             Error::MalformedXml { pos, .. } => Some(pos),
[INFO] [stderr] 574 |             Error::UnexpectedEvent { pos, .. } => Some(pos),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:592:9
[INFO] [stderr]     |
[INFO] [stderr] 592 | /         match self {
[INFO] [stderr] 593 | |             &Error::MalformedXml { ref pos, ref msg } =>
[INFO] [stderr] 594 | |                 write!(f, "Malformed XML: {} ({})", msg, pos),
[INFO] [stderr] 595 | |             &Error::Io(ref e) => write!(f, "{}", e),
[INFO] [stderr] ...   |
[INFO] [stderr] 600 | |                 f, "Encountered duplicated namespace prefix"),
[INFO] [stderr] 601 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 592 |         match *self {
[INFO] [stderr] 593 |             Error::MalformedXml { ref pos, ref msg } =>
[INFO] [stderr] 594 |                 write!(f, "Malformed XML: {} ({})", msg, pos),
[INFO] [stderr] 595 |             Error::Io(ref e) => write!(f, "{}", e),
[INFO] [stderr] 596 |             Error::Utf8(ref e) => write!(f, "{}", e),
[INFO] [stderr] 597 |             Error::UnexpectedEvent { ref msg, .. } =>
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:607:9
[INFO] [stderr]     |
[INFO] [stderr] 607 | /         match self {
[INFO] [stderr] 608 | |             &Error::MalformedXml { .. } => "Malformed XML",
[INFO] [stderr] 609 | |             &Error::Io(..) => "IO error",
[INFO] [stderr] 610 | |             &Error::Utf8(..) => "utf-8 error",
[INFO] [stderr] 611 | |             &Error::UnexpectedEvent { .. } => "Unexpected XML element",
[INFO] [stderr] 612 | |             &Error::DuplicateNamespacePrefix => "Duplicated namespace prefix",
[INFO] [stderr] 613 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 607 |         match *self {
[INFO] [stderr] 608 |             Error::MalformedXml { .. } => "Malformed XML",
[INFO] [stderr] 609 |             Error::Io(..) => "IO error",
[INFO] [stderr] 610 |             Error::Utf8(..) => "utf-8 error",
[INFO] [stderr] 611 |             Error::UnexpectedEvent { .. } => "Unexpected XML element",
[INFO] [stderr] 612 |             Error::DuplicateNamespacePrefix => "Duplicated namespace prefix",
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:617:9
[INFO] [stderr]     |
[INFO] [stderr] 617 | /         match self {
[INFO] [stderr] 618 | |             &Error::Io(ref e) => Some(e),
[INFO] [stderr] 619 | |             &Error::Utf8(ref e) => Some(e),
[INFO] [stderr] 620 | |             _ => None,
[INFO] [stderr] 621 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 617 |         match *self {
[INFO] [stderr] 618 |             Error::Io(ref e) => Some(e),
[INFO] [stderr] 619 |             Error::Utf8(ref e) => Some(e),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:628:9
[INFO] [stderr]     |
[INFO] [stderr] 628 | /         match err.kind() {
[INFO] [stderr] 629 | |             &XmlReadErrorKind::Io(ref err) => Error::Io(
[INFO] [stderr] 630 | |                 io::Error::new(err.kind(), err.description())),
[INFO] [stderr] 631 | |             &XmlReadErrorKind::Utf8(ref err) => Error::Utf8(err.clone()),
[INFO] [stderr] ...   |
[INFO] [stderr] 640 | |             }
[INFO] [stderr] 641 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 628 |         match *err.kind() {
[INFO] [stderr] 629 |             XmlReadErrorKind::Io(ref err) => Error::Io(
[INFO] [stderr] 630 |                 io::Error::new(err.kind(), err.description())),
[INFO] [stderr] 631 |             XmlReadErrorKind::Utf8(ref err) => Error::Utf8(err.clone()),
[INFO] [stderr] 632 |             XmlReadErrorKind::UnexpectedEof => Error::Io(
[INFO] [stderr] 633 |                 io::Error::new(io::ErrorKind::UnexpectedEof,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:631:61
[INFO] [stderr]     |
[INFO] [stderr] 631 |             &XmlReadErrorKind::Utf8(ref err) => Error::Utf8(err.clone()),
[INFO] [stderr]     |                                                             ^^^^^^^^^^^ help: try dereferencing it: `*err`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> src/lib.rs:927:24
[INFO] [stderr]     |
[INFO] [stderr] 927 |                     if &name.local_name == self.tag.name() &&
[INFO] [stderr]     |                        ----------------^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |                        |
[INFO] [stderr]     |                        help: use the left value directly: `name.local_name`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]     --> src/lib.rs:1081:5
[INFO] [stderr]      |
[INFO] [stderr] 1081 | /     pub fn children<'a>(&'a self) -> Children<'a> {
[INFO] [stderr] 1082 | |         Children {
[INFO] [stderr] 1083 | |             idx: 0,
[INFO] [stderr] 1084 | |             element: self,
[INFO] [stderr] 1085 | |         }
[INFO] [stderr] 1086 | |     }
[INFO] [stderr]      | |_____^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]     --> src/lib.rs:1089:5
[INFO] [stderr]      |
[INFO] [stderr] 1089 | /     pub fn children_mut<'a>(&'a mut self) -> ChildrenMut<'a> {
[INFO] [stderr] 1090 | |         ChildrenMut {
[INFO] [stderr] 1091 | |             iter: self.children.iter_mut(),
[INFO] [stderr] 1092 | |         }
[INFO] [stderr] 1093 | |     }
[INFO] [stderr]      | |_____^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]     --> src/lib.rs:1166:5
[INFO] [stderr]      |
[INFO] [stderr] 1166 | /     pub fn attrs<'a>(&'a self) -> Attrs<'a> {
[INFO] [stderr] 1167 | |         Attrs {
[INFO] [stderr] 1168 | |             iter: self.attributes.iter(),
[INFO] [stderr] 1169 | |         }
[INFO] [stderr] 1170 | |     }
[INFO] [stderr]      | |_____^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:312:24
[INFO] [stderr]     |
[INFO] [stderr] 312 |                     if ns.len() > 0 {
[INFO] [stderr]     |                        ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!ns.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:572:9
[INFO] [stderr]     |
[INFO] [stderr] 572 | /         match self {
[INFO] [stderr] 573 | |             &Error::MalformedXml { pos, .. } => Some(pos),
[INFO] [stderr] 574 | |             &Error::UnexpectedEvent { pos, .. } => Some(pos),
[INFO] [stderr] 575 | |             _ => None,
[INFO] [stderr] 576 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 572 |         match *self {
[INFO] [stderr] 573 |             Error::MalformedXml { pos, .. } => Some(pos),
[INFO] [stderr] 574 |             Error::UnexpectedEvent { pos, .. } => Some(pos),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:592:9
[INFO] [stderr]     |
[INFO] [stderr] 592 | /         match self {
[INFO] [stderr] 593 | |             &Error::MalformedXml { ref pos, ref msg } =>
[INFO] [stderr] 594 | |                 write!(f, "Malformed XML: {} ({})", msg, pos),
[INFO] [stderr] 595 | |             &Error::Io(ref e) => write!(f, "{}", e),
[INFO] [stderr] ...   |
[INFO] [stderr] 600 | |                 f, "Encountered duplicated namespace prefix"),
[INFO] [stderr] 601 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 592 |         match *self {
[INFO] [stderr] 593 |             Error::MalformedXml { ref pos, ref msg } =>
[INFO] [stderr] 594 |                 write!(f, "Malformed XML: {} ({})", msg, pos),
[INFO] [stderr] 595 |             Error::Io(ref e) => write!(f, "{}", e),
[INFO] [stderr] 596 |             Error::Utf8(ref e) => write!(f, "{}", e),
[INFO] [stderr] 597 |             Error::UnexpectedEvent { ref msg, .. } =>
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:607:9
[INFO] [stderr]     |
[INFO] [stderr] 607 | /         match self {
[INFO] [stderr] 608 | |             &Error::MalformedXml { .. } => "Malformed XML",
[INFO] [stderr] 609 | |             &Error::Io(..) => "IO error",
[INFO] [stderr] 610 | |             &Error::Utf8(..) => "utf-8 error",
[INFO] [stderr] 611 | |             &Error::UnexpectedEvent { .. } => "Unexpected XML element",
[INFO] [stderr] 612 | |             &Error::DuplicateNamespacePrefix => "Duplicated namespace prefix",
[INFO] [stderr] 613 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 607 |         match *self {
[INFO] [stderr] 608 |             Error::MalformedXml { .. } => "Malformed XML",
[INFO] [stderr] 609 |             Error::Io(..) => "IO error",
[INFO] [stderr] 610 |             Error::Utf8(..) => "utf-8 error",
[INFO] [stderr] 611 |             Error::UnexpectedEvent { .. } => "Unexpected XML element",
[INFO] [stderr] 612 |             Error::DuplicateNamespacePrefix => "Duplicated namespace prefix",
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:617:9
[INFO] [stderr]     |
[INFO] [stderr] 617 | /         match self {
[INFO] [stderr] 618 | |             &Error::Io(ref e) => Some(e),
[INFO] [stderr] 619 | |             &Error::Utf8(ref e) => Some(e),
[INFO] [stderr] 620 | |             _ => None,
[INFO] [stderr] 621 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 617 |         match *self {
[INFO] [stderr] 618 |             Error::Io(ref e) => Some(e),
[INFO] [stderr] 619 |             Error::Utf8(ref e) => Some(e),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:628:9
[INFO] [stderr]     |
[INFO] [stderr] 628 | /         match err.kind() {
[INFO] [stderr] 629 | |             &XmlReadErrorKind::Io(ref err) => Error::Io(
[INFO] [stderr] 630 | |                 io::Error::new(err.kind(), err.description())),
[INFO] [stderr] 631 | |             &XmlReadErrorKind::Utf8(ref err) => Error::Utf8(err.clone()),
[INFO] [stderr] ...   |
[INFO] [stderr] 640 | |             }
[INFO] [stderr] 641 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 628 |         match *err.kind() {
[INFO] [stderr] 629 |             XmlReadErrorKind::Io(ref err) => Error::Io(
[INFO] [stderr] 630 |                 io::Error::new(err.kind(), err.description())),
[INFO] [stderr] 631 |             XmlReadErrorKind::Utf8(ref err) => Error::Utf8(err.clone()),
[INFO] [stderr] 632 |             XmlReadErrorKind::UnexpectedEof => Error::Io(
[INFO] [stderr] 633 |                 io::Error::new(io::ErrorKind::UnexpectedEof,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:631:61
[INFO] [stderr]     |
[INFO] [stderr] 631 |             &XmlReadErrorKind::Utf8(ref err) => Error::Utf8(err.clone()),
[INFO] [stderr]     |                                                             ^^^^^^^^^^^ help: try dereferencing it: `*err`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> src/lib.rs:927:24
[INFO] [stderr]     |
[INFO] [stderr] 927 |                     if &name.local_name == self.tag.name() &&
[INFO] [stderr]     |                        ----------------^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |                        |
[INFO] [stderr]     |                        help: use the left value directly: `name.local_name`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]     --> src/lib.rs:1081:5
[INFO] [stderr]      |
[INFO] [stderr] 1081 | /     pub fn children<'a>(&'a self) -> Children<'a> {
[INFO] [stderr] 1082 | |         Children {
[INFO] [stderr] 1083 | |             idx: 0,
[INFO] [stderr] 1084 | |             element: self,
[INFO] [stderr] 1085 | |         }
[INFO] [stderr] 1086 | |     }
[INFO] [stderr]      | |_____^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]     --> src/lib.rs:1089:5
[INFO] [stderr]      |
[INFO] [stderr] 1089 | /     pub fn children_mut<'a>(&'a mut self) -> ChildrenMut<'a> {
[INFO] [stderr] 1090 | |         ChildrenMut {
[INFO] [stderr] 1091 | |             iter: self.children.iter_mut(),
[INFO] [stderr] 1092 | |         }
[INFO] [stderr] 1093 | |     }
[INFO] [stderr]      | |_____^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]     --> src/lib.rs:1166:5
[INFO] [stderr]      |
[INFO] [stderr] 1166 | /     pub fn attrs<'a>(&'a self) -> Attrs<'a> {
[INFO] [stderr] 1167 | |         Attrs {
[INFO] [stderr] 1168 | |             iter: self.attributes.iter(),
[INFO] [stderr] 1169 | |         }
[INFO] [stderr] 1170 | |     }
[INFO] [stderr]      | |_____^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> examples/basic.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> examples/basic.rs:6:13
[INFO] [stderr]   |
[INFO] [stderr] 6 | const XML: &'static str = include_str!("test.xml");
[INFO] [stderr]   |            -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> tests/test_basic.rs:138:13
[INFO] [stderr]     |
[INFO] [stderr] 138 |         let mut list = root.append_new_child("{demo}list");
[INFO] [stderr]     |             ----^^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> tests/test_basic.rs:183:13
[INFO] [stderr]     |
[INFO] [stderr] 183 |         let mut list = root.append_new_child("{demo}list");
[INFO] [stderr]     |             ----^^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> tests/test_basic.rs:210:13
[INFO] [stderr]     |
[INFO] [stderr] 210 |         let mut list = root.append_new_child("{demo}list");
[INFO] [stderr]     |             ----^^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> tests/test_basic.rs:238:13
[INFO] [stderr]     |
[INFO] [stderr] 238 |         let mut list = root.append_new_child("{demo}list");
[INFO] [stderr]     |             ----^^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> tests/test_basic.rs:266:13
[INFO] [stderr]     |
[INFO] [stderr] 266 |         let mut list = root.append_new_child("{demo}list");
[INFO] [stderr]     |             ----^^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> tests/test_basic.rs:323:13
[INFO] [stderr]     |
[INFO] [stderr] 323 |         let mut list = root.find_mut("list").unwrap();
[INFO] [stderr]     |             ----^^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> tests/test_basic.rs:8:37
[INFO] [stderr]    |
[INFO] [stderr] 8  |       let root = Element::from_reader(r#"<?xml version="1.0"?>
[INFO] [stderr]    |  _____________________________________^
[INFO] [stderr] 9  | |     <root>
[INFO] [stderr] 10 | |         <list>
[INFO] [stderr] 11 | |             <item>Item 1</item>Tail 1
[INFO] [stderr] ...  |
[INFO] [stderr] 15 | |     </root>
[INFO] [stderr] 16 | |     "#.as_bytes()).unwrap();
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] help: consider using a byte string literal instead
[INFO] [stderr]    |
[INFO] [stderr] 8  |     let root = Element::from_reader(br#"<?xml version="1.0"?>
[INFO] [stderr] 9  |     <root>
[INFO] [stderr] 10 |         <list>
[INFO] [stderr] 11 |             <item>Item 1</item>Tail 1
[INFO] [stderr] 12 |             <item>Item 2</item>Tail 2
[INFO] [stderr] 13 |             <item>Item 3</item>Tail 3
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> tests/test_basic.rs:30:37
[INFO] [stderr]    |
[INFO] [stderr] 30 |       let root = Element::from_reader(r#"<?xml version="1.0"?>
[INFO] [stderr]    |  _____________________________________^
[INFO] [stderr] 31 | |     <root>
[INFO] [stderr] 32 | |         <list a="1" b="2" c="3">
[INFO] [stderr] 33 | |             <item attr="foo1"/>
[INFO] [stderr] ...  |
[INFO] [stderr] 37 | |     </root>
[INFO] [stderr] 38 | |     "#.as_bytes()).unwrap();
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] help: consider using a byte string literal instead
[INFO] [stderr]    |
[INFO] [stderr] 30 |     let root = Element::from_reader(br#"<?xml version="1.0"?>
[INFO] [stderr] 31 |     <root>
[INFO] [stderr] 32 |         <list a="1" b="2" c="3">
[INFO] [stderr] 33 |             <item attr="foo1"/>
[INFO] [stderr] 34 |             <item attr="foo2"/>
[INFO] [stderr] 35 |             <item attr="foo3"/>
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> tests/test_basic.rs:55:37
[INFO] [stderr]    |
[INFO] [stderr] 55 |       let root = Element::from_reader(r#"<?xml version="1.0"?>
[INFO] [stderr]    |  _____________________________________^
[INFO] [stderr] 56 | |     <root xmlns="root" xmlns:foo="child">
[INFO] [stderr] 57 | |         <list a="1" b="2" c="3">
[INFO] [stderr] 58 | |             <item foo:attr="foo1"/>
[INFO] [stderr] ...  |
[INFO] [stderr] 62 | |     </root>
[INFO] [stderr] 63 | |     "#.as_bytes()).unwrap();
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] help: consider using a byte string literal instead
[INFO] [stderr]    |
[INFO] [stderr] 55 |     let root = Element::from_reader(br#"<?xml version="1.0"?>
[INFO] [stderr] 56 |     <root xmlns="root" xmlns:foo="child">
[INFO] [stderr] 57 |         <list a="1" b="2" c="3">
[INFO] [stderr] 58 |             <item foo:attr="foo1"/>
[INFO] [stderr] 59 |             <item foo:attr="foo2"/>
[INFO] [stderr] 60 |             <item foo:attr="foo3"/>
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> tests/test_basic.rs:90:37
[INFO] [stderr]    |
[INFO] [stderr] 90 |       let root = Element::from_reader(r#"<?xml version="1.0"?>
[INFO] [stderr]    |  _____________________________________^
[INFO] [stderr] 91 | |     <root>&#83;</root>
[INFO] [stderr] 92 | |     "#.as_bytes()).unwrap();
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] help: consider using a byte string literal instead
[INFO] [stderr]    |
[INFO] [stderr] 90 |     let root = Element::from_reader(br#"<?xml version="1.0"?>
[INFO] [stderr] 91 |     <root>&#83;</root>
[INFO] [stderr] 92 |     "#).unwrap();
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> tests/test_basic.rs:158:37
[INFO] [stderr]     |
[INFO] [stderr] 158 |       let root = Element::from_reader(r#"<?xml version="1.0"?>
[INFO] [stderr]     |  _____________________________________^
[INFO] [stderr] 159 | |     <root>
[INFO] [stderr] 160 | |         <list>
[INFO] [stderr] 161 | |             <item> Item 1 </item>Tail 1
[INFO] [stderr] ...   |
[INFO] [stderr] 165 | |     </root>
[INFO] [stderr] 166 | |     "#.as_bytes()).unwrap();
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] help: consider using a byte string literal instead
[INFO] [stderr]     |
[INFO] [stderr] 158 |     let root = Element::from_reader(br#"<?xml version="1.0"?>
[INFO] [stderr] 159 |     <root>
[INFO] [stderr] 160 |         <list>
[INFO] [stderr] 161 |             <item> Item 1 </item>Tail 1
[INFO] [stderr] 162 |             <item> Item 2 </item>Tail 2
[INFO] [stderr] 163 |             <item> Item 3 </item>Tail 3
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> tests/test_basic.rs:312:41
[INFO] [stderr]     |
[INFO] [stderr] 312 |       let mut root = Element::from_reader(r#"<?xml version="1.0"?>
[INFO] [stderr]     |  _________________________________________^
[INFO] [stderr] 313 | |     <root>
[INFO] [stderr] 314 | |         <list>
[INFO] [stderr] 315 | |             <item> Item 1 </item>Tail 1
[INFO] [stderr] ...   |
[INFO] [stderr] 319 | |     </root>
[INFO] [stderr] 320 | |     "#.as_bytes()).unwrap();
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] help: consider using a byte string literal instead
[INFO] [stderr]     |
[INFO] [stderr] 312 |     let mut root = Element::from_reader(br#"<?xml version="1.0"?>
[INFO] [stderr] 313 |     <root>
[INFO] [stderr] 314 |         <list>
[INFO] [stderr] 315 |             <item> Item 1 </item>Tail 1
[INFO] [stderr] 316 |             <item> Item 2 </item>Tail 2
[INFO] [stderr] 317 |             <item> Item 3 </item>Tail 3
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.79s
[INFO] running `"docker" "inspect" "ada8e036369b6d5e807b8c0ad0783dee17ec506977b87d0319681db35c00acf3"`
[INFO] running `"docker" "rm" "-f" "ada8e036369b6d5e807b8c0ad0783dee17ec506977b87d0319681db35c00acf3"`
[INFO] [stdout] ada8e036369b6d5e807b8c0ad0783dee17ec506977b87d0319681db35c00acf3