[INFO] crate elefren 0.16.0 is already in cache [INFO] extracting crate elefren 0.16.0 into work/ex/clippy-test-run/sources/stable/reg/elefren/0.16.0 [INFO] extracting crate elefren 0.16.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/elefren/0.16.0 [INFO] validating manifest of elefren-0.16.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of elefren-0.16.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing elefren-0.16.0 [INFO] finished frobbing elefren-0.16.0 [INFO] frobbed toml for elefren-0.16.0 written to work/ex/clippy-test-run/sources/stable/reg/elefren/0.16.0/Cargo.toml [INFO] started frobbing elefren-0.16.0 [INFO] finished frobbing elefren-0.16.0 [INFO] frobbed toml for elefren-0.16.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/elefren/0.16.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting elefren-0.16.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/elefren/0.16.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eb60dc8b9292a320947d44dd927d437d4f6739dcae7f3309c92cb02720be38cb [INFO] running `"docker" "start" "-a" "eb60dc8b9292a320947d44dd927d437d4f6739dcae7f3309c92cb02720be38cb"` [INFO] [stderr] Checking tap-reader v1.0.1 [INFO] [stderr] Checking doc-comment v0.1.2 [INFO] [stderr] Checking hyper-old-types v0.11.0 [INFO] [stderr] Compiling indoc-impl v0.2.8 [INFO] [stderr] Compiling rand_pcg v0.1.1 [INFO] [stderr] Checking skeptic v0.13.4 [INFO] [stderr] Compiling elefren v0.16.0 (/opt/crater/workdir) [INFO] [stderr] Checking uuid v0.7.2 [INFO] [stderr] Checking tokio-reactor v0.1.8 [INFO] [stderr] Checking tokio-threadpool v0.1.11 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking indoc v0.2.8 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Compiling phf_generator v0.7.24 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Compiling phf_codegen v0.7.24 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.6 [INFO] [stderr] Compiling isolang v0.2.1 [INFO] [stderr] Checking hyper v0.12.23 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.9 [INFO] [stderr] error: this if statement can be collapsed [INFO] [stderr] --> src/entities/itemsiter.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | / if self.need_next_page() { [INFO] [stderr] 83 | | if self.fill_next_page().is_none() { [INFO] [stderr] 84 | | return None; [INFO] [stderr] 85 | | } [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | warnings, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::collapsible_if)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 82 | if self.need_next_page() && self.fill_next_page().is_none() { [INFO] [stderr] 83 | return None; [INFO] [stderr] 84 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/registration.rs:16:30 [INFO] [stderr] | [INFO] [stderr] 16 | const DEFAULT_REDIRECT_URI: &'static str = "urn:ietf:wg:oauth:2.0:oob"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | warnings, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::const_static_lifetime)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: this if statement can be collapsed [INFO] [stderr] --> src/entities/itemsiter.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | / if self.need_next_page() { [INFO] [stderr] 83 | | if self.fill_next_page().is_none() { [INFO] [stderr] 84 | | return None; [INFO] [stderr] 85 | | } [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | warnings, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::collapsible_if)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 82 | if self.need_next_page() && self.fill_next_page().is_none() { [INFO] [stderr] 83 | return None; [INFO] [stderr] 84 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/registration.rs:16:30 [INFO] [stderr] | [INFO] [stderr] 16 | const DEFAULT_REDIRECT_URI: &'static str = "urn:ietf:wg:oauth:2.0:oob"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | warnings, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::const_static_lifetime)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `elefren`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `elefren`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "eb60dc8b9292a320947d44dd927d437d4f6739dcae7f3309c92cb02720be38cb"` [INFO] running `"docker" "rm" "-f" "eb60dc8b9292a320947d44dd927d437d4f6739dcae7f3309c92cb02720be38cb"` [INFO] [stdout] eb60dc8b9292a320947d44dd927d437d4f6739dcae7f3309c92cb02720be38cb